38226 2010-04-27 16:08:03 -0700 Full width spaces are collapsed in option element 2011-10-11 02:24:09 -0700 1 1 1 Unclassified WebKit Text 528+ (Nightly build) All All RESOLVED DUPLICATE 57746 P2 Normal --- 1 phnixwxz webkit-unassigned ap dglazkov just2contribute tkent wangxianzhu oldest_to_newest 218020 0 phnixwxz 2010-04-27 16:08:03 -0700 URLs (if applicable) : Other browsers tested: Add OK or FAIL after other browsers where you have tested this issue: Chrome 5: FAIL Firefox 3.x: OK IE 8: OK What steps will reproduce the problem? 1. Open the attached test case What is the expected result? The text in the selection box should be like this: ====================== full-width spaces non-breakable-spaces normal-spaces ====================== What happens instead? Full width spaces are incorrectly collapsed: ====================== full-width spaces non-breakable-spaces normal-spaces ====================== 218486 1 54585 phnixwxz 2010-04-28 10:57:48 -0700 Created attachment 54585 testcase 221417 2 phnixwxz 2010-05-05 18:22:52 -0700 The reason that full-width spaces are collapsed is that the option element uses String::stripWhiteSpace() and String::simplifyWhiteSpace() which handle the set of white spaces different from the set of collapsable white spaces defined in HTML/CSS spec. I think there are two ways of solutions: 1. Add String::stringHTMLWhiteSpace() and String::simplifyHTMLWhiteSpace() and call them from OptionElement. In this way, the code change is small, but we can't share the same code with existing HTML/CSS white space handling. 2. Refactor rendering of select element and option element, let option elements be rendered as text blocks, thus take advantage of existing HTML/CSS white space handling. In this way, we can also allow the style of select/option to be controlled by CSS, such as text wrapping, word breaking, hover color, margin and padding, etc. Some hard-coded features, such as optgroup indentation, can also be implemented with CSS. I'd like to hear more opinions. 481432 3 just2contribute 2011-10-10 21:45:27 -0700 Can we directly modify the WTF::String function; static inline bool isSpaceOrNewline(UChar c) like; this is checking whether it is an ASCII space or a Unicode space (using the ICU function for directionality information) in the conditional statement. Hence can we just have a check for this full-width charatcter before this conditional statement as follows; if (c == 0x3000) return false; which will basically return false from there itself, interpreting it as non-white space character, which is the way I feel bcoz U+3000 (full-width space) should not be considered for any whitespace/newline procerssing as per its properties I guess. Does this impact any thing else, bcoz I could see this function being used in a number of places, especially in rendering, loader etc? 481527 4 tkent 2011-10-11 02:24:09 -0700 I think this was fixed in another bug. *** This bug has been marked as a duplicate of bug 57746 *** 54585 2010-04-28 10:57:48 -0700 2010-04-28 10:57:48 -0700 testcase testselect.html text/html 177 phnixwxz PGZvcm0+CjxzZWxlY3Qgc2l6ZT0iMyI+CjxvcHRpb24+JiMxMjI4ODsmIzEyMjg4O2Z1bGwtd2lk dGgtc3BhY2VzPC9vcHRpb24+CjxvcHRpb24+Jm5ic3A7Jm5ic3A7bm9uLWJyZWFrYWJsZS1zcGFj ZXM8L29wdGlvbj4KPG9wdGlvbj4gIG5vcm1hbC1zcGFjZXM8L29wdGlvbj4KPC9zZWxlY3Q+Cjwv Zm9ybT4K