38225 2010-04-27 15:23:08 -0700 run-bindings-tests doesn't work in an SVN checkout 2010-04-27 21:49:54 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue eric jamesr yaar oldest_to_newest 217990 0 abarth 2010-04-27 15:23:08 -0700 run-bindings-tests doesn't work in an SVN checkout 217991 1 54460 abarth 2010-04-27 15:23:44 -0700 Created attachment 54460 Patch 217993 2 54460 eric 2010-04-27 15:25:50 -0700 Comment on attachment 54460 Patch This seems like a bug in detect_scm_system and shoudl have a test. 218003 3 abarth 2010-04-27 15:42:04 -0700 Darn you for making me run test-webkitpy --all. I'm going to go read a book. :) 218009 4 54464 abarth 2010-04-27 15:51:43 -0700 Created attachment 54464 Patch 218012 5 54464 eric 2010-04-27 15:54:24 -0700 Comment on attachment 54464 Patch You can probably get the tmp folder from getcwd() or from self._svn_repository or whatever it's set as. I think I probably would have fixed SVN's usage instead of the caller of in_working_directory, since git's seems to take relative paths just fine. typo: + # I wanted to asser that we got the right path, but there was some 218019 6 54467 abarth 2010-04-27 16:06:11 -0700 Created attachment 54467 Patch for landing 218192 7 54467 commit-queue 2010-04-27 21:49:49 -0700 Comment on attachment 54467 Patch for landing Clearing flags on attachment: 54467 Committed r58376: <http://trac.webkit.org/changeset/58376> 218193 8 commit-queue 2010-04-27 21:49:54 -0700 All reviewed patches have been landed. Closing bug. 54460 2010-04-27 15:23:44 -0700 2010-04-27 15:51:38 -0700 Patch bug-38225-20100427152343.patch text/plain 1105 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MzQyKQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBydW4tYmluZGluZ3MtdGVzdHMgZG9lc24ndCB3b3JrIGluIGFuIFNWTiBjaGVja291 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMjUK KworICAgICAgICBUdXJucyBvdXQgZGV0ZWN0X3NjbV9zeXN0ZW0gbmVlZHMgYW4gYWJzb2x1dGUg cGF0aC4KKworICAgICAgICAqIFNjcmlwdHMvcnVuLWJpbmRpbmdzLXRlc3RzOgorCiAyMDEwLTA0 LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10 ZXN0cwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10ZXN0 cwkocmV2aXNpb24gNTgzNDIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3J1bi1iaW5kaW5ncy10 ZXN0cwkod29ya2luZyBjb3B5KQpAQCAtMTA2LDcgKzEwNiw3IEBAIGRlZiBtYWluKGFyZ3YpOgog ICAgICIiIgogICAgIHJlc2V0X3Jlc3VsdHMgPSAiLS1yZXNldC1yZXN1bHRzIiBpbiBhcmd2CiAK LSAgICBjdXJyZW50X3NjbSA9IHNjbS5kZXRlY3Rfc2NtX3N5c3RlbShvcy5jdXJkaXIpCisgICAg Y3VycmVudF9zY20gPSBzY20uZGV0ZWN0X3NjbV9zeXN0ZW0ob3MucGF0aC5hYnNwYXRoKG9zLmN1 cmRpcikpCiAgICAgb3MuY2hkaXIoY3VycmVudF9zY20uY2hlY2tvdXRfcm9vdCkKIAogICAgIGFs bF90ZXN0c19wYXNzZWQgPSBUcnVlCg== 54464 2010-04-27 15:51:43 -0700 2010-04-27 16:06:04 -0700 Patch bug-38225-20100427155141.patch text/plain 2324 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MzQ0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBydW4tYmluZGluZ3MtdGVzdHMgZG9lc24ndCB3b3JrIGluIGFuIFNWTiBjaGVja291 dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMjUK KworICAgICAgICBQcmV2aW91c2x5IGRldGVjdF9zY21fc3lzdGVtIG5lZWRlZCBhbiBhYnNvbHV0 ZSBwYXRoIGZvciBTVk4uICBOb3cgd2UKKyAgICAgICAgYWNjZXB0IGEgcmVsYXRpdmUgcGF0aC4K KworICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weToKKyAg ICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY21fdW5pdHRlc3QucHk6 CisKIDIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9T Y3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkJKHJldmlzaW9uIDU4MzQyKQor KysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CSh3 b3JraW5nIGNvcHkpCkBAIC00MSwxMSArNDEsMTMgQEAgZnJvbSB3ZWJraXRweS5jb21tb24uc3lz dGVtLmRlcHJlY2F0ZWRfbAogCiAKIGRlZiBkZXRlY3Rfc2NtX3N5c3RlbShwYXRoKToKLSAgICBp ZiBTVk4uaW5fd29ya2luZ19kaXJlY3RvcnkocGF0aCk6Ci0gICAgICAgIHJldHVybiBTVk4oY3dk PXBhdGgpCisgICAgYWJzb2x1dGVfcGF0aCA9IG9zLnBhdGguYWJzcGF0aChwYXRoKQorCisgICAg aWYgU1ZOLmluX3dvcmtpbmdfZGlyZWN0b3J5KGFic29sdXRlX3BhdGgpOgorICAgICAgICByZXR1 cm4gU1ZOKGN3ZD1hYnNvbHV0ZV9wYXRoKQogICAgIAotICAgIGlmIEdpdC5pbl93b3JraW5nX2Rp cmVjdG9yeShwYXRoKToKLSAgICAgICAgcmV0dXJuIEdpdChjd2Q9cGF0aCkKKyAgICBpZiBHaXQu aW5fd29ya2luZ19kaXJlY3RvcnkoYWJzb2x1dGVfcGF0aCk6CisgICAgICAgIHJldHVybiBHaXQo Y3dkPWFic29sdXRlX3BhdGgpCiAgICAgCiAgICAgcmV0dXJuIE5vbmUKIApJbmRleDogV2ViS2l0 VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtX3VuaXR0ZXN0LnB5Cj09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0 L3NjbV91bml0dGVzdC5weQkocmV2aXNpb24gNTgzNDIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY21fdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkK QEAgLTQ4Nyw2ICs0ODcsMTIgQEAgY2xhc3MgU1ZOVGVzdChTQ01UZXN0KToKICAgICBkZWYgdGVh ckRvd24oc2VsZik6CiAgICAgICAgIFNWTlRlc3RSZXBvc2l0b3J5LnRlYXJfZG93bihzZWxmKQog CisgICAgZGVmIHRlc3RfZGV0ZWN0X3NjbV9zeXN0ZW1fcmVsYXRpdmVfdXJsKHNlbGYpOgorICAg ICAgICBzY20gPSBkZXRlY3Rfc2NtX3N5c3RlbSgiLiIpCisgICAgICAgICMgSSB3YW50ZWQgdG8g YXNzZXIgdGhhdCB3ZSBnb3QgdGhlIHJpZ2h0IHBhdGgsIGJ1dCB0aGVyZSB3YXMgc29tZQorICAg ICAgICAjIGNyYXp5IG1hZ2ljIHdpdGggdGVtcCBmb2xkZXIgbmFtZXMgdGhhdCBJIGNvdWxkbid0 IGZpZ3VyZSBvdXQuCisgICAgICAgIHNlbGYuYXNzZXJ0VHJ1ZShzY20uY2hlY2tvdXRfcm9vdCkK KwogICAgIGRlZiB0ZXN0X2NyZWF0ZV9wYXRjaF9pc19mdWxsX3BhdGNoKHNlbGYpOgogICAgICAg ICB0ZXN0X2Rpcl9wYXRoID0gb3MucGF0aC5qb2luKHNlbGYuc3ZuX2NoZWNrb3V0X3BhdGgsICJ0 ZXN0X2RpcjIiKQogICAgICAgICBvcy5ta2Rpcih0ZXN0X2Rpcl9wYXRoKQo= 54467 2010-04-27 16:06:11 -0700 2010-04-27 21:49:49 -0700 Patch for landing bug-38225-20100427160610.patch text/plain 2322 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MzQ0KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KKworICAg ICAgICBydW4tYmluZGluZ3MtdGVzdHMgZG9lc24ndCB3b3JrIGluIGFuIFNWTiBjaGVja291dAor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgyMjUKKwor ICAgICAgICBQcmV2aW91c2x5IGRldGVjdF9zY21fc3lzdGVtIG5lZWRlZCBhbiBhYnNvbHV0ZSBw YXRoIGZvciBTVk4uICBOb3cgd2UKKyAgICAgICAgYWNjZXB0IGEgcmVsYXRpdmUgcGF0aC4KKwor ICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weToKKyAgICAg ICAgKiBTY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY21fdW5pdHRlc3QucHk6CisK IDIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAogICAgICAgICBS ZXZpZXdlZCBieSBEYXJpbiBBZGxlci4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3Jp cHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkJKHJldmlzaW9uIDU4MzQyKQorKysg V2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5CSh3b3Jr aW5nIGNvcHkpCkBAIC00MSwxMSArNDEsMTMgQEAgZnJvbSB3ZWJraXRweS5jb21tb24uc3lzdGVt LmRlcHJlY2F0ZWRfbAogCiAKIGRlZiBkZXRlY3Rfc2NtX3N5c3RlbShwYXRoKToKLSAgICBpZiBT Vk4uaW5fd29ya2luZ19kaXJlY3RvcnkocGF0aCk6Ci0gICAgICAgIHJldHVybiBTVk4oY3dkPXBh dGgpCisgICAgYWJzb2x1dGVfcGF0aCA9IG9zLnBhdGguYWJzcGF0aChwYXRoKQorCisgICAgaWYg U1ZOLmluX3dvcmtpbmdfZGlyZWN0b3J5KGFic29sdXRlX3BhdGgpOgorICAgICAgICByZXR1cm4g U1ZOKGN3ZD1hYnNvbHV0ZV9wYXRoKQogICAgIAotICAgIGlmIEdpdC5pbl93b3JraW5nX2RpcmVj dG9yeShwYXRoKToKLSAgICAgICAgcmV0dXJuIEdpdChjd2Q9cGF0aCkKKyAgICBpZiBHaXQuaW5f d29ya2luZ19kaXJlY3RvcnkoYWJzb2x1dGVfcGF0aCk6CisgICAgICAgIHJldHVybiBHaXQoY3dk PWFic29sdXRlX3BhdGgpCiAgICAgCiAgICAgcmV0dXJuIE5vbmUKIApJbmRleDogV2ViS2l0VG9v bHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtX3VuaXR0ZXN0LnB5Cj09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL2NoZWNrb3V0L3Nj bV91bml0dGVzdC5weQkocmV2aXNpb24gNTgzNDIpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL3dl YmtpdHB5L2NvbW1vbi9jaGVja291dC9zY21fdW5pdHRlc3QucHkJKHdvcmtpbmcgY29weSkKQEAg LTQ4Nyw2ICs0ODcsMTIgQEAgY2xhc3MgU1ZOVGVzdChTQ01UZXN0KToKICAgICBkZWYgdGVhckRv d24oc2VsZik6CiAgICAgICAgIFNWTlRlc3RSZXBvc2l0b3J5LnRlYXJfZG93bihzZWxmKQogCisg ICAgZGVmIHRlc3RfZGV0ZWN0X3NjbV9zeXN0ZW1fcmVsYXRpdmVfdXJsKHNlbGYpOgorICAgICAg ICBzY20gPSBkZXRlY3Rfc2NtX3N5c3RlbSgiLiIpCisgICAgICAgICMgSSB3YW50ZWQgdG8gYXNz ZXJ0IHRoYXQgd2UgZ290IHRoZSByaWdodCBwYXRoLCBidXQgdGhlcmUgd2FzIHNvbWUKKyAgICAg ICAgIyBjcmF6eSBtYWdpYyB3aXRoIHRlbXAgZm9sZGVyIG5hbWVzIHRoYXQgSSBjb3VsZG4ndCBm aWd1cmUgb3V0LgorICAgICAgICBzZWxmLmFzc2VydFRydWUoc2NtLmNoZWNrb3V0X3Jvb3QpCisK ICAgICBkZWYgdGVzdF9jcmVhdGVfcGF0Y2hfaXNfZnVsbF9wYXRjaChzZWxmKToKICAgICAgICAg dGVzdF9kaXJfcGF0aCA9IG9zLnBhdGguam9pbihzZWxmLnN2bl9jaGVja291dF9wYXRoLCAidGVz dF9kaXIyIikKICAgICAgICAgb3MubWtkaXIodGVzdF9kaXJfcGF0aCkK