38216 2010-04-27 13:55:03 -0700 [Qt] GraphicsContext3DQt.cpp does not implement isGLES2Compliant() 2010-04-29 01:26:09 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 0 jarkko.j.sakkinen webkit-unassigned commit-queue oldest_to_newest 217913 0 jarkko.j.sakkinen 2010-04-27 13:55:03 -0700 New method has been added to GraphicsContext3D.h called isGLES2Compiliant(). In Mac WebKit it is implemented by returning false. The proper way to implement it in Qt side is probably checking whether paint engine is of type OpenGL2. 217926 1 54453 jarkko.j.sakkinen 2010-04-27 14:07:40 -0700 Created attachment 54453 Checks the paint engine type. 218896 2 54453 commit-queue 2010-04-29 01:26:04 -0700 Comment on attachment 54453 Checks the paint engine type. Clearing flags on attachment: 54453 Committed r58484: <http://trac.webkit.org/changeset/58484> 218897 3 commit-queue 2010-04-29 01:26:09 -0700 All reviewed patches have been landed. Closing bug. 54453 2010-04-27 14:07:40 -0700 2010-04-29 01:26:04 -0700 Checks the paint engine type. 38216.diff text/plain 1206 jarkko.j.sakkinen ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjY3ZDVjNi4uNDcwYjIwNyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0yNyAgSmFya2tvIFNha2tp bmVuICA8amFya2tvLmouc2Fra2luZW5AZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gR3JhcGhpY3NDb250ZXh0M0RRdC5jcHAg ZG9lcyBub3QgaW1wbGVtZW50IGlzR0xFUzJDb21wbGlhbnQoKSAKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MjE2CisKKyAgICAgICAgKiBwbGF0Zm9y bS9ncmFwaGljcy9xdC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OkdyYXBoaWNzQ29udGV4dDNEOjppc0dMRVMyQ29tcGxpYW50KToKKwogMjAxMC0wNC0yNyAgQW5k cmV5IEtvc3lha292ICA8Y2FzZXFAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IFl1cnkgU2VtaWtoYXRza3kuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNz L3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9x dC9HcmFwaGljc0NvbnRleHQzRFF0LmNwcAppbmRleCBlOGE4ZmUzLi5jZDA0ZTI2IDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzQ29udGV4dDNEUXQuY3Bw CisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NDb250ZXh0M0RRdC5j cHAKQEAgLTU4Myw2ICs1ODMsMTEgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6cmVzaGFwZShp bnQgd2lkdGgsIGludCBoZWlnaHQpCiAgICAgZ2xGbHVzaCgpOwogfQogCitib29sIEdyYXBoaWNz Q29udGV4dDNEOjppc0dMRVMyQ29tcGxpYW50KCkgY29uc3QKK3sKKyAgICByZXR1cm4gbV9pbnRl cm5hbC0+bV9nbFdpZGdldC0+cGFpbnRFbmdpbmUoKS0+dHlwZSgpID09IFFQYWludEVuZ2luZTo6 T3BlbkdMMjsKK30KKwogdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6YWN0aXZlVGV4dHVyZSh1bnNp Z25lZCBsb25nIHRleHR1cmUpCiB7CiAgICAgbV9pbnRlcm5hbC0+bV9nbFdpZGdldC0+bWFrZUN1 cnJlbnQoKTsK