<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>38209</bug_id>
          
          <creation_ts>2010-04-27 11:42:47 -0700</creation_ts>
          <short_desc>commands/steps should use a tighter mock for options</short_desc>
          <delta_ts>2010-04-27 11:42:47 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Tools / Tests</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>PC</rep_platform>
          <op_sys>OS X 10.5</op_sys>
          <bug_status>NEW</bug_status>
          <resolution></resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Ojan Vafai">ojan</reporter>
          <assigned_to name="Nobody">webkit-unassigned</assigned_to>
          <cc>abarth</cc>
    
    <cc>cjerdonek</cc>
    
    <cc>eric</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>217808</commentid>
    <comment_count>0</comment_count>
    <who name="Ojan Vafai">ojan</who>
    <bug_when>2010-04-27 11:42:47 -0700</bug_when>
    <thetext>[11:39am] abarth: the real issue
[11:39am] abarth: is that we use a very loose mock for options
[11:39am] abarth: the right thing to do
[11:39am] abarth: is to use a much tighter mock
[11:39am] abarth: that&apos;s an easy change
[11:40am] abarth: in commandtest.py
[11:40am] abarth: options=Mock()
[11:40am] abarth: which means we assume that every option can be read
[11:40am] abarth: when running the command
[11:40am] abarth: instead
[11:40am] abarth: we should compute which options will actually exist
[11:40am] abarth: from the |command|</thetext>
  </long_desc>
      
      

    </bug>

</bugzilla>