38204 2010-04-27 10:40:25 -0700 REGRESSION(r58261): webkit-patch edit-changelogs is broken 2010-04-27 13:22:32 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric ojan oldest_to_newest 217778 0 abarth 2010-04-27 10:40:25 -0700 REGRESSION(r58261): webkit-patch edit-changelogs is broken 217779 1 54429 abarth 2010-04-27 10:42:18 -0700 Created attachment 54429 Patch 217801 2 54429 ojan 2010-04-27 11:25:06 -0700 Comment on attachment 54429 Patch Sorry, I thought I caught all the cases that needed this. Putting this in AbstractStep is much better. 217818 3 54429 eric 2010-04-27 11:58:07 -0700 Comment on attachment 54429 Patch To quote someone I know: "Where are the tests? r-". 217820 4 54429 abarth 2010-04-27 12:00:14 -0700 Comment on attachment 54429 Patch The tests will be in https://bugs.webkit.org/show_bug.cgi?id=38209 217877 5 54429 abarth 2010-04-27 13:14:18 -0700 Comment on attachment 54429 Patch Will land by hand. 217880 6 abarth 2010-04-27 13:22:32 -0700 Committed r58328: <http://trac.webkit.org/changeset/58328> 54429 2010-04-27 10:42:18 -0700 2010-04-27 13:14:18 -0700 Patch bug-38204-20100427104216.patch text/plain 3937 abarth ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCA4MjA0YTdjNDhkYWM0YTdiMWZiMmQzMWM3YzNmYjViMjhkNmFjYzg3Li5kNzI1MGRj YTYyYmVkMmFhNWMxNmJlYjE0MGNkZjEzNzcyOTQxOWY0IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMjIgQEAK IDIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSRUdSRVNTSU9OKHI1ODI2MSk6 IHdlYmtpdC1wYXRjaCBlZGl0LWNoYW5nZWxvZ3MgaXMgYnJva2VuCisgICAgICAgIGh0dHBzOi8v YnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODIwNAorCisgICAgICAgIEluIDU4MjYx LCB3ZSBhZGRlZCBjb2RlIHRvIGFic3RyYWN0IHN0ZXAgdGhhdCBpbnRlcnJvZ2F0ZXMgdGhlIHNx dWFzaAorICAgICAgICBhbmQgZ2l0X2NvbW1pdCBvcHRpb25zLCBidXQgaXQgZG9lc24ndCBkZWNs YXJlIHRoYXQgaXQgdXNlcyB0aG9zZQorICAgICAgICBvcHRpb25zLiAgVGhhdCBtZWFucyBhbnkg Y29tbWFuZCB0aGF0IGRvZXNuJ3QgaGFwcGVuIHRvIGRlY2xhcmUgdGhvc2UKKyAgICAgICAgb3B0 aW9ucyBtaWdodCBiZSBicm9rZW4gaWYgaXQgdXNlcyB0aGUgY2FjaGVkX2xvb2t1cCBtZWNoYW5p c20uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvYWJzdHJhY3RzdGVw LnB5OgorICAgICAgICAqIFNjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5w eToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9zdGNvZGVyZXZpZXcu cHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bvc3RkaWZmLnB5Ogor CisyMDEwLTA0LTI3ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CisKICAgICAgICAg UmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCiAKICAgICAgICAgUkVHUkVTU0lPTihyNTgy NjEpOiB3ZWJraXQtcGF0Y2ggdXBsb2FkIGRvZXMgbm90IHdvcmsgaW4gYW4gU1ZOIGNoZWNrb3V0 LgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Fi c3RyYWN0c3RlcC5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9h YnN0cmFjdHN0ZXAucHkKaW5kZXggMjc4MTI2MGQ5ZjY3MDExNDFhOWE1MTAxZDkzZDg5ZTJlMWFh MGYxYy4uYWJhZmU2Mzk5OGYyMDFmOWQ2MDEyNGQ2ZTIwNGMyNTkxOTNkMGU1NiAxMDA2NDQKLS0t IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2Fic3RyYWN0c3RlcC5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvYWJzdHJhY3Rz dGVwLnB5CkBAIC0yOCw2ICsyOCw3IEBACiAKIGZyb20gd2Via2l0cHkuY29tbW9uLnN5c3RlbS5k ZXByZWNhdGVkX2xvZ2dpbmcgaW1wb3J0IGxvZwogZnJvbSB3ZWJraXRweS5jb21tb24uY29uZmln LnBvcnRzIGltcG9ydCBXZWJLaXRQb3J0Citmcm9tIHdlYmtpdHB5LnRvb2wuc3RlcHMub3B0aW9u cyBpbXBvcnQgT3B0aW9ucwogCiAKIGNsYXNzIEFic3RyYWN0U3RlcChvYmplY3QpOgpAQCAtNjYs NyArNjcsMTIgQEAgY2xhc3MgQWJzdHJhY3RTdGVwKG9iamVjdCk6CiAKICAgICBAY2xhc3NtZXRo b2QKICAgICBkZWYgb3B0aW9ucyhjbHMpOgotICAgICAgICByZXR1cm4gW10KKyAgICAgICAgcmV0 dXJuIFsKKyAgICAgICAgICAgICMgV2UgbmVlZCB0aGVzZSBvcHRpb25zIGhlcmUgYmVjYXVzZSBj YWNoZWRfbG9va3VwIHVzZXMgdGhlbS4gIDooCisgICAgICAgICAgICBPcHRpb25zLmdpdF9jb21t aXQsCisgICAgICAgICAgICBPcHRpb25zLm5vX3NxdWFzaCwKKyAgICAgICAgICAgIE9wdGlvbnMu c3F1YXNoLAorICAgICAgICBdCiAKICAgICBkZWYgcnVuKHNlbGYsIHN0YXRlKToKICAgICAgICAg cmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNsYXNzZXMgbXVzdCBpbXBsZW1lbnQiCmRp ZmYgLS1naXQgYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29uZmly bWRpZmYucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvY29uZmly bWRpZmYucHkKaW5kZXggNDg1NzgzYTAxOWEzODUzOGEyZmYxM2UwOGY1ZjQxNGQ1MDRiY2I4Ni4u ZDA4ZTQ3Nzk0OTdiNmE3MmM0Mzk5ZTVmMzgxOGRiNjA2YmYzNzVjYiAxMDA2NDQKLS0tIGEvV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL2NvbmZpcm1kaWZmLnB5CisrKyBi L1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9jb25maXJtZGlmZi5weQpA QCAtNDMsOCArNDMsNiBAQCBjbGFzcyBDb25maXJtRGlmZihBYnN0cmFjdFN0ZXApOgogICAgIGRl ZiBvcHRpb25zKGNscyk6CiAgICAgICAgIHJldHVybiBbCiAgICAgICAgICAgICBPcHRpb25zLmNv bmZpcm0sCi0gICAgICAgICAgICBPcHRpb25zLmdpdF9jb21taXQsCi0gICAgICAgICAgICBPcHRp b25zLm5vX3NxdWFzaCwKICAgICAgICAgXQogCiAgICAgZGVmIF9zaG93X3ByZXR0eV9kaWZmKHNl bGYsIGRpZmYpOgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29s L3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90 b29sL3N0ZXBzL3Bvc3Rjb2RlcmV2aWV3LnB5CmluZGV4IDEwZmJkMWNhNzNjOTgyMmNjYjZmN2Yz YmE4MWNjZGU0NzExNjQ1OTkuLjdiOTViODRiNzkwM2M5YmRiOWQ4MTJkZTA0YzZhMTY3ZWQ3OGU2 YjMgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9w b3N0Y29kZXJldmlldy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wv c3RlcHMvcG9zdGNvZGVyZXZpZXcucHkKQEAgLTM3LDkgKzM3LDYgQEAgY2xhc3MgUG9zdENvZGVS ZXZpZXcoQWJzdHJhY3RTdGVwKToKICAgICAgICAgICAgIE9wdGlvbnMuY2MsCiAgICAgICAgICAg ICBPcHRpb25zLmRlc2NyaXB0aW9uLAogICAgICAgICAgICAgT3B0aW9ucy5mYW5jeV9yZXZpZXcs Ci0gICAgICAgICAgICBPcHRpb25zLmdpdF9jb21taXQsCi0gICAgICAgICAgICBPcHRpb25zLm5v X3NxdWFzaCwKLSAgICAgICAgICAgIE9wdGlvbnMuc3F1YXNoLAogICAgICAgICBdCiAKICAgICBk ZWYgcnVuKHNlbGYsIHN0YXRlKToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Vi a2l0cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvdG9vbC9zdGVwcy9wb3N0ZGlmZi5weQppbmRleCBlYmNjMjUxNGZjZWMwYTAxMGY5ZTE2ZTRl ZDBlYmI2NjcyYWUxZmE5Li44MGRhY2NhYWNiNTJjZGRjZDk1OWU4ZmE5NTZiYjYyZDdlMDc0MmJi IDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvcG9z dGRpZmYucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3Bv c3RkaWZmLnB5CkBAIC0zOCw5ICszOCw2IEBAIGNsYXNzIFBvc3REaWZmKEFic3RyYWN0U3RlcCk6 CiAgICAgICAgICAgICBPcHRpb25zLnJldmlldywKICAgICAgICAgICAgIE9wdGlvbnMucmVxdWVz dF9jb21taXQsCiAgICAgICAgICAgICBPcHRpb25zLm9wZW5fYnVnLAotICAgICAgICAgICAgT3B0 aW9ucy5naXRfY29tbWl0LAotICAgICAgICAgICAgT3B0aW9ucy5ub19zcXVhc2gsCi0gICAgICAg ICAgICBPcHRpb25zLnNxdWFzaCwKICAgICAgICAgXQogCiAgICAgZGVmIHJ1bihzZWxmLCBzdGF0 ZSk6Cg==