<?xml version="1.0" encoding="UTF-8" standalone="yes" ?>
<!DOCTYPE bugzilla SYSTEM "https://bugs.webkit.org/page.cgi?id=bugzilla.dtd">

<bugzilla version="5.0.4.1"
          urlbase="https://bugs.webkit.org/"
          
          maintainer="admin@webkit.org"
>

    <bug>
          <bug_id>38199</bug_id>
          
          <creation_ts>2010-04-27 07:30:05 -0700</creation_ts>
          <short_desc>Get rid of forceLayout() on FrameView</short_desc>
          <delta_ts>2010-04-29 10:35:28 -0700</delta_ts>
          <reporter_accessible>1</reporter_accessible>
          <cclist_accessible>1</cclist_accessible>
          <classification_id>1</classification_id>
          <classification>Unclassified</classification>
          <product>WebKit</product>
          <component>Layout and Rendering</component>
          <version>528+ (Nightly build)</version>
          <rep_platform>All</rep_platform>
          <op_sys>All</op_sys>
          <bug_status>RESOLVED</bug_status>
          <resolution>FIXED</resolution>
          
          
          <bug_file_loc></bug_file_loc>
          <status_whiteboard></status_whiteboard>
          <keywords></keywords>
          <priority>P2</priority>
          <bug_severity>Normal</bug_severity>
          <target_milestone>---</target_milestone>
          
          
          <everconfirmed>1</everconfirmed>
          <reporter name="Benjamin Poulain">benjamin</reporter>
          <assigned_to name="Benjamin Poulain">benjamin</assigned_to>
          <cc>commit-queue</cc>
    
    <cc>hyatt</cc>
    
    <cc>kenneth</cc>
    
    <cc>manyoso</cc>
    
    <cc>simon.fraser</cc>
    
    <cc>tonikitoo</cc>
          

      

      

      

          <comment_sort_order>oldest_to_newest</comment_sort_order>  
          <long_desc isprivate="0" >
    <commentid>217691</commentid>
    <comment_count>0</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-27 07:30:05 -0700</bug_when>
    <thetext>FrameView::forceLayout() is just calling layout(). It seems we can just get rid of the function and call layout directly.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>217700</commentid>
    <comment_count>1</comment_count>
      <attachid>54415</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-27 07:36:24 -0700</bug_when>
    <thetext>Created attachment 54415
Remove forceLayout

I did not commented on the changelog of each port, the change seems simple enough.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>217715</commentid>
    <comment_count>2</comment_count>
      <attachid>54415</attachid>
    <who name="Simon Fraser (smfr)">simon.fraser</who>
    <bug_when>2010-04-27 08:39:00 -0700</bug_when>
    <thetext>Comment on attachment 54415
Remove forceLayout

I think there&apos;s semantic value in forceLayout(), and useful history in the comment in FrameView::forceLayout() that you are removing.

I suggest leaving things as they are.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>217720</commentid>
    <comment_count>3</comment_count>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-27 08:46:27 -0700</bug_when>
    <thetext>Personally it has just confused me and it doesn&apos;t actually *force* the layout.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>217722</commentid>
    <comment_count>4</comment_count>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-27 08:47:14 -0700</bug_when>
    <thetext>(In reply to comment #2)
&gt; (From update of attachment 54415 [details])
&gt; I think there&apos;s semantic value in forceLayout(), and useful history in the
&gt; comment in FrameView::forceLayout() that you are removing.

Doesn&apos;t it just add complexity?
A newcomer, let say me ;), would assume that forceLayout() always relayout the render tree.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218917</commentid>
    <comment_count>5</comment_count>
      <attachid>54686</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-29 02:40:02 -0700</bug_when>
    <thetext>Created attachment 54686
Patch for Qt only

Remove forceLayout() use in Qt, replace them by layout().

I did not changed one in QWebPage because it is gonna disappear altogether thanks to https://bugs.webkit.org/show_bug.cgi?id=38179</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>218976</commentid>
    <comment_count>6</comment_count>
      <attachid>54686</attachid>
    <who name="Kenneth Rohde Christiansen">kenneth</who>
    <bug_when>2010-04-29 05:29:58 -0700</bug_when>
    <thetext>Comment on attachment 54686
Patch for Qt only

I support this change!</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>219010</commentid>
    <comment_count>7</comment_count>
      <attachid>54686</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-29 07:08:36 -0700</bug_when>
    <thetext>Comment on attachment 54686
Patch for Qt only

Rejecting patch 54686 from commit-queue.

Failed to run &quot;[u&apos;/Users/eseidel/Projects/CommitQueue/WebKitTools/Scripts/svn-apply&apos;, u&apos;--reviewer&apos;, u&apos;Kenneth Rohde Christiansen&apos;, u&apos;--force&apos;]&quot; exit_code: 1
Parsed 4 diffs from patch file(s).
patching file WebKit/qt/Api/qwebpage.cpp
Hunk #1 FAILED at 127.
Hunk #2 succeeded at 2104 (offset 4 lines).
1 out of 2 hunks FAILED -- saving rejects to file WebKit/qt/Api/qwebpage.cpp.rej
patching file WebKit/qt/ChangeLog
Hunk #1 succeeded at 1 with fuzz 3.
patching file WebKit/qt/WebCoreSupport/DumpRenderTreeSupportQt.cpp
Hunk #1 succeeded at 347 (offset 5 lines).
patching file WebKit/qt/WebCoreSupport/FrameLoaderClientQt.cpp

Full output: http://webkit-commit-queue.appspot.com/results/1851187</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>219030</commentid>
    <comment_count>8</comment_count>
      <attachid>54706</attachid>
    <who name="Benjamin Poulain">benjamin</who>
    <bug_when>2010-04-29 07:39:30 -0700</bug_when>
    <thetext>Created attachment 54706
Patch for Qt only

Luiz was faster than me to patch QWebPage :) 
Same patch updated without conflict.</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>219084</commentid>
    <comment_count>9</comment_count>
      <attachid>54706</attachid>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-29 10:35:21 -0700</bug_when>
    <thetext>Comment on attachment 54706
Patch for Qt only

Clearing flags on attachment: 54706

Committed r58523: &lt;http://trac.webkit.org/changeset/58523&gt;</thetext>
  </long_desc><long_desc isprivate="0" >
    <commentid>219085</commentid>
    <comment_count>10</comment_count>
    <who name="WebKit Commit Bot">commit-queue</who>
    <bug_when>2010-04-29 10:35:28 -0700</bug_when>
    <thetext>All reviewed patches have been landed.  Closing bug.</thetext>
  </long_desc>
      
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54415</attachid>
            <date>2010-04-27 07:36:24 -0700</date>
            <delta_ts>2010-04-27 08:38:59 -0700</delta_ts>
            <desc>Remove forceLayout</desc>
            <filename>38199.patch</filename>
            <type>text/plain</type>
            <size>13936</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg
OWIxNTU3MS4uYzNkZDU3YyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi
Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0yNyAgQmVuamFtaW4gUG91
bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5
IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCByaWQgb2YgZm9yY2VMYXlvdXQoKSBvbiBG
cmFtZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lk
PTM4MTk5CisKKyAgICAgICAgRnJhbWVWaWV3Ojpmb3JjZUxheW91dCgpIGlzIGVxdWl2YWxlbnQg
dG8gRnJhbWVWaWV3OjpsYXlvdXQoKSwKKyAgICAgICAgZm9yY2VMYXlvdXQoKSBjYW4gYmUgcmVt
b3ZlZCBhbmQgd2UgdXNlIGxheW91dCBkaXJlY3RseS4KKworICAgICAgICAqIGxvYWRlci9GcmFt
ZUxvYWRlci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxvYWRlcjo6Y29tbWl0UHJvdmlz
aW9uYWxMb2FkKToKKyAgICAgICAgKiBwYWdlL0ZyYW1lVmlldy5jcHA6CisgICAgICAgIChXZWJD
b3JlOjpGcmFtZVZpZXc6OmZvcmNlTGF5b3V0V2l0aFBhZ2VXaWR0aFJhbmdlKToKKyAgICAgICAg
KiBwYWdlL0ZyYW1lVmlldy5oOgorCiAyMDEwLTA0LTI3ICBKZXJlbXkgT3Jsb3cgIDxqb3Jsb3dA
Y2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQgYnVpbGQgZml4LgpkaWZmIC0tZ2l0
IGEvV2ViQ29yZS9sb2FkZXIvRnJhbWVMb2FkZXIuY3BwIGIvV2ViQ29yZS9sb2FkZXIvRnJhbWVM
b2FkZXIuY3BwCmluZGV4IDI4NDU3Y2UuLjEyZmJiMDEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvbG9h
ZGVyL0ZyYW1lTG9hZGVyLmNwcAorKysgYi9XZWJDb3JlL2xvYWRlci9GcmFtZUxvYWRlci5jcHAK
QEAgLTIzNzcsOCArMjM3Nyw4IEBAIHZvaWQgRnJhbWVMb2FkZXI6OmNvbW1pdFByb3Zpc2lvbmFs
TG9hZChQYXNzUmVmUHRyPENhY2hlZFBhZ2U+IHBycENhY2hlZFBhZ2UpCiAgICAgaWYgKG1fbG9h
ZGluZ0Zyb21DYWNoZWRQYWdlKSB7CiAgICAgICAgIG1fZnJhbWUtPmRvY3VtZW50KCktPmRvY3Vt
ZW50RGlkQmVjb21lQWN0aXZlKCk7CiAgICAgICAgIAotICAgICAgICAvLyBGb3JjZSBhIGxheW91
dCB0byB1cGRhdGUgdmlldyBzaXplIGFuZCB0aGVyZWJ5IHVwZGF0ZSBzY3JvbGxiYXJzLgotICAg
ICAgICBtX2ZyYW1lLT52aWV3KCktPmZvcmNlTGF5b3V0KCk7CisgICAgICAgIC8vIExheW91dCB0
byB1cGRhdGUgdmlldyBzaXplIGFuZCB0aGVyZWJ5IHVwZGF0ZSBzY3JvbGxiYXJzLgorICAgICAg
ICBtX2ZyYW1lLT52aWV3KCktPmxheW91dCgpOwogCiAgICAgICAgIGNvbnN0IFJlc3BvbnNlVmVj
dG9yJiByZXNwb25zZXMgPSBtX2RvY3VtZW50TG9hZGVyLT5yZXNwb25zZXMoKTsKICAgICAgICAg
c2l6ZV90IGNvdW50ID0gcmVzcG9uc2VzLnNpemUoKTsKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGFn
ZS9GcmFtZVZpZXcuY3BwIGIvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKaW5kZXggMzQzODk2
My4uYTg1Y2FhYyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKKysrIGIv
V2ViQ29yZS9wYWdlL0ZyYW1lVmlldy5jcHAKQEAgLTE5MDEsMTcgKzE5MDEsNiBAQCB2b2lkIEZy
YW1lVmlldzo6Zmx1c2hEZWZlcnJlZFJlcGFpbnRzKCkKICAgICBkb0RlZmVycmVkUmVwYWludHMo
KTsKIH0KIAotdm9pZCBGcmFtZVZpZXc6OmZvcmNlTGF5b3V0KGJvb2wgYWxsb3dTdWJ0cmVlKQot
ewotICAgIGxheW91dChhbGxvd1N1YnRyZWUpOwotICAgIC8vIFdlIGNhbm5vdCB1bnNjaGVkdWxl
IGEgcGVuZGluZyByZWxheW91dCwgc2luY2UgdGhlIGZvcmNlIGNhbiBiZSBjYWxsZWQgd2l0aAot
ICAgIC8vIGEgdGlueSByZWN0YW5nbGUgZnJvbSBhIGRyYXdSZWN0IHVwZGF0ZS4gIEJ5IHVuc2No
ZWR1bGluZyB3ZSBpbiBlZmZlY3QKLSAgICAvLyAidmFsaWRhdGUiIGFuZCBzdG9wIHRoZSBuZWNl
c3NhcnkgZnVsbCByZXBhaW50IGZyb20gb2NjdXJyaW5nLiAgQmFzaWNhbGx5IGFueSBiYXNpYwot
ICAgIC8vIGFwcGVuZC9yZW1vdmUgREhUTUwgaXMgYnJva2VuIGJ5IHRoaXMgY2FsbC4gIEZvciBu
b3csIEkgaGF2ZSByZW1vdmVkIHRoZSBvcHRpbWl6YXRpb24KLSAgICAvLyB1bnRpbCB3ZSBoYXZl
IGEgYmV0dGVyIGludmFsaWRhdGlvbiBzdGF0ZWd5LiAtZHdoCi0gICAgLy91bnNjaGVkdWxlUmVs
YXlvdXQoKTsKLX0KLQogdm9pZCBGcmFtZVZpZXc6OmZvcmNlTGF5b3V0V2l0aFBhZ2VXaWR0aFJh
bmdlKGZsb2F0IG1pblBhZ2VXaWR0aCwgZmxvYXQgbWF4UGFnZVdpZHRoLCBib29sIF9hZGp1c3RW
aWV3U2l6ZSkKIHsKICAgICAvLyBEdW1waW5nIGV4dGVybmFsUmVwcmVzZW50YXRpb24obV9mcmFt
ZS0+cmVuZGVyZXIoKSkuYXNjaWkoKSBpcyBhIGdvb2QgdHJpY2sgdG8gc2VlCkBAIC0xOTIyLDcg
KzE5MTEsNyBAQCB2b2lkIEZyYW1lVmlldzo6Zm9yY2VMYXlvdXRXaXRoUGFnZVdpZHRoUmFuZ2Uo
ZmxvYXQgbWluUGFnZVdpZHRoLCBmbG9hdCBtYXhQYWdlVwogICAgICAgICBpbnQgcGFnZVcgPSAo
aW50KWNlaWxmKG1pblBhZ2VXaWR0aCk7CiAgICAgICAgIHJvb3QtPnNldFdpZHRoKHBhZ2VXKTsK
ICAgICAgICAgcm9vdC0+c2V0TmVlZHNMYXlvdXRBbmRQcmVmV2lkdGhzUmVjYWxjKCk7Ci0gICAg
ICAgIGZvcmNlTGF5b3V0KCk7CisgICAgICAgIGxheW91dCgpOwogCiAgICAgICAgIC8vIElmIHdl
IGRvbid0IGZpdCBpbiB0aGUgbWluaW11bSBwYWdlIHdpZHRoLCB3ZSdsbCBsYXkgb3V0IGFnYWlu
LiBJZiB3ZSBkb24ndCBmaXQgaW4gdGhlCiAgICAgICAgIC8vIG1heGltdW0gcGFnZSB3aWR0aCwg
d2Ugd2lsbCBsYXkgb3V0IHRvIHRoZSBtYXhpbXVtIHBhZ2Ugd2lkdGggYW5kIGNsaXAgZXh0cmEg
Y29udGVudC4KQEAgLTE5MzMsNyArMTkyMiw3IEBAIHZvaWQgRnJhbWVWaWV3Ojpmb3JjZUxheW91
dFdpdGhQYWdlV2lkdGhSYW5nZShmbG9hdCBtaW5QYWdlV2lkdGgsIGZsb2F0IG1heFBhZ2VXCiAg
ICAgICAgICAgICBwYWdlVyA9IHN0ZDo6bWluKHJpZ2h0bW9zdFBvcywgKGludCljZWlsZihtYXhQ
YWdlV2lkdGgpKTsKICAgICAgICAgICAgIHJvb3QtPnNldFdpZHRoKHBhZ2VXKTsKICAgICAgICAg
ICAgIHJvb3QtPnNldE5lZWRzTGF5b3V0QW5kUHJlZldpZHRoc1JlY2FsYygpOwotICAgICAgICAg
ICAgZm9yY2VMYXlvdXQoKTsKKyAgICAgICAgICAgIGxheW91dCgpOwogICAgICAgICB9CiAgICAg
fQogCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BhZ2UvRnJhbWVWaWV3LmggYi9XZWJDb3JlL3BhZ2Uv
RnJhbWVWaWV3LmgKaW5kZXggY2JkMGNiOS4uOTg0Njk1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9w
YWdlL0ZyYW1lVmlldy5oCisrKyBiL1dlYkNvcmUvcGFnZS9GcmFtZVZpZXcuaApAQCAtMTkxLDcg
KzE5MSw2IEBAIHB1YmxpYzoKIAogICAgIHZvaWQgc2V0SXNWaXN1YWxseU5vbkVtcHR5KCkgeyBt
X2lzVmlzdWFsbHlOb25FbXB0eSA9IHRydWU7IH0KIAotICAgIHZvaWQgZm9yY2VMYXlvdXQoYm9v
bCBhbGxvd1N1YnRyZWUgPSBmYWxzZSk7CiAgICAgdm9pZCBmb3JjZUxheW91dFdpdGhQYWdlV2lk
dGhSYW5nZShmbG9hdCBtaW5QYWdlV2lkdGgsIGZsb2F0IG1heFBhZ2VXaWR0aCwgYm9vbCBhZGp1
c3RWaWV3U2l6ZSk7CiAKICAgICB2b2lkIGFkanVzdFBhZ2VIZWlnaHQoZmxvYXQqIG5ld0JvdHRv
bSwgZmxvYXQgb2xkVG9wLCBmbG9hdCBvbGRCb3R0b20sIGZsb2F0IGJvdHRvbUxpbWl0KTsKZGlm
ZiAtLWdpdCBhL1dlYktpdC9DaGFuZ2VMb2cgYi9XZWJLaXQvQ2hhbmdlTG9nCmluZGV4IGRkMGMx
YmMuLmMxMjJhZmYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L0No
YW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA0LTI3ICBCZW5qYW1pbiBQb3VsYWluICA8
YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBmb3JjZUxheW91dCgpIG9uIEZyYW1lVmll
dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxOTkK
KworICAgICAgICAqIGVmbC9ld2svZXdrX2ZyYW1lLmNwcDoKKyAgICAgICAgKGV3a19mcmFtZV9m
b3JjZV9sYXlvdXQpOgorICAgICAgICAqIGVmbC9ld2svZXdrX3ZpZXcuY3BwOgorICAgICAgICAo
X2V3a192aWV3X3NtYXJ0X2NhbGN1bGF0ZSk6CisgICAgICAgIChld2tfdmlld19maXhlZF9sYXlv
dXRfc2l6ZV9zZXQpOgorICAgICAgICAoZXdrX3ZpZXdfcGFpbnQpOgorCiAyMDEwLTA0LTIyICBM
ZWFuZHJvIFBlcmVpcmEgIDxsZWFuZHJvQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmll
d2VkIGJ5IEd1c3Rhdm8gTm9yb25oYSBTaWx2YS4KZGlmZiAtLWdpdCBhL1dlYktpdC9lZmwvZXdr
L2V3a19mcmFtZS5jcHAgYi9XZWJLaXQvZWZsL2V3ay9ld2tfZnJhbWUuY3BwCmluZGV4IDVlOTNh
MDUuLjRiN2EyNDggMTAwNjQ0Ci0tLSBhL1dlYktpdC9lZmwvZXdrL2V3a19mcmFtZS5jcHAKKysr
IGIvV2ViS2l0L2VmbC9ld2svZXdrX2ZyYW1lLmNwcApAQCAtMTgyOCw3ICsxODI4LDcgQEAgdm9p
ZCBld2tfZnJhbWVfZm9yY2VfbGF5b3V0KEV2YXNfT2JqZWN0KiBvKQogICAgIEVJTkFfU0FGRVRZ
X09OX05VTExfUkVUVVJOKHNkLT5mcmFtZSk7CiAgICAgV2ViQ29yZTo6RnJhbWVWaWV3KiB2aWV3
ID0gc2QtPmZyYW1lLT52aWV3KCk7CiAgICAgaWYgKHZpZXcpCi0gICAgICAgIHZpZXctPmZvcmNl
TGF5b3V0KHRydWUpOworICAgICAgICB2aWV3LT5sYXlvdXQodHJ1ZSk7CiB9CiAKIFdURjo6UGFz
c1JlZlB0cjxXZWJDb3JlOjpXaWRnZXQ+IGV3a19mcmFtZV9wbHVnaW5fY3JlYXRlKEV2YXNfT2Jq
ZWN0KiBvLCBjb25zdCBXZWJDb3JlOjpJbnRTaXplJiBwbHVnaW5TaXplLCBXZWJDb3JlOjpIVE1M
UGx1Z0luRWxlbWVudCogZWxlbWVudCwgY29uc3QgV2ViQ29yZTo6S1VSTCYgdXJsLCBjb25zdCBX
VEY6OlZlY3RvcjxXZWJDb3JlOjpTdHJpbmc+JiBwYXJhbU5hbWVzLCBjb25zdCBXVEY6OlZlY3Rv
cjxXZWJDb3JlOjpTdHJpbmc+JiBwYXJhbVZhbHVlcywgY29uc3QgV2ViQ29yZTo6U3RyaW5nJiBt
aW1lVHlwZSwgYm9vbCBsb2FkTWFudWFsbHkpCmRpZmYgLS1naXQgYS9XZWJLaXQvZWZsL2V3ay9l
d2tfdmlldy5jcHAgYi9XZWJLaXQvZWZsL2V3ay9ld2tfdmlldy5jcHAKaW5kZXggZDk4MTQ1OS4u
MDFhY2QwYiAxMDA2NDQKLS0tIGEvV2ViS2l0L2VmbC9ld2svZXdrX3ZpZXcuY3BwCisrKyBiL1dl
YktpdC9lZmwvZXdrL2V3a192aWV3LmNwcApAQCAtNzQ5LDcgKzc0OSw3IEBAIHN0YXRpYyB2b2lk
IF9ld2tfdmlld19zbWFydF9jYWxjdWxhdGUoRXZhc19PYmplY3QqIG8pCiAgICAgICAgIFdlYkNv
cmU6OkZyYW1lVmlldyogdmlldyA9IHByaXYtPm1haW5fZnJhbWUtPnZpZXcoKTsKICAgICAgICAg
aWYgKHZpZXcpIHsKICAgICAgICAgICAgIHZpZXctPnJlc2l6ZSh3LCBoKTsKLSAgICAgICAgICAg
IHZpZXctPmZvcmNlTGF5b3V0KCk7CisgICAgICAgICAgICB2aWV3LT5sYXlvdXQoKTsKICAgICAg
ICAgICAgIHZpZXctPmFkanVzdFZpZXdTaXplKCk7CiAgICAgICAgICAgICBJbnRTaXplIHNpemUg
PSB2aWV3LT5jb250ZW50c1NpemUoKTsKICAgICAgICAgICAgIGlmICghc2QtPmFwaS0+Y29udGVu
dHNfcmVzaXplKHNkLCBzaXplLndpZHRoKCksIHNpemUuaGVpZ2h0KCkpKQpAQCAtMTAxNiw3ICsx
MDE2LDcgQEAgdm9pZCBld2tfdmlld19maXhlZF9sYXlvdXRfc2l6ZV9zZXQoRXZhc19PYmplY3Qq
IG8sIEV2YXNfQ29vcmQgdywgRXZhc19Db29yZCBoKQogICAgIGlmICghdmlldykKICAgICAgICAg
cmV0dXJuOwogICAgIHZpZXctPnNldFVzZUZpeGVkTGF5b3V0KHByaXYtPmZpeGVkX2xheW91dC51
c2UpOwotICAgIHZpZXctPmZvcmNlTGF5b3V0KCk7CisgICAgdmlldy0+bGF5b3V0KCk7CiB9CiAK
IC8qKgpAQCAtMjg1MCw3ICsyODUwLDcgQEAgRWluYV9Cb29sIGV3a192aWV3X3BhaW50KEV3a19W
aWV3X1ByaXZhdGVfRGF0YSogcHJpdiwgY2Fpcm9fdCogY3IsIGNvbnN0IEVpbmFfUmUKICAgICBF
SU5BX1NBRkVUWV9PTl9OVUxMX1JFVFVSTl9WQUwodmlldywgRUlOQV9GQUxTRSk7CiAKICAgICBp
ZiAodmlldy0+bmVlZHNMYXlvdXQoKSkKLSAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKKyAg
ICAgICAgdmlldy0+bGF5b3V0KCk7CiAgICAgV2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0IGdjKGNy
KTsKICAgICBXZWJDb3JlOjpJbnRSZWN0IHJlY3QoYXJlYS0+eCwgYXJlYS0+eSwgYXJlYS0+dywg
YXJlYS0+aCk7CiAKZGlmZiAtLWdpdCBhL1dlYktpdC9ndGsvQ2hhbmdlTG9nIGIvV2ViS2l0L2d0
ay9DaGFuZ2VMb2cKaW5kZXggZmU5ZTA1Yi4uNGQ1OGIzYSAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0
ay9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2d0ay9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAor
MjAxMC0wNC0yNyAgQmVuamFtaW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29t
PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCBy
aWQgb2YgZm9yY2VMYXlvdXQoKSBvbiBGcmFtZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndl
YmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MTk5CisKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9y
dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHA6CisgICAgICAgIChXZWJLaXQ6OkZyYW1lTG9hZGVy
Q2xpZW50Ojpmb3JjZUxheW91dCk6CisKIDIwMTAtMDQtMjUgIFNhbSBXZWluaWcgIDxzYW1Ad2Vi
a2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAt
LWdpdCBhL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRHdGsuY3Bw
IGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKaW5k
ZXggZDc1ZmU4YS4uZGM1ZTQxMCAxMDA2NDQKLS0tIGEvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y
dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKKysrIGIvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9y
dC9GcmFtZUxvYWRlckNsaWVudEd0ay5jcHAKQEAgLTYzNyw3ICs2MzcsNyBAQCB2b2lkIEZyYW1l
TG9hZGVyQ2xpZW50Ojpmb3JjZUxheW91dCgpCiB7CiAgICAgRnJhbWVWaWV3KiB2aWV3ID0gY29y
ZShtX2ZyYW1lKS0+dmlldygpOwogICAgIGlmICh2aWV3KQotICAgICAgICB2aWV3LT5mb3JjZUxh
eW91dCh0cnVlKTsKKyAgICAgICAgdmlldy0+bGF5b3V0KHRydWUpOwogfQogCiB2b2lkIEZyYW1l
TG9hZGVyQ2xpZW50Ojpmb3JjZUxheW91dEZvck5vbkhUTUwoKQpkaWZmIC0tZ2l0IGEvV2ViS2l0
L21hYy9DaGFuZ2VMb2cgYi9XZWJLaXQvbWFjL0NoYW5nZUxvZwppbmRleCBmYTc2MDFmLi44YzZh
M2IyIDEwMDY0NAotLS0gYS9XZWJLaXQvbWFjL0NoYW5nZUxvZworKysgYi9XZWJLaXQvbWFjL0No
YW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0LTI3ICBCZW5qYW1pbiBQb3VsYWluICA8
YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ
IChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBmb3JjZUxheW91dCgpIG9uIEZyYW1lVmll
dworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxOTkK
KworICAgICAgICAqIFdlYlZpZXcvV2ViSFRNTFZpZXcubW06CisgICAgICAgICgtW1dlYkhUTUxW
aWV3IGxheW91dFRvTWluaW11bVBhZ2VXaWR0aDptYXhpbXVtUGFnZVdpZHRoOmFkanVzdGluZ1Zp
ZXdTaXplOl0pOgorCiAyMDEwLTA0LTI1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAK
ICAgICAgICAgUmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJL
aXQvbWFjL1dlYlZpZXcvV2ViSFRNTFZpZXcubW0gYi9XZWJLaXQvbWFjL1dlYlZpZXcvV2ViSFRN
TFZpZXcubW0KaW5kZXggNzZlNzk0Yi4uMTg5MDFmYiAxMDA2NDQKLS0tIGEvV2ViS2l0L21hYy9X
ZWJWaWV3L1dlYkhUTUxWaWV3Lm1tCisrKyBiL1dlYktpdC9tYWMvV2ViVmlldy9XZWJIVE1MVmll
dy5tbQpAQCAtMzA5NCw3ICszMDk0LDcgQEAgV0VCQ09SRV9DT01NQU5EKHlhbmtBbmRTZWxlY3Qp
CiAgICAgICAgIGlmIChtaW5QYWdlV2lkdGggPiAwLjApCiAgICAgICAgICAgICBjb3JlVmlldy0+
Zm9yY2VMYXlvdXRXaXRoUGFnZVdpZHRoUmFuZ2UobWluUGFnZVdpZHRoLCBtYXhQYWdlV2lkdGgs
IGFkanVzdFZpZXdTaXplKTsKICAgICAgICAgZWxzZSB7Ci0gICAgICAgICAgICBjb3JlVmlldy0+
Zm9yY2VMYXlvdXQoIWFkanVzdFZpZXdTaXplKTsKKyAgICAgICAgICAgIGNvcmVWaWV3LT5sYXlv
dXQoIWFkanVzdFZpZXdTaXplKTsKICAgICAgICAgICAgIGlmIChhZGp1c3RWaWV3U2l6ZSkKICAg
ICAgICAgICAgICAgICBjb3JlVmlldy0+YWRqdXN0Vmlld1NpemUoKTsKICAgICAgICAgfQpkaWZm
IC0tZ2l0IGEvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAgYi9XZWJLaXQvcXQvQXBpL3F3ZWJw
YWdlLmNwcAppbmRleCAwYTI0ZjBhLi5mYTdhZWIyIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQXBp
L3F3ZWJwYWdlLmNwcAorKysgYi9XZWJLaXQvcXQvQXBpL3F3ZWJwYWdlLmNwcApAQCAtMTI3LDcg
KzEyNyw3IEBAIHZvaWQgUVdFQktJVF9FWFBPUlQgcXRfd3J0X3NldFZpZXdNb2RlKFFXZWJQYWdl
KiBwYWdlLCBjb25zdCBRU3RyaW5nJiBtb2RlKQogICAgIFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9
IFFXZWJGcmFtZVByaXZhdGU6OmNvcmUocGFnZS0+bWFpbkZyYW1lKCkpOwogICAgIFdlYkNvcmU6
OkZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7CiAgICAgZnJhbWUtPmRvY3VtZW50KCkt
PnVwZGF0ZVN0eWxlU2VsZWN0b3IoKTsKLSAgICB2aWV3LT5mb3JjZUxheW91dCgpOworICAgIHZp
ZXctPmxheW91dCgpOwogfQogCiBib29sIFFXZWJQYWdlUHJpdmF0ZTo6ZHJ0UnVuID0gZmFsc2U7
CkBAIC0yMDYzLDcgKzIwNjMsNyBAQCB2b2lkIFFXZWJQYWdlOjpzZXRWaWV3cG9ydFNpemUoY29u
c3QgUVNpemUgJnNpemUpIGNvbnN0CiAgICAgaWYgKGZyYW1lLT5kLT5mcmFtZSAmJiBmcmFtZS0+
ZC0+ZnJhbWUtPnZpZXcoKSkgewogICAgICAgICBXZWJDb3JlOjpGcmFtZVZpZXcqIHZpZXcgPSBm
cmFtZS0+ZC0+ZnJhbWUtPnZpZXcoKTsKICAgICAgICAgdmlldy0+c2V0RnJhbWVSZWN0KFFSZWN0
KFFQb2ludCgwLCAwKSwgc2l6ZSkpOwotICAgICAgICB2aWV3LT5mb3JjZUxheW91dCgpOworICAg
ICAgICB2aWV3LT5sYXlvdXQoKTsKICAgICAgICAgdmlldy0+YWRqdXN0Vmlld1NpemUoKTsKICAg
ICB9CiB9CkBAIC0yMTAwLDEwICsyMTAwLDEwIEBAIHZvaWQgUVdlYlBhZ2U6OnNldFByZWZlcnJl
ZENvbnRlbnRzU2l6ZShjb25zdCBRU2l6ZSAmc2l6ZSkgY29uc3QKICAgICAgICAgaWYgKHNpemUu
aXNWYWxpZCgpKSB7CiAgICAgICAgICAgICB2aWV3LT5zZXRVc2VGaXhlZExheW91dCh0cnVlKTsK
ICAgICAgICAgICAgIHZpZXctPnNldEZpeGVkTGF5b3V0U2l6ZShzaXplKTsKLSAgICAgICAgICAg
IHZpZXctPmZvcmNlTGF5b3V0KCk7CisgICAgICAgICAgICB2aWV3LT5sYXlvdXQoKTsKICAgICAg
ICAgfSBlbHNlIGlmICh2aWV3LT51c2VGaXhlZExheW91dCgpKSB7CiAgICAgICAgICAgICB2aWV3
LT5zZXRVc2VGaXhlZExheW91dChmYWxzZSk7Ci0gICAgICAgICAgICB2aWV3LT5mb3JjZUxheW91
dCgpOworICAgICAgICAgICAgdmlldy0+bGF5b3V0KCk7CiAgICAgICAgIH0KICAgICB9CiB9CmRp
ZmYgLS1naXQgYS9XZWJLaXQvcXQvQ2hhbmdlTG9nIGIvV2ViS2l0L3F0L0NoYW5nZUxvZwppbmRl
eCA5ZWYxNmVmLi42YmIzNGRjIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvQ2hhbmdlTG9nCisrKyBi
L1dlYktpdC9xdC9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0yNyAgQmVuamFt
aW4gUG91bGFpbiAgPGJlbmphbWluLnBvdWxhaW5Abm9raWEuY29tPgorCisgICAgICAgIFJldmll
d2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEdldCByaWQgb2YgZm9yY2VMYXlvdXQo
KSBvbiBGcmFtZVZpZXcKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu
Y2dpP2lkPTM4MTk5CisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAocXRf
d3J0X3NldFZpZXdNb2RlKToKKyAgICAgICAgKFFXZWJQYWdlOjpzZXRWaWV3cG9ydFNpemUpOgor
ICAgICAgICAoUVdlYlBhZ2U6OnNldFByZWZlcnJlZENvbnRlbnRzU2l6ZSk6CisgICAgICAgICog
V2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwOgorICAgICAgICAoRHVt
cFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldE1lZGlhVHlwZSk6CisgICAgICAgICogV2ViQ29yZVN1
cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpGcmFtZUxv
YWRlckNsaWVudFF0Ojpmb3JjZUxheW91dCk6CisKIDIwMTAtMDQtMjUgIFNhbSBXZWluaWcgIDxz
YW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4K
ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBv
cnRRdC5jcHAgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0
UXQuY3BwCmluZGV4IGI0NWY0MTguLmFmNmRiZWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9xdC9XZWJD
b3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dl
YkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcApAQCAtMzQyLDcgKzM0Miw3
IEBAIHZvaWQgRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQ6OnNldE1lZGlhVHlwZShRV2ViRnJhbWUq
IGZyYW1lLCBjb25zdCBRU3RyaW5nJiB0eXBlCiAgICAgV2ViQ29yZTo6RnJhbWVWaWV3KiB2aWV3
ID0gY29yZUZyYW1lLT52aWV3KCk7CiAgICAgdmlldy0+c2V0TWVkaWFUeXBlKHR5cGUpOwogICAg
IGNvcmVGcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVTZWxlY3RvcigpOwotICAgIHZpZXct
PmZvcmNlTGF5b3V0KCk7CisgICAgdmlldy0+bGF5b3V0KCk7CiB9CiAKIHZvaWQgRHVtcFJlbmRl
clRyZWVTdXBwb3J0UXQ6OnNldFNtYXJ0SW5zZXJ0RGVsZXRlRW5hYmxlZChRV2ViUGFnZSogcGFn
ZSwgYm9vbCBlbmFibGVkKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0Zy
YW1lTG9hZGVyQ2xpZW50UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h
ZGVyQ2xpZW50UXQuY3BwCmluZGV4IDdhMzkyZTAuLmEwYjA2ZmIgMTAwNjQ0Ci0tLSBhL1dlYktp
dC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAorKysgYi9XZWJLaXQv
cXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKQEAgLTI1OCw3ICsyNTgs
NyBAQCB2b2lkIEZyYW1lTG9hZGVyQ2xpZW50UXQ6OmZvcmNlTGF5b3V0KCkKIHsKICAgICBGcmFt
ZVZpZXcqIHZpZXcgPSBtX2ZyYW1lLT52aWV3KCk7CiAgICAgaWYgKHZpZXcpCi0gICAgICAgIHZp
ZXctPmZvcmNlTGF5b3V0KHRydWUpOworICAgICAgICB2aWV3LT5sYXlvdXQodHJ1ZSk7CiB9CiAK
IApkaWZmIC0tZ2l0IGEvV2ViS2l0L3dpbi9DaGFuZ2VMb2cgYi9XZWJLaXQvd2luL0NoYW5nZUxv
ZwppbmRleCAwMGUwZjZjLi4yYzBhZmNmIDEwMDY0NAotLS0gYS9XZWJLaXQvd2luL0NoYW5nZUxv
ZworKysgYi9XZWJLaXQvd2luL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0LTI3
ICBCZW5qYW1pbiBQb3VsYWluICA8YmVuamFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAg
ICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBmb3Jj
ZUxheW91dCgpIG9uIEZyYW1lVmlldworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z
aG93X2J1Zy5jZ2k/aWQ9MzgxOTkKKworICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L1dlYkZyYW1l
TG9hZGVyQ2xpZW50LmNwcDoKKyAgICAgICAgKFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojpmb3JjZUxh
eW91dCk6CisKIDIwMTAtMDQtMjUgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAg
ICAgICBSZXZpZXdlZCBieSBNYWNpZWogU3RhY2hvd2lhay4KZGlmZiAtLWdpdCBhL1dlYktpdC93
aW4vV2ViQ29yZVN1cHBvcnQvV2ViRnJhbWVMb2FkZXJDbGllbnQuY3BwIGIvV2ViS2l0L3dpbi9X
ZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRlckNsaWVudC5jcHAKaW5kZXggNDhmN2YzYi4uNDU4
ZmJmNCAxMDA2NDQKLS0tIGEvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRl
ckNsaWVudC5jcHAKKysrIGIvV2ViS2l0L3dpbi9XZWJDb3JlU3VwcG9ydC9XZWJGcmFtZUxvYWRl
ckNsaWVudC5jcHAKQEAgLTEwOCw3ICsxMDgsNyBAQCB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50
Ojpmb3JjZUxheW91dCgpCiAgICAgICAgIHJldHVybjsKIAogICAgIHZpZXctPnNldE5lZWRzTGF5
b3V0KCk7Ci0gICAgdmlldy0+Zm9yY2VMYXlvdXQodHJ1ZSk7CisgICAgdmlldy0+bGF5b3V0KHRy
dWUpOwogfQogCiB2b2lkIFdlYkZyYW1lTG9hZGVyQ2xpZW50Ojphc3NpZ25JZGVudGlmaWVyVG9J
bml0aWFsUmVxdWVzdCh1bnNpZ25lZCBsb25nIGlkZW50aWZpZXIsIERvY3VtZW50TG9hZGVyKiBs
b2FkZXIsIGNvbnN0IFJlc291cmNlUmVxdWVzdCYgcmVxdWVzdCkKZGlmZiAtLWdpdCBhL1dlYktp
dC93eC9DaGFuZ2VMb2cgYi9XZWJLaXQvd3gvQ2hhbmdlTG9nCmluZGV4IDk2YjBiMjIuLmY2NzQ5
MWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC93eC9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L3d4L0NoYW5n
ZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0LTI3ICBCZW5qYW1pbiBQb3VsYWluICA8YmVu
amFtaW4ucG91bGFpbkBub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChP
T1BTISkuCisKKyAgICAgICAgR2V0IHJpZCBvZiBmb3JjZUxheW91dCgpIG9uIEZyYW1lVmlldwor
ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxOTkKKwor
ICAgICAgICAqIFdlYlZpZXcuY3BwOgorICAgICAgICAod3hXZWJWaWV3OjpPblNpemUpOgorCiAy
MDEwLTA0LTI1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3
ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJLaXQvd3gvV2ViVmlldy5j
cHAgYi9XZWJLaXQvd3gvV2ViVmlldy5jcHAKaW5kZXggODNmNzRkMy4uMzVhMmJiZiAxMDA2NDQK
LS0tIGEvV2ViS2l0L3d4L1dlYlZpZXcuY3BwCisrKyBiL1dlYktpdC93eC9XZWJWaWV3LmNwcApA
QCAtNTgxLDcgKzU4MSw3IEBAIHZvaWQgd3hXZWJWaWV3OjpPblNpemUod3hTaXplRXZlbnQmIGV2
ZW50KQogICAgIGlmIChtX2lzSW5pdGlhbGl6ZWQgJiYgbV9tYWluRnJhbWUpIHsKICAgICAgICAg
V2ViQ29yZTo6RnJhbWUqIGZyYW1lID0gbV9tYWluRnJhbWUtPkdldEZyYW1lKCk7CiAgICAgICAg
IGZyYW1lLT52aWV3KCktPnNldEZyYW1lUmVjdCh3eFJlY3Qod3hQb2ludCgwLDApLCBldmVudC5H
ZXRTaXplKCkpKTsKLSAgICAgICAgZnJhbWUtPnZpZXcoKS0+Zm9yY2VMYXlvdXQoKTsKKyAgICAg
ICAgZnJhbWUtPnZpZXcoKS0+bGF5b3V0KCk7CiAgICAgICAgIGZyYW1lLT52aWV3KCktPmFkanVz
dFZpZXdTaXplKCk7CiAgICAgfQogICAgICAgCg==
</data>
<flag name="review"
          id="38383"
          type_id="1"
          status="-"
          setter="simon.fraser"
    />
    <flag name="commit-queue"
          id="38384"
          type_id="3"
          status="-"
          setter="simon.fraser"
    />
          </attachment>
          <attachment
              isobsolete="1"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54686</attachid>
            <date>2010-04-29 02:40:02 -0700</date>
            <delta_ts>2010-04-29 07:39:30 -0700</delta_ts>
            <desc>Patch for Qt only</desc>
            <filename>38199_Qt.patch</filename>
            <type>text/plain</type>
            <size>3111</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x
d2VicGFnZS5jcHAKaW5kZXggMGEyNGYwYS4uZDU2OWY1ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0
L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEy
Nyw3ICsxMjcsNyBAQCB2b2lkIFFXRUJLSVRfRVhQT1JUIHF0X3dydF9zZXRWaWV3TW9kZShRV2Vi
UGFnZSogcGFnZSwgY29uc3QgUVN0cmluZyYgbW9kZSkKICAgICBXZWJDb3JlOjpGcmFtZSogZnJh
bWUgPSBRV2ViRnJhbWVQcml2YXRlOjpjb3JlKHBhZ2UtPm1haW5GcmFtZSgpKTsKICAgICBXZWJD
b3JlOjpGcmFtZVZpZXcqIHZpZXcgPSBmcmFtZS0+dmlldygpOwogICAgIGZyYW1lLT5kb2N1bWVu
dCgpLT51cGRhdGVTdHlsZVNlbGVjdG9yKCk7Ci0gICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKKyAg
ICB2aWV3LT5sYXlvdXQoKTsKIH0KIAogYm9vbCBRV2ViUGFnZVByaXZhdGU6OmRydFJ1biA9IGZh
bHNlOwpAQCAtMjEwMCwxMCArMjEwMCwxMCBAQCB2b2lkIFFXZWJQYWdlOjpzZXRQcmVmZXJyZWRD
b250ZW50c1NpemUoY29uc3QgUVNpemUgJnNpemUpIGNvbnN0CiAgICAgICAgIGlmIChzaXplLmlz
VmFsaWQoKSkgewogICAgICAgICAgICAgdmlldy0+c2V0VXNlRml4ZWRMYXlvdXQodHJ1ZSk7CiAg
ICAgICAgICAgICB2aWV3LT5zZXRGaXhlZExheW91dFNpemUoc2l6ZSk7Ci0gICAgICAgICAgICB2
aWV3LT5mb3JjZUxheW91dCgpOworICAgICAgICAgICAgdmlldy0+bGF5b3V0KCk7CiAgICAgICAg
IH0gZWxzZSBpZiAodmlldy0+dXNlRml4ZWRMYXlvdXQoKSkgewogICAgICAgICAgICAgdmlldy0+
c2V0VXNlRml4ZWRMYXlvdXQoZmFsc2UpOwotICAgICAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQo
KTsKKyAgICAgICAgICAgIHZpZXctPmxheW91dCgpOwogICAgICAgICB9CiAgICAgfQogfQpkaWZm
IC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktpdC9xdC9DaGFuZ2VMb2cKaW5kZXgg
OWVmMTZlZi4uMTU4MTc0OSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L0NoYW5nZUxvZworKysgYi9X
ZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAKKzIwMTAtMDQtMjkgIEJlbmphbWlu
IFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNvbT4KKworICAgICAgICBSZXZpZXdl
ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXQgcmlkIG9mIGZvcmNlTGF5b3V0KCkg
b24gRnJhbWVWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn
aT9pZD0zODE5OQorCisgICAgICAgIFRoZSBmdW5jdGlvbiBGcmFtZVZpZXc6OmZvcmNlTGF5b3V0
KCkgaXMgbWlzc2xlYWRpbmcKKyAgICAgICAgYmVjYXVzZSBpdCBkb2VzIG5vdCBhY3R1YWxseSBm
b3JjZSB0aGUgbGF5b3V0LCB0aGUgY2FsbCBpcworICAgICAgICBlcXVpdmFsZW50IHRvIGxheW91
dCgpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVwbGFjZSB0aGUgY2FsbCB0byBmb3JjZUxheW91
dCgpIGJ5IGxheW91dCgpIGluIFF0CisgICAgICAgIHRvIGF2b2lkIHRoZSBtaXN1bmRlcnN0YW5k
aW5nL2ltcHJvdmUgcmVhZGFiaWxpdHkuCisKKyAgICAgICAgKiBBcGkvcXdlYnBhZ2UuY3BwOgor
ICAgICAgICAocXRfd3J0X3NldFZpZXdNb2RlKToKKyAgICAgICAgKFFXZWJQYWdlOjpzZXRQcmVm
ZXJyZWRDb250ZW50c1NpemUpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJU
cmVlU3VwcG9ydFF0LmNwcDoKKyAgICAgICAgKER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRN
ZWRpYVR5cGUpOgorICAgICAgICAqIFdlYkNvcmVTdXBwb3J0L0ZyYW1lTG9hZGVyQ2xpZW50UXQu
Y3BwOgorICAgICAgICAoV2ViQ29yZTo6RnJhbWVMb2FkZXJDbGllbnRRdDo6Zm9yY2VMYXlvdXQp
OgorCiAyMDEwLTA0LTI1ICBTYW0gV2VpbmlnICA8c2FtQHdlYmtpdC5vcmc+CiAKICAgICAgICAg
UmV2aWV3ZWQgYnkgTWFjaWVqIFN0YWNob3dpYWsuCmRpZmYgLS1naXQgYS9XZWJLaXQvcXQvV2Vi
Q29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVTdXBwb3J0UXQuY3BwIGIvV2ViS2l0L3F0L1dlYkNv
cmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcAppbmRleCBiNDVmNDE4Li5hZjZk
YmVlIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT
dXBwb3J0UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJl
ZVN1cHBvcnRRdC5jcHAKQEAgLTM0Miw3ICszNDIsNyBAQCB2b2lkIER1bXBSZW5kZXJUcmVlU3Vw
cG9ydFF0OjpzZXRNZWRpYVR5cGUoUVdlYkZyYW1lKiBmcmFtZSwgY29uc3QgUVN0cmluZyYgdHlw
ZQogICAgIFdlYkNvcmU6OkZyYW1lVmlldyogdmlldyA9IGNvcmVGcmFtZS0+dmlldygpOwogICAg
IHZpZXctPnNldE1lZGlhVHlwZSh0eXBlKTsKICAgICBjb3JlRnJhbWUtPmRvY3VtZW50KCktPnVw
ZGF0ZVN0eWxlU2VsZWN0b3IoKTsKLSAgICB2aWV3LT5mb3JjZUxheW91dCgpOworICAgIHZpZXct
PmxheW91dCgpOwogfQogCiB2b2lkIER1bXBSZW5kZXJUcmVlU3VwcG9ydFF0OjpzZXRTbWFydElu
c2VydERlbGV0ZUVuYWJsZWQoUVdlYlBhZ2UqIHBhZ2UsIGJvb2wgZW5hYmxlZCkKZGlmZiAtLWdp
dCBhL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcCBiL1dl
YktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcAppbmRleCA3YTM5
MmUwLi5hMGIwNmZiIDEwMDY0NAotLS0gYS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVM
b2FkZXJDbGllbnRRdC5jcHAKKysrIGIvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h
ZGVyQ2xpZW50UXQuY3BwCkBAIC0yNTgsNyArMjU4LDcgQEAgdm9pZCBGcmFtZUxvYWRlckNsaWVu
dFF0Ojpmb3JjZUxheW91dCgpCiB7CiAgICAgRnJhbWVWaWV3KiB2aWV3ID0gbV9mcmFtZS0+dmll
dygpOwogICAgIGlmICh2aWV3KQotICAgICAgICB2aWV3LT5mb3JjZUxheW91dCh0cnVlKTsKKyAg
ICAgICAgdmlldy0+bGF5b3V0KHRydWUpOwogfQogCiAK
</data>
<flag name="review"
          id="38703"
          type_id="1"
          status="+"
          setter="kenneth"
    />
    <flag name="commit-queue"
          id="38704"
          type_id="3"
          status="-"
          setter="commit-queue"
    />
          </attachment>
          <attachment
              isobsolete="0"
              ispatch="1"
              isprivate="0"
          >
            <attachid>54706</attachid>
            <date>2010-04-29 07:39:30 -0700</date>
            <delta_ts>2010-04-29 10:35:21 -0700</delta_ts>
            <desc>Patch for Qt only</desc>
            <filename>38199_Qt.patch</filename>
            <type>text/plain</type>
            <size>3166</size>
            <attacher name="Benjamin Poulain">benjamin</attacher>
            
              <data encoding="base64">ZGlmZiAtLWdpdCBhL1dlYktpdC9xdC9BcGkvcXdlYnBhZ2UuY3BwIGIvV2ViS2l0L3F0L0FwaS9x
d2VicGFnZS5jcHAKaW5kZXggOTFmODRhOS4uNWM1Zjc5ZiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0
L0FwaS9xd2VicGFnZS5jcHAKKysrIGIvV2ViS2l0L3F0L0FwaS9xd2VicGFnZS5jcHAKQEAgLTEy
MTYsNyArMTIxNiw3IEBAIHZvaWQgUVdlYlBhZ2VQcml2YXRlOjpkeW5hbWljUHJvcGVydHlDaGFu
Z2VFdmVudChRRHluYW1pY1Byb3BlcnR5Q2hhbmdlRXZlbnQqIGV2CiAgICAgICAgICAgICBXZWJD
b3JlOjpGcmFtZSogZnJhbWUgPSBRV2ViRnJhbWVQcml2YXRlOjpjb3JlKHEtPm1haW5GcmFtZSgp
KTsKICAgICAgICAgICAgIFdlYkNvcmU6OkZyYW1lVmlldyogdmlldyA9IGZyYW1lLT52aWV3KCk7
CiAgICAgICAgICAgICBmcmFtZS0+ZG9jdW1lbnQoKS0+dXBkYXRlU3R5bGVTZWxlY3RvcigpOwot
ICAgICAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKKyAgICAgICAgICAgIHZpZXctPmxheW91
dCgpOwogICAgICAgICB9CiAgICAgfQogfQpAQCAtMjEwNCwxMCArMjEwNCwxMCBAQCB2b2lkIFFX
ZWJQYWdlOjpzZXRQcmVmZXJyZWRDb250ZW50c1NpemUoY29uc3QgUVNpemUgJnNpemUpIGNvbnN0
CiAgICAgICAgIGlmIChzaXplLmlzVmFsaWQoKSkgewogICAgICAgICAgICAgdmlldy0+c2V0VXNl
Rml4ZWRMYXlvdXQodHJ1ZSk7CiAgICAgICAgICAgICB2aWV3LT5zZXRGaXhlZExheW91dFNpemUo
c2l6ZSk7Ci0gICAgICAgICAgICB2aWV3LT5mb3JjZUxheW91dCgpOworICAgICAgICAgICAgdmll
dy0+bGF5b3V0KCk7CiAgICAgICAgIH0gZWxzZSBpZiAodmlldy0+dXNlRml4ZWRMYXlvdXQoKSkg
ewogICAgICAgICAgICAgdmlldy0+c2V0VXNlRml4ZWRMYXlvdXQoZmFsc2UpOwotICAgICAgICAg
ICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKKyAgICAgICAgICAgIHZpZXctPmxheW91dCgpOwogICAg
ICAgICB9CiAgICAgfQogfQpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L0NoYW5nZUxvZyBiL1dlYktp
dC9xdC9DaGFuZ2VMb2cKaW5kZXggMzlhNTIxNy4uNDc4M2RhMyAxMDA2NDQKLS0tIGEvV2ViS2l0
L3F0L0NoYW5nZUxvZworKysgYi9XZWJLaXQvcXQvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjUgQEAK
KzIwMTAtMDQtMjkgIEJlbmphbWluIFBvdWxhaW4gIDxiZW5qYW1pbi5wb3VsYWluQG5va2lhLmNv
bT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBHZXQg
cmlkIG9mIGZvcmNlTGF5b3V0KCkgb24gRnJhbWVWaWV3CisgICAgICAgIGh0dHBzOi8vYnVncy53
ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODE5OQorCisgICAgICAgIFRoZSBmdW5jdGlvbiBG
cmFtZVZpZXc6OmZvcmNlTGF5b3V0KCkgaXMgbWlzc2xlYWRpbmcKKyAgICAgICAgYmVjYXVzZSBp
dCBkb2VzIG5vdCBhY3R1YWxseSBmb3JjZSB0aGUgbGF5b3V0LCB0aGUgY2FsbCBpcworICAgICAg
ICBlcXVpdmFsZW50IHRvIGxheW91dCgpLgorCisgICAgICAgIFRoaXMgcGF0Y2ggcmVwbGFjZSB0
aGUgY2FsbCB0byBmb3JjZUxheW91dCgpIGJ5IGxheW91dCgpIGluIFF0CisgICAgICAgIHRvIGF2
b2lkIHRoZSBtaXN1bmRlcnN0YW5kaW5nL2ltcHJvdmUgcmVhZGFiaWxpdHkuCisKKyAgICAgICAg
KiBBcGkvcXdlYnBhZ2UuY3BwOgorICAgICAgICAoUVdlYlBhZ2VQcml2YXRlOjpkeW5hbWljUHJv
cGVydHlDaGFuZ2VFdmVudCk6CisgICAgICAgIChRV2ViUGFnZTo6c2V0UHJlZmVycmVkQ29udGVu
dHNTaXplKToKKyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRR
dC5jcHA6CisgICAgICAgIChEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0TWVkaWFUeXBlKToK
KyAgICAgICAgKiBXZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRlckNsaWVudFF0LmNwcDoKKyAgICAg
ICAgKFdlYkNvcmU6OkZyYW1lTG9hZGVyQ2xpZW50UXQ6OmZvcmNlTGF5b3V0KToKKwogMjAxMC0w
NC0yOSAgQW5kcmVhcyBLbGluZyAgPGFuZHJlYXMua2xpbmdAbm9raWEuY29tPgogCiAgICAgICAg
IFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L3F0L1dlYkNv
cmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3VwcG9ydFF0LmNwcCBiL1dlYktpdC9xdC9XZWJDb3Jl
U3VwcG9ydC9EdW1wUmVuZGVyVHJlZVN1cHBvcnRRdC5jcHAKaW5kZXggMjJkM2ViOC4uN2M1MzMw
ZSAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0R1bXBSZW5kZXJUcmVlU3Vw
cG9ydFF0LmNwcAorKysgYi9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRHVtcFJlbmRlclRyZWVT
dXBwb3J0UXQuY3BwCkBAIC0zNDcsNyArMzQ3LDcgQEAgdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBv
cnRRdDo6c2V0TWVkaWFUeXBlKFFXZWJGcmFtZSogZnJhbWUsIGNvbnN0IFFTdHJpbmcmIHR5cGUK
ICAgICBXZWJDb3JlOjpGcmFtZVZpZXcqIHZpZXcgPSBjb3JlRnJhbWUtPnZpZXcoKTsKICAgICB2
aWV3LT5zZXRNZWRpYVR5cGUodHlwZSk7CiAgICAgY29yZUZyYW1lLT5kb2N1bWVudCgpLT51cGRh
dGVTdHlsZVNlbGVjdG9yKCk7Ci0gICAgdmlldy0+Zm9yY2VMYXlvdXQoKTsKKyAgICB2aWV3LT5s
YXlvdXQoKTsKIH0KIAogdm9pZCBEdW1wUmVuZGVyVHJlZVN1cHBvcnRRdDo6c2V0U21hcnRJbnNl
cnREZWxldGVFbmFibGVkKFFXZWJQYWdlKiBwYWdlLCBib29sIGVuYWJsZWQpCmRpZmYgLS1naXQg
YS9XZWJLaXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAgYi9XZWJL
aXQvcXQvV2ViQ29yZVN1cHBvcnQvRnJhbWVMb2FkZXJDbGllbnRRdC5jcHAKaW5kZXggN2EzOTJl
MC4uYTBiMDZmYiAxMDA2NDQKLS0tIGEvV2ViS2l0L3F0L1dlYkNvcmVTdXBwb3J0L0ZyYW1lTG9h
ZGVyQ2xpZW50UXQuY3BwCisrKyBiL1dlYktpdC9xdC9XZWJDb3JlU3VwcG9ydC9GcmFtZUxvYWRl
ckNsaWVudFF0LmNwcApAQCAtMjU4LDcgKzI1OCw3IEBAIHZvaWQgRnJhbWVMb2FkZXJDbGllbnRR
dDo6Zm9yY2VMYXlvdXQoKQogewogICAgIEZyYW1lVmlldyogdmlldyA9IG1fZnJhbWUtPnZpZXco
KTsKICAgICBpZiAodmlldykKLSAgICAgICAgdmlldy0+Zm9yY2VMYXlvdXQodHJ1ZSk7CisgICAg
ICAgIHZpZXctPmxheW91dCh0cnVlKTsKIH0KIAogCg==
</data>

          </attachment>
      

    </bug>

</bugzilla>