38186 2010-04-27 01:57:22 -0700 REGRESSION(r58261): webkit-patch upload does not work in an SVN checkout. 2010-04-27 02:35:26 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 mjs webkit-unassigned abarth eric ojan webkit.review.bot oldest_to_newest 217596 0 mjs 2010-04-27 01:57:22 -0700 webkit-patch upload does not work in an SVN checkout. This is a regression from r58261. It gives this error: $ webkit-patch upload Parsing ChangeLog: /Users/mjs/Work/src/Safari/OpenSource/WebCore/ChangeLog Traceback (most recent call last): File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkit-patch", line 56, in <module> main() File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkit-patch", line 51, in main WebKitPatch(__file__).main() File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 302, in main result = command.check_arguments_and_execute(options, args, self) File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/multicommandtool.py", line 113, in check_arguments_and_execute return self.execute(options, args, tool) or 0 File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/abstractsequencedcommand.py", line 43, in execute self._sequence.run_and_handle_errors(tool, options, self._prepare_state(options, args, tool)) File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 66, in run_and_handle_errors self._run(tool, options, state) File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/commands/stepsequence.py", line 60, in _run step(tool, options).run(state) File "/Users/mjs/Work/src/Safari/OpenSource/WebKitTools/Scripts/webkitpy/tool/steps/checkstyle.py", line 56, in run if self._tool.scm().should_squash(self._options.squash): AttributeError: SVN instance has no attribute 'should_squash' 217598 1 54400 abarth 2010-04-27 02:02:20 -0700 Created attachment 54400 Patch 217599 2 webkit.review.bot 2010-04-27 02:05:08 -0700 Attachment 54400 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebKitTools/Scripts/webkitpy/common/checkout/scm.py:215: deprecated form of raising exception [pep8/W602] [5] Total errors found: 1 in 3 files If any of these errors are false positives, please file a bug against check-webkit-style. 217600 3 54400 mjs 2010-04-27 02:07:21 -0700 Comment on attachment 54400 Patch r=me You may want to fix the style complaints before committing. 217603 4 abarth 2010-04-27 02:10:24 -0700 Committed r58297: <http://trac.webkit.org/changeset/58297> 217611 5 abarth 2010-04-27 02:27:14 -0700 We use this style for "NotImplemented" exceptions because Eric said it integrates with some python tool. I'm not sure if that's something we still care about now that we've adopted PEP8. 217612 6 eric 2010-04-27 02:31:10 -0700 The tool is pylint. But we don't have to follow it to the letter. WE just have to throw NotImplemented. But we could throw the more supported raise NotImplemented("foo") i think. 217614 7 eric 2010-04-27 02:32:28 -0700 raise NotImplementedError("foo") rather. 217616 8 eric 2010-04-27 02:35:26 -0700 We could test this using something like: http://trac.webkit.org/browser/trunk/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py#L159 which just called SVN.should_squash to validate it returned false. 54400 2010-04-27 02:02:20 -0700 2010-04-27 02:33:54 -0700 Patch bug-38186-20100427020219.patch text/plain 2753 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4Mjk2KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjcgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBSRUdSRVNTSU9OKHI1ODI2MSk6IHdlYmtpdC1wYXRjaCB1cGxvYWQgZG9lcyBub3Qg d29yayBpbiBhbiBTVk4gY2hlY2tvdXQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zODE4NgorCisgICAgICAgIFVuZm9ydHVuYXRlbHksIHdlIGRvbid0 IGhhdmUgYSBnb29kIHdheSBvZiB0ZXN0aW5nIHRoaXMgY2hhbmdlIGJlY2F1c2UKKyAgICAgICAg b3VyIHRlc3QgY292ZXJhZ2Ugb2YgdGhlIHNjbS5weSBBUEkgaXMgcG9vci4uLgorCisgICAgICAg ICogU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvc2NtLnB5OgorICAgICAgICAqIFNj cmlwdHMvd2Via2l0cHkvdG9vbC9zdGVwcy9wcmVwYXJlY2hhbmdlbG9nLnB5OgorCiAyMDEwLTA0 LTI2ICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBi eSBBZGFtIEJhcnRoLgpJbmRleDogV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24v Y2hlY2tvdXQvc2NtLnB5Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0 cHkvY29tbW9uL2NoZWNrb3V0L3NjbS5weQkocmV2aXNpb24gNTgyOTYpCisrKyBXZWJLaXRUb29s cy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9zY20ucHkJKHdvcmtpbmcgY29weSkK QEAgLTIxMSw2ICsyMTEsOSBAQCBjbGFzcyBTQ006CiAgICAgZGVmIHJldmVydF9maWxlcyhzZWxm LCBmaWxlX3BhdGhzKToKICAgICAgICAgcmFpc2UgTm90SW1wbGVtZW50ZWRFcnJvciwgInN1YmNs YXNzZXMgbXVzdCBpbXBsZW1lbnQiCiAKKyAgICBkZWYgc2hvdWxkX3NxdWFzaChzZWxmLCBzcXVh c2gpOgorICAgICAgICByYWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0 IGltcGxlbWVudCIKKwogICAgIGRlZiBjb21taXRfd2l0aF9tZXNzYWdlKHNlbGYsIG1lc3NhZ2Us IHVzZXJuYW1lPU5vbmUsIGdpdF9jb21taXQ9Tm9uZSwgc3F1YXNoPU5vbmUpOgogICAgICAgICBy YWlzZSBOb3RJbXBsZW1lbnRlZEVycm9yLCAic3ViY2xhc3NlcyBtdXN0IGltcGxlbWVudCIKIApA QCAtMzkxLDYgKzM5NCwxMCBAQCBjbGFzcyBTVk4oU0NNKToKICAgICAgICAgIyBGSVhNRTogVGhp cyBzaG91bGQgcHJvYmFibHkgdXNlIGN3ZD1zZWxmLmNoZWNrb3V0X3Jvb3QuCiAgICAgICAgIHJ1 bl9jb21tYW5kKFsnc3ZuJywgJ3JldmVydCddICsgZmlsZV9wYXRocykKIAorICAgIGRlZiBzaG91 bGRfc3F1YXNoKHNlbGYsIHNxdWFzaCk6CisgICAgICAgICMgU1ZOIGRvZXNuJ3Qgc3VwcG9ydCB0 aGUgY29uY2VwdCBvZiBzcXVhc2hpbmcuCisgICAgICAgIHJldHVybiBGYWxzZQorCiAgICAgZGVm IGNvbW1pdF93aXRoX21lc3NhZ2Uoc2VsZiwgbWVzc2FnZSwgdXNlcm5hbWU9Tm9uZSwgZ2l0X2Nv bW1pdD1Ob25lLCBzcXVhc2g9Tm9uZSk6CiAgICAgICAgICMgc3F1YXNoIGFuZCBnaXQtY29tbWl0 IGFyZSBub3QgdXNlZCBieSBTVk4uCiAgICAgICAgIGlmIHNlbGYuZHJ5cnVuOgpJbmRleDogV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3ByZXBhcmVjaGFuZ2Vsb2cucHkK PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PQotLS0gV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL3By ZXBhcmVjaGFuZ2Vsb2cucHkJKHJldmlzaW9uIDU4Mjk2KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0 cy93ZWJraXRweS90b29sL3N0ZXBzL3ByZXBhcmVjaGFuZ2Vsb2cucHkJKHdvcmtpbmcgY29weSkK QEAgLTU1LDggKzU1LDcgQEAgY2xhc3MgUHJlcGFyZUNoYW5nZUxvZyhBYnN0cmFjdFN0ZXApOgog ICAgICAgICAgICAgYXJncy5hcHBlbmQoIi0tYnVnPSVzIiAlIHN0YXRlWyJidWdfaWQiXSkKICAg ICAgICAgaWYgc2VsZi5fb3B0aW9ucy5lbWFpbDoKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCIt LWVtYWlsPSVzIiAlIHNlbGYuX29wdGlvbnMuZW1haWwpCi0gICAgICAgIGlmIChzZWxmLl90b29s LnNjbSgpLnN1cHBvcnRzX2xvY2FsX2NvbW1pdHMoKSBhbmQKLSAgICAgICAgICAgIHNlbGYuX3Rv b2wuc2NtKCkuc2hvdWxkX3NxdWFzaChzZWxmLl9vcHRpb25zLnNxdWFzaCkpOgorICAgICAgICBp ZiBzZWxmLl90b29sLnNjbSgpLnNob3VsZF9zcXVhc2goc2VsZi5fb3B0aW9ucy5zcXVhc2gpOgog ICAgICAgICAgICAgYXJncy5hcHBlbmQoIi0tbWVyZ2UtYmFzZT0lcyIgJSBzZWxmLl90b29sLnNj bSgpLnN2bl9tZXJnZV9iYXNlKCkpCiAgICAgICAgIGlmIHNlbGYuX29wdGlvbnMuZ2l0X2NvbW1p dDoKICAgICAgICAgICAgIGFyZ3MuYXBwZW5kKCItLWdpdC1jb21taXQ9JXMiICUgc2VsZi5fb3B0 aW9ucy5naXRfY29tbWl0KQo=