3818 2005-07-02 14:03:10 -0700 Fallback font doesn't have requested weight in ATSUI-rendered text 2005-11-04 00:32:59 -0800 1 1 1 Unclassified WebKit Layout and Rendering 412 Mac OS X 10.4 CLOSED FIXED P2 Normal --- 1 mitz hyatt oldest_to_newest 13708 0 mitz 2005-07-02 14:03:10 -0700 When the specified font (or the fallback font, in case the former is not available) does not include glyphs needed for rendering the text, ATSUI uses a fallback font, which does include the required glyphs, instead, but the fallback font chosen is not boldface even if the original font is. To reproduce: Open the testcase. Expected: The Hebrew letters in the end of each line to be in boldface. Actual: On the second and fourth line, the Hebrew letters in the end of the line are not boldface (are the same weight as the Hebrew letters in the middle of the same line). Analysis: ATSUI's default fallback font search method, which is what WebTextRenderer uses, does not take font weight into account. It seems that using ATSUFontFallbacks would not help either. Perhaps ATSUMatchFontsToText should be called and then WKGetFontInLanguageForRange should be used to find the best font for the rest of the run. 13709 1 2758 mitz 2005-07-02 14:03:58 -0700 Created attachment 2758 Testcase 13811 2 joost 2005-07-03 08:25:42 -0700 wight is probably not what you meant, weight probably is :) if so, this one is confirmed, otherwise please mail me ;). 13918 3 2793 mitz 2005-07-04 11:01:40 -0700 Created attachment 2793 Proposed fix 13940 4 2793 mjs 2005-07-04 20:45:21 -0700 Comment on attachment 2793 Proposed fix r=me assuming it passes the existing tests and does the right thing on the new test. 2758 2005-07-02 14:03:58 -0700 2005-07-02 14:03:58 -0700 Testcase fallbackFonts.html text/html 1470 mitz PCFET0NUWVBFIEhUTUwgUFVCTElDICItLy9XM0MvL0RURCBIVE1MIDQuMDEgVHJhbnNpdGlvbmFs Ly9FTiIgCiJodHRwOi8vd3d3LnczLm9yZy9UUi9odG1sNC9sb29zZS5kdGQiPgo8aHRtbD4NCjxo ZWFkPg0KPHRpdGxlPkFUU1VJIGZhbGxiYWNrIGZvbnQ8L3RpdGxlPg0KPC9oZWFkPg0KPGJvZHk+ CjxwPgpJbiBlYWNoIG9mIHRoZSBmb2xsb3dpbmcgbGluZXMsIHRoZSBIZWJyZXcKbGV0dGVycyAm I3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsmI3gwNWQzOyBpbiB0aGUgZW5kIHNob3VsZCBiZSBpbiBi b2xkZmFjZQooY29tcGFyZSB3aXRoIHRoZSBzYW1lIGxldHRlcnMgaW4gdGhlIG1pZGRsZSBvZiB0 aGUgbGluZSkuCkRpc3JlZ2FyZCB0aGUgdGhpcmQgbGluZSBpZiB5b3UgZG9uJnJzcXVvO3QgaGF2 ZSBSYWFuYW5hLgo8L3A+CjwhLS0gTHVjaWRhIEdyYW5kZSBleGlzdHMgYW5kIGluY2x1ZGVzIEhl YnJldzsgbm8gZmFsbGJhY2sgbmVjZXNzYXJ5IC0tPgo8cCBzdHlsZT0iZm9udC1mYW1pbHk6J0x1 Y2lkYSBHcmFuZGUnOyI+CmFiY2QgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7JiN4MDVkMzsKPGI+ YWJjZCAmI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsmI3gwNWQzOzwvYj4KPC9wPgo8IS0tIENvdXJp ZXIgZXhpc3RzIGJ1dCBkb2Vzbid0IGluY2x1ZGUgSGVicmV3OyBXZWJLaXQgZmFsbHMgYmFjayB0 bwpIZWx2ZXRpY2EgYW5kIEhlbHZldGljYSBCb2xkIGZvciBIZWJyZXcsIGJ1dCB0aGVuIEFUU1VJ IGZhbGxzIGJhY2sgdG8KTHVjaWRhIEdyYW5kZSAobm90IGJvbGQpIC0tPgo8cCBzdHlsZT0iZm9u dC1mYW1pbHk6J0NvdXJpZXInOyI+CmFiY2QgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7JiN4MDVk MzsKPGI+YWJjZCAmI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsmI3gwNWQzOzwvYj4KPC9wPgo8IS0t IFJhYW5hbmEgZXhpc3RzIGJ1dCBkb2Vzbid0IGluY2x1ZGUgUm9tYW47IFdlYktpdCBmYWxscyBi YWNrIHRvCkhlbHZldGljYSBhbmQgSGVsdmV0aWNhIEJvbGQgZm9yIFJvbWFuIC0tPgo8cCBzdHls ZT0iZm9udC1mYW1pbHk6J1JhYW5hbmEnOyI+CmFiY2QgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7 JiN4MDVkMzsKPGI+YWJjZCAmI3gwNWQwOyYjeDA1ZDE7JiN4MDVkMjsmI3gwNWQzOzwvYj4KPC9w Pgo8IS0tIG5vU3VjaEZhbWlseUZvclN1cmUgZG9lc24ndCBleGlzdDsgV2ViS2l0IGZhbGxzIGJh Y2sgdG8gSGVsdmV0aWNhCmFuZCBIZWx2ZXRpY2EgQm9sZCBmb3IgYm90aCBSb21hbiBhbmQgSGVi cmV3LCBidXQgdGhlbiBBVFNVSSBmYWxscyBiYWNrIHRvCkx1Y2lkYSBHcmFuZGUgKG5vdCBib2xk KSBmb3IgSGVicmV3IC0tPgo8cCBzdHlsZT0iZm9udC1mYW1pbHk6J25vU3VjaEZhbWlseUZvclN1 cmUnOyI+CmFiY2QgJiN4MDVkMDsmI3gwNWQxOyYjeDA1ZDI7JiN4MDVkMzsKPGI+YWJjZCAmI3gw NWQwOyYjeDA1ZDE7JiN4MDVkMjsmI3gwNWQzOzwvYj4KPC9wPgo8L2JvZHk+ 2793 2005-07-04 11:01:40 -0700 2005-07-04 20:45:21 -0700 Proposed fix 3818_patch_r1.txt text/plain 1828 mitz SW5kZXg6IFdlYlRleHRSZW5kZXJlci5tCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KUkNTIGZpbGU6IC9jdnMvcm9vdC9X ZWJLaXQvV2ViQ29yZVN1cHBvcnQuc3VicHJvai9XZWJUZXh0UmVuZGVyZXIubSx2CnJldHJpZXZp bmcgcmV2aXNpb24gMS4xNzYKZGlmZiAtdSAtcCAtcjEuMTc2IFdlYlRleHRSZW5kZXJlci5tCi0t LSBXZWJUZXh0UmVuZGVyZXIubQkyMDA1LzA2LzMwIDAxOjI4OjM2CTEuMTc2CisrKyBXZWJUZXh0 UmVuZGVyZXIubQkyMDA1LzA3LzA0IDE3OjU5OjQ3CkBAIC0xNDg2LDYgKzE0ODYsOSBAQCBzdGF0 aWMgY29uc3QgY2hhciAqam9pbmluZ05hbWVzW10gPSB7CiAKICAgICBBVFNVVGV4dExheW91dCBs YXlvdXQ7CiAgICAgVW5pQ2hhckNvdW50IHJ1bkxlbmd0aDsKKyAgICBBVFNVRm9udElEIEFUU1VT dWJzdGl0dXRlRm9udDsKKyAgICBVbmlDaGFyQXJyYXlPZmZzZXQgc3Vic3RpdHV0ZU9mZnNldDsK KyAgICBVbmlDaGFyQ291bnQgc3Vic3RpdHV0ZUxlbmd0aDsKICAgICBPU1N0YXR1cyBzdGF0dXM7 CiAgICAgCiAgICAgW3NlbGYgX2luaXRpYWxpemVBVFNVU3R5bGVdOwpAQCAtMTUyMiw2ICsxNTI1 LDIwIEBAIHN0YXRpYyBjb25zdCBjaGFyICpqb2luaW5nTmFtZXNbXSA9IHsKICAgICBzdGF0dXMg PSBBVFNVU2V0VHJhbnNpZW50Rm9udE1hdGNoaW5nIChsYXlvdXQsIFlFUyk7CiAgICAgaWYoc3Rh dHVzICE9IG5vRXJyKQogICAgICAgICBGQVRBTF9BTFdBWVMgKCJBVFNVU2V0VHJhbnNpZW50Rm9u dE1hdGNoaW5nIGZhaWxlZCglZCkiLCBzdGF0dXMpOworCisgICAgc3Vic3RpdHV0ZU9mZnNldCA9 IHJ1bi0+ZnJvbTsKKyAgICB3aGlsZSAoKHN0YXR1cyA9IEFUU1VNYXRjaEZvbnRzVG9UZXh0KGxh eW91dCwgc3Vic3RpdHV0ZU9mZnNldCwga0FUU1VUb1RleHRFbmQsICZBVFNVU3Vic3RpdHV0ZUZv bnQsICZzdWJzdGl0dXRlT2Zmc2V0LCAmc3Vic3RpdHV0ZUxlbmd0aCkpID09IGtBVFNVRm9udHNN YXRjaGVkIHx8IHN0YXR1cyA9PSBrQVRTVUZvbnRzTm90TWF0Y2hlZCkgeworICAgICAgICBOU0Zv bnQgKnN1YnN0aXR1dGVGb250ID0gW3NlbGYgX3N1YnN0aXR1dGVGb250Rm9yQ2hhcmFjdGVyczpy dW4tPmNoYXJhY3RlcnMrc3Vic3RpdHV0ZU9mZnNldCBsZW5ndGg6c3Vic3RpdHV0ZUxlbmd0aCBm YW1pbGllczpzdHlsZS0+ZmFtaWxpZXNdOworICAgICAgICBpZiAoc3Vic3RpdHV0ZUZvbnQpIHsK KyAgICAgICAgICAgIFdlYlRleHRSZW5kZXJlciAqc3Vic3RpdHV0ZVJlbmRlcmVyID0gW1tXZWJU ZXh0UmVuZGVyZXJGYWN0b3J5IHNoYXJlZEZhY3RvcnldIHJlbmRlcmVyV2l0aEZvbnQ6c3Vic3Rp dHV0ZUZvbnQgdXNpbmdQcmludGVyRm9udDp1c2luZ1ByaW50ZXJGb250XTsKKyAgICAgICAgICAg IFtzdWJzdGl0dXRlUmVuZGVyZXIgX2luaXRpYWxpemVBVFNVU3R5bGVdOworICAgICAgICAgICAg aWYgKHN1YnN0aXR1dGVSZW5kZXJlciAmJiBzdWJzdGl0dXRlUmVuZGVyZXItPl9BVFNVU3N0eWxl KQorICAgICAgICAgICAgICAgIEFUU1VTZXRSdW5TdHlsZShsYXlvdXQsIHN1YnN0aXR1dGVSZW5k ZXJlci0+X0FUU1VTc3R5bGUsIHN1YnN0aXR1dGVPZmZzZXQsIHN1YnN0aXR1dGVMZW5ndGgpOwor ICAgICAgICAgICAgLy8gaWdub3JpbmcgZXJyb3JzCisgICAgICAgIH0KKyAgICAgICAgc3Vic3Rp dHV0ZU9mZnNldCArPSBzdWJzdGl0dXRlTGVuZ3RoOworICAgIH07CisgICAgLy8gaWdub3Jpbmcg ZXJyb3JzIGluIGZvbnQgc3Vic3RpdHV0aW9uCiAgICAgICAgIAogICAgIHJldHVybiBsYXlvdXQ7 CiB9Cg==