38176 2010-04-26 23:52:48 -0700 Move code out of GenerateImplementation to make it more smaller 2010-04-27 01:02:50 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth commit-queue oldest_to_newest 217547 0 eric 2010-04-26 23:52:48 -0700 Move code out of GenerateImplementation to make it more smaller 217549 1 eric 2010-04-26 23:54:18 -0700 Just moving code. 217550 2 54388 eric 2010-04-26 23:54:23 -0700 Created attachment 54388 Patch 217552 3 54388 abarth 2010-04-26 23:58:15 -0700 Comment on attachment 54388 Patch ok 217570 4 54388 commit-queue 2010-04-27 01:02:44 -0700 Comment on attachment 54388 Patch Clearing flags on attachment: 54388 Committed r58296: <http://trac.webkit.org/changeset/58296> 217571 5 commit-queue 2010-04-27 01:02:50 -0700 All reviewed patches have been landed. Closing bug. 54388 2010-04-26 23:54:23 -0700 2010-04-27 01:02:44 -0700 Patch bug-38176-20100426235422.patch text/plain 6647 eric ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ODU4ZmU2ZDk1ZTY1YTE1MzcyZmM3ZjE5ODIzNjBkM2Q4OTk5N2I0NS4uOWFiNTk2NjQyODNhODhk ZjcyNjY5N2FmODA4OWI4MmEyYWMxYjc5NyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cK KysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0yNiAgRXJp YyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgTW92ZSBjb2RlIG91dCBvZiBHZW5lcmF0ZUltcGxlbWVudGF0 aW9uIHRvIG1ha2UgaXQgbW9yZSBzbWFsbGVyCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zODE3NgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9D b2RlR2VuZXJhdG9ySlMucG06CisgICAgICAgICAtIE1vdmUgc29tZSBjb2RlIGludG8gYSBuZXcg R2VuZXJhdGVBdHRyaWJ1dGVzSGFzaFRhYmxlIG1ldGhvZC4KKwogMjAxMC0wNC0yNiAgQWRhbSBC YXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2Vp ZGVsLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JK Uy5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9ySlMucG0KaW5kZXgg M2NjM2NjNWQyMzM1MDI0NmQ2YjgzYTU5MmVlZWI5NzFiYzhmMjYzNi4uY2Y4MzU5NWY3YTU2OTAy OTZhY2IzNDdhMGE3ODZjY2Q3Zjk1ZTU0ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5kaW5ncy9z Y3JpcHRzL0NvZGVHZW5lcmF0b3JKUy5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvckpTLnBtCkBAIC05MzUsNiArOTM1LDczIEBAIHN1YiBHZW5lcmF0ZUhlYWRl cgogICAgIH0KIH0KIAorc3ViIEdlbmVyYXRlQXR0cmlidXRlc0hhc2hUYWJsZSgkJCkKK3sKKyAg ICBteSAoJG9iamVjdCwgJGRhdGFOb2RlKSA9IEBfOworCisgICAgIyBGSVhNRTogVGhlc2Ugc2hv dWxkIGJlIGZ1bmN0aW9ucyBvbiAkZGF0YU5vZGUuCisgICAgbXkgJGludGVyZmFjZU5hbWUgPSAk ZGF0YU5vZGUtPm5hbWU7CisgICAgbXkgJGNsYXNzTmFtZSA9ICJKUyRpbnRlcmZhY2VOYW1lIjsK KyAgICAKKyAgICAjIC0gQWRkIGFsbCBhdHRyaWJ1dGVzIGluIGEgaGFzaHRhYmxlIGRlZmluaXRp b24KKyAgICBteSAkbnVtQXR0cmlidXRlcyA9IEB7JGRhdGFOb2RlLT5hdHRyaWJ1dGVzfTsKKyAg ICAkbnVtQXR0cmlidXRlcysrIGlmICghKCRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57 Ik9taXRDb25zdHJ1Y3RvciJ9IHx8ICRkYXRhTm9kZS0+ZXh0ZW5kZWRBdHRyaWJ1dGVzLT57IkN1 c3RvbUNvbnN0cnVjdG9yIn0pKTsKKworICAgIHJldHVybiAwICBpZiAhJG51bUF0dHJpYnV0ZXM7 CisKKyAgICBteSAkaGFzaFNpemUgPSAkbnVtQXR0cmlidXRlczsKKyAgICBteSAkaGFzaE5hbWUg PSAkY2xhc3NOYW1lIC4gIlRhYmxlIjsKKworICAgIG15IEBoYXNoS2V5cyA9ICgpOworICAgIG15 IEBoYXNoU3BlY2lhbHMgPSAoKTsKKyAgICBteSBAaGFzaFZhbHVlMSA9ICgpOworICAgIG15IEBo YXNoVmFsdWUyID0gKCk7CisgICAgbXkgJWNvbmRpdGlvbmFscyA9ICgpOworCisgICAgbXkgQGVu dHJpZXMgPSAoKTsKKworICAgIGZvcmVhY2ggbXkgJGF0dHJpYnV0ZSAoQHskZGF0YU5vZGUtPmF0 dHJpYnV0ZXN9KSB7CisgICAgICAgIG15ICRuYW1lID0gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5u YW1lOworICAgICAgICBwdXNoKEBoYXNoS2V5cywgJG5hbWUpOworCisgICAgICAgIG15IEBzcGVj aWFscyA9ICgpOworICAgICAgICBwdXNoKEBzcGVjaWFscywgIkRvbnREZWxldGUiKSB1bmxlc3Mg JGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiRGVsZXRhYmxlIn07 CisgICAgICAgIHB1c2goQHNwZWNpYWxzLCAiRG9udEVudW0iKSBpZiAkYXR0cmlidXRlLT5zaWdu YXR1cmUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJEb250RW51bSJ9OworICAgICAgICBwdXNoKEBz cGVjaWFscywgIlJlYWRPbmx5IikgaWYgJGF0dHJpYnV0ZS0+dHlwZSA9fiAvcmVhZG9ubHkvOwor ICAgICAgICBteSAkc3BlY2lhbCA9IChAc3BlY2lhbHMgPiAwKSA/IGpvaW4oInwiLCBAc3BlY2lh bHMpIDogIjAiOworICAgICAgICBwdXNoKEBoYXNoU3BlY2lhbHMsICRzcGVjaWFsKTsKKworICAg ICAgICBteSAkZ2V0dGVyID0gImpzIiAuICRpbnRlcmZhY2VOYW1lIC4gJGNvZGVHZW5lcmF0b3It PldLX3VjZmlyc3QoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5uYW1lKSAuICgkYXR0cmlidXRlLT5z aWduYXR1cmUtPnR5cGUgPX4gL0NvbnN0cnVjdG9yJC8gPyAiQ29uc3RydWN0b3IiIDogIiIpOwor ICAgICAgICBwdXNoKEBoYXNoVmFsdWUxLCAkZ2V0dGVyKTsKKworICAgICAgICBpZiAoJGF0dHJp YnV0ZS0+dHlwZSA9fiAvcmVhZG9ubHkvKSB7CisgICAgICAgICAgICBwdXNoKEBoYXNoVmFsdWUy LCAiMCIpOworICAgICAgICB9IGVsc2UgeworICAgICAgICAgICAgbXkgJHNldHRlciA9ICJzZXRK UyIgLiAkaW50ZXJmYWNlTmFtZSAuICRjb2RlR2VuZXJhdG9yLT5XS191Y2ZpcnN0KCRhdHRyaWJ1 dGUtPnNpZ25hdHVyZS0+bmFtZSkgLiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT50eXBlID1+IC9D b25zdHJ1Y3RvciQvID8gIkNvbnN0cnVjdG9yIiA6ICIiKTsKKyAgICAgICAgICAgIHB1c2goQGhh c2hWYWx1ZTIsICRzZXR0ZXIpOworICAgICAgICB9CisKKyAgICAgICAgbXkgJGNvbmRpdGlvbmFs ID0gJGF0dHJpYnV0ZS0+c2lnbmF0dXJlLT5leHRlbmRlZEF0dHJpYnV0ZXMtPnsiQ29uZGl0aW9u YWwifTsKKyAgICAgICAgaWYgKCRjb25kaXRpb25hbCkgeworICAgICAgICAgICAgJGNvbmRpdGlv bmFsc3skbmFtZX0gPSAkY29uZGl0aW9uYWw7CisgICAgICAgIH0KKyAgICB9CisKKyAgICBpZiAo ISgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPbWl0Q29uc3RydWN0b3IifSB8fCAk ZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21Db25zdHJ1Y3RvciJ9KSkgewor ICAgICAgICBwdXNoKEBoYXNoS2V5cywgImNvbnN0cnVjdG9yIik7CisgICAgICAgIG15ICRnZXR0 ZXIgPSAianMiIC4gJGludGVyZmFjZU5hbWUgLiAiQ29uc3RydWN0b3IiOworICAgICAgICBwdXNo KEBoYXNoVmFsdWUxLCAkZ2V0dGVyKTsKKyAgICAgICAgcHVzaChAaGFzaFZhbHVlMiwgIjAiKTsK KyAgICAgICAgcHVzaChAaGFzaFNwZWNpYWxzLCAiRG9udEVudW18UmVhZE9ubHkiKTsgIyBGSVhN RTogU2V0dGluZyB0aGUgY29uc3RydWN0b3Igc2hvdWxkIGJlIHBvc3NpYmxlLgorICAgIH0KKwor ICAgICRvYmplY3QtPkdlbmVyYXRlSGFzaFRhYmxlKCRoYXNoTmFtZSwgJGhhc2hTaXplLAorICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgIFxAaGFzaEtleXMsIFxAaGFzaFNwZWNpYWxzLAor ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFxAaGFzaFZhbHVlMSwgXEBoYXNoVmFsdWUy LAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFwlY29uZGl0aW9uYWxzKTsKKyAgICBy ZXR1cm4gJG51bUF0dHJpYnV0ZXM7Cit9CisKIHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiB7 CiAgICAgbXkgKCRvYmplY3QsICRkYXRhTm9kZSkgPSBAXzsKQEAgLTk3Myw2MiArMTA0MCw3IEBA IHN1YiBHZW5lcmF0ZUltcGxlbWVudGF0aW9uCiAKICAgICBwdXNoKEBpbXBsQ29udGVudCwgIkFT U0VSVF9DTEFTU19GSVRTX0lOX0NFTEwoJGNsYXNzTmFtZSk7XG5cbiIpOwogCi0gICAgIyAtIEFk ZCBhbGwgYXR0cmlidXRlcyBpbiBhIGhhc2h0YWJsZSBkZWZpbml0aW9uCi0gICAgbXkgJG51bUF0 dHJpYnV0ZXMgPSBAeyRkYXRhTm9kZS0+YXR0cmlidXRlc307Ci0gICAgJG51bUF0dHJpYnV0ZXMr KyBpZiAoISgkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPbWl0Q29uc3RydWN0b3Ii fSB8fCAkZGF0YU5vZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21Db25zdHJ1Y3RvciJ9 KSk7Ci0KLSAgICBpZiAoJG51bUF0dHJpYnV0ZXMgPiAwKSB7Ci0gICAgICAgIG15ICRoYXNoU2l6 ZSA9ICRudW1BdHRyaWJ1dGVzOwotICAgICAgICBteSAkaGFzaE5hbWUgPSAkY2xhc3NOYW1lIC4g IlRhYmxlIjsKLQotICAgICAgICBteSBAaGFzaEtleXMgPSAoKTsKLSAgICAgICAgbXkgQGhhc2hT cGVjaWFscyA9ICgpOwotICAgICAgICBteSBAaGFzaFZhbHVlMSA9ICgpOwotICAgICAgICBteSBA aGFzaFZhbHVlMiA9ICgpOwotICAgICAgICBteSAlY29uZGl0aW9uYWxzID0gKCk7Ci0KLSAgICAg ICAgbXkgQGVudHJpZXMgPSAoKTsKLQotICAgICAgICBmb3JlYWNoIG15ICRhdHRyaWJ1dGUgKEB7 JGRhdGFOb2RlLT5hdHRyaWJ1dGVzfSkgewotICAgICAgICAgICAgbXkgJG5hbWUgPSAkYXR0cmli dXRlLT5zaWduYXR1cmUtPm5hbWU7Ci0gICAgICAgICAgICBwdXNoKEBoYXNoS2V5cywgJG5hbWUp OwotCi0gICAgICAgICAgICBteSBAc3BlY2lhbHMgPSAoKTsKLSAgICAgICAgICAgIHB1c2goQHNw ZWNpYWxzLCAiRG9udERlbGV0ZSIpIHVubGVzcyAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVu ZGVkQXR0cmlidXRlcy0+eyJEZWxldGFibGUifTsKLSAgICAgICAgICAgIHB1c2goQHNwZWNpYWxz LCAiRG9udEVudW0iKSBpZiAkYXR0cmlidXRlLT5zaWduYXR1cmUtPmV4dGVuZGVkQXR0cmlidXRl cy0+eyJEb250RW51bSJ9OwotICAgICAgICAgICAgcHVzaChAc3BlY2lhbHMsICJSZWFkT25seSIp IGlmICRhdHRyaWJ1dGUtPnR5cGUgPX4gL3JlYWRvbmx5LzsKLSAgICAgICAgICAgIG15ICRzcGVj aWFsID0gKEBzcGVjaWFscyA+IDApID8gam9pbigifCIsIEBzcGVjaWFscykgOiAiMCI7Ci0gICAg ICAgICAgICBwdXNoKEBoYXNoU3BlY2lhbHMsICRzcGVjaWFsKTsKLQotICAgICAgICAgICAgbXkg JGdldHRlciA9ICJqcyIgLiAkaW50ZXJmYWNlTmFtZSAuICRjb2RlR2VuZXJhdG9yLT5XS191Y2Zp cnN0KCRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+bmFtZSkgLiAoJGF0dHJpYnV0ZS0+c2lnbmF0dXJl LT50eXBlID1+IC9Db25zdHJ1Y3RvciQvID8gIkNvbnN0cnVjdG9yIiA6ICIiKTsKLSAgICAgICAg ICAgIHB1c2goQGhhc2hWYWx1ZTEsICRnZXR0ZXIpOwotICAgIAotICAgICAgICAgICAgaWYgKCRh dHRyaWJ1dGUtPnR5cGUgPX4gL3JlYWRvbmx5LykgewotICAgICAgICAgICAgICAgIHB1c2goQGhh c2hWYWx1ZTIsICIwIik7Ci0gICAgICAgICAgICB9IGVsc2UgewotICAgICAgICAgICAgICAgIG15 ICRzZXR0ZXIgPSAic2V0SlMiIC4gJGludGVyZmFjZU5hbWUgLiAkY29kZUdlbmVyYXRvci0+V0tf dWNmaXJzdCgkYXR0cmlidXRlLT5zaWduYXR1cmUtPm5hbWUpIC4gKCRhdHRyaWJ1dGUtPnNpZ25h dHVyZS0+dHlwZSA9fiAvQ29uc3RydWN0b3IkLyA/ICJDb25zdHJ1Y3RvciIgOiAiIik7Ci0gICAg ICAgICAgICAgICAgcHVzaChAaGFzaFZhbHVlMiwgJHNldHRlcik7Ci0gICAgICAgICAgICB9Ci0K LSAgICAgICAgICAgIG15ICRjb25kaXRpb25hbCA9ICRhdHRyaWJ1dGUtPnNpZ25hdHVyZS0+ZXh0 ZW5kZWRBdHRyaWJ1dGVzLT57IkNvbmRpdGlvbmFsIn07Ci0gICAgICAgICAgICBpZiAoJGNvbmRp dGlvbmFsKSB7Ci0gICAgICAgICAgICAgICAgJGNvbmRpdGlvbmFsc3skbmFtZX0gPSAkY29uZGl0 aW9uYWw7Ci0gICAgICAgICAgICB9Ci0gICAgICAgIH0KLQotICAgICAgICBpZiAoISgkZGF0YU5v ZGUtPmV4dGVuZGVkQXR0cmlidXRlcy0+eyJPbWl0Q29uc3RydWN0b3IifSB8fCAkZGF0YU5vZGUt PmV4dGVuZGVkQXR0cmlidXRlcy0+eyJDdXN0b21Db25zdHJ1Y3RvciJ9KSkgewotICAgICAgICAg ICAgcHVzaChAaGFzaEtleXMsICJjb25zdHJ1Y3RvciIpOwotICAgICAgICAgICAgbXkgJGdldHRl ciA9ICJqcyIgLiAkaW50ZXJmYWNlTmFtZSAuICJDb25zdHJ1Y3RvciI7Ci0gICAgICAgICAgICBw dXNoKEBoYXNoVmFsdWUxLCAkZ2V0dGVyKTsKLSAgICAgICAgICAgIHB1c2goQGhhc2hWYWx1ZTIs ICIwIik7Ci0gICAgICAgICAgICBwdXNoKEBoYXNoU3BlY2lhbHMsICJEb250RW51bXxSZWFkT25s eSIpOyAjIEZJWE1FOiBTZXR0aW5nIHRoZSBjb25zdHJ1Y3RvciBzaG91bGQgYmUgcG9zc2libGUu Ci0gICAgICAgIH0KLQotICAgICAgICAkb2JqZWN0LT5HZW5lcmF0ZUhhc2hUYWJsZSgkaGFzaE5h bWUsICRoYXNoU2l6ZSwKLSAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgXEBoYXNo S2V5cywgXEBoYXNoU3BlY2lhbHMsCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFxAaGFzaFZhbHVlMSwgXEBoYXNoVmFsdWUyLAotICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBcJWNvbmRpdGlvbmFscyk7Ci0gICAgfQorICAgIG15ICRudW1BdHRyaWJ1dGVzID0g R2VuZXJhdGVBdHRyaWJ1dGVzSGFzaFRhYmxlKCRvYmplY3QsICRkYXRhTm9kZSk7CiAKICAgICBt eSAkbnVtQ29uc3RhbnRzID0gQHskZGF0YU5vZGUtPmNvbnN0YW50c307CiAgICAgbXkgJG51bUZ1 bmN0aW9ucyA9IEB7JGRhdGFOb2RlLT5mdW5jdGlvbnN9Owo=