38175 2010-04-26 23:38:06 -0700 REGRESSION (r48698): Selection drag-and-drop doesn't work for input/textarea 2010-04-29 05:03:50 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All All RESOLVED FIXED http://crbug.com/new InRadar, Regression P1 Normal --- 1 dcheng webkit-unassigned abarth ap eric mitz rolandsteiner tkent webkit.review.bot oldest_to_newest 217541 0 dcheng 2010-04-26 23:38:06 -0700 In http://crbug.com/new, attempt to drag some text from a TEXTAREA to an empty text input. It will fail, and will raise an assert in debug builds: ASSERT(oldLength >= selectionLength); I think this is because WebCore is calculating oldLength from the wrong element; it looks like it's calculating the length of the text field being dragged to rather than the text field being dragged from. However, I'm not familiar enough with this code to say for sure. 217668 1 54411 tkent 2010-04-27 06:12:49 -0700 Created attachment 54411 Patch 217874 2 54411 darin 2010-04-27 13:04:19 -0700 Comment on attachment 54411 Patch In what way is this "incorrect arithmetic"? Can we re-title the bug to be clearer? I don't understand the comment "No need to calculate the selection length in a case of selection drag-and-drop." - The comment doesn't say why focused() is a reliable way to detect the fact that selected text is being dragged within the element. - The comment doesn't say why setting selectionLength to 0 is a good way to bypass the selection check entirely. The main purpose of comments is to explain why the code exists. The code can speak for itself on *what* it does. I am not convinced that setting selectionLength to 0 is the best way to handle this. 218135 3 54498 tkent 2010-04-27 19:05:38 -0700 Created attachment 54498 Patch (rev.2) 218142 4 mitz 2010-04-27 19:09:43 -0700 This seems to be a regression from Safari 4.0.5. Any idea what caused it? I am asking because whatever it was may have had other side effects that your patch will not address. 218144 5 tkent 2010-04-27 19:11:11 -0700 Thank you for reviewing (In reply to comment #2) > I don't understand the comment "No need to calculate the selection length in a > case of selection drag-and-drop." > - The comment doesn't say why focused() is a reliable way to detect the fact > that selected text is being dragged within the element. > - The comment doesn't say why setting selectionLength to 0 is a good way to > bypass the selection check entirely. > The main purpose of comments is to explain why the code exists. The code can > speak for itself on *what* it does. > > I am not convinced that setting selectionLength to 0 is the best way to handle > this. I updated the comments. I think the new comments explain them. And I removed the existing comment "// selection() may be a pre-edit text.". I added it when I fixed an issue for IME, but the comment is not helpful for now though it was helpful during the IME change. 218155 6 mitz 2010-04-27 19:23:51 -0700 Caused by <http://trac.webkit.org/changeset/48698>. 218156 7 mitz 2010-04-27 19:26:11 -0700 <rdar://problem/7915903> 218158 8 tkent 2010-04-27 19:27:58 -0700 (In reply to comment #6) > Caused by <http://trac.webkit.org/changeset/48698>. Or r48011. The assertion has been there for a long time. The code have never considered text drag-and-drop, but it worked accidentally. It seems my change exposed the problem. 218953 9 tkent 2010-04-29 04:27:17 -0700 Landed as r58502. 218962 10 webkit.review.bot 2010-04-29 04:50:13 -0700 http://trac.webkit.org/changeset/58502 might have broken GTK Linux 32-bit Release 218967 11 tkent 2010-04-29 05:03:50 -0700 (In reply to comment #10) > http://trac.webkit.org/changeset/58502 might have broken GTK Linux 32-bit > Release I'll add the test to the skipped list for GTK and Qt. 54411 2010-04-27 06:12:49 -0700 2010-04-27 19:05:32 -0700 Patch bug-38175-20100427221247.patch text/plain 6448 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNjAzZGM2Li40OTBjNjA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQt MjcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1ZyB0aGF0IHNlbGVjdGlvbiBk cmFnLWFuZC1kcm9wIGRvZXNuJ3Qgd29yayBmb3IgaW5wdXQvdGV4dGFyZWEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODE3NQorCisgICAgICAgICog ZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWRyb3AtaW5wdXQtdGV4 dGFyZWEuaHRtbDogQWRkZWQuCisKIDIwMTAtMDQtMjUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJl YS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1kcm9w LWlucHV0LXRleHRhcmVhLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4xYTgyNWFiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9w YXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSw1IEBACitUaGlzIHRlc3RzIHRleHQgc2VsZWN0aW9uIGRyYWcgZnJvbSBhIHRleHRhcmVhIGFu ZCBkcm9wIHRvIGFuIGlucHV0LCBhbmQgdmljZSB2ZXJzYS4gVGhlcmUgd2FzIGEgYnVnIG9mIGFu IGFzc2VydGlvbiBmYWlsdXJlIGluIGEgY2FzZSBvZiB0aGUgc2VsZWN0ZWQgdGV4dCB3YXMgbG9u Z2VyIHRoYW4gdGhlIGRlc3RpbmF0aW9uIHRleHQuCisKK1BBU1M6IHRvIGlucHV0CitQQVNTOiB0 byB0ZXh0YXJlYQorIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJk L2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0 ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjM2NDYxYTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9l ZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1kcm9wLWlucHV0LXRleHRhcmVhLmh0bWwKQEAgLTAsMCAr MSw1OCBAQAorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQ+CitmdW5jdGlvbiBkZWJ1Zyhtc2cpIHsK KyAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpOworICB2 YXIgbGluZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworICBsaW5lLnRleHRDb250 ZW50ID0gbXNnOworICBjb25zb2xlLmFwcGVuZENoaWxkKGxpbmUpOworfQorCitmdW5jdGlvbiBl ZGl0aW5nVGVzdCgpIHsKKyAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgcmV0dXJuOworCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKworICAgIC8vIERyYWcg YSB3b3JkIGluIHRoZSB0ZXh0YXJlYQorICAgIHZhciB0ZXh0YXJlYSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0ZXh0YXJlYSIpOworICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDAs IDQpOworICAgIHggPSB0ZXh0YXJlYS5vZmZzZXRMZWZ0ICsgMTA7CisgICAgeSA9IHRleHRhcmVh Lm9mZnNldFRvcCArIHRleHRhcmVhLm9mZnNldEhlaWdodCAvIDI7CisgICAgZXZlbnRTZW5kZXIu bW91c2VNb3ZlVG8oeCwgeSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgLy8g YW5kIGRyb3AgaXQgb2ZmIHRvIHRoZSBpbnB1dCBmaWVsZAorICAgIHZhciBpbnB1dCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJkZXN0aW5hdGlvbiIpOworICAgIGV2ZW50U2VuZGVyLmxlYXBG b3J3YXJkKDUwMCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oaW5wdXQub2Zmc2V0TGVm dCArIDEwLCBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRIZWlnaHQgLyAyKTsKKyAgICBl dmVudFNlbmRlci5tb3VzZVVwKCk7CisKKyAgICB2YXIgcmVzdWx0ID0gaW5wdXQudmFsdWU7Cisg ICAgZGVidWcocmVzdWx0ID09ICdXaGF0JyA/ICdQQVNTOiB0byBpbnB1dCcgOiAnRkFJTDogZXhw ZWN0ZWQgdmFsdWU9IldoYXQiLCBhY3R1YWwgdmFsdWU9IicgKyByZXN1bHQgKyAnIicpOworCisg ICAgLy8gRHJhZyBmcm9tIHRoZSBpbnB1dCB0byB0aGUgdGV4dGFyZWEuCisgICAgdGV4dGFyZWEu dmFsdWUgPSAnJzsKKyAgICBpbnB1dC5mb2N1cygpOworICAgIGlucHV0LnNldFNlbGVjdGlvblJh bmdlKDAsIDQpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGlucHV0Lm9mZnNldExlZnQg KyAxMCwgaW5wdXQub2Zmc2V0VG9wICsgaW5wdXQub2Zmc2V0SGVpZ2h0IC8gMik7CisgICAgZXZl bnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubGVhcEZvcndhcmQoNTAwKTsK KyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh0ZXh0YXJlYS5vZmZzZXRMZWZ0ICsgMTAsIHRl eHRhcmVhLm9mZnNldFRvcCArIDEwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAg dmFyIHJlc3VsdCA9IHRleHRhcmVhLnZhbHVlOworICAgIGRlYnVnKHJlc3VsdCA9PSAnV2hhdCcg PyAnUEFTUzogdG8gdGV4dGFyZWEnIDogJ0ZBSUw6IGV4cGVjdGVkIHZhbHVlPSJXaGF0IiwgYWN0 dWFsIHZhbHVlPSInICsgcmVzdWx0ICsgJyInKTsKKyAgICAKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzxwPlRoaXMgdGVzdHMgdGV4dCBzZWxl Y3Rpb24gZHJhZyBmcm9tIGEgdGV4dGFyZWEgYW5kIGRyb3AgdG8gYW4gaW5wdXQsIGFuZCB2aWNl IHZlcnNhLgorICBUaGVyZSB3YXMgYSBidWcgb2YgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4gYSBj YXNlIG9mIHRoZSBzZWxlY3RlZCB0ZXh0IHdhcworICBsb25nZXIgdGhhbiB0aGUgZGVzdGluYXRp b24gdGV4dC48L3A+Cis8ZGl2IGlkPWNvbnNvbGU+PC9kaXY+Cis8aW5wdXQgaWQ9ZGVzdGluYXRp b24+Cis8dGV4dGFyZWEgaWQ9dGV4dGFyZWEgcm93cz0xPldoYXQgc3RlcHMgd2lsbCByZXByb2R1 Y2UgdGhlIHByb2JsZW0/Cis8L3RleHRhcmVhPgorPHNjcmlwdD5lZGl0aW5nVGVzdCgpOzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYzRmYjU2Li4zYjEwOGU0IDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisy MDEwLTA0LTI3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBzZWxl Y3Rpb24gZHJhZy1hbmQtZHJvcCBkb2Vzbid0IHdvcmsgZm9yIGlucHV0L3RleHRhcmVhLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxNzUKKworICAg ICAgICBUaGUgY29kZSBzdXBwb3NlZCB0aGUgc2VsZWN0ZWQgcmVnaW9uIHdhcyBpbiB0aGUgZGVz dGluYXRpb24gdGV4dAorICAgICAgICBmaWVsZC4gSXQgaXMgbm90IHRydWUgaW4gYSBjYXNlIG9m IGRyYWctYW5kLWRyb3AuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWct ZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sCisKKyAgICAgICAgKiBkb20vSW5wdXRFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0RWxlbWVudDo6aGFuZGxlQmVmb3JlVGV4dEluc2Vy dGVkRXZlbnQpOgorICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpoYW5kbGVCZWZvcmVUZXh0SW5zZXJ0 ZWRFdmVudCk6CisKIDIwMTAtMDQtMjUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9kb20vSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0lucHV0RWxlbWVudC5jcHAKaW5k ZXggNTI4MTJmOS4uYTJkYmZkOSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vSW5wdXRFbGVtZW50 LmNwcAorKysgYi9XZWJDb3JlL2RvbS9JbnB1dEVsZW1lbnQuY3BwCkBAIC0xNzIsOCArMTcyLDkg QEAgdm9pZCBJbnB1dEVsZW1lbnQ6OmhhbmRsZUJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KElucHV0 RWxlbWVudERhdGEmIGRhdGEsIElucHV0RWwKICAgICAvLyBSZW5kZXJUZXh0Q29udHJvbFNpbmds ZUxpbmU6OnN1YnRyZWVIYXNDaGFuZ2VkKCkgaW4gc29tZSBjYXNlcy4KICAgICB1bnNpZ25lZCBv bGRMZW5ndGggPSBudW1HcmFwaGVtZUNsdXN0ZXJzKHRvUmVuZGVyVGV4dENvbnRyb2xTaW5nbGVM aW5lKGVsZW1lbnQtPnJlbmRlcmVyKCkpLT50ZXh0KCkpOwogCisgICAgLy8gTm8gbmVlZCB0byBj YWxjdWxhdGUgdGhlIHNlbGVjdGlvbiBsZW5ndGggaW4gYSBjYXNlIG9mIHNlbGVjdGlvbiBkcmFn LWFuZC1kcm9wLgogICAgIC8vIHNlbGVjdGlvbigpIG1heSBiZSBhIHByZS1lZGl0IHRleHQuCi0g ICAgdW5zaWduZWQgc2VsZWN0aW9uTGVuZ3RoID0gbnVtR3JhcGhlbWVDbHVzdGVycyhwbGFpblRl eHQoZWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUoKS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigp LnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpKTsKKyAgICB1bnNpZ25lZCBzZWxlY3Rpb25MZW5n dGggPSBlbGVtZW50LT5mb2N1c2VkKCkgPyBudW1HcmFwaGVtZUNsdXN0ZXJzKHBsYWluVGV4dChl bGVtZW50LT5kb2N1bWVudCgpLT5mcmFtZSgpLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkudG9O b3JtYWxpemVkUmFuZ2UoKS5nZXQoKSkpIDogMDsKICAgICBBU1NFUlQob2xkTGVuZ3RoID49IHNl bGVjdGlvbkxlbmd0aCk7CiAKICAgICAvLyBTZWxlY3RlZCBjaGFyYWN0ZXJzIHdpbGwgYmUgcmVt b3ZlZCBieSB0aGUgbmV4dCB0ZXh0IGV2ZW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9odG1sL0hU TUxUZXh0QXJlYUVsZW1lbnQuY3BwIGIvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQu Y3BwCmluZGV4IDM2ZTgzYmUuLjE2NGNjMzAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaHRtbC9IVE1M VGV4dEFyZWFFbGVtZW50LmNwcAorKysgYi9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVu dC5jcHAKQEAgLTI0MSw3ICsyNDEsOCBAQCB2b2lkIEhUTUxUZXh0QXJlYUVsZW1lbnQ6OmhhbmRs ZUJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KEJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KgogICAgIHVu c2lnbmVkIHVuc2lnbmVkTWF4TGVuZ3RoID0gc3RhdGljX2Nhc3Q8dW5zaWduZWQ+KHNpZ25lZE1h eExlbmd0aCk7CiAKICAgICB1bnNpZ25lZCBjdXJyZW50TGVuZ3RoID0gbnVtR3JhcGhlbWVDbHVz dGVycyh0b1JlbmRlclRleHRDb250cm9sKHJlbmRlcmVyKCkpLT50ZXh0KCkpOwotICAgIHVuc2ln bmVkIHNlbGVjdGlvbkxlbmd0aCA9IG51bUdyYXBoZW1lQ2x1c3RlcnMocGxhaW5UZXh0KGRvY3Vt ZW50KCktPmZyYW1lKCktPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS50b05vcm1hbGl6ZWRSYW5n ZSgpLmdldCgpKSk7CisgICAgLy8gTm8gbmVlZCB0byBjYWxjdWxhdGUgdGhlIHNlbGVjdGlvbiBs ZW5ndGggaW4gYSBjYXNlIG9mIHNlbGVjdGlvbiBkcmFnLWFuZC1kcm9wLgorICAgIHVuc2lnbmVk IHNlbGVjdGlvbkxlbmd0aCA9IGZvY3VzZWQoKSA/IG51bUdyYXBoZW1lQ2x1c3RlcnMocGxhaW5U ZXh0KGRvY3VtZW50KCktPmZyYW1lKCktPnNlbGVjdGlvbigpLT5zZWxlY3Rpb24oKS50b05vcm1h bGl6ZWRSYW5nZSgpLmdldCgpKSkgOiAwOwogICAgIEFTU0VSVChjdXJyZW50TGVuZ3RoID49IHNl bGVjdGlvbkxlbmd0aCk7CiAgICAgdW5zaWduZWQgYmFzZUxlbmd0aCA9IGN1cnJlbnRMZW5ndGgg LSBzZWxlY3Rpb25MZW5ndGg7CiAgICAgdW5zaWduZWQgYXBwZW5kYWJsZUxlbmd0aCA9IHVuc2ln bmVkTWF4TGVuZ3RoID4gYmFzZUxlbmd0aCA/IHVuc2lnbmVkTWF4TGVuZ3RoIC0gYmFzZUxlbmd0 aCA6IDA7Cg== 54498 2010-04-27 19:05:38 -0700 2010-04-29 04:27:30 -0700 Patch (rev.2) bug-38175-20100428110536.patch text/plain 6950 tkent ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAwNjAzZGM2Li40OTBjNjA5IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQt MjcgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIEZpeCBhIGJ1ZyB0aGF0IHNlbGVjdGlvbiBk cmFnLWFuZC1kcm9wIGRvZXNuJ3Qgd29yayBmb3IgaW5wdXQvdGV4dGFyZWEuCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODE3NQorCisgICAgICAgICog ZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS1leHBlY3RlZC50eHQ6 IEFkZGVkLgorICAgICAgICAqIGVkaXRpbmcvcGFzdGVib2FyZC9kcmFnLWRyb3AtaW5wdXQtdGV4 dGFyZWEuaHRtbDogQWRkZWQuCisKIDIwMTAtMDQtMjUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hy b21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0 IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJl YS1leHBlY3RlZC50eHQgYi9MYXlvdXRUZXN0cy9lZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1kcm9w LWlucHV0LXRleHRhcmVhLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwLi4xYTgyNWFiCi0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9w YXN0ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS1leHBlY3RlZC50eHQKQEAgLTAsMCAr MSw1IEBACitUaGlzIHRlc3RzIHRleHQgc2VsZWN0aW9uIGRyYWcgZnJvbSBhIHRleHRhcmVhIGFu ZCBkcm9wIHRvIGFuIGlucHV0LCBhbmQgdmljZSB2ZXJzYS4gVGhlcmUgd2FzIGEgYnVnIG9mIGFu IGFzc2VydGlvbiBmYWlsdXJlIGluIGEgY2FzZSBvZiB0aGUgc2VsZWN0ZWQgdGV4dCB3YXMgbG9u Z2VyIHRoYW4gdGhlIGRlc3RpbmF0aW9uIHRleHQuCisKK1BBU1M6IHRvIGlucHV0CitQQVNTOiB0 byB0ZXh0YXJlYQorIApkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0ZWJvYXJk L2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sIGIvTGF5b3V0VGVzdHMvZWRpdGluZy9wYXN0 ZWJvYXJkL2RyYWctZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sCm5ldyBmaWxlIG1vZGUgMTAwNjQ0 CmluZGV4IDAwMDAwMDAuLjM2NDYxYTAKLS0tIC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9l ZGl0aW5nL3Bhc3RlYm9hcmQvZHJhZy1kcm9wLWlucHV0LXRleHRhcmVhLmh0bWwKQEAgLTAsMCAr MSw1OCBAQAorPGh0bWw+Cis8Ym9keT4KKzxzY3JpcHQ+CitmdW5jdGlvbiBkZWJ1Zyhtc2cpIHsK KyAgdmFyIGNvbnNvbGUgPSBkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgnY29uc29sZScpOworICB2 YXIgbGluZSA9IGRvY3VtZW50LmNyZWF0ZUVsZW1lbnQoJ2RpdicpOworICBsaW5lLnRleHRDb250 ZW50ID0gbXNnOworICBjb25zb2xlLmFwcGVuZENoaWxkKGxpbmUpOworfQorCitmdW5jdGlvbiBl ZGl0aW5nVGVzdCgpIHsKKyAgICBpZiAoIXdpbmRvdy5sYXlvdXRUZXN0Q29udHJvbGxlcikKKyAg ICAgICAgcmV0dXJuOworCisgICAgbGF5b3V0VGVzdENvbnRyb2xsZXIuZHVtcEFzVGV4dCgpOwor ICAgIGxheW91dFRlc3RDb250cm9sbGVyLndhaXRVbnRpbERvbmUoKTsKKworICAgIC8vIERyYWcg YSB3b3JkIGluIHRoZSB0ZXh0YXJlYQorICAgIHZhciB0ZXh0YXJlYSA9IGRvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0ZXh0YXJlYSIpOworICAgIHRleHRhcmVhLnNldFNlbGVjdGlvblJhbmdlKDAs IDQpOworICAgIHggPSB0ZXh0YXJlYS5vZmZzZXRMZWZ0ICsgMTA7CisgICAgeSA9IHRleHRhcmVh Lm9mZnNldFRvcCArIHRleHRhcmVhLm9mZnNldEhlaWdodCAvIDI7CisgICAgZXZlbnRTZW5kZXIu bW91c2VNb3ZlVG8oeCwgeSk7CisgICAgZXZlbnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgLy8g YW5kIGRyb3AgaXQgb2ZmIHRvIHRoZSBpbnB1dCBmaWVsZAorICAgIHZhciBpbnB1dCA9IGRvY3Vt ZW50LmdldEVsZW1lbnRCeUlkKCJkZXN0aW5hdGlvbiIpOworICAgIGV2ZW50U2VuZGVyLmxlYXBG b3J3YXJkKDUwMCk7CisgICAgZXZlbnRTZW5kZXIubW91c2VNb3ZlVG8oaW5wdXQub2Zmc2V0TGVm dCArIDEwLCBpbnB1dC5vZmZzZXRUb3AgKyBpbnB1dC5vZmZzZXRIZWlnaHQgLyAyKTsKKyAgICBl dmVudFNlbmRlci5tb3VzZVVwKCk7CisKKyAgICB2YXIgcmVzdWx0ID0gaW5wdXQudmFsdWU7Cisg ICAgZGVidWcocmVzdWx0ID09ICdXaGF0JyA/ICdQQVNTOiB0byBpbnB1dCcgOiAnRkFJTDogZXhw ZWN0ZWQgdmFsdWU9IldoYXQiLCBhY3R1YWwgdmFsdWU9IicgKyByZXN1bHQgKyAnIicpOworCisg ICAgLy8gRHJhZyBmcm9tIHRoZSBpbnB1dCB0byB0aGUgdGV4dGFyZWEuCisgICAgdGV4dGFyZWEu dmFsdWUgPSAnJzsKKyAgICBpbnB1dC5mb2N1cygpOworICAgIGlucHV0LnNldFNlbGVjdGlvblJh bmdlKDAsIDQpOworICAgIGV2ZW50U2VuZGVyLm1vdXNlTW92ZVRvKGlucHV0Lm9mZnNldExlZnQg KyAxMCwgaW5wdXQub2Zmc2V0VG9wICsgaW5wdXQub2Zmc2V0SGVpZ2h0IC8gMik7CisgICAgZXZl bnRTZW5kZXIubW91c2VEb3duKCk7CisgICAgZXZlbnRTZW5kZXIubGVhcEZvcndhcmQoNTAwKTsK KyAgICBldmVudFNlbmRlci5tb3VzZU1vdmVUbyh0ZXh0YXJlYS5vZmZzZXRMZWZ0ICsgMTAsIHRl eHRhcmVhLm9mZnNldFRvcCArIDEwKTsKKyAgICBldmVudFNlbmRlci5tb3VzZVVwKCk7CisgICAg dmFyIHJlc3VsdCA9IHRleHRhcmVhLnZhbHVlOworICAgIGRlYnVnKHJlc3VsdCA9PSAnV2hhdCcg PyAnUEFTUzogdG8gdGV4dGFyZWEnIDogJ0ZBSUw6IGV4cGVjdGVkIHZhbHVlPSJXaGF0IiwgYWN0 dWFsIHZhbHVlPSInICsgcmVzdWx0ICsgJyInKTsKKyAgICAKKyAgICBsYXlvdXRUZXN0Q29udHJv bGxlci5ub3RpZnlEb25lKCk7Cit9Cis8L3NjcmlwdD4KKzxwPlRoaXMgdGVzdHMgdGV4dCBzZWxl Y3Rpb24gZHJhZyBmcm9tIGEgdGV4dGFyZWEgYW5kIGRyb3AgdG8gYW4gaW5wdXQsIGFuZCB2aWNl IHZlcnNhLgorICBUaGVyZSB3YXMgYSBidWcgb2YgYW4gYXNzZXJ0aW9uIGZhaWx1cmUgaW4gYSBj YXNlIG9mIHRoZSBzZWxlY3RlZCB0ZXh0IHdhcworICBsb25nZXIgdGhhbiB0aGUgZGVzdGluYXRp b24gdGV4dC48L3A+Cis8ZGl2IGlkPWNvbnNvbGU+PC9kaXY+Cis8aW5wdXQgaWQ9ZGVzdGluYXRp b24+Cis8dGV4dGFyZWEgaWQ9dGV4dGFyZWEgcm93cz0xPldoYXQgc3RlcHMgd2lsbCByZXByb2R1 Y2UgdGhlIHByb2JsZW0/Cis8L3RleHRhcmVhPgorPHNjcmlwdD5lZGl0aW5nVGVzdCgpOzwvc2Ny aXB0PgorPC9ib2R5PgorPC9odG1sPgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9X ZWJDb3JlL0NoYW5nZUxvZwppbmRleCAyYzRmYjU2Li4zYjEwOGU0IDEwMDY0NAotLS0gYS9XZWJD b3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDIwIEBACisy MDEwLTA0LTI3ICBLZW50IFRhbXVyYSAgPHRrZW50QGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBGaXggYSBidWcgdGhhdCBzZWxl Y3Rpb24gZHJhZy1hbmQtZHJvcCBkb2Vzbid0IHdvcmsgZm9yIGlucHV0L3RleHRhcmVhLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxNzUKKworICAg ICAgICBUaGUgY29kZSBzdXBwb3NlZCB0aGUgc2VsZWN0ZWQgcmVnaW9uIHdhcyBpbiB0aGUgZGVz dGluYXRpb24gdGV4dAorICAgICAgICBmaWVsZC4gSXQgaXMgbm90IHRydWUgaW4gYSBjYXNlIG9m IGRyYWctYW5kLWRyb3AuCisKKyAgICAgICAgVGVzdDogZWRpdGluZy9wYXN0ZWJvYXJkL2RyYWct ZHJvcC1pbnB1dC10ZXh0YXJlYS5odG1sCisKKyAgICAgICAgKiBkb20vSW5wdXRFbGVtZW50LmNw cDoKKyAgICAgICAgKFdlYkNvcmU6OklucHV0RWxlbWVudDo6aGFuZGxlQmVmb3JlVGV4dEluc2Vy dGVkRXZlbnQpOgorICAgICAgICAqIGh0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHA6CisgICAg ICAgIChXZWJDb3JlOjpIVE1MVGV4dEFyZWFFbGVtZW50OjpoYW5kbGVCZWZvcmVUZXh0SW5zZXJ0 ZWRFdmVudCk6CisKIDIwMTAtMDQtMjUgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3Jn PgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9kb20vSW5wdXRFbGVtZW50LmNwcCBiL1dlYkNvcmUvZG9tL0lucHV0RWxlbWVudC5jcHAKaW5k ZXggNTI4MTJmOS4uMmI5ZGE5MiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vSW5wdXRFbGVtZW50 LmNwcAorKysgYi9XZWJDb3JlL2RvbS9JbnB1dEVsZW1lbnQuY3BwCkBAIC0xNzIsOCArMTcyLDEy IEBAIHZvaWQgSW5wdXRFbGVtZW50OjpoYW5kbGVCZWZvcmVUZXh0SW5zZXJ0ZWRFdmVudChJbnB1 dEVsZW1lbnREYXRhJiBkYXRhLCBJbnB1dEVsCiAgICAgLy8gUmVuZGVyVGV4dENvbnRyb2xTaW5n bGVMaW5lOjpzdWJ0cmVlSGFzQ2hhbmdlZCgpIGluIHNvbWUgY2FzZXMuCiAgICAgdW5zaWduZWQg b2xkTGVuZ3RoID0gbnVtR3JhcGhlbWVDbHVzdGVycyh0b1JlbmRlclRleHRDb250cm9sU2luZ2xl TGluZShlbGVtZW50LT5yZW5kZXJlcigpKS0+dGV4dCgpKTsKIAotICAgIC8vIHNlbGVjdGlvbigp IG1heSBiZSBhIHByZS1lZGl0IHRleHQuCi0gICAgdW5zaWduZWQgc2VsZWN0aW9uTGVuZ3RoID0g bnVtR3JhcGhlbWVDbHVzdGVycyhwbGFpblRleHQoZWxlbWVudC0+ZG9jdW1lbnQoKS0+ZnJhbWUo KS0+c2VsZWN0aW9uKCktPnNlbGVjdGlvbigpLnRvTm9ybWFsaXplZFJhbmdlKCkuZ2V0KCkpKTsK KyAgICAvLyBzZWxlY3Rpb25MZW5ndGggcmVwcmVzZW50cyB0aGUgc2VsZWN0aW9uIGxlbmd0aCBv ZiB0aGlzIHRleHQgZmllbGQgdG8gYmUKKyAgICAvLyByZW1vdmVkIGJ5IHRoaXMgaW5zZXJ0aW9u LgorICAgIC8vIElmIHRoZSB0ZXh0IGZpZWxkIGhhcyBubyBmb2N1cywgd2UgZG9uJ3QgbmVlZCB0 byB0YWtlIGFjY291bnQgb2YgdGhlCisgICAgLy8gc2VsZWN0aW9uIGxlbmd0aC4gVGhlIHNlbGVj dGlvbiBpcyB0aGUgc291cmNlIG9mIHRleHQgZHJhZy1hbmQtZHJvcCBpbgorICAgIC8vIHRoYXQg Y2FzZSwgYW5kIG5vdGhpbmcgaW4gdGhlIHRleHQgZmllbGQgd2lsbCBiZSByZW1vdmVkLgorICAg IHVuc2lnbmVkIHNlbGVjdGlvbkxlbmd0aCA9IGVsZW1lbnQtPmZvY3VzZWQoKSA/IG51bUdyYXBo ZW1lQ2x1c3RlcnMocGxhaW5UZXh0KGVsZW1lbnQtPmRvY3VtZW50KCktPmZyYW1lKCktPnNlbGVj dGlvbigpLT5zZWxlY3Rpb24oKS50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpKSkgOiAwOwogICAg IEFTU0VSVChvbGRMZW5ndGggPj0gc2VsZWN0aW9uTGVuZ3RoKTsKIAogICAgIC8vIFNlbGVjdGVk IGNoYXJhY3RlcnMgd2lsbCBiZSByZW1vdmVkIGJ5IHRoZSBuZXh0IHRleHQgZXZlbnQuCmRpZmYg LS1naXQgYS9XZWJDb3JlL2h0bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAgYi9XZWJDb3JlL2h0 bWwvSFRNTFRleHRBcmVhRWxlbWVudC5jcHAKaW5kZXggMzZlODNiZS4uMWE3NzExNiAxMDA2NDQK LS0tIGEvV2ViQ29yZS9odG1sL0hUTUxUZXh0QXJlYUVsZW1lbnQuY3BwCisrKyBiL1dlYkNvcmUv aHRtbC9IVE1MVGV4dEFyZWFFbGVtZW50LmNwcApAQCAtMjQxLDcgKzI0MSwxMiBAQCB2b2lkIEhU TUxUZXh0QXJlYUVsZW1lbnQ6OmhhbmRsZUJlZm9yZVRleHRJbnNlcnRlZEV2ZW50KEJlZm9yZVRl eHRJbnNlcnRlZEV2ZW50KgogICAgIHVuc2lnbmVkIHVuc2lnbmVkTWF4TGVuZ3RoID0gc3RhdGlj X2Nhc3Q8dW5zaWduZWQ+KHNpZ25lZE1heExlbmd0aCk7CiAKICAgICB1bnNpZ25lZCBjdXJyZW50 TGVuZ3RoID0gbnVtR3JhcGhlbWVDbHVzdGVycyh0b1JlbmRlclRleHRDb250cm9sKHJlbmRlcmVy KCkpLT50ZXh0KCkpOwotICAgIHVuc2lnbmVkIHNlbGVjdGlvbkxlbmd0aCA9IG51bUdyYXBoZW1l Q2x1c3RlcnMocGxhaW5UZXh0KGRvY3VtZW50KCktPmZyYW1lKCktPnNlbGVjdGlvbigpLT5zZWxl Y3Rpb24oKS50b05vcm1hbGl6ZWRSYW5nZSgpLmdldCgpKSk7CisgICAgLy8gc2VsZWN0aW9uTGVu Z3RoIHJlcHJlc2VudHMgdGhlIHNlbGVjdGlvbiBsZW5ndGggb2YgdGhpcyB0ZXh0IGZpZWxkIHRv IGJlCisgICAgLy8gcmVtb3ZlZCBieSB0aGlzIGluc2VydGlvbi4KKyAgICAvLyBJZiB0aGUgdGV4 dCBmaWVsZCBoYXMgbm8gZm9jdXMsIHdlIGRvbid0IG5lZWQgdG8gdGFrZSBhY2NvdW50IG9mIHRo ZQorICAgIC8vIHNlbGVjdGlvbiBsZW5ndGguIFRoZSBzZWxlY3Rpb24gaXMgdGhlIHNvdXJjZSBv ZiB0ZXh0IGRyYWctYW5kLWRyb3AgaW4KKyAgICAvLyB0aGF0IGNhc2UsIGFuZCBub3RoaW5nIGlu IHRoZSB0ZXh0IGZpZWxkIHdpbGwgYmUgcmVtb3ZlZC4KKyAgICB1bnNpZ25lZCBzZWxlY3Rpb25M ZW5ndGggPSBmb2N1c2VkKCkgPyBudW1HcmFwaGVtZUNsdXN0ZXJzKHBsYWluVGV4dChkb2N1bWVu dCgpLT5mcmFtZSgpLT5zZWxlY3Rpb24oKS0+c2VsZWN0aW9uKCkudG9Ob3JtYWxpemVkUmFuZ2Uo KS5nZXQoKSkpIDogMDsKICAgICBBU1NFUlQoY3VycmVudExlbmd0aCA+PSBzZWxlY3Rpb25MZW5n dGgpOwogICAgIHVuc2lnbmVkIGJhc2VMZW5ndGggPSBjdXJyZW50TGVuZ3RoIC0gc2VsZWN0aW9u TGVuZ3RoOwogICAgIHVuc2lnbmVkIGFwcGVuZGFibGVMZW5ndGggPSB1bnNpZ25lZE1heExlbmd0 aCA+IGJhc2VMZW5ndGggPyB1bnNpZ25lZE1heExlbmd0aCAtIGJhc2VMZW5ndGggOiAwOwo=