38164 2010-04-26 21:01:20 -0700 Refactor results.html generation out into a new method and test it 2010-04-26 21:22:13 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 eric webkit-unassigned abarth cjerdonek dpranke ojan oldest_to_newest 217476 0 eric 2010-04-26 21:01:20 -0700 Refactor results.html generation out into a new method and test it 217482 1 54378 eric 2010-04-26 21:09:58 -0700 Created attachment 54378 Patch 217490 2 54378 abarth 2010-04-26 21:17:34 -0700 Comment on attachment 54378 Patch Ok. run_webkit_tests.py feels like the everything file. 217492 3 eric 2010-04-26 21:19:06 -0700 It is sadly, the everything file.... for now. Hopefully this (small) re-factoring will not conflict with any dpranke has in flight. 217494 4 eric 2010-04-26 21:22:13 -0700 Committed r58285: <http://trac.webkit.org/changeset/58285> 54378 2010-04-26 21:09:58 -0700 2010-04-26 21:17:33 -0700 Patch bug-38164-20100426210956.patch text/plain 6200 eric ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMmMwYWRkZGVkZmVmOGQ4ZDZkZmU3ZDRkMjBiYmFlMmVkYWJhY2ZjLi5hMTY0YTU1 MTRmMDQ4YTAyOGJiNDFhZTBkMGJhOWEwZGQyOGE5ZWU4IDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDQtMjYgIEVyaWMgU2VpZGVsICA8ZXJpY0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZmFjdG9yIHJlc3VsdHMuaHRt bCBnZW5lcmF0aW9uIG91dCBpbnRvIGEgbmV3IG1ldGhvZCBhbmQgdGVzdCBpdAorICAgICAgICBo dHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxNjQKKworICAgICAgICBI b3BlZnVsbHkgdGhpcyByZXN1bHRzIGluIG5vIGNoYW5nZSBpbiBmdW5jdGlvbmFsaXR5LgorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0cy5w eToKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0X3Rl c3RzX3VuaXR0ZXN0LnB5OgorCiAyMDEwLTA0LTI2ICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtp dC5vcmc+CiAKICAgICAgICAgVW5yZXZpZXdlZCwgcm9sbGluZyBvdXQgcjU4MjY1LgpkaWZmIC0t Z2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weSBiL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1 bl93ZWJraXRfdGVzdHMucHkKaW5kZXggMWU2M2E3YTAxZDVhNjM5NmE2ZTBmYTE2ZWQ5NmRhOWFk ZTM4NGI1Zi4uNzdiMzE1MDA0MThlYjExOGQ4MDBjY2UwNDI0YTE0MDU4ZDIyZWZmNyAxMDA3NTUK LS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9sYXlvdXRfdGVzdHMvcnVuX3dlYmtp dF90ZXN0cy5weQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0 cy9ydW5fd2Via2l0X3Rlc3RzLnB5CkBAIC0xNDA0LDYgKzE0MDQsMzIgQEAgY2xhc3MgVGVzdFJ1 bm5lcjoKICAgICAgICAgaWYgbGVuKHVuZXhwZWN0ZWRfcmVzdWx0c1sndGVzdHMnXSkgYW5kIHNl bGYuX29wdGlvbnMudmVyYm9zZToKICAgICAgICAgICAgIHByaW50ICItIiAqIDc4CiAKKyAgICBk ZWYgX3Jlc3VsdHNfaHRtbChzZWxmLCB0ZXN0X2ZpbGVzLCBmYWlsdXJlcywgdGl0bGU9IlRlc3Qg RmFpbHVyZXMiLCBvdmVycmlkZV90aW1lPU5vbmUpOgorICAgICAgICAiIiIKKyAgICAgICAgdGVz dF9maWxlcyA9IGEgbGlzdCBvZiBmaWxlIHBhdGhzCisgICAgICAgIGZhaWx1cmVzID0gZGljdGlv bmFyeSBtYXBwaW5nIHRlc3QgcGF0aHMgdG8gZmFpbHVyZSBvYmplY3RzCisgICAgICAgIHRpdGxl ID0gdGl0bGUgcHJpbnRlZCBhdCB0b3Agb2YgdGVzdAorICAgICAgICBvdmVycmlkZV90aW1lID0g Y3VycmVudCB0aW1lICh1c2VkIGJ5IHVuaXQgdGVzdHMpCisgICAgICAgICIiIgorICAgICAgICBw YWdlID0gIiIiPGh0bWw+CisgIDxoZWFkPgorICAgIDx0aXRsZT5MYXlvdXQgVGVzdCBSZXN1bHRz ICglKHRpbWUpcyk8L3RpdGxlPgorICA8L2hlYWQ+CisgIDxib2R5PgorICAgIDxoMj4lKHRpdGxl KXMgKCUodGltZSlzKTwvaDI+CisgICAgICAgICIiIiAlIHsndGl0bGUnOiB0aXRsZSwgJ3RpbWUn OiBvdmVycmlkZV90aW1lIG9yIHRpbWUuYXNjdGltZSgpfQorCisgICAgICAgIGZvciB0ZXN0X2Zp bGUgaW4gc29ydGVkKHRlc3RfZmlsZXMpOgorICAgICAgICAgICAgdGVzdF9uYW1lID0gc2VsZi5f cG9ydC5yZWxhdGl2ZV90ZXN0X2ZpbGVuYW1lKHRlc3RfZmlsZSkKKyAgICAgICAgICAgIHRlc3Rf dXJsID0gc2VsZi5fcG9ydC5maWxlbmFtZV90b191cmkodGVzdF9maWxlKQorICAgICAgICAgICAg cGFnZSArPSB1IjxwPjxhIGhyZWY9JyVzJz4lczwvYT48YnIgLz5cbiIgJSAodGVzdF91cmwsIHRl c3RfbmFtZSkKKyAgICAgICAgICAgIHRlc3RfZmFpbHVyZXMgPSBmYWlsdXJlcy5nZXQodGVzdF9m aWxlLCBbXSkKKyAgICAgICAgICAgIGZvciBmYWlsdXJlIGluIHRlc3RfZmFpbHVyZXM6CisgICAg ICAgICAgICAgICAgcGFnZSArPSB1IiZuYnNwOyZuYnNwOyVzPGJyLz4iICUgZmFpbHVyZS5yZXN1 bHRfaHRtbF9vdXRwdXQodGVzdF9uYW1lKQorICAgICAgICAgICAgcGFnZSArPSAiPC9wPlxuIgor ICAgICAgICBwYWdlICs9ICI8L2JvZHk+PC9odG1sPlxuIgorICAgICAgICByZXR1cm4gcGFnZQor CiAgICAgZGVmIF93cml0ZV9yZXN1bHRzX2h0bWxfZmlsZShzZWxmLCByZXN1bHRfc3VtbWFyeSk6 CiAgICAgICAgICIiIldyaXRlIHJlc3VsdHMuaHRtbCB3aGljaCBpcyBhIHN1bW1hcnkgb2YgdGVz dHMgdGhhdCBmYWlsZWQuCiAKQEAgLTE0MTYsOCArMTQ0MiwxMCBAQCBjbGFzcyBUZXN0UnVubmVy OgogICAgICAgICAiIiIKICAgICAgICAgIyB0ZXN0IGZhaWx1cmVzCiAgICAgICAgIGlmIHNlbGYu X29wdGlvbnMuZnVsbF9yZXN1bHRzX2h0bWw6CisgICAgICAgICAgICByZXN1bHRzX3RpdGxlID0g IlRlc3QgRmFpbHVyZXMiCiAgICAgICAgICAgICB0ZXN0X2ZpbGVzID0gcmVzdWx0X3N1bW1hcnku ZmFpbHVyZXMua2V5cygpCiAgICAgICAgIGVsc2U6CisgICAgICAgICAgICByZXN1bHRzX3RpdGxl ID0gIlVuZXhwZWN0ZWQgVGVzdCBGYWlsdXJlcyIKICAgICAgICAgICAgIHVuZXhwZWN0ZWRfZmFp bHVyZXMgPSBzZWxmLl9nZXRfZmFpbHVyZXMocmVzdWx0X3N1bW1hcnksCiAgICAgICAgICAgICAg ICAgaW5jbHVkZV9jcmFzaGVzPVRydWUpCiAgICAgICAgICAgICB0ZXN0X2ZpbGVzID0gdW5leHBl Y3RlZF9mYWlsdXJlcy5rZXlzKCkKQEAgLTE0MjYsMzMgKzE0NTQsMTAgQEAgY2xhc3MgVGVzdFJ1 bm5lcjoKIAogICAgICAgICBvdXRfZmlsZW5hbWUgPSBvcy5wYXRoLmpvaW4oc2VsZi5fb3B0aW9u cy5yZXN1bHRzX2RpcmVjdG9yeSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICJyZXN1bHRzLmh0bWwiKQotICAgICAgICAjIEZJWE1FOiBUaGlzIHNob3VsZCBiZSByZS13cml0 dGVuIHRvIHByZXBhcmUgdGhlIHN0cmluZyBmaXJzdAotICAgICAgICAjIHNvIHRoYXQgdGhlICJv cGVuIiBjYWxsIGNhbiBiZSB3cmFwcGVkIGluIGEgd2l0aCBzdGF0ZW1lbnQuCi0gICAgICAgIG91 dF9maWxlID0gY29kZWNzLm9wZW4ob3V0X2ZpbGVuYW1lLCAidyIsICJ1dGYtOCIpCi0gICAgICAg ICMgaGVhZGVyCi0gICAgICAgIGlmIHNlbGYuX29wdGlvbnMuZnVsbF9yZXN1bHRzX2h0bWw6Ci0g ICAgICAgICAgICBoMiA9ICJUZXN0IEZhaWx1cmVzIgotICAgICAgICBlbHNlOgotICAgICAgICAg ICAgaDIgPSAiVW5leHBlY3RlZCBUZXN0IEZhaWx1cmVzIgotICAgICAgICBvdXRfZmlsZS53cml0 ZSgiPGh0bWw+PGhlYWQ+PHRpdGxlPkxheW91dCBUZXN0IFJlc3VsdHMgKCUodGltZSlzKSIKLSAg ICAgICAgICAgICAgICAgICAgICAgIjwvdGl0bGU+PC9oZWFkPjxib2R5PjxoMj4lKGgyKXMgKCUo dGltZSlzKTwvaDI+XG4iCi0gICAgICAgICAgICAgICAgICAgICAgICUgeydoMic6IGgyLCAndGlt ZSc6IHRpbWUuYXNjdGltZSgpfSkKKyAgICAgICAgd2l0aCBjb2RlY3Mub3BlbihvdXRfZmlsZW5h bWUsICJ3IiwgInV0Zi04IikgYXMgcmVzdWx0c19maWxlOgorICAgICAgICAgICAgaHRtbCA9IHNl bGYuX3Jlc3VsdHNfaHRtbCh0ZXN0X2ZpbGVzLCByZXN1bHRfc3VtbWFyeS5mYWlsdXJlcywgcmVz dWx0c190aXRsZSkKKyAgICAgICAgICAgIHJlc3VsdHNfZmlsZS53cml0ZShodG1sKQogCi0gICAg ICAgIHRlc3RfZmlsZXMuc29ydCgpCi0gICAgICAgIGZvciB0ZXN0X2ZpbGUgaW4gdGVzdF9maWxl czoKLSAgICAgICAgICAgIHRlc3RfZmFpbHVyZXMgPSByZXN1bHRfc3VtbWFyeS5mYWlsdXJlcy5n ZXQodGVzdF9maWxlLCBbXSkKLSAgICAgICAgICAgIG91dF9maWxlLndyaXRlKHUiPHA+PGEgaHJl Zj0nJXMnPiVzPC9hPjxiciAvPlxuIgotICAgICAgICAgICAgICAgICAgICAgICAgICAgJSAoc2Vs Zi5fcG9ydC5maWxlbmFtZV90b191cmkodGVzdF9maWxlKSwKLSAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgIHNlbGYuX3BvcnQucmVsYXRpdmVfdGVzdF9maWxlbmFtZSh0ZXN0X2ZpbGUpKSkK LSAgICAgICAgICAgIGZvciBmYWlsdXJlIGluIHRlc3RfZmFpbHVyZXM6Ci0gICAgICAgICAgICAg ICAgb3V0X2ZpbGUud3JpdGUodSImbmJzcDsmbmJzcDslczxici8+IgotICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICUgZmFpbHVyZS5yZXN1bHRfaHRtbF9vdXRwdXQoCi0gICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICBzZWxmLl9wb3J0LnJlbGF0aXZlX3Rlc3RfZmlsZW5hbWUo dGVzdF9maWxlKSkpCi0gICAgICAgICAgICBvdXRfZmlsZS53cml0ZSgiPC9wPlxuIikKLQotICAg ICAgICAjIGZvb3RlcgotICAgICAgICBvdXRfZmlsZS53cml0ZSgiPC9ib2R5PjwvaHRtbD5cbiIp Ci0gICAgICAgIG91dF9maWxlLmNsb3NlKCkKICAgICAgICAgcmV0dXJuIFRydWUKIAogICAgIGRl ZiBfc2hvd19yZXN1bHRzX2h0bWxfZmlsZShzZWxmKToKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xz L1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJraXRfdGVzdHNfdW5pdHRlc3Qu cHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2xheW91dF90ZXN0cy9ydW5fd2Via2l0 X3Rlc3RzX3VuaXR0ZXN0LnB5CmluZGV4IDlmZTBlNzQ4OWFmODNhMTAwZTA2OGVhMzVmNGE2YTdm ZTgxMmMxMDcuLmVkYzVhYzM0Nzg2MzliNDVhMDc4NTI4MWIxYTUyNzQ1NDc5YzExZGIgMTAwNjQ0 Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvbGF5b3V0X3Rlc3RzL3J1bl93ZWJr aXRfdGVzdHNfdW5pdHRlc3QucHkKKysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9s YXlvdXRfdGVzdHMvcnVuX3dlYmtpdF90ZXN0c191bml0dGVzdC5weQpAQCAtMzUsNiArMzUsOCBA QCBpbXBvcnQgdW5pdHRlc3QKIAogaW1wb3J0IHdlYmtpdHB5LmxheW91dF90ZXN0cy5ydW5fd2Vi a2l0X3Rlc3RzIGFzIHJ1bl93ZWJraXRfdGVzdHMKIAorZnJvbSB3ZWJraXRweS50aGlyZHBhcnR5 Lm1vY2sgaW1wb3J0IE1vY2sKKwogCiBkZWYgcGFzc2luZ19ydW4oYXJncyk6CiAgICAgb3B0aW9u cywgYXJncyA9IHJ1bl93ZWJraXRfdGVzdHMucGFyc2VfYXJncyhhcmdzKQpAQCAtNTcsNiArNTks MjcgQEAgY2xhc3MgTWFpblRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgogICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICdmYXN0L2h0bWwnXSkpCiAKIAorY2xhc3MgVGVzdFJ1bm5l clRlc3QodW5pdHRlc3QuVGVzdENhc2UpOgorICAgIGRlZiB0ZXN0X3Jlc3VsdHNfaHRtbChzZWxm KToKKyAgICAgICAgbW9ja19wb3J0ID0gTW9jaygpCisgICAgICAgIG1vY2tfcG9ydC5yZWxhdGl2 ZV90ZXN0X2ZpbGVuYW1lID0gbGFtYmRhIG5hbWU6IG5hbWUKKyAgICAgICAgbW9ja19wb3J0LmZp bGVuYW1lX3RvX3VyaSA9IGxhbWJkYSBuYW1lOiBuYW1lCisKKyAgICAgICAgcnVubmVyID0gcnVu X3dlYmtpdF90ZXN0cy5UZXN0UnVubmVyKHBvcnQ9bW9ja19wb3J0LCBvcHRpb25zPU1vY2soKSwg bWV0ZXI9TW9jaygpKQorICAgICAgICBleHBlY3RlZF9odG1sID0gdSIiIjxodG1sPgorICA8aGVh ZD4KKyAgICA8dGl0bGU+TGF5b3V0IFRlc3QgUmVzdWx0cyAodGltZSk8L3RpdGxlPgorICA8L2hl YWQ+CisgIDxib2R5PgorICAgIDxoMj5UaXRsZSAodGltZSk8L2gyPgorICAgICAgICA8cD48YSBo cmVmPSd0ZXN0X3BhdGgnPnRlc3RfcGF0aDwvYT48YnIgLz4KKzwvcD4KKzwvYm9keT48L2h0bWw+ CisiIiIKKyAgICAgICAgaHRtbCA9IHJ1bm5lci5fcmVzdWx0c19odG1sKFsidGVzdF9wYXRoIl0s IHt9LCAiVGl0bGUiLCBvdmVycmlkZV90aW1lPSJ0aW1lIikKKyAgICAgICAgc2VsZi5hc3NlcnRF cXVhbChodG1sLCBleHBlY3RlZF9odG1sKQorCisKIGNsYXNzIERyeXJ1blRlc3QodW5pdHRlc3Qu VGVzdENhc2UpOgogICAgIGRlZiB0ZXN0X2Jhc2ljcyhzZWxmKToKICAgICAgICAgc2VsZi5hc3Nl cnRUcnVlKHBhc3NpbmdfcnVuKFsnLS1wbGF0Zm9ybScsICdkcnlydW4nLAo=