38159 2010-04-26 17:58:04 -0700 [chromium] Fix ChromiumDataObject::setURL to not populate its internal URL list with empty URLs 2010-04-26 20:07:51 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) Other Windows 7 RESOLVED FIXED P2 Normal --- 0 dcheng webkit-unassigned commit-queue jianli webkit.review.bot oldest_to_newest 217398 0 54357 dcheng 2010-04-26 17:58:04 -0700 Created attachment 54357 Fix for ChromiumDataObject::setURL This wouldn't be a problem except that it appends URLs to an internal list. The fix should be to not append empty URLs; otherwise, asserts in getData will be triggered. 217402 1 webkit.review.bot 2010-04-26 18:02:52 -0700 Attachment 54357 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 WebCore/platform/chromium/ChromiumDataObject.h:80: Tab found; better to use spaces [whitespace/tab] [1] WebCore/platform/chromium/ChromiumDataObject.h:81: Tab found; better to use spaces [whitespace/tab] [1] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 217403 2 54359 dcheng 2010-04-26 18:04:46 -0700 Created attachment 54359 Fix for ChromiumDataObject::setURL Removed the tabs that VS inserted. 217410 3 54363 dcheng 2010-04-26 18:15:31 -0700 Created attachment 54363 Fix for ChromiumDataObject::setURL Move the return, per the discussion. 217412 4 54365 dcheng 2010-04-26 18:17:38 -0700 Created attachment 54365 Fix for ChromiumDataObject::setURL Fix ChangeLog 217413 5 54365 jianli 2010-04-26 18:20:25 -0700 Comment on attachment 54365 Fix for ChromiumDataObject::setURL r=me 217459 6 54365 commit-queue 2010-04-26 20:07:46 -0700 Comment on attachment 54365 Fix for ChromiumDataObject::setURL Clearing flags on attachment: 54365 Committed r58280: <http://trac.webkit.org/changeset/58280> 217460 7 commit-queue 2010-04-26 20:07:51 -0700 All reviewed patches have been landed. Closing bug. 54357 2010-04-26 17:58:04 -0700 2010-04-26 18:04:46 -0700 Fix for ChromiumDataObject::setURL assert.patch text/plain 1023 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q1M2E1ZC4uNjQ1ZDU1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNiAgRGFuaWVsIENoZW5n ICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggQ2hyb21pdW1EYXRhT2JqZWN0OjpzZXRVUkwgdG8gbm90IHBv cHVsYXRlIGl0cyBpbnRlcm5hbCBVUkwgbGlzdCB3aXRoIGVtcHR5IFVSTHMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRh T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURhdGFPYmplY3Q6OnNldFVSTCk6 CisKIDIwMTAtMDQtMjYgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAppbmRleCA2MjVjYjhjLi5lZjg3ZTFiIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmgKQEAgLTc3LDYg Kzc3LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgc2V0VVJMKGNvbnN0 IEtVUkwmIG5ld1VSTCkKICAgICAgICAgeworCQkJaWYgKG5ld1VSTC5pc0VtcHR5KCkpCisJCQkJ cmV0dXJuOwogICAgICAgICAgICAgdXJsID0gbmV3VVJMOwogICAgICAgICAgICAgdXJpTGlzdC5j bGVhcigpOwogICAgICAgICAgICAgdXJpTGlzdC5hcHBlbmQobmV3VVJMLnN0cmluZygpKTsK 54359 2010-04-26 18:04:46 -0700 2010-04-26 18:15:31 -0700 Fix for ChromiumDataObject::setURL assert.patch text/plain 1044 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q1M2E1ZC4uNjQ1ZDU1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNiAgRGFuaWVsIENoZW5n ICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggQ2hyb21pdW1EYXRhT2JqZWN0OjpzZXRVUkwgdG8gbm90IHBv cHVsYXRlIGl0cyBpbnRlcm5hbCBVUkwgbGlzdCB3aXRoIGVtcHR5IFVSTHMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRh T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURhdGFPYmplY3Q6OnNldFVSTCk6 CisKIDIwMTAtMDQtMjYgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAppbmRleCA2MjVjYjhjLi4wNmQ1ZTBiIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmgKQEAgLTc3LDYg Kzc3LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogCiAgICAgICAgIHZvaWQgc2V0VVJMKGNvbnN0 IEtVUkwmIG5ld1VSTCkKICAgICAgICAgeworICAgICAgICAgICAgaWYgKG5ld1VSTC5pc0VtcHR5 KCkpCisgICAgICAgICAgICAgICAgcmV0dXJuOwogICAgICAgICAgICAgdXJsID0gbmV3VVJMOwog ICAgICAgICAgICAgdXJpTGlzdC5jbGVhcigpOwogICAgICAgICAgICAgdXJpTGlzdC5hcHBlbmQo bmV3VVJMLnN0cmluZygpKTsK 54363 2010-04-26 18:15:31 -0700 2010-04-26 18:17:38 -0700 Fix for ChromiumDataObject::setURL assert.patch text/plain 1014 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q1M2E1ZC4uNjQ1ZDU1ZSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNiAgRGFuaWVsIENoZW5n ICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBGaXggQ2hyb21pdW1EYXRhT2JqZWN0OjpzZXRVUkwgdG8gbm90IHBv cHVsYXRlIGl0cyBpbnRlcm5hbCBVUkwgbGlzdCB3aXRoIGVtcHR5IFVSTHMuCisKKyAgICAgICAg Tm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRh T2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURhdGFPYmplY3Q6OnNldFVSTCk6 CisKIDIwMTAtMDQtMjYgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRm b3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJv bWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAppbmRleCA2MjVjYjhjLi5hZjBhM2ZhIDEwMDY0NAot LS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmgKQEAgLTc5LDYg Kzc5LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB7CiAgICAgICAgICAgICB1cmwg PSBuZXdVUkw7CiAgICAgICAgICAgICB1cmlMaXN0LmNsZWFyKCk7CisgICAgICAgICAgICBpZiAo bmV3VVJMLmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CiAgICAgICAgICAgICB1 cmlMaXN0LmFwcGVuZChuZXdVUkwuc3RyaW5nKCkpOwogICAgICAgICB9CiAK 54365 2010-04-26 18:17:38 -0700 2010-04-26 20:07:46 -0700 Fix for ChromiumDataObject::setURL assert.patch text/plain 1080 dcheng ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q1M2E1ZC4uNTkxYTM3NSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0yNiAgRGFuaWVsIENoZW5n ICA8ZGNoZW5nQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIEZpeCBDaHJvbWl1bURhdGFPYmplY3Q6OnNldFVS TCB0byBub3QgcG9wdWxhdGUgaXRzIGludGVybmFsIFVSTCBsaXN0IHdpdGggZW1wdHkgVVJMcy4K KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MTU5CisK KyAgICAgICAgTm8gbmV3IHRlc3RzLgorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21pdW0vQ2hy b21pdW1EYXRhT2JqZWN0Lmg6CisgICAgICAgIChXZWJDb3JlOjpDaHJvbWl1bURhdGFPYmplY3Q6 OnNldFVSTCk6CisKIDIwMTAtMDQtMjYgIFJvbWFuIEdlcnNobWFuICA8cm9tYW5nZUBnb29nbGUu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFydGguCmRpZmYgLS1naXQgYS9XZWJD b3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVjdC5oIGIvV2ViQ29yZS9wbGF0 Zm9ybS9jaHJvbWl1bS9DaHJvbWl1bURhdGFPYmplY3QuaAppbmRleCA2MjVjYjhjLi5hZjBhM2Zh IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Nocm9taXVtRGF0YU9iamVj dC5oCisrKyBiL1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vQ2hyb21pdW1EYXRhT2JqZWN0LmgK QEAgLTc5LDYgKzc5LDggQEAgbmFtZXNwYWNlIFdlYkNvcmUgewogICAgICAgICB7CiAgICAgICAg ICAgICB1cmwgPSBuZXdVUkw7CiAgICAgICAgICAgICB1cmlMaXN0LmNsZWFyKCk7CisgICAgICAg ICAgICBpZiAobmV3VVJMLmlzRW1wdHkoKSkKKyAgICAgICAgICAgICAgICByZXR1cm47CiAgICAg ICAgICAgICB1cmlMaXN0LmFwcGVuZChuZXdVUkwuc3RyaW5nKCkpOwogICAgICAgICB9CiAK