38154 2010-04-26 17:31:24 -0700 REGRESSION: after 56028 FastMalloc calls madvise too often 2010-04-27 16:31:31 -0700 1 1 1 Unclassified WebKit JavaScriptCore 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED InRadar P2 Normal --- 1 slewis webkit-unassigned ggaren slewis webkit.review.bot oldest_to_newest 217377 0 slewis 2010-04-26 17:31:24 -0700 <rdar://problem/7834433> REGRESSSION: 1.5% PLT regression due to 56028 (return memory quicker). To save on madvise calls when recommitting memory recommit the entire chosen span and then carve the span instead of carving the span up and only committing the part that will be used immediately. 217385 1 54354 slewis 2010-04-26 17:43:09 -0700 Created attachment 54354 Change the recommit policy to commit entire spans at one time. Change the recommit policy to recommit entire spans at one time. 217388 2 webkit.review.bot 2010-04-26 17:45:41 -0700 Attachment 54354 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style', '--no-squash']" exit_code: 1 JavaScriptCore/wtf/FastMalloc.cpp:1688: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] JavaScriptCore/wtf/FastMalloc.cpp:1694: Weird number of spaces at line-start. Are you using a 4-space indent? [whitespace/indent] [3] Total errors found: 2 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 217759 3 54354 ggaren 2010-04-27 10:14:18 -0700 Comment on attachment 54354 Change the recommit policy to commit entire spans at one time. r=me Any data on how much of an improvement this is? 218033 4 slewis 2010-04-27 16:31:23 -0700 Committed http://trac.webkit.org/changeset/58346. This is about a .5% improvement. The FastMalloc file has historically not conformed to style guidelines, and my changes matched the file's style. 54354 2010-04-26 17:43:09 -0700 2010-04-27 10:14:18 -0700 Change the recommit policy to commit entire spans at one time. FastMallocfixPart1.txt text/plain 5138 slewis SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4MjczKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjYgIFN0ZXBoYW5p ZSBMZXdpcyAgPHNsZXdpc0BhcHBsZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChPT1BTISkuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dp P2lkPTM4MTU0IEZhc3RNYWxsb2MgY2FsbHMgbWFkdmlzZSB0b28gb2Z0ZW4uCisgICAgICAgIDxy ZGFyOi8vcHJvYmxlbS83ODM0NDMzPiBSRUdSRVNTU0lPTjogMS41JSBQTFQgcmVncmVzc2lvbiBk dWUgdG8gNTYwMjggKHJldHVybiBtZW1vcnkgcXVpY2tlcikuICAKKyAgICAgICAgVG8gc2F2ZSBv biBtYWR2aXNlIGNhbGxzIHdoZW4gcmVjb21taXR0aW5nIG1lbW9yeSByZWNvbW1pdCB0aGUgZW50 aXJlIHNwYW4gYW5kIHRoZW4gY2FydmUgaXQKKyAgICAgICAgaW5zdGVhZCBvZiBjYXJ2aW5nIHRo ZSBzcGFuIHVwIGFuZCBvbmx5IGNvbW1pdHRpbmcgdGhlIHBhcnQgdGhhdCB3aWxsIGJlIHVzZWQg aW1tZWRpYXRlbHkuCisKKyAgICAgICAgKiB3dGYvRmFzdE1hbGxvYy5jcHA6CisgICAgICAgIChX VEY6OlRDTWFsbG9jX1BhZ2VIZWFwOjpOZXcpOgorICAgICAgICAoV1RGOjpUQ01hbGxvY19QYWdl SGVhcDo6QWxsb2NMYXJnZSk6CisgICAgICAgIChXVEY6OlRDTWFsbG9jX1BhZ2VIZWFwOjpDYXJ2 ZSk6CisKIDIwMTAtMDQtMjYgIFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAg ICBGaXggVGlnZXIgYnVpbGQuCkluZGV4OiBKYXZhU2NyaXB0Q29yZS93dGYvRmFzdE1hbGxvYy5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL0Zhc3RNYWxsb2MuY3BwCShyZXZp c2lvbiA1ODI2NSkKKysrIEphdmFTY3JpcHRDb3JlL3d0Zi9GYXN0TWFsbG9jLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtMTU4MywxOSArMTU4MywxMyBAQCBpbmxpbmUgU3BhbiogVENNYWxsb2NfUGFn ZUhlYXA6Ok5ldyhMZW5nCiAKICAgICBTcGFuKiByZXN1bHQgPSBsbC0+bmV4dDsKICAgICBDYXJ2 ZShyZXN1bHQsIG4sIHJlbGVhc2VkKTsKLSAgICBpZiAocmVzdWx0LT5kZWNvbW1pdHRlZCkgewot ICAgICAgICBUQ01hbGxvY19TeXN0ZW1Db21taXQocmVpbnRlcnByZXRfY2FzdDx2b2lkKj4ocmVz dWx0LT5zdGFydCA8PCBrUGFnZVNoaWZ0KSwgc3RhdGljX2Nhc3Q8c2l6ZV90PihuIDw8IGtQYWdl U2hpZnQpKTsKLSAgICAgICAgcmVzdWx0LT5kZWNvbW1pdHRlZCA9IGZhbHNlOwotICAgIH0KICNp ZiBVU0VfQkFDS0dST1VORF9USFJFQURfVE9fU0NBVkVOR0VfTUVNT1JZCi0gICAgZWxzZSB7Ci0g ICAgICAgIC8vIFRoZSBuZXdseSBhbGxvY2F0ZWQgbWVtb3J5IGlzIGZyb20gYSBzcGFuIHRoYXQn cyBpbiB0aGUgbm9ybWFsIHNwYW4gbGlzdCAoYWxyZWFkeSBjb21taXR0ZWQpLiAgVXBkYXRlIHRo ZQotICAgICAgICAvLyBmcmVlIGNvbW1pdHRlZCBwYWdlcyBjb3VudC4KLSAgICAgICAgQVNTRVJU KGZyZWVfY29tbWl0dGVkX3BhZ2VzXyA+PSBuKTsKLSAgICAgICAgZnJlZV9jb21taXR0ZWRfcGFn ZXNfIC09IG47Ci0gICAgICAgIGlmIChmcmVlX2NvbW1pdHRlZF9wYWdlc18gPCBtaW5fZnJlZV9j b21taXR0ZWRfcGFnZXNfc2luY2VfbGFzdF9zY2F2ZW5nZV8pCi0gICAgICAgICAgICBtaW5fZnJl ZV9jb21taXR0ZWRfcGFnZXNfc2luY2VfbGFzdF9zY2F2ZW5nZV8gPSBmcmVlX2NvbW1pdHRlZF9w YWdlc187Ci0gICAgfQorICAgIC8vIFRoZSBuZXdseSBhbGxvY2F0ZWQgbWVtb3J5IGlzIGZyb20g YSBzcGFuIHRoYXQncyBpbiB0aGUgbm9ybWFsIHNwYW4gbGlzdCAoYWxyZWFkeSBjb21taXR0ZWQp LiAgVXBkYXRlIHRoZQorICAgIC8vIGZyZWUgY29tbWl0dGVkIHBhZ2VzIGNvdW50LgorICAgIEFT U0VSVChmcmVlX2NvbW1pdHRlZF9wYWdlc18gPj0gbik7CisgICAgZnJlZV9jb21taXR0ZWRfcGFn ZXNfIC09IG47CisgICAgaWYgKGZyZWVfY29tbWl0dGVkX3BhZ2VzXyA8IG1pbl9mcmVlX2NvbW1p dHRlZF9wYWdlc19zaW5jZV9sYXN0X3NjYXZlbmdlXykgCisgICAgICBtaW5fZnJlZV9jb21taXR0 ZWRfcGFnZXNfc2luY2VfbGFzdF9zY2F2ZW5nZV8gPSBmcmVlX2NvbW1pdHRlZF9wYWdlc187CiAj ZW5kaWYgIC8vIFVTRV9CQUNLR1JPVU5EX1RIUkVBRF9UT19TQ0FWRU5HRV9NRU1PUlkKICAgICBB U1NFUlQoQ2hlY2soKSk7CiAgICAgZnJlZV9wYWdlc18gLT0gbjsKQEAgLTE2NTMsMTkgKzE2NDcs MTMgQEAgU3BhbiogVENNYWxsb2NfUGFnZUhlYXA6OkFsbG9jTGFyZ2UoTGVuZwogCiAgIGlmIChi ZXN0ICE9IE5VTEwpIHsKICAgICBDYXJ2ZShiZXN0LCBuLCBmcm9tX3JlbGVhc2VkKTsKLSAgICBp ZiAoYmVzdC0+ZGVjb21taXR0ZWQpIHsKLSAgICAgICAgVENNYWxsb2NfU3lzdGVtQ29tbWl0KHJl aW50ZXJwcmV0X2Nhc3Q8dm9pZCo+KGJlc3QtPnN0YXJ0IDw8IGtQYWdlU2hpZnQpLCBzdGF0aWNf Y2FzdDxzaXplX3Q+KG4gPDwga1BhZ2VTaGlmdCkpOwotICAgICAgICBiZXN0LT5kZWNvbW1pdHRl ZCA9IGZhbHNlOwotICAgIH0KICNpZiBVU0VfQkFDS0dST1VORF9USFJFQURfVE9fU0NBVkVOR0Vf TUVNT1JZCi0gICAgZWxzZSB7Ci0gICAgICAgIC8vIFRoZSBuZXdseSBhbGxvY2F0ZWQgbWVtb3J5 IGlzIGZyb20gYSBzcGFuIHRoYXQncyBpbiB0aGUgbm9ybWFsIHNwYW4gbGlzdCAoYWxyZWFkeSBj b21taXR0ZWQpLiAgVXBkYXRlIHRoZQotICAgICAgICAvLyBmcmVlIGNvbW1pdHRlZCBwYWdlcyBj b3VudC4KLSAgICAgICAgQVNTRVJUKGZyZWVfY29tbWl0dGVkX3BhZ2VzXyA+PSBuKTsKLSAgICAg ICAgZnJlZV9jb21taXR0ZWRfcGFnZXNfIC09IG47Ci0gICAgICAgIGlmIChmcmVlX2NvbW1pdHRl ZF9wYWdlc18gPCBtaW5fZnJlZV9jb21taXR0ZWRfcGFnZXNfc2luY2VfbGFzdF9zY2F2ZW5nZV8p Ci0gICAgICAgICAgICBtaW5fZnJlZV9jb21taXR0ZWRfcGFnZXNfc2luY2VfbGFzdF9zY2F2ZW5n ZV8gPSBmcmVlX2NvbW1pdHRlZF9wYWdlc187Ci0gICAgfQorICAgIC8vIFRoZSBuZXdseSBhbGxv Y2F0ZWQgbWVtb3J5IGlzIGZyb20gYSBzcGFuIHRoYXQncyBpbiB0aGUgbm9ybWFsIHNwYW4gbGlz dCAoYWxyZWFkeSBjb21taXR0ZWQpLiAgVXBkYXRlIHRoZQorICAgIC8vIGZyZWUgY29tbWl0dGVk IHBhZ2VzIGNvdW50LgorICAgIEFTU0VSVChmcmVlX2NvbW1pdHRlZF9wYWdlc18gPj0gbik7Cisg ICAgZnJlZV9jb21taXR0ZWRfcGFnZXNfIC09IG47CisgICAgaWYgKGZyZWVfY29tbWl0dGVkX3Bh Z2VzXyA8IG1pbl9mcmVlX2NvbW1pdHRlZF9wYWdlc19zaW5jZV9sYXN0X3NjYXZlbmdlXykKKyAg ICAgIG1pbl9mcmVlX2NvbW1pdHRlZF9wYWdlc19zaW5jZV9sYXN0X3NjYXZlbmdlXyA9IGZyZWVf Y29tbWl0dGVkX3BhZ2VzXzsKICNlbmRpZiAgLy8gVVNFX0JBQ0tHUk9VTkRfVEhSRUFEX1RPX1ND QVZFTkdFX01FTU9SWQogICAgIEFTU0VSVChDaGVjaygpKTsKICAgICBmcmVlX3BhZ2VzXyAtPSBu OwpAQCAtMTY5MSwyOSArMTY3OSwzMiBAQCBTcGFuKiBUQ01hbGxvY19QYWdlSGVhcDo6U3BsaXQo U3Bhbiogc3BhCiAgIHJldHVybiBsZWZ0b3ZlcjsKIH0KIAotc3RhdGljIEFMV0FZU19JTkxJTkUg dm9pZCBwcm9wYWdhdGVEZWNvbW1pdHRlZFN0YXRlKFNwYW4qIGRlc3RpbmF0aW9uLCBTcGFuKiBz b3VyY2UpCi17Ci0gICAgZGVzdGluYXRpb24tPmRlY29tbWl0dGVkID0gc291cmNlLT5kZWNvbW1p dHRlZDsKLX0KLQogaW5saW5lIHZvaWQgVENNYWxsb2NfUGFnZUhlYXA6OkNhcnZlKFNwYW4qIHNw YW4sIExlbmd0aCBuLCBib29sIHJlbGVhc2VkKSB7CiAgIEFTU0VSVChuID4gMCk7CiAgIERMTF9S ZW1vdmUoc3Bhbik7CiAgIHNwYW4tPmZyZWUgPSAwOwogICBFdmVudChzcGFuLCAnQScsIG4pOwog CisgIGlmIChyZWxlYXNlZCkgeworICAgIC8vIElmIHRoZSBzcGFuIGNob3NlbiB0byBjYXJ2ZSBm cm9tIGlzIGRlY29tbWl0ZWQsIGNvbW1pdCB0aGUgZW50aXJlIHNwYW4gYXQgb25jZSB0byBhdm9p ZCBjb21taXR0aW5nIHNwYW5zIDEgcGFnZSBhdCBhIHRpbWUuCisgICAgQVNTRVJUKHNwYW4tPmRl Y29tbWl0dGVkKTsKKyAgICBUQ01hbGxvY19TeXN0ZW1Db21taXQocmVpbnRlcnByZXRfY2FzdDx2 b2lkKj4oc3Bhbi0+c3RhcnQgPDwga1BhZ2VTaGlmdCksIHN0YXRpY19jYXN0PHNpemVfdD4oc3Bh bi0+bGVuZ3RoIDw8IGtQYWdlU2hpZnQpKTsKKyAgICBzcGFuLT5kZWNvbW1pdHRlZCA9IGZhbHNl OworICAgIGZyZWVfY29tbWl0dGVkX3BhZ2VzXyArPSBzcGFuLT5sZW5ndGg7CisgIH0KKyAgCiAg IGNvbnN0IGludCBleHRyYSA9IHN0YXRpY19jYXN0PGludD4oc3Bhbi0+bGVuZ3RoIC0gbik7CiAg IEFTU0VSVChleHRyYSA+PSAwKTsKICAgaWYgKGV4dHJhID4gMCkgewogICAgIFNwYW4qIGxlZnRv dmVyID0gTmV3U3BhbihzcGFuLT5zdGFydCArIG4sIGV4dHJhKTsKICAgICBsZWZ0b3Zlci0+ZnJl ZSA9IDE7Ci0gICAgcHJvcGFnYXRlRGVjb21taXR0ZWRTdGF0ZShsZWZ0b3Zlciwgc3Bhbik7Cisg ICAgbGVmdG92ZXItPmRlY29tbWl0dGVkID0gZmFsc2U7CiAgICAgRXZlbnQobGVmdG92ZXIsICdT JywgZXh0cmEpOwogICAgIFJlY29yZFNwYW4obGVmdG92ZXIpOwogCiAgICAgLy8gUGxhY2UgbGVm dG92ZXIgc3BhbiBvbiBhcHByb3ByaWF0ZSBmcmVlIGxpc3QKICAgICBTcGFuTGlzdCogbGlzdHBh aXIgPSAoc3RhdGljX2Nhc3Q8c2l6ZV90PihleHRyYSkgPCBrTWF4UGFnZXMpID8gJmZyZWVfW2V4 dHJhXSA6ICZsYXJnZV87Ci0gICAgU3BhbiogZHN0ID0gcmVsZWFzZWQgPyAmbGlzdHBhaXItPnJl dHVybmVkIDogJmxpc3RwYWlyLT5ub3JtYWw7CisgICAgU3BhbiogZHN0ID0gJmxpc3RwYWlyLT5u b3JtYWw7CiAgICAgRExMX1ByZXBlbmQoZHN0LCBsZWZ0b3Zlcik7CiAKICAgICBzcGFuLT5sZW5n dGggPSBuOwo=