38135 2010-04-26 13:06:54 -0700 Include RuntimeEnabledFeatures in the Qt build 2010-04-27 07:39:15 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED INVALID P2 Enhancement --- 37485 0 gdk webkit-unassigned eric kenneth ossy oldest_to_newest 217231 0 gdk 2010-04-26 13:06:54 -0700 Currently, RuntimeEnabledFeatures is not included in the Qt build. This patch adds it to the Qt build, alongside a modification in WebSockets to remove the guards that stop runtime-feature support from only being enabled under the V8 platform. 217232 1 54325 gdk 2010-04-26 13:08:14 -0700 Created attachment 54325 Initial patch 217235 2 54325 kenneth 2010-04-26 13:13:47 -0700 Comment on attachment 54325 Initial patch What is this exactly? How do we enable this? Do we need to add a setting to the QWebSettings class? If you can answer those questions, I will happily review the patch. 217257 3 eric 2010-04-26 13:59:17 -0700 Why does Qt want this? 217329 4 ossy 2010-04-26 15:47:48 -0700 (In reply to comment #3) > Why does Qt want this? I'm not convinced if Qt port would like to use it, but this patch blocks https://bugs.webkit.org/show_bug.cgi?id=37485 217351 5 54325 levin 2010-04-26 16:30:35 -0700 Comment on attachment 54325 Initial patch WebCore/websockets/WebSocket.cpp:81 + static bool webSocketsAvailable = true; There is no explanation for this change in the ChangeLog. WebCore/ChangeLog:5 + Include RuntimeEnabledFeatures in the Qt build. It sounds like folks who work on Qt aren't convinced that this is a change they want. Why not just have a implementation of RuntimeEnabledFeatures that just returns true and use that for Qt (and include it with the other patch that needs it)? 217431 6 kenneth 2010-04-26 18:49:06 -0700 (In reply to comment #5) > It sounds like folks who work on Qt aren't convinced that this is a change they > want. I'm not really against it, but I just have no idea what it is :-) thus it is very hard to give an opinion on whether this is a change we want or not. 217613 7 ossy 2010-04-27 02:31:52 -0700 As far as I see only Chromium port uses RuntimeEnabledFeature now. I think it can be useful for testing experimental features on other ports. If we really want to use this feature into Qt port, it's OK. But I think the goal of this patch is to "Make touch event support a RuntimeEnabledFeature" ( https://bugs.webkit.org/show_bug.cgi?id=37485 ) for the Chromium port without breaking Qt port. If I am correct, it isn't the good solution, but papering over the cracks. 217703 8 gdk 2010-04-27 07:39:15 -0700 Papier-mâché seems like a poor approach. I've changed the proposed patch for 37485 and am closing this issue. 54325 2010-04-26 13:08:14 -0700 2010-04-26 16:30:35 -0700 Initial patch qt-rtef.patch text/plain 2663 gdk ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Y2Q1M2E1ZC4uYTMxYjEwYSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNiAgR2FycmV0IEtlbGx5 ICA8Z2RrQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMh KS4KKworICAgICAgICBJbmNsdWRlIFJ1bnRpbWVFbmFibGVkRmVhdHVyZXMgaW4gdGhlIFF0IGJ1 aWxkLgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzgx MzUKKworICAgICAgICAqIFdlYkNvcmUucHJvOiBBZGRpbmcgUnVudGltZUVuYWJsZWRGZWF0dXJl cyBzb3VyY2VzIGFuZCBoZWFkZXJzLgorICAgICAgICAqIHdlYnNvY2tldHMvV2ViU29ja2V0LmNw cDogUmVtb3ZpbmcgVjgtb25seSBndWFyZHMuCisgICAgICAgICogd2Vic29ja2V0cy9XZWJTb2Nr ZXQuaDogUmVtb3ZpbmcgVjgtb25seSBndWFyZHMuCisKIDIwMTAtMDQtMjYgIFJvbWFuIEdlcnNo bWFuICA8cm9tYW5nZUBnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gQmFy dGguCmRpZmYgLS1naXQgYS9XZWJDb3JlL1dlYkNvcmUucHJvIGIvV2ViQ29yZS9XZWJDb3JlLnBy bwppbmRleCAzOGQ5NmViLi4wM2NhYTRjIDEwMDY0NAotLS0gYS9XZWJDb3JlL1dlYkNvcmUucHJv CisrKyBiL1dlYkNvcmUvV2ViQ29yZS5wcm8KQEAgLTEwMTgsNiArMTAxOCw3IEBAIEhFQURFUlMg Kz0gXAogICAgIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlSGVhZGVyQ29udGFpbmVy LmggXAogICAgIGFjY2Vzc2liaWxpdHkvQWNjZXNzaWJpbGl0eVRhYmxlUm93LmggXAogICAgIGFj Y2Vzc2liaWxpdHkvQVhPYmplY3RDYWNoZS5oIFwKKyAgICBiaW5kaW5ncy9nZW5lcmljL1J1bnRp bWVFbmFibGVkRmVhdHVyZXMuaCBcCiAgICAgYmluZGluZ3MvanMvQ2FjaGVkU2NyaXB0U291cmNl UHJvdmlkZXIuaCBcCiAgICAgYmluZGluZ3MvanMvR0NDb250cm9sbGVyLmggXAogICAgIGJpbmRp bmdzL2pzL0RPTU9iamVjdEhhc2hUYWJsZU1hcC5oIFwKQEAgLTIwMzYsNiArMjAzNyw3IEBAIEhF QURFUlMgKz0gXAogCiBTT1VSQ0VTICs9IFwKICAgICBhY2Nlc3NpYmlsaXR5L3F0L0FjY2Vzc2li aWxpdHlPYmplY3RRdC5jcHAgXAorICAgIGJpbmRpbmdzL2dlbmVyaWMvUnVudGltZUVuYWJsZWRG ZWF0dXJlcy5jcHAgXAogICAgIGJpbmRpbmdzL2pzL1NjcmlwdENvbnRyb2xsZXJRdC5jcHAgXAog ICAgIGJyaWRnZS9xdC9xdF9jbGFzcy5jcHAgXAogICAgIGJyaWRnZS9xdC9xdF9pbnN0YW5jZS5j cHAgXApkaWZmIC0tZ2l0IGEvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5jcHAgYi9XZWJD b3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAppbmRleCBhODIwYzJhLi43ODM4ZDJkIDEwMDY0 NAotLS0gYS9XZWJDb3JlL3dlYnNvY2tldHMvV2ViU29ja2V0LmNwcAorKysgYi9XZWJDb3JlL3dl YnNvY2tldHMvV2ViU29ja2V0LmNwcApAQCAtNzgsOSArNzgsNyBAQCBzdGF0aWMgU3RyaW5nIGVu Y29kZVByb3RvY29sU3RyaW5nKGNvbnN0IFN0cmluZyYgcHJvdG9jb2wpCiAgICAgcmV0dXJuIGJ1 aWxkZXIudG9TdHJpbmcoKTsKIH0KIAotI2lmIFVTRShWOCkKLQotc3RhdGljIGJvb2wgd2ViU29j a2V0c0F2YWlsYWJsZSA9IGZhbHNlOworc3RhdGljIGJvb2wgd2ViU29ja2V0c0F2YWlsYWJsZSA9 IHRydWU7CiAKIHZvaWQgV2ViU29ja2V0OjpzZXRJc0F2YWlsYWJsZShib29sIGF2YWlsYWJsZSkK IHsKQEAgLTkyLDggKzkwLDYgQEAgYm9vbCBXZWJTb2NrZXQ6OmlzQXZhaWxhYmxlKCkKICAgICBy ZXR1cm4gd2ViU29ja2V0c0F2YWlsYWJsZTsKIH0KIAotI2VuZGlmCi0KIFdlYlNvY2tldDo6V2Vi U29ja2V0KFNjcmlwdEV4ZWN1dGlvbkNvbnRleHQqIGNvbnRleHQpCiAgICAgOiBBY3RpdmVET01P YmplY3QoY29udGV4dCwgdGhpcykKICAgICAsIG1fc3RhdGUoQ09OTkVDVElORykKZGlmZiAtLWdp dCBhL1dlYkNvcmUvd2Vic29ja2V0cy9XZWJTb2NrZXQuaCBiL1dlYkNvcmUvd2Vic29ja2V0cy9X ZWJTb2NrZXQuaAppbmRleCBlOTE3OTZmLi4wOTg2YzNmIDEwMDY0NAotLS0gYS9XZWJDb3JlL3dl YnNvY2tldHMvV2ViU29ja2V0LmgKKysrIGIvV2ViQ29yZS93ZWJzb2NrZXRzL1dlYlNvY2tldC5o CkBAIC01MCwxMCArNTAsOCBAQCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKICAgICBjbGFzcyBXZWJT b2NrZXQgOiBwdWJsaWMgUmVmQ291bnRlZDxXZWJTb2NrZXQ+LCBwdWJsaWMgRXZlbnRUYXJnZXQs IHB1YmxpYyBBY3RpdmVET01PYmplY3QsIHB1YmxpYyBXZWJTb2NrZXRDaGFubmVsQ2xpZW50IHsK ICAgICBwdWJsaWM6Ci0jaWYgVVNFKFY4KQogICAgICAgICBzdGF0aWMgdm9pZCBzZXRJc0F2YWls YWJsZShib29sKTsKICAgICAgICAgc3RhdGljIGJvb2wgaXNBdmFpbGFibGUoKTsKLSNlbmRpZgog ICAgICAgICBzdGF0aWMgUGFzc1JlZlB0cjxXZWJTb2NrZXQ+IGNyZWF0ZShTY3JpcHRFeGVjdXRp b25Db250ZXh0KiBjb250ZXh0KSB7IHJldHVybiBhZG9wdFJlZihuZXcgV2ViU29ja2V0KGNvbnRl eHQpKTsgfQogICAgICAgICB2aXJ0dWFsIH5XZWJTb2NrZXQoKTsKIAo=