38125 2010-04-26 07:15:07 -0700 View modes names in CSSValueKeywords.in 2010-05-05 08:14:14 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All CLOSED FIXED P2 Normal --- 35784 1 luiz webkit-unassigned commit-queue hausmann laszlo.gombos oldest_to_newest 217080 0 luiz 2010-04-26 07:15:07 -0700 View mode names has changed in previous patch but CSSValueKeywords.in file was not updated. Layout tests should fail but they do not because of bug 38116. 217082 1 54294 luiz 2010-04-26 07:21:24 -0700 Created attachment 54294 patch 1 217083 2 laszlo.gombos 2010-04-26 07:22:57 -0700 Looks good, but should we sort these strings when possible ? 217092 3 luiz 2010-04-26 07:32:34 -0700 (In reply to comment #2) > Looks good, but should we sort these strings when possible ? no problem. :) 217098 4 54299 luiz 2010-04-26 07:38:30 -0700 Created attachment 54299 patch 2 217131 5 54299 commit-queue 2010-04-26 09:21:52 -0700 Comment on attachment 54299 patch 2 Clearing flags on attachment: 54299 Committed r58258: <http://trac.webkit.org/changeset/58258> 217132 6 commit-queue 2010-04-26 09:21:58 -0700 All reviewed patches have been landed. Closing bug. 221116 7 hausmann 2010-05-05 08:14:03 -0700 Revision r58258 cherry-picked into qtwebkit-2.0 with commit ddf1a58c83038dfe71ff66417d4a4a8d0c3a2bb5 54294 2010-04-26 07:21:24 -0700 2010-04-26 07:38:30 -0700 patch 1 0001-View-modes-names-in-CSSValueKeywords.in.patch text/plain 1510 luiz RnJvbSA5Y2I0NWM4MTY4Y2UzZmViOTlkNjA0NTMxYzQwMzc4NzYxMGI3Mzc0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgMjYgQXByIDIwMTAgMTE6MTc6NDIgLTAzMDAKU3ViamVjdDogW1BB VENIXSBWaWV3IG1vZGVzIG5hbWVzIGluIENTU1ZhbHVlS2V5d29yZHMuaW4KIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODEyNQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpWaWV3IG1vZGUgbmFtZXMgaGFzIGNoYW5nZWQgaW4gcHJldmlvdXMgcGF0Y2ggYnV0 IENTU1ZhbHVlS2V5d29yZHMuaW4gZmlsZSB3YXMKbm90IHVwZGF0ZWQuCgoqIGNzcy9DU1NWYWx1 ZUtleXdvcmRzLmluOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbiB8ICAgIDUgKysr LS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ3 OTIxNjIuLjQzN2RkZTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMjYgIEx1aXogQWdvc3Rpbmkg IDxsdWl6LmFnb3N0aW5pQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVmlldyBtb2RlcyBuYW1lcyBpbiBDU1NWYWx1ZUtleXdv cmRzLmluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z ODEyNQorCisgICAgICAgIFZpZXcgbW9kZSBuYW1lcyBoYXMgY2hhbmdlZCBpbiBwcmV2aW91cyBw YXRjaCBidXQgQ1NTVmFsdWVLZXl3b3Jkcy5pbiBmaWxlIHdhcworICAgICAgICBub3QgdXBkYXRl ZC4KKworICAgICAgICAqIGNzcy9DU1NWYWx1ZUtleXdvcmRzLmluOgorCiAyMDEwLTA0LTI0ICBB bnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmlu IGIvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgppbmRleCAwOWQ5NjlhLi4zOWVlNDgw IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluCisrKyBiL1dlYkNv cmUvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4KQEAgLTcxMSw3ICs3MTEsOCBAQCBnZW9tZXRyaWNQ cmVjaXNpb24KIHNSR0IKIAogIyAoLXdlYmtpdC12aWV3LW1vZGU6KSBtZWRpYSBmZWF0dXJlOgot bWluaQorbWF4aW1pemVkCittaW5pbWl6ZWQKIGZsb2F0aW5nCi1hcHBsaWNhdGlvbgogZnVsbHNj cmVlbgord2luZG93ZWQKLS0gCjEuNi4zLjMKCg== 54299 2010-04-26 07:38:30 -0700 2010-04-26 09:21:52 -0700 patch 2 0001-View-modes-names-in-CSSValueKeywords.in.patch text/plain 1510 luiz RnJvbSA2MGIzMDYzYjBmY2ZkMzFiZTVhY2E0OThhYzE5MjUxNzhlODk1MjE2IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBMdWl6IEFnb3N0aW5pIDxsdWl6LmFnb3N0aW5pQG9wZW5ib3Nz YS5vcmc+CkRhdGU6IE1vbiwgMjYgQXByIDIwMTAgMTE6MzA6NDYgLTAzMDAKU3ViamVjdDogW1BB VENIXSBWaWV3IG1vZGVzIG5hbWVzIGluIENTU1ZhbHVlS2V5d29yZHMuaW4KIGh0dHBzOi8vYnVn cy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODEyNQoKUmV2aWV3ZWQgYnkgTk9CT0RZIChP T1BTISkuCgpWaWV3IG1vZGUgbmFtZXMgaGFzIGNoYW5nZWQgaW4gcHJldmlvdXMgcGF0Y2ggYnV0 IENTU1ZhbHVlS2V5d29yZHMuaW4gZmlsZSB3YXMKbm90IHVwZGF0ZWQuCgoqIGNzcy9DU1NWYWx1 ZUtleXdvcmRzLmluOgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAgICAgfCAgIDEy ICsrKysrKysrKysrKwogV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbiB8ICAgIDUgKysr LS0KIDIgZmlsZXMgY2hhbmdlZCwgMTUgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKCmRp ZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IGQ3 OTIxNjIuLjQzN2RkZTcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNv cmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMjYgIEx1aXogQWdvc3Rpbmkg IDxsdWl6LmFnb3N0aW5pQG9wZW5ib3NzYS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgVmlldyBtb2RlcyBuYW1lcyBpbiBDU1NWYWx1ZUtleXdv cmRzLmluCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0z ODEyNQorCisgICAgICAgIFZpZXcgbW9kZSBuYW1lcyBoYXMgY2hhbmdlZCBpbiBwcmV2aW91cyBw YXRjaCBidXQgQ1NTVmFsdWVLZXl3b3Jkcy5pbiBmaWxlIHdhcworICAgICAgICBub3QgdXBkYXRl ZC4KKworICAgICAgICAqIGNzcy9DU1NWYWx1ZUtleXdvcmRzLmluOgorCiAyMDEwLTA0LTI0ICBB bnRvbiBNdWhpbiAgPGFudG9ubUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmlu IGIvV2ViQ29yZS9jc3MvQ1NTVmFsdWVLZXl3b3Jkcy5pbgppbmRleCAwOWQ5NjlhLi4xMDI4ZGNm IDEwMDY0NAotLS0gYS9XZWJDb3JlL2Nzcy9DU1NWYWx1ZUtleXdvcmRzLmluCisrKyBiL1dlYkNv cmUvY3NzL0NTU1ZhbHVlS2V5d29yZHMuaW4KQEAgLTcxMSw3ICs3MTEsOCBAQCBnZW9tZXRyaWNQ cmVjaXNpb24KIHNSR0IKIAogIyAoLXdlYmtpdC12aWV3LW1vZGU6KSBtZWRpYSBmZWF0dXJlOgot bWluaQogZmxvYXRpbmcKLWFwcGxpY2F0aW9uCiBmdWxsc2NyZWVuCittYXhpbWl6ZWQKK21pbmlt aXplZAord2luZG93ZWQKLS0gCjEuNi4zLjMKCg==