38105 2010-04-25 23:51:37 -0700 [chromium] Select popups should be closed when select is clicked 2010-04-27 19:29:36 -0700 1 1 1 Unclassified WebKit WebKit Misc. 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 jcivelli webkit-unassigned commit-queue webkit.review.bot oldest_to_newest 216919 0 jcivelli 2010-04-25 23:51:37 -0700 - In Chromium open a page with a select - Click the select, the popup is opened - Click the select again Expected: The popup is closed. Actual: The popup remains open. 216920 1 54261 jcivelli 2010-04-25 23:59:27 -0700 Created attachment 54261 Fix for closing a select popup when there is a click on the select 216921 2 webkit.review.bot 2010-04-26 00:01:36 -0700 Attachment 54261 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/chromium/src/WebViewImpl.cpp:329: One or more unexpected \r (^M) found; better to use only a \n [whitespace/carriage_return] [1] Suppressing further [whitespace/carriage_return] reports for this file. Total errors found: 9 in 2 files If any of these errors are false positives, please file a bug against check-webkit-style. 216924 3 54263 jcivelli 2010-04-26 00:11:57 -0700 Created attachment 54263 Fixing style 218159 4 54263 commit-queue 2010-04-27 19:29:31 -0700 Comment on attachment 54263 Fixing style Clearing flags on attachment: 54263 Committed r58370: <http://trac.webkit.org/changeset/58370> 218160 5 commit-queue 2010-04-27 19:29:36 -0700 All reviewed patches have been landed. Closing bug. 54261 2010-04-25 23:59:27 -0700 2010-04-26 00:11:57 -0700 Fix for closing a select popup when there is a click on the select select_click.patch text/plain 2280 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODIzNSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZXMgY2xpY2tpbmcgYSBzZWxlY3QgZWxlbWVu dCBjbG9zZSBpdHMgYXNzb2NpYXRlZCBwb3B1cCBpZgorICAgICAgICBpdCBpcyBvcGVuLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxMDUKKworICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs Ojptb3VzZURvd24pOgorCiAyMDEwLTA0LTIzICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTgyMTApCisrKyBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI2LDkgKzMyNiwxMiBAQCB2 b2lkIFdlYlZpZXdJbXBsOjptb3VzZURvd24oY29uc3QgV2ViTW91CiAgICAgaWYgKCFtYWluRnJh bWVJbXBsKCkgfHwgIW1haW5GcmFtZUltcGwoKS0+ZnJhbWVWaWV3KCkpCiAgICAgICAgIHJldHVy bjsKIAotICAgIC8vIElmIHRoZXJlIGlzIGEgc2VsZWN0IHBvcHVwIG9wZW5lZCwgY2xvc2UgaXQg YXMgdGhlIHVzZXIgaXMgY2xpY2tpbmcgb24KLSAgICAvLyB0aGUgcGFnZSAob3V0c2lkZSBvZiB0 aGUgcG9wdXApLgorICAgIC8vIElmIHRoZXJlIGlzIGEgc2VsZWN0IHBvcHVwIG9wZW4sIGNsb3Nl IGl0IGFzIHRoZSB1c2VyIGlzIGNsaWNraW5nIG9uDQorICAgIC8vIHRoZSBwYWdlIChvdXRzaWRl IG9mIHRoZSBwb3B1cCkuICBXZSBhbHNvIHNhdmUgaXQgc28gd2UgY2FuIHByZXZlbnQgYQ0KKyAg ICAvLyBjbGljayBvbiB0aGUgc2VsZWN0IGVsZW1lbnQgZnJvbSBpbW1lZGlhdGVseSByZW9wZW5p bmcgdGhlIHBvcHVwLg0KKyAgICBSZWZQdHI8V2ViQ29yZTo6UG9wdXBDb250YWluZXI+IHNlbGVj dFBvcHVwID0gbV9zZWxlY3RQb3B1cDsNCiAgICAgaGlkZVNlbGVjdFBvcHVwKCk7CisgICAgQVNT RVJUKCFtX3NlbGVjdFBvcHVwKTsKIAogICAgIG1fbGFzdE1vdXNlRG93blBvaW50ID0gV2ViUG9p bnQoZXZlbnQueCwgZXZlbnQueSk7CiAgICAgbV9oYXZlTW91c2VDYXB0dXJlID0gdHJ1ZTsKQEAg LTM2Miw2ICszNjUsMTMgQEAgdm9pZCBXZWJWaWV3SW1wbDo6bW91c2VEb3duKGNvbnN0IFdlYk1v dQogICAgICAgICBzdGF0aWNfY2FzdDxFZGl0b3JDbGllbnRJbXBsKj4obV9wYWdlLT5lZGl0b3JD bGllbnQoKSktPgogICAgICAgICAgICAgc2hvd0Zvcm1BdXRvZmlsbEZvck5vZGUoY2xpY2tlZE5v ZGUuZ2V0KCkpOwogICAgIH0KKyAgICBpZiAobV9zZWxlY3RQb3B1cCAmJiBtX3NlbGVjdFBvcHVw ID09IHNlbGVjdFBvcHVwKSB7DQorICAgICAgICAvLyBUaGF0IGNsaWNrIHRyaWdnZXJlZCBhIHNl bGVjdCBwb3B1cCB3aGljaCBpcyB0aGUgc2FtZSBhcyB0aGUgb25lIHRoYXQNCisgICAgICAgIC8v IHdhcyBzaG93aW5nIGJlZm9yZSB0aGUgY2xpY2suICBJdCBtZWFucyB0aGUgdXNlciBjbGlja2Vk IHRoZSBzZWxlY3QNCisgICAgICAgIC8vIHdoaWxlIHRoZSBwb3B1cCB3YXMgc2hvd2luZywgYW5k IGFzIGEgcmVzdWx0IHdlIGZpcnN0IGNsb3NlZCB0aGVuDQorICAgICAgICAvLyBpbW1lZGlhdGVs eSByZW9wZW5lZCB0aGUgc2VsZWN0IHBvcHVwLiAgSXQgbmVlZHMgdG8gYmUgY2xvc2VkLg0KKyAg ICAgICAgaGlkZVNlbGVjdFBvcHVwKCk7CisgICAgfQogCiAgICAgLy8gRGlzcGF0Y2ggdGhlIGNv bnRleHRtZW51IGV2ZW50IHJlZ2FyZGxlc3Mgb2YgaWYgdGhlIGNsaWNrIHdhcyBzd2FsbG93ZWQu CiAgICAgLy8gT24gV2luZG93cywgd2UgaGFuZGxlIGl0IG9uIG1vdXNlIHVwLCBub3QgZG93bi4K 54263 2010-04-26 00:11:57 -0700 2010-04-27 19:29:31 -0700 Fixing style select_click.patch text/plain 2271 jcivelli SW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cNCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1ODIzNSkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNCBAQAorMjAxMC0wNC0yNSAgSmF5 IENpdmVsbGkgIDxqY2l2ZWxsaUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkg Tk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZXMgY2xpY2tpbmcgYSBzZWxlY3QgZWxlbWVu dCBjbG9zZSBpdHMgYXNzb2NpYXRlZCBwb3B1cCBpZgorICAgICAgICBpdCBpcyBvcGVuLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgxMDUKKworICAg ICAgICAqIHNyYy9XZWJWaWV3SW1wbC5jcHA6CisgICAgICAgIChXZWJLaXQ6OldlYlZpZXdJbXBs Ojptb3VzZURvd24pOgorCiAyMDEwLTA0LTIzICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+ CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gRmlzaGVyLgpJbmRleDogV2ViS2l0L2Nocm9t aXVtL3NyYy9XZWJWaWV3SW1wbC5jcHANCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0NCi0tLSBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkocmV2aXNpb24gNTgyMTApCisrKyBXZWJLaXQvY2hyb21pdW0v c3JjL1dlYlZpZXdJbXBsLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMzI2LDkgKzMyNiwxMiBAQCB2 b2lkIFdlYlZpZXdJbXBsOjptb3VzZURvd24oY29uc3QgV2ViTW91CiAgICAgaWYgKCFtYWluRnJh bWVJbXBsKCkgfHwgIW1haW5GcmFtZUltcGwoKS0+ZnJhbWVWaWV3KCkpCiAgICAgICAgIHJldHVy bjsKIAotICAgIC8vIElmIHRoZXJlIGlzIGEgc2VsZWN0IHBvcHVwIG9wZW5lZCwgY2xvc2UgaXQg YXMgdGhlIHVzZXIgaXMgY2xpY2tpbmcgb24KLSAgICAvLyB0aGUgcGFnZSAob3V0c2lkZSBvZiB0 aGUgcG9wdXApLgorICAgIC8vIElmIHRoZXJlIGlzIGEgc2VsZWN0IHBvcHVwIG9wZW4sIGNsb3Nl IGl0IGFzIHRoZSB1c2VyIGlzIGNsaWNraW5nIG9uCisgICAgLy8gdGhlIHBhZ2UgKG91dHNpZGUg b2YgdGhlIHBvcHVwKS4gIFdlIGFsc28gc2F2ZSBpdCBzbyB3ZSBjYW4gcHJldmVudCBhCisgICAg Ly8gY2xpY2sgb24gdGhlIHNlbGVjdCBlbGVtZW50IGZyb20gaW1tZWRpYXRlbHkgcmVvcGVuaW5n IHRoZSBwb3B1cC4KKyAgICBSZWZQdHI8V2ViQ29yZTo6UG9wdXBDb250YWluZXI+IHNlbGVjdFBv cHVwID0gbV9zZWxlY3RQb3B1cDsKICAgICBoaWRlU2VsZWN0UG9wdXAoKTsKKyAgICBBU1NFUlQo IW1fc2VsZWN0UG9wdXApOwogCiAgICAgbV9sYXN0TW91c2VEb3duUG9pbnQgPSBXZWJQb2ludChl dmVudC54LCBldmVudC55KTsKICAgICBtX2hhdmVNb3VzZUNhcHR1cmUgPSB0cnVlOwpAQCAtMzYy LDYgKzM2NSwxMyBAQCB2b2lkIFdlYlZpZXdJbXBsOjptb3VzZURvd24oY29uc3QgV2ViTW91CiAg ICAgICAgIHN0YXRpY19jYXN0PEVkaXRvckNsaWVudEltcGwqPihtX3BhZ2UtPmVkaXRvckNsaWVu dCgpKS0+CiAgICAgICAgICAgICBzaG93Rm9ybUF1dG9maWxsRm9yTm9kZShjbGlja2VkTm9kZS5n ZXQoKSk7CiAgICAgfQorICAgIGlmIChtX3NlbGVjdFBvcHVwICYmIG1fc2VsZWN0UG9wdXAgPT0g c2VsZWN0UG9wdXApIHsKKyAgICAgICAgLy8gVGhhdCBjbGljayB0cmlnZ2VyZWQgYSBzZWxlY3Qg cG9wdXAgd2hpY2ggaXMgdGhlIHNhbWUgYXMgdGhlIG9uZSB0aGF0CisgICAgICAgIC8vIHdhcyBz aG93aW5nIGJlZm9yZSB0aGUgY2xpY2suICBJdCBtZWFucyB0aGUgdXNlciBjbGlja2VkIHRoZSBz ZWxlY3QKKyAgICAgICAgLy8gd2hpbGUgdGhlIHBvcHVwIHdhcyBzaG93aW5nLCBhbmQgYXMgYSBy ZXN1bHQgd2UgZmlyc3QgY2xvc2VkIHRoZW4KKyAgICAgICAgLy8gaW1tZWRpYXRlbHkgcmVvcGVu ZWQgdGhlIHNlbGVjdCBwb3B1cC4gIEl0IG5lZWRzIHRvIGJlIGNsb3NlZC4KKyAgICAgICAgaGlk ZVNlbGVjdFBvcHVwKCk7CisgICAgfQogCiAgICAgLy8gRGlzcGF0Y2ggdGhlIGNvbnRleHRtZW51 IGV2ZW50IHJlZ2FyZGxlc3Mgb2YgaWYgdGhlIGNsaWNrIHdhcyBzd2FsbG93ZWQuCiAgICAgLy8g T24gV2luZG93cywgd2UgaGFuZGxlIGl0IG9uIG1vdXNlIHVwLCBub3QgZG93bi4K