38091 2010-04-25 00:38:53 -0700 Build error without geolocation 2010-05-12 05:14:52 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 ojab webkit-unassigned bunhere commit-queue ht990332 laszlo.gombos nayankk oldest_to_newest 216798 0 ojab 2010-04-25 00:38:53 -0700 CXXLD libwebkit-1.0.la /bin/mkdir -p ./.deps/DerivedSources CC WebKitTools/GtkLauncher/Programs_GtkLauncher-main.o CCLD Programs/GtkLauncher ./.libs/libwebkit-1.0.so: undefined reference to `WebCore::Geolocation::clearWatch(int)' collect2: ld returned 1 exit status make[1]: *** [Programs/GtkLauncher] Error 1 make[1]: Leaving directory `/sources/WebKit/WebKitBuild/Release' make: *** [all] Error 2 216814 1 54237 bunhere 2010-04-25 06:04:03 -0700 Created attachment 54237 Fixing build break when Geolocation feature is disabled Can I fix this build break? I am newbie in webkit.org My modification is as below, Index: WebCore/page/Geolocation.cpp =================================================================== --- WebCore/page/Geolocation.cpp (revision 58227) +++ WebCore/page/Geolocation.cpp (working copy) @@ -659,6 +659,8 @@ void Geolocation::stopUpdating() namespace WebCore { +void Geolocation::clearWatch(int watchId) {} + I think clearWatch() should be added to #else of ENABLE(GEOLOCATION) in Geolocation.cpp Thank you, Ryuan Choi 217102 2 laszlo.gombos 2010-04-26 07:54:47 -0700 Some of these are addresses in bug 25756. At least for the QtWebKit port this change is not needed. Where is call site for clearWatch if ENABLE(GEOLOCATION) is turned of ? 217265 3 54237 eric 2010-04-26 14:06:26 -0700 Comment on attachment 54237 Fixing build break when Geolocation feature is disabled No new tests. (OOPS!) should be replaced with a statement as to why there are no tests. In this case, it's rather obvious, this is a build fix only. The "Reviewed by NOBODY (OOPS!)." line will automatically get updated by the commit-queue or webkit-patch or however this patch is landed. 217798 4 54433 bunhere 2010-04-27 11:11:15 -0700 Created attachment 54433 fix ChangeLog Thank you for answer, Eric. I fixed Changelog and I saw this build break in gtk port. 219952 5 54237 eric 2010-05-02 18:58:46 -0700 Comment on attachment 54237 Fixing build break when Geolocation feature is disabled Please obsolete your old patches when posting a new one. webkit-patch upload will automate the entire process of posting a patch for you. :) 220078 6 54922 bunhere 2010-05-03 06:36:40 -0700 Created attachment 54922 Patch 220080 7 bunhere 2010-05-03 06:46:31 -0700 hmm. sorry I missed --no-obsolete option and I had some issues about LANG. (I use ko_KR.UTF-8) anyway, Thank you for your kindness. 220162 8 54922 commit-queue 2010-05-03 10:24:39 -0700 Comment on attachment 54922 Patch Clearing flags on attachment: 54922 Committed r58682: <http://trac.webkit.org/changeset/58682> 220163 9 commit-queue 2010-05-03 10:24:44 -0700 All reviewed patches have been landed. Closing bug. 224539 10 nayankk 2010-05-12 05:14:52 -0700 *** Bug 38451 has been marked as a duplicate of this bug. *** 54237 2010-04-25 06:04:03 -0700 2010-05-02 18:58:45 -0700 Fixing build break when Geolocation feature is disabled FixingBuildBreak.patch text/plain 1039 bunhere SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODIyNykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjUgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBm aXhpbmcgYnVpbGQgYnJlYWsgZHVlIHRvIGNsZWFyV2F0Y2goKSB3aGVuIEdlb2xvY2F0aW9uIGZl YXR1cmUgaXMKKyAgICAgICAgZGlzYWJsZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDkxCisKKyAgICAgICAgTm8gbmV3IHRlc3RzLiAoT09Q UyEpCisKKyAgICAgICAgKiBwYWdlL0dlb2xvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 Okdlb2xvY2F0aW9uOjpjbGVhcldhdGNoKToKKwogMjAxMC0wNC0yNCAgU2ltb24gRnJhc2VyICA8 c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEYW4gQmVybnN0 ZWluLgpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNwcAo9PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBX ZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lvbiA1ODIyNykKKysrIFdlYkNvcmUv cGFnZS9HZW9sb2NhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTY1OSw2ICs2NTksOCBAQCB2 b2lkIEdlb2xvY2F0aW9uOjpzdG9wVXBkYXRpbmcoKQogCiBuYW1lc3BhY2UgV2ViQ29yZSB7CiAK K3ZvaWQgR2VvbG9jYXRpb246OmNsZWFyV2F0Y2goaW50IHdhdGNoSWQpIHt9CisKIHZvaWQgR2Vv bG9jYXRpb246OmRpc2Nvbm5lY3RGcmFtZSgpIHt9CiAKIEdlb2xvY2F0aW9uOjpHZW9sb2NhdGlv bihGcmFtZSopIHt9Cg== 54433 2010-04-27 11:11:15 -0700 2010-05-03 06:36:35 -0700 fix ChangeLog FixingBuildBreak.patch text/plain 1057 bunhere SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODMxMykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjcgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBm aXhpbmcgYnVpbGQgYnJlYWsgZHVlIHRvIGNsZWFyV2F0Y2goKSB3aGVuIEdlb2xvY2F0aW9uIGZl YXR1cmUgaXMKKyAgICAgICAgZGlzYWJsZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDkxCisKKyAgICAgICAgbm8gdGVzdCBiZWNhdXNlIHRo aXMgaXMgYSBidWlsZCBmaXggb25seQorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6Y2xlYXJXYXRjaCk6CisKIDIwMTAtMDQt MjcgIEpvc2VwaCBQZWNvcmFybyAgPGpvZXBlY2tAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYW4gQmVybnN0ZWluLgpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNw cAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lvbiA1 ODMxMykKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTY1OSw2ICs2NTksOCBAQCB2b2lkIEdlb2xvY2F0aW9uOjpzdG9wVXBkYXRpbmcoKQogCiBuYW1l c3BhY2UgV2ViQ29yZSB7CiAKK3ZvaWQgR2VvbG9jYXRpb246OmNsZWFyV2F0Y2goaW50IHdhdGNo SWQpIHt9CisKIHZvaWQgR2VvbG9jYXRpb246OmRpc2Nvbm5lY3RGcmFtZSgpIHt9CiAKIEdlb2xv Y2F0aW9uOjpHZW9sb2NhdGlvbihGcmFtZSopIHt9Cg== 54922 2010-05-03 06:36:40 -0700 2010-05-03 10:24:39 -0700 Patch bug-38091-20100503223638.patch text/plain 1071 bunhere SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODY3MCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDUtMDMgIFJ5dWFuIENob2kgIDxyeXVhbi5jaG9pQGdtYWls LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBm aXhpbmcgYnVpbGQgYnJlYWsgZHVlIHRvIGNsZWFyV2F0Y2goKSB3aGVuIEdlb2xvY2F0aW9uIGZl YXR1cmUgaXMKKyAgICAgICAgZGlzYWJsZWQuCisKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDkxCisKKyAgICAgICAgbm8gdGVzdCBiZWNhdXNlIHRo aXMgaXMgYSBidWlsZCBmaXggb25seQorCisgICAgICAgICogcGFnZS9HZW9sb2NhdGlvbi5jcHA6 CisgICAgICAgIChXZWJDb3JlOjpHZW9sb2NhdGlvbjo6Y2xlYXJXYXRjaCk6CisKIDIwMTAtMDUt MDMgIFRvciBBcm5lIFZlc3Riw7ggIDx0b3IuYXJuZS52ZXN0Ym9Abm9raWEuY29tPgogCiAgICAg ICAgIFtRdF0gRml4IGJ1aWxkIGJyZWFrIG9uIE1hYyBPUyBYCkluZGV4OiBXZWJDb3JlL3BhZ2Uv R2VvbG9jYXRpb24uY3BwCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5j cHAJKHJldmlzaW9uIDU4NjcwKQorKysgV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNwcAkod29y a2luZyBjb3B5KQpAQCAtNjU5LDYgKzY1OSw4IEBAIHZvaWQgR2VvbG9jYXRpb246OnN0b3BVcGRh dGluZygpCiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAordm9pZCBHZW9sb2NhdGlvbjo6Y2xlYXJX YXRjaChpbnQgd2F0Y2hJZCkge30KKwogdm9pZCBHZW9sb2NhdGlvbjo6ZGlzY29ubmVjdEZyYW1l KCkge30KIAogR2VvbG9jYXRpb246Okdlb2xvY2F0aW9uKEZyYW1lKikge30K