38086 2010-04-24 18:20:17 -0700 focus handling needs improving 2010-04-25 15:04:20 -0700 1 1 1 Unclassified WebKit WebKit wx 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 0 kevinwatters webkit-unassigned kevino oldest_to_newest 216769 0 54226 kevinwatters 2010-04-24 18:20:17 -0700 Created attachment 54226 improves focus handling The wx port need to use page->focusController methods in a few places it is not currently. 216853 1 kevino 2010-04-25 15:04:20 -0700 Landed in r58231, thanks! 54226 2010-04-24 18:20:17 -0700 2010-04-25 14:21:36 -0700 improves focus handling focus_fixes.patch text/plain 5014 kevinwatters SW5kZXg6IFdlYktpdC93eC9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L3d4L0NoYW5n ZUxvZwkocmV2aXNpb24gNTgyMDEpCisrKyBXZWJLaXQvd3gvQ2hhbmdlTG9nCSh3b3JraW5nIGNv cHkpCkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjMgIEtldmluIFdhdHRlcnMgIDxrZXZpbndh dHRlcnNAZ21haWwuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFVwZGF0ZSBmb2N1cyBoYW5kbGluZyBjb2RlIHRvIG1hdGNoIGN1cnJlbnQgYXBw cm9hY2hlcyB1c2VkIGJ5IG90aGVyIHBsYXRmb3JtcywKKyAgICAgICAgYW5kIGZpeCBmb2N1cyBo YW5kbGluZyBmb3IgY29ybmVyIGNhc2VzIHN1Y2ggYXMgd2hlbiBhIG1vdXNlIGRvd24gcG9wcyB1 cCBhIGRpYWxvZy4gCisKKyAgICAgICAgKiBXZWJWaWV3LmNwcDoKKyAgICAgICAgKHd4V2ViVmll dzo6Q3JlYXRlKToKKyAgICAgICAgKHd4V2ViVmlldzo6T25UTFdBY3RpdmF0ZWQpOgorICAgICAg ICAod3hXZWJWaWV3OjpPblBhaW50KToKKyAgICAgICAgKHd4V2ViVmlldzo6T25Nb3VzZUV2ZW50 cyk6CisgICAgICAgICh3eFdlYlZpZXc6Ok9uU2V0Rm9jdXMpOgorICAgICAgICAod3hXZWJWaWV3 OjpPbktpbGxGb2N1cyk6CisgICAgICAgICogV2ViVmlldy5oOgorCiAyMDEwLTA0LTIwICBBZGFt IEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRXJpYyBT ZWlkZWwuCkluZGV4OiBXZWJLaXQvd3gvV2ViVmlldy5jcHAKPT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0 L3d4L1dlYlZpZXcuY3BwCShyZXZpc2lvbiA1ODE5OSkKKysrIFdlYktpdC93eC9XZWJWaWV3LmNw cAkod29ya2luZyBjb3B5KQpAQCAtMzQwLDYgKzM0MCw5IEBACiAgICAgU2V0RGF0YWJhc2VzRW5h YmxlZCh0cnVlKTsKICNlbmRpZgogCisgICAgd3hXaW5kb3cqIHRsdyA9IHd4R2V0VG9wTGV2ZWxQ YXJlbnQodGhpcyk7CisgICAgdGx3LT5Db25uZWN0KC0xLCB3eEVWVF9BQ1RJVkFURSwgd3hBY3Rp dmF0ZUV2ZW50SGFuZGxlcih3eFdlYlZpZXc6Ok9uVExXQWN0aXZhdGVkKSk7CisKICAgICBtX2lz SW5pdGlhbGl6ZWQgPSB0cnVlOwogCiAgICAgcmV0dXJuIHRydWU7CkBAIC0zNTksNiArMzYyLDE1 IEBACiAgICAgbV9pbXBsLT5wYWdlID0gMDsgICAKIH0KIAordm9pZCB3eFdlYlZpZXc6Ok9uVExX QWN0aXZhdGVkKHd4QWN0aXZhdGVFdmVudCYgZXZlbnQpCit7ICAgICAgICAKKyAgICBpZiAobV9p bXBsICYmIG1faW1wbC0+cGFnZSAmJiBtX2ltcGwtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpKQor ICAgICAgICBtX2ltcGwtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5zZXRBY3RpdmUoZXZlbnQu R2V0QWN0aXZlKCkpOworICAgIAorICAgIGV2ZW50LlNraXAoKTsKKyAgICAKK30KKwogdm9pZCB3 eFdlYlZpZXc6OlN0b3AoKQogewogICAgIGlmIChtX21haW5GcmFtZSkKQEAgLTUyOCwxMyArNTQw LDYgQEAKICAgICBpZiAobV9iZWluZ0Rlc3Ryb3llZCB8fCAhbV9tYWluRnJhbWUpCiAgICAgICAg IHJldHVybjsKIAotICAgIC8vIFdlYlZpZXcgYWN0aXZlIHN0YXRlIGlzIGJhc2VkIG9uIFRMVyBh Y3RpdmUgc3RhdGUuCi0gICAgd3hUb3BMZXZlbFdpbmRvdyogdGx3ID0gZHluYW1pY19jYXN0PHd4 VG9wTGV2ZWxXaW5kb3cqPih3eEdldFRvcExldmVsUGFyZW50KHRoaXMpKTsKLSAgICBpZiAodGx3 ICYmIHRsdy0+SXNBY3RpdmUoKSkKLSAgICAgICAgbV9pbXBsLT5wYWdlLT5mb2N1c0NvbnRyb2xs ZXIoKS0+c2V0QWN0aXZlKHRydWUpOwotICAgIGVsc2UgewotICAgICAgICBtX2ltcGwtPnBhZ2Ut PmZvY3VzQ29udHJvbGxlcigpLT5zZXRBY3RpdmUoZmFsc2UpOwotICAgIH0KICAgICBXZWJDb3Jl OjpGcmFtZSogZnJhbWUgPSBtX21haW5GcmFtZS0+R2V0RnJhbWUoKTsKICAgICBpZiAoIWZyYW1l IHx8ICFmcmFtZS0+dmlldygpKQogICAgICAgICByZXR1cm47CkBAIC02MjAsNiArNjI1LDIxIEBA CiAgICAgICAgIHJldHVybjsKICAgICB9CiAgICAgCisgICAgLy8gSWYgYW4gZXZlbnQsIHN1Y2gg YXMgYSByaWdodC1jbGljayBldmVudCwgbGVhZHMgdG8gYSBmb2N1cyBjaGFuZ2UgKGUuZy4gaXQg CisgICAgLy8gcmFpc2VzIGEgZGlhbG9nKSwgV2ViS2l0IG5ldmVyIGdldHMgdGhlIG1vdXNlIHVw IGV2ZW50IGFuZCBuZXZlciByZWxpbnF1aXNoZXMgCisgICAgLy8gbW91c2UgY2FwdHVyZS4gVGhp cyBsZWFkcyB0byBXZWJLaXQgaGFuZGxpbmcgbW91c2UgZXZlbnRzLCBzdWNoIGFzIG1vZGlmeWlu ZworICAgIC8vIHRoZSBzZWxlY3Rpb24sIHdoaWxlIG90aGVyIGNvbnRyb2xzIG9yIHRvcCBsZXZl bCB3aW5kb3dzIGhhdmUgdGhlIGZvY3VzLgorICAgIC8vIEknbSBub3Qgc3VyZSBpZiB0aGlzIGlz IHRoZSByaWdodCBwbGFjZSB0byBoYW5kbGUgdGhpcywgYnV0IEkgY2FuJ3Qgc2VlbSB0bworICAg IC8vIGZpbmQgYSBwcmVjZWRlbnQgb24gaG93IHRvIGhhbmRsZSB0aGlzIGluIG90aGVyIHBvcnRz LgorICAgIGlmICh3eFdpbmRvdzo6RmluZEZvY3VzKCkgIT0gdGhpcykgeworICAgICAgICB3aGls ZSAoSGFzQ2FwdHVyZSgpKQorICAgICAgICAgICAgUmVsZWFzZU1vdXNlKCk7CisKKyAgICAgICAg ZnJhbWUtPmV2ZW50SGFuZGxlcigpLT5zZXRNb3VzZVByZXNzZWQoZmFsc2UpOworCisgICAgICAg IHJldHVybjsKKyAgICB9CisgICAgICAgIAogICAgIGludCBjbGlja0NvdW50ID0gZXZlbnQuQnV0 dG9uRENsaWNrKCkgPyAyIDogMTsKIAogICAgIGlmIChjbGlja0NvdW50ID09IDEgJiYgbV9pbXBs LT50cmlwbGVDbGlja1RpbWVyLklzUnVubmluZygpKSB7CkBAIC04ODIsMjYgKzkwMiwzNSBAQAog CiB2b2lkIHd4V2ViVmlldzo6T25TZXRGb2N1cyh3eEZvY3VzRXZlbnQmIGV2ZW50KQogewotICAg IFdlYkNvcmU6OkZyYW1lKiBmcmFtZSA9IDA7Ci0gICAgaWYgKG1fbWFpbkZyYW1lKQotICAgICAg ICBmcmFtZSA9IG1fbWFpbkZyYW1lLT5HZXRGcmFtZSgpOwotICAgICAgICAKLSAgICBpZiAoZnJh bWUpIHsKLSAgICAgICAgZnJhbWUtPnNlbGVjdGlvbigpLT5zZXRGb2N1c2VkKHRydWUpOworICAg IGlmIChtX2ltcGwgJiYgbV9pbXBsLT5wYWdlICYmIG1faW1wbC0+cGFnZS0+Zm9jdXNDb250cm9s bGVyKCkpIHsKKyAgICAgICAgbV9pbXBsLT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9j dXNlZCh0cnVlKTsKKyAgICAgICAgbV9pbXBsLT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0 QWN0aXZlKHRydWUpOworCisgICAgICAgIGlmICghbV9pbXBsLT5wYWdlLT5mb2N1c0NvbnRyb2xs ZXIoKS0+Zm9jdXNlZEZyYW1lKCkgJiYgbV9tYWluRnJhbWUpCisgICAgICAgICAgICBtX2ltcGwt PnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5zZXRGb2N1c2VkRnJhbWUobV9tYWluRnJhbWUtPkdl dEZyYW1lKCkpOwogICAgIH0KLQorICAgIAogICAgIGV2ZW50LlNraXAoKTsKIH0KIAogdm9pZCB3 eFdlYlZpZXc6Ok9uS2lsbEZvY3VzKHd4Rm9jdXNFdmVudCYgZXZlbnQpCiB7Ci0gICAgV2ViQ29y ZTo6RnJhbWUqIGZyYW1lID0gMDsKLSAgICBpZiAobV9tYWluRnJhbWUpCi0gICAgICAgIGZyYW1l ID0gbV9tYWluRnJhbWUtPkdldEZyYW1lKCk7Ci0gICAgICAgIAotICAgIGlmIChmcmFtZSkgewot ICAgICAgICBmcmFtZS0+c2VsZWN0aW9uKCktPnNldEZvY3VzZWQoZmFsc2UpOworICAgIGlmICht X2ltcGwgJiYgbV9pbXBsLT5wYWdlICYmIG1faW1wbC0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCkp IHsKKyAgICAgICAgbV9pbXBsLT5wYWdlLT5mb2N1c0NvbnRyb2xsZXIoKS0+c2V0Rm9jdXNlZChm YWxzZSk7CisKKyAgICAgICAgLy8gV2UgYWxzbyBoYW5kbGUgYWN0aXZlIHN0YXRlIGluIE9uVExX QWN0aXZhdGVkLCBidXQgaWYgYSB1c2VyIGRvZXMgbm90CisgICAgICAgIC8vIGNhbGwgZXZlbnQu U2tpcCgpIGluIHRoZWlyIG93biBFVlRfQUNUSVZBVEUgaGFuZGxlciwgd2Ugd29uJ3QgZ2V0IHRo b3NlCisgICAgICAgIC8vIGNhbGxiYWNrcy4gU28gd2UgaGFuZGxlIGFjdGl2ZSBzdGF0ZSBoZXJl IGFzIHdlbGwgYXMgYSBmYWxsYmFjay4KKyAgICAgICAgd3hUb3BMZXZlbFdpbmRvdyogdGx3ID0g ZHluYW1pY19jYXN0PHd4VG9wTGV2ZWxXaW5kb3cqPih3eEdldFRvcExldmVsUGFyZW50KHRoaXMp KTsKKyAgICAgICAgaWYgKHRsdyAmJiB0bHctPklzQWN0aXZlKCkpCisgICAgICAgICAgICBtX2lt cGwtPnBhZ2UtPmZvY3VzQ29udHJvbGxlcigpLT5zZXRBY3RpdmUodHJ1ZSk7CisgICAgICAgIGVs c2UKKyAgICAgICAgICAgIG1faW1wbC0+cGFnZS0+Zm9jdXNDb250cm9sbGVyKCktPnNldEFjdGl2 ZShmYWxzZSk7CiAgICAgfQorICAgIAorICAgIHdoaWxlIChIYXNDYXB0dXJlKCkpCisgICAgICAg IFJlbGVhc2VNb3VzZSgpOworICAgIAogICAgIGV2ZW50LlNraXAoKTsKIH0KIApJbmRleDogV2Vi S2l0L3d4L1dlYlZpZXcuaAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvd3gvV2ViVmlldy5oCShyZXZp c2lvbiA1ODE5OSkKKysrIFdlYktpdC93eC9XZWJWaWV3LmgJKHdvcmtpbmcgY29weSkKQEAgLTIy Niw2ICsyMjYsNyBAQAogICAgIHZvaWQgT25LZXlFdmVudHMod3hLZXlFdmVudCYgZXZlbnQpOwog ICAgIHZvaWQgT25TZXRGb2N1cyh3eEZvY3VzRXZlbnQmIGV2ZW50KTsKICAgICB2b2lkIE9uS2ls bEZvY3VzKHd4Rm9jdXNFdmVudCYgZXZlbnQpOworICAgIHZvaWQgT25UTFdBY3RpdmF0ZWQod3hB Y3RpdmF0ZUV2ZW50JiBldmVudCk7CiAgICAgCiBwcml2YXRlOgogICAgIC8vIGFueSBjbGFzcyB3 aXNoaW5nIHRvIHByb2Nlc3Mgd3hXaW5kb3dzIGV2ZW50cyBtdXN0IHVzZSB0aGlzIG1hY3JvCg==