38076 2010-04-23 18:53:34 -0700 [Qt] GraphicsLayer: flicker when starting an animation before the previous one ended. 2010-04-30 00:04:57 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) PC All CLOSED FIXED Qt P2 Normal --- 38071 1 noam webkit-unassigned commit-queue hausmann oldest_to_newest 216666 0 noam 2010-04-23 18:53:34 -0700 See bug 38071 for test case - click on the animated item frequently. 216728 1 54219 noam 2010-04-24 09:28:28 -0700 Created attachment 54219 Fix flicker in end of animation 218866 2 54219 commit-queue 2010-04-29 00:15:24 -0700 Comment on attachment 54219 Fix flicker in end of animation Clearing flags on attachment: 54219 Committed r58480: <http://trac.webkit.org/changeset/58480> 218867 3 commit-queue 2010-04-29 00:15:30 -0700 All reviewed patches have been landed. Closing bug. 219386 4 hausmann 2010-04-30 00:04:46 -0700 Revision r58480 cherry-picked into qtwebkit-2.0 with commit 540ae4ccd25609e1bfe1673195ce126255e36774 54219 2010-04-24 09:28:28 -0700 2010-04-29 00:15:24 -0700 Fix flicker in end of animation patch-38076-1.diff text/plain 4973 noam ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg Njg1MzNkZi4uZTM3OTg4MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTIsNiArMiwzMCBAQAogCiAgICAgICAgIFJldmlld2VkIGJ5IE5P Qk9EWSAoT09QUyEpLgogCisgICAgICAgIFtRdF0gR3JhcGhpY3NMYXllcjogZmxpY2tlciB3aGVu IHN0YXJ0aW5nIGFuIGFuaW1hdGlvbiBiZWZvcmUgdGhlIHByZXZpb3VzIG9uZSBlbmRlZC4KKyAg ICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDc2CisKKyAg ICAgICAgVGhpcyB3YXMgZHVlIHRvIHRoZSBjdWRlIGluIHRoZSByZW1vdmVBbmltYXRpb25zIGZ1 bmN0aW9ucywgd2hpY2ggY2FsbGVkIGRlbGV0ZUxhdGVyKCkgd2l0aG91dCBzdG9wcGluZyB0aGUK KyAgICAgICAgYW5pbWF0aW9uIHN5bmNocm9ub3VzbHkuIFRoZSBkZWxheSBiZXR3ZWVuIHRoZSBj YWxsIHRvIHRoYXQgZnVuY3Rpb24gYW5kIHRoZSBhY3R1YWwgY2FsbCB0byB0aGUgYW5pbWF0aW9u J3MgZGVzdHJ1Y3RvcgorICAgICAgICBpcyB3aGVuIHRoZSBmbGlja2VyIG9jY3VyZWQuIFdlIGZp eCB0aGlzIGJ5IGNhbGxpbmcgc3RvcCgpIHN5bmNocm9ub3VzbHksIGFuZCBtYWtpbmcgc3VyZSB0 aGF0IHRoZSB2YWx1ZSBpcyByZXZlcnRlZAorICAgICAgICB1cG9uIHN0b3AgKHVwZGF0ZVN0YXRl KSBhbmQgbm90IHVwb24gdGhlIG9iamVjdCdzIGRlc3RydWN0aW9uLgorCisgICAgICAgIGh0dHA6 Ly9zdGFmZi53YXNoaW5ndG9uLmVkdS9mbWYvMjAwOS8wMy8yNS9pcGhvbmUtM2QtY3NzLXRyYW5z Zm9ybWF0aW9ucy8gbm93IGRvZXNuJ3QgZmxpY2tlciB3aGVuCisgICAgICAgIHRoZSBhbmltYXRp b24gaXMgdG9nZ2xlZCBmcmVxdWVudGx5LgorCisgICAgICAgICogcGxhdGZvcm0vZ3JhcGhpY3Mv cXQvR3JhcGhpY3NMYXllclF0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OlRyYW5zZm9ybUFuaW1h dGlvblF0Ojp+VHJhbnNmb3JtQW5pbWF0aW9uUXQpOgorICAgICAgICAoV2ViQ29yZTo6VHJhbnNm b3JtQW5pbWF0aW9uUXQ6OmFwcGx5RnJhbWUpOgorICAgICAgICAoV2ViQ29yZTo6VHJhbnNmb3Jt QW5pbWF0aW9uUXQ6OnVwZGF0ZVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6Ok9wYWNpdHlBbmlt YXRpb25RdDo6fk9wYWNpdHlBbmltYXRpb25RdCk6CisgICAgICAgIChXZWJDb3JlOjpPcGFjaXR5 QW5pbWF0aW9uUXQ6OnVwZGF0ZVN0YXRlKToKKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzTGF5 ZXJRdDo6cmVtb3ZlQW5pbWF0aW9uc0ZvclByb3BlcnR5KToKKyAgICAgICAgKFdlYkNvcmU6Okdy YXBoaWNzTGF5ZXJRdDo6cmVtb3ZlQW5pbWF0aW9uc0ZvcktleWZyYW1lcyk6CisKKzIwMTAtMDQt MjQgIE5vYW0gUm9zZW50aGFsICA8bm9hbS5yb3NlbnRoYWxAbm9raWEuY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCiAgICAgICAgIFJldmVyc2UgYW5pbWF0aW9u cyBkb24ndCB3b3JrIGluIHNvbWUgdXNlIGNhc2VzICAgICAgICAKICAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDc1CiAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcGxhdGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcCBiL1dlYkNvcmUvcGxh dGZvcm0vZ3JhcGhpY3MvcXQvR3JhcGhpY3NMYXllclF0LmNwcAppbmRleCA3NTVlMjQxLi43YzVm MTQ5IDEwMDY0NAotLS0gYS9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0dyYXBoaWNzTGF5 ZXJRdC5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9xdC9HcmFwaGljc0xheWVy UXQuY3BwCkBAIC0xMTQ1LDggKzExNDUsNiBAQCBwdWJsaWM6CiAgICAgewogICAgICAgICBpZiAo bV9maWxsc0ZvcndhcmRzKQogICAgICAgICAgICAgc2V0Q3VycmVudFRpbWUoMSk7Ci0gICAgICAg IGVsc2UgaWYgKG1fbGF5ZXIgJiYgbV9sYXllci5kYXRhKCktPm1fbGF5ZXIpCi0gICAgICAgICAg ICBtX2xheWVyLmRhdGEoKS0+c2V0QmFzZVRyYW5zZm9ybShtX2xheWVyLmRhdGEoKS0+bV9sYXll ci0+dHJhbnNmb3JtKCkpOwogICAgIH0KIAogICAgIC8vIHRoZSBpZGVhIGlzIHRoYXQgd2UgbGV0 IFdlYkNvcmUgbWFuYWdlIHRoZSB0cmFuc2Zvcm0tb3BlcmF0aW9ucwpAQCAtMTE3NSw2ICsxMTcz LDcgQEAgcHVibGljOgogICAgICAgICAgICAgdGFyZ2V0T3BlcmF0aW9ucy5hcHBseShtX2JveFNp emUsIHRyYW5zZm9ybU1hdHJpeCk7CiAgICAgICAgICAgICB0cmFuc2Zvcm1NYXRyaXguYmxlbmQo bV9zb3VyY2VNYXRyaXgsIHByb2dyZXNzKTsKICAgICAgICAgfQorCiAgICAgICAgIG1fbGF5ZXIu ZGF0YSgpLT5zZXRCYXNlVHJhbnNmb3JtKHRyYW5zZm9ybU1hdHJpeCk7CiAgICAgICAgIGlmICht X2ZpbGxzRm9yd2FyZHMpCiAgICAgICAgICAgICBtX2xheWVyLmRhdGEoKS0+bV9sYXllci0+c2V0 VHJhbnNmb3JtKG1fbGF5ZXIuZGF0YSgpLT5tX2Jhc2VUcmFuc2Zvcm0pOwpAQCAtMTE5Myw3ICsx MTkyLDEwIEBAIHB1YmxpYzoKICAgICAgICAgICAgIG1fc291cmNlTWF0cml4ID0gbV9sYXllci5k YXRhKCktPm1fbGF5ZXItPnRyYW5zZm9ybSgpOwogICAgICAgICAgICAgbV9sYXllci5kYXRhKCkt Pm1fdHJhbnNmb3JtQW5pbWF0aW9uUnVubmluZyA9IHRydWU7CiAgICAgICAgIH0gZWxzZSBpZiAo bmV3U3RhdGUgPT0gUUFic3RyYWN0QW5pbWF0aW9uOjpTdG9wcGVkKSB7CisgICAgICAgICAgICAv LyBXZSB1cGRhdGUgdGhlIHRyYW5zZm9ybSBiYWNrIHRvIHRoZSBkZWZhdWx0LiBUaGlzIGFscmVh ZHkgdGFrZXMgZmlsbC1tb2RlcyBpbnRvIGFjY291bnQuCiAgICAgICAgICAgICBtX2xheWVyLmRh dGEoKS0+bV90cmFuc2Zvcm1BbmltYXRpb25SdW5uaW5nID0gZmFsc2U7CisgICAgICAgICAgICBp ZiAobV9sYXllciAmJiBtX2xheWVyLmRhdGEoKS0+bV9sYXllcikKKyAgICAgICAgICAgICAgICBt X2xheWVyLmRhdGEoKS0+c2V0QmFzZVRyYW5zZm9ybShtX2xheWVyLmRhdGEoKS0+bV9sYXllci0+ dHJhbnNmb3JtKCkpOwogICAgICAgICB9CiAgICAgfQogCkBAIC0xMjExLDggKzEyMTMsNiBAQCBw dWJsaWM6CiAgICAgewogICAgICAgICBpZiAobV9maWxsc0ZvcndhcmRzKQogICAgICAgICAgICAg c2V0Q3VycmVudFRpbWUoMSk7Ci0gICAgICAgIGVsc2UgaWYgKG1fbGF5ZXIgJiYgbV9sYXllci5k YXRhKCktPm1fbGF5ZXIpCi0gICAgICAgICAgICBtX2xheWVyLmRhdGEoKS0+c2V0T3BhY2l0eSht X2xheWVyLmRhdGEoKS0+bV9sYXllci0+b3BhY2l0eSgpKTsKICAgICB9CiAgICAgdmlydHVhbCB2 b2lkIGFwcGx5RnJhbWUoY29uc3QgcXJlYWwmIGZyb21WYWx1ZSwgY29uc3QgcXJlYWwmIHRvVmFs dWUsIHFyZWFsIHByb2dyZXNzKQogICAgIHsKQEAgLTEyMzQsNiArMTIzNCwxMiBAQCBwdWJsaWM6 CiAKICAgICAgICAgaWYgKG1fbGF5ZXIpCiAgICAgICAgICAgICBtX2xheWVyLmRhdGEoKS0+bV9v cGFjaXR5QW5pbWF0aW9uUnVubmluZyA9IChuZXdTdGF0ZSA9PSBRQWJzdHJhY3RBbmltYXRpb246 OlJ1bm5pbmcpOworCisgICAgICAgIC8vIElmIHN0b3BwZWQsIHdlIHVwZGF0ZSB0aGUgb3BhY2l0 eSBiYWNrIHRvIHRoZSBkZWZhdWx0LiBUaGlzIGFscmVhZHkgdGFrZXMgZmlsbC1tb2RlcyBpbnRv IGFjY291bnQuCisgICAgICAgIGlmIChuZXdTdGF0ZSA9PSBTdG9wcGVkKQorICAgICAgICAgICAg aWYgKG1fbGF5ZXIgJiYgbV9sYXllci5kYXRhKCktPm1fbGF5ZXIpCisgICAgICAgICAgICAgICAg bV9sYXllci5kYXRhKCktPnNldE9wYWNpdHkobV9sYXllci5kYXRhKCktPm1fbGF5ZXItPm9wYWNp dHkoKSk7CisKICAgICB9CiB9OwogCkBAIC0xMjk5LDYgKzEzMDUsOCBAQCB2b2lkIEdyYXBoaWNz TGF5ZXJRdDo6cmVtb3ZlQW5pbWF0aW9uc0ZvclByb3BlcnR5KEFuaW1hdGVkUHJvcGVydHlJRCBp ZCkKICAgICAgICAgaWYgKCppdCkgewogICAgICAgICAgICAgQW5pbWF0aW9uUXRCYXNlKiBhbmlt ID0gc3RhdGljX2Nhc3Q8QW5pbWF0aW9uUXRCYXNlKj4oaXQtPmRhdGEoKSk7CiAgICAgICAgICAg ICBpZiAoYW5pbSAmJiBhbmltLT5tX3dlYmtpdFByb3BlcnR5SUQgPT0gaWQpIHsKKyAgICAgICAg ICAgICAgICAvLyBXZSBuZWVkIHRvIHN0b3AgdGhlIGFuaW1hdGlvbiByaWdodCBhd2F5LCBvciBp dCBtaWdodCBmbGlja2VyIGJlZm9yZSBpdCdzIGRlbGV0ZWQuCisgICAgICAgICAgICAgICAgYW5p bS0+c3RvcCgpOwogICAgICAgICAgICAgICAgIGFuaW0tPmRlbGV0ZUxhdGVyKCk7CiAgICAgICAg ICAgICAgICAgaXQgPSBtX2ltcGwtPm1fYW5pbWF0aW9ucy5lcmFzZShpdCk7CiAgICAgICAgICAg ICAgICAgLS1pdDsKQEAgLTEzMTMsNyArMTMyMSw5IEBAIHZvaWQgR3JhcGhpY3NMYXllclF0Ojpy ZW1vdmVBbmltYXRpb25zRm9yS2V5ZnJhbWVzKGNvbnN0IFN0cmluZyYgbmFtZSkKICAgICAgICAg aWYgKCppdCkgewogICAgICAgICAgICAgQW5pbWF0aW9uUXRCYXNlKiBhbmltID0gc3RhdGljX2Nh c3Q8QW5pbWF0aW9uUXRCYXNlKj4oKCppdCkuZGF0YSgpKTsKICAgICAgICAgICAgIGlmIChhbmlt ICYmIGFuaW0tPm1fa2V5ZnJhbWVzTmFtZSA9PSBRU3RyaW5nKG5hbWUpKSB7Ci0gICAgICAgICAg ICAgICAgKCppdCkuZGF0YSgpLT5kZWxldGVMYXRlcigpOworICAgICAgICAgICAgICAgIC8vIFdl IG5lZWQgdG8gc3RvcCB0aGUgYW5pbWF0aW9uIHJpZ2h0IGF3YXksIG9yIGl0IG1pZ2h0IGZsaWNr ZXIgYmVmb3JlIGl0J3MgZGVsZXRlZC4KKyAgICAgICAgICAgICAgICBhbmltLT5zdG9wKCk7Cisg ICAgICAgICAgICAgICAgYW5pbS0+ZGVsZXRlTGF0ZXIoKTsKICAgICAgICAgICAgICAgICBpdCA9 IG1faW1wbC0+bV9hbmltYXRpb25zLmVyYXNlKGl0KTsKICAgICAgICAgICAgICAgICAtLWl0Owog ICAgICAgICAgICAgfQo=