38073 2010-04-23 18:37:00 -0700 Clean up a few compiler warnings seen on Chromium Windows 2010-12-23 15:22:05 -0800 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 jamesr jamesr aroben bweinstein darin eric evan levin sfalken oldest_to_newest 216660 0 jamesr 2010-04-23 18:37:00 -0700 Clean up a few compiler warnings 216662 1 54208 jamesr 2010-04-23 18:38:52 -0700 Created attachment 54208 Patch 216727 2 54208 darin 2010-04-24 09:27:44 -0700 Comment on attachment 54208 Patch What compiler generates these warnings? 216729 3 54208 darin 2010-04-24 09:28:34 -0700 Comment on attachment 54208 Patch > class StyleReflection; > class StyleTransformData; > struct ContentData; > -struct ShadowData; > +class ShadowData; This should be re-sorted above with the class forward declarations. And the struct forward declarations should be in a separate paragraph (blank line between the paragraphs). 216730 4 54208 darin 2010-04-24 09:29:27 -0700 Comment on attachment 54208 Patch > - unsigned width() const { return m_width; } > + unsigned width() const { return static_cast<unsigned>(m_width); } > void setWidth(float w) { m_width = w; } This worries me; not the type cast, but the existing code. Why is it OK to convert the width into an unsigned? 217275 5 54330 jamesr 2010-04-26 14:21:12 -0700 Created attachment 54330 Patch 217276 6 jamesr 2010-04-26 14:22:04 -0700 The warnings are from MSVC, but they are all fairly general. I agree that the TextMetrics rounding looks weird, but I'm not familiar enough with this code to guess whether or not it's an issue. 217296 7 darin 2010-04-26 14:48:20 -0700 (In reply to comment #6) > The warnings are from MSVC Good to know. Are these particular MSVC warnings off for the Windows build (the one Apple uses for Windows Safari)? Should we turn them on? > but they are all fairly general. I don't know what that means. > I agree that the > TextMetrics rounding looks weird, but I'm not familiar enough with this code to > guess whether or not it's an issue. Generally I think it’s not good to silence a warning if the warning may be pointed to a real problem. I am familiar enough to know that it might be an issue. 217361 8 54330 eric 2010-04-26 16:53:07 -0700 Comment on attachment 54330 Patch I recommend posting and landing the uncontentious fixes first, and then asking mitz about what's up with the width() code. 217435 9 54370 jamesr 2010-04-26 19:09:55 -0700 Created attachment 54370 Patch 217436 10 jamesr 2010-04-26 19:10:53 -0700 I like Eric's idea, this patch does that. It adds a FIXME instead of the cast. 217712 11 darin 2010-04-27 08:22:33 -0700 (In reply to comment #7) > Are these particular MSVC warnings off for the Windows build (the one Apple > uses for Windows Safari)? Should we turn them on? I'm still waiting for the answer to this question. 218036 12 jamesr 2010-04-27 16:34:51 -0700 I should have clarified that these are warnings seen in the Chromium Windows build using those warning settings. I don't know which warnings the Safari Win port suppresses and do not have access to a Safari Win build environment to check. I think those decisions will have to be made by the Safari Win port maintainers. That said, I think it's reasonable that shared code not generate warnings for any port unless there's a good reason to (which there does not seem to be in this case). 218104 13 levin 2010-04-27 17:58:43 -0700 s/Safari/WebKit/ (In reply to comment #12) > I should have clarified that these are warnings seen in the Chromium Windows > build using those warning settings. I don't know which warnings the Safari Win > port suppresses and do not have access to a Safari Win build environment to > check. Here ya go: http://webkit.org/building/checkout.html > I think those decisions will have to be made by the Safari Win port > maintainers. I bet folks would be ok with the warnings being turned on as long as it doesn't break the build. If in doubt, you could send email to webkit-dev asking for objections. By turning on the warning, you will help make sure that more people are concerned about them as well. 219954 14 54370 eric 2010-05-02 19:01:31 -0700 Comment on attachment 54370 Patch LGTM. 219955 15 eric 2010-05-02 19:03:20 -0700 Adam, Steve, and Brian are a few of the windows guys. If you post a patch to WebCore.vcproj enabling the warnings, I expect they'd be happy to review. 219991 16 eric 2010-05-02 19:32:06 -0700 Attachment 54370 was posted by a committer and has review+, assigning to James Robinson for commit. 220372 17 54370 jamesr 2010-05-03 17:04:15 -0700 Comment on attachment 54370 Patch Clearing flags on attachment: 54370 Committed r58718: <http://trac.webkit.org/changeset/58718> 220373 18 jamesr 2010-05-03 17:04:23 -0700 All reviewed patches have been landed. Closing bug. 326317 19 evan 2010-12-23 15:22:05 -0800 I filed bug 51566 for the discussion of the mysterious truncator unsigned width() from comments #4, #7, #8, #9. 54208 2010-04-23 18:38:52 -0700 2010-04-26 14:21:09 -0700 Patch bug-38073-20100423183851.patch text/plain 3173 jamesr ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCAxMmFiOWQ1Li4wMjJiNGNlIDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29y ZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMg QEAKKzIwMTAtMDQtMjMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCBh IGZldyBjb21waWxlciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9z aG93X2J1Zy5jZ2k/aWQ9MzgwNzMKKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmluZ0ltcGwuY3Bw OgorICAgICAgICAoV2ViQ29yZTo6U3RyaW5nSW1wbDo6YXNjaWkpOgorCiAyMDEwLTA0LTIyICBT aGVyaWZmIEJvdCAgPHdlYmtpdC5yZXZpZXcuYm90QGdtYWlsLmNvbT4KIAogICAgICAgICBVbnJl dmlld2VkLCByb2xsaW5nIG91dCByNTgxMTAuCmRpZmYgLS1naXQgYS9KYXZhU2NyaXB0Q29yZS93 dGYvdGV4dC9TdHJpbmdJbXBsLmNwcCBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0cmluZ0lt cGwuY3BwCmluZGV4IDJjNTVkOGUuLmQ1OTAyYWUgMTAwNjQ0Ci0tLSBhL0phdmFTY3JpcHRDb3Jl L3d0Zi90ZXh0L1N0cmluZ0ltcGwuY3BwCisrKyBiL0phdmFTY3JpcHRDb3JlL3d0Zi90ZXh0L1N0 cmluZ0ltcGwuY3BwCkBAIC04ODAsNyArODgwLDcgQEAgVmVjdG9yPGNoYXI+IFN0cmluZ0ltcGw6 OmFzY2lpKCkKICAgICBmb3IgKHVuc2lnbmVkIGkgPSAwOyBpICE9IG1fbGVuZ3RoOyArK2kpIHsK ICAgICAgICAgVUNoYXIgYyA9IG1fZGF0YVtpXTsKICAgICAgICAgaWYgKChjID49IDB4MjAgJiYg YyA8IDB4N0YpIHx8IGMgPT0gMHgwMCkKLSAgICAgICAgICAgIGJ1ZmZlcltpXSA9IGM7CisgICAg ICAgICAgICBidWZmZXJbaV0gPSBzdGF0aWNfY2FzdDxjaGFyPihjKTsKICAgICAgICAgZWxzZQog ICAgICAgICAgICAgYnVmZmVyW2ldID0gJz8nOwogICAgIH0KZGlmZiAtLWdpdCBhL1dlYkNvcmUv Q2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZTI0NjM0Yi4uZGM0MDgyOSAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEs MyArMSwxNSBAQAorMjAxMC0wNC0yMyAgSmFtZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENs ZWFuIHVwIGEgZmV3IGNvbXBpbGVyIHdhcm5pbmdzCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJr aXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODA3MworCisgICAgICAgICogaHRtbC9UZXh0TWV0cmlj cy5oOgorICAgICAgICAoV2ViQ29yZTo6VGV4dE1ldHJpY3M6OndpZHRoKToKKyAgICAgICAgKiBy ZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0YS5oOgorICAgICAgICAqIHJlbmRl cmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmg6CisKIDIwMTAtMDQtMjIgIERh dmUgTW9vcmUgIDxkYXZlbW9vcmVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERpbWl0cmkgR2xhemtvdi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9UZXh0TWV0cmljcy5o IGIvV2ViQ29yZS9odG1sL1RleHRNZXRyaWNzLmgKaW5kZXggMzRhMzM3OC4uZDhjZmNhMiAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9odG1sL1RleHRNZXRyaWNzLmgKKysrIGIvV2ViQ29yZS9odG1sL1Rl eHRNZXRyaWNzLmgKQEAgLTM0LDcgKzM0LDcgQEAgY2xhc3MgVGV4dE1ldHJpY3MgOiBwdWJsaWMg UmVmQ291bnRlZDxUZXh0TWV0cmljcz4gewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRy PFRleHRNZXRyaWNzPiBjcmVhdGUoKSB7IHJldHVybiBhZG9wdFJlZihuZXcgVGV4dE1ldHJpY3Mp OyB9CiAKLSAgICB1bnNpZ25lZCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fd2lkdGg7IH0KKyAg ICB1bnNpZ25lZCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPiht X3dpZHRoKTsgfQogICAgIHZvaWQgc2V0V2lkdGgoZmxvYXQgdykgeyBtX3dpZHRoID0gdzsgfQog CiBwcml2YXRlOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJl SW5oZXJpdGVkRGF0YS5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJp dGVkRGF0YS5oCmluZGV4IDJlODdlNmIuLmY5MWI5MGYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaAorKysgYi9XZWJDb3JlL3JlbmRl cmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmgKQEAgLTMyLDcgKzMyLDcgQEAKIAog bmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdHJ1Y3QgU2hhZG93RGF0YTsKK2NsYXNzIFNoYWRvd0Rh dGE7CiAKIC8vIFRoaXMgc3RydWN0IGlzIGZvciByYXJlbHkgdXNlZCBpbmhlcml0ZWQgQ1NTMywg Q1NTMiwgYW5kIFdlYktpdC1zcGVjaWZpYyBwcm9wZXJ0aWVzLgogLy8gQnkgZ3JvdXBpbmcgdGhl bSB0b2dldGhlciwgd2Ugc2F2ZSBzcGFjZSwgYW5kIG9ubHkgYWxsb2NhdGUgdGhpcyBvYmplY3Qg d2hlbiBzb21lb25lCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJh cmVOb25Jbmhlcml0ZWREYXRhLmggYi9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJhcmVO b25Jbmhlcml0ZWREYXRhLmgKaW5kZXggNDUyYjI3My4uZTc4YzJmOSAxMDA2NDQKLS0tIGEvV2Vi Q29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oCisrKyBiL1dl YkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaApAQCAtNDYs NyArNDYsNyBAQCBjbGFzcyBTdHlsZU11bHRpQ29sRGF0YTsKIGNsYXNzIFN0eWxlUmVmbGVjdGlv bjsKIGNsYXNzIFN0eWxlVHJhbnNmb3JtRGF0YTsKIHN0cnVjdCBDb250ZW50RGF0YTsKLXN0cnVj dCBTaGFkb3dEYXRhOworY2xhc3MgU2hhZG93RGF0YTsKIAogI2lmIEVOQUJMRShEQVNIQk9BUkRf U1VQUE9SVCkKIGNsYXNzIFN0eWxlRGFzaGJvYXJkUmVnaW9uOwo= 54330 2010-04-26 14:21:12 -0700 2010-04-26 19:09:52 -0700 Patch bug-38073-20100426142111.patch text/plain 3712 jamesr ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3ZjkxYmQ5NTNlNWJhNTM5Njk1NjA5OWU2ZjhjN2M4ZDVjZTFhYjIzLi4w MWVjYzIwNWZmZjNhNTg2NjAxMzM2NTExZDhjYmZkYTRkYWZmMDJjIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDQtMjMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD bGVhbiB1cCBhIGZldyBjb21waWxlciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwNzMKKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmlu Z0ltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RyaW5nSW1wbDo6YXNjaWkpOgorCiAyMDEw LTA0LTI2ICBKZWRyemVqIE5vd2Fja2kgIDxqZWRyemVqLm5vd2Fja2lAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAgYi9KYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCAyYzU1ZDhlOTI1MzMwOTlmZTZhNDE2YzQ3 MGFkY2UzNzBmYmMzODEwLi5kNTkwMmFlMWNlNmI4OTRjOTQ4OWMzMTNlYjdiZjFmYjI4MjU4M2Q0 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAorKysg Yi9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcApAQCAtODgwLDcgKzg4MCw3 IEBAIFZlY3RvcjxjaGFyPiBTdHJpbmdJbXBsOjphc2NpaSgpCiAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSAhPSBtX2xlbmd0aDsgKytpKSB7CiAgICAgICAgIFVDaGFyIGMgPSBtX2RhdGFbaV07 CiAgICAgICAgIGlmICgoYyA+PSAweDIwICYmIGMgPCAweDdGKSB8fCBjID09IDB4MDApCi0gICAg ICAgICAgICBidWZmZXJbaV0gPSBjOworICAgICAgICAgICAgYnVmZmVyW2ldID0gc3RhdGljX2Nh c3Q8Y2hhcj4oYyk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGJ1ZmZlcltpXSA9ICc/JzsK ICAgICB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGU2NGMxYmFhM2FkNmE4MTM3NjBjY2ZiZDU4MDc3ZjA4Y2JiMjExYWEuLjgxMDJhZTFi OGE3ODA2OTA2NzgxNTVmMWRmNDQ0Yjg1OWNmM2ZkMjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MjMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCBhIGZldyBjb21waWxl ciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzgwNzMKKworICAgICAgICAqIGh0bWwvVGV4dE1ldHJpY3MuaDoKKyAgICAgICAgKFdlYkNv cmU6OlRleHRNZXRyaWNzOjp3aWR0aCk6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxl UmFyZUluaGVyaXRlZERhdGEuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YS5oOgorCiAyMDEwLTA0LTI2ICBMYXN6bG8gR29tYm9zICA8bGFzemxv LjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFu bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9UZXh0TWV0cmljcy5oIGIvV2ViQ29yZS9odG1s L1RleHRNZXRyaWNzLmgKaW5kZXggMzRhMzM3OGQwZjU1NTgxMGU0ZTM0MjUxMThlOTFiZDZhMTgx NWI1Zi4uZDhjZmNhMmQyYTk0YzkzMDkzMDA1Nzk5MTJjNzRlZDViNjgzYTcyZiAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL1RleHRNZXRyaWNzLmgKKysrIGIvV2ViQ29yZS9odG1sL1RleHRNZXRy aWNzLmgKQEAgLTM0LDcgKzM0LDcgQEAgY2xhc3MgVGV4dE1ldHJpY3MgOiBwdWJsaWMgUmVmQ291 bnRlZDxUZXh0TWV0cmljcz4gewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFRleHRN ZXRyaWNzPiBjcmVhdGUoKSB7IHJldHVybiBhZG9wdFJlZihuZXcgVGV4dE1ldHJpY3MpOyB9CiAK LSAgICB1bnNpZ25lZCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIG1fd2lkdGg7IH0KKyAgICB1bnNp Z25lZCB3aWR0aCgpIGNvbnN0IHsgcmV0dXJuIHN0YXRpY19jYXN0PHVuc2lnbmVkPihtX3dpZHRo KTsgfQogICAgIHZvaWQgc2V0V2lkdGgoZmxvYXQgdykgeyBtX3dpZHRoID0gdzsgfQogCiBwcml2 YXRlOgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJp dGVkRGF0YS5oIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlSW5oZXJpdGVkRGF0 YS5oCmluZGV4IDJlODdlNmI5N2ZkMmEwYWMwMThiNTY5NmQ1MzdmZWEyMmU0YzlkMmIuLmY5MWI5 MGY4MjFjZDMzMmNkZjIwYWUyNDcyMWIyODA4MTllNTAwM2IgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUv cmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaAorKysgYi9XZWJDb3JlL3Jl bmRlcmluZy9zdHlsZS9TdHlsZVJhcmVJbmhlcml0ZWREYXRhLmgKQEAgLTMyLDcgKzMyLDcgQEAK IAogbmFtZXNwYWNlIFdlYkNvcmUgewogCi1zdHJ1Y3QgU2hhZG93RGF0YTsKK2NsYXNzIFNoYWRv d0RhdGE7CiAKIC8vIFRoaXMgc3RydWN0IGlzIGZvciByYXJlbHkgdXNlZCBpbmhlcml0ZWQgQ1NT MywgQ1NTMiwgYW5kIFdlYktpdC1zcGVjaWZpYyBwcm9wZXJ0aWVzLgogLy8gQnkgZ3JvdXBpbmcg dGhlbSB0b2dldGhlciwgd2Ugc2F2ZSBzcGFjZSwgYW5kIG9ubHkgYWxsb2NhdGUgdGhpcyBvYmpl Y3Qgd2hlbiBzb21lb25lCmRpZmYgLS1naXQgYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHls ZVJhcmVOb25Jbmhlcml0ZWREYXRhLmggYi9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJh cmVOb25Jbmhlcml0ZWREYXRhLmgKaW5kZXggNDUyYjI3M2RlMmY2MjU2NjI5YThjMDAxYjc0MGI1 NTQxNWYxMjQyYy4uMjFiYmU5NDM0YjM0ZTI4Y2QzYTljMTU0MmJkODE5ZjNkMmRkM2Y3MyAxMDA2 NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0 YS5oCisrKyBiL1dlYkNvcmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERh dGEuaApAQCAtNDAsMTMgKzQwLDE0IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKIAogY2xhc3MgQW5p bWF0aW9uTGlzdDsKIGNsYXNzIENTU1N0eWxlU2VsZWN0b3I7CitjbGFzcyBTaGFkb3dEYXRhOwog Y2xhc3MgU3R5bGVGbGV4aWJsZUJveERhdGE7CiBjbGFzcyBTdHlsZU1hcnF1ZWVEYXRhOwogY2xh c3MgU3R5bGVNdWx0aUNvbERhdGE7CiBjbGFzcyBTdHlsZVJlZmxlY3Rpb247CiBjbGFzcyBTdHls ZVRyYW5zZm9ybURhdGE7CisKIHN0cnVjdCBDb250ZW50RGF0YTsKLXN0cnVjdCBTaGFkb3dEYXRh OwogCiAjaWYgRU5BQkxFKERBU0hCT0FSRF9TVVBQT1JUKQogY2xhc3MgU3R5bGVEYXNoYm9hcmRS ZWdpb247Cg== 54370 2010-04-26 19:09:55 -0700 2010-05-03 17:04:15 -0700 Patch bug-38073-20100426190954.patch text/plain 3746 jamesr ZGlmZiAtLWdpdCBhL0phdmFTY3JpcHRDb3JlL0NoYW5nZUxvZyBiL0phdmFTY3JpcHRDb3JlL0No YW5nZUxvZwppbmRleCA3ZjkxYmQ5NTNlNWJhNTM5Njk1NjA5OWU2ZjhjN2M4ZDVjZTFhYjIzLi4w MWVjYzIwNWZmZjNhNTg2NjAxMzM2NTExZDhjYmZkYTRkYWZmMDJjIDEwMDY0NAotLS0gYS9KYXZh U2NyaXB0Q29yZS9DaGFuZ2VMb2cKKysrIGIvSmF2YVNjcmlwdENvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTMgQEAKKzIwMTAtMDQtMjMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVt Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBD bGVhbiB1cCBhIGZldyBjb21waWxlciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwNzMKKworICAgICAgICAqIHd0Zi90ZXh0L1N0cmlu Z0ltcGwuY3BwOgorICAgICAgICAoV2ViQ29yZTo6U3RyaW5nSW1wbDo6YXNjaWkpOgorCiAyMDEw LTA0LTI2ICBKZWRyemVqIE5vd2Fja2kgIDxqZWRyemVqLm5vd2Fja2lAbm9raWEuY29tPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IEtlbm5ldGggUm9oZGUgQ2hyaXN0aWFuc2VuLgpkaWZmIC0tZ2l0 IGEvSmF2YVNjcmlwdENvcmUvd3RmL3RleHQvU3RyaW5nSW1wbC5jcHAgYi9KYXZhU2NyaXB0Q29y ZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAppbmRleCAyYzU1ZDhlOTI1MzMwOTlmZTZhNDE2YzQ3 MGFkY2UzNzBmYmMzODEwLi5kNTkwMmFlMWNlNmI4OTRjOTQ4OWMzMTNlYjdiZjFmYjI4MjU4M2Q0 IDEwMDY0NAotLS0gYS9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcAorKysg Yi9KYXZhU2NyaXB0Q29yZS93dGYvdGV4dC9TdHJpbmdJbXBsLmNwcApAQCAtODgwLDcgKzg4MCw3 IEBAIFZlY3RvcjxjaGFyPiBTdHJpbmdJbXBsOjphc2NpaSgpCiAgICAgZm9yICh1bnNpZ25lZCBp ID0gMDsgaSAhPSBtX2xlbmd0aDsgKytpKSB7CiAgICAgICAgIFVDaGFyIGMgPSBtX2RhdGFbaV07 CiAgICAgICAgIGlmICgoYyA+PSAweDIwICYmIGMgPCAweDdGKSB8fCBjID09IDB4MDApCi0gICAg ICAgICAgICBidWZmZXJbaV0gPSBjOworICAgICAgICAgICAgYnVmZmVyW2ldID0gc3RhdGljX2Nh c3Q8Y2hhcj4oYyk7CiAgICAgICAgIGVsc2UKICAgICAgICAgICAgIGJ1ZmZlcltpXSA9ICc/JzsK ICAgICB9CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9n CmluZGV4IGU2NGMxYmFhM2FkNmE4MTM3NjBjY2ZiZDU4MDc3ZjA4Y2JiMjExYWEuLjgxMDJhZTFi OGE3ODA2OTA2NzgxNTVmMWRmNDQ0Yjg1OWNmM2ZkMjcgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MjMgIEphbWVzIFJvYmluc29uICA8amFtZXNyQGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZp ZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDbGVhbiB1cCBhIGZldyBjb21waWxl ciB3YXJuaW5ncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/ aWQ9MzgwNzMKKworICAgICAgICAqIGh0bWwvVGV4dE1ldHJpY3MuaDoKKyAgICAgICAgKFdlYkNv cmU6OlRleHRNZXRyaWNzOjp3aWR0aCk6CisgICAgICAgICogcmVuZGVyaW5nL3N0eWxlL1N0eWxl UmFyZUluaGVyaXRlZERhdGEuaDoKKyAgICAgICAgKiByZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJl Tm9uSW5oZXJpdGVkRGF0YS5oOgorCiAyMDEwLTA0LTI2ICBMYXN6bG8gR29tYm9zICA8bGFzemxv LjEuZ29tYm9zQG5va2lhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBTaW1vbiBIYXVzbWFu bi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvaHRtbC9UZXh0TWV0cmljcy5oIGIvV2ViQ29yZS9odG1s L1RleHRNZXRyaWNzLmgKaW5kZXggMzRhMzM3OGQwZjU1NTgxMGU0ZTM0MjUxMThlOTFiZDZhMTgx NWI1Zi4uMTRjZGI2NzMyMDgyYTA5NTY3ODU2MDY4NWU1YWVkNDQyMTFjMDJjMCAxMDA2NDQKLS0t IGEvV2ViQ29yZS9odG1sL1RleHRNZXRyaWNzLmgKKysrIGIvV2ViQ29yZS9odG1sL1RleHRNZXRy aWNzLmgKQEAgLTM0LDYgKzM0LDcgQEAgY2xhc3MgVGV4dE1ldHJpY3MgOiBwdWJsaWMgUmVmQ291 bnRlZDxUZXh0TWV0cmljcz4gewogcHVibGljOgogICAgIHN0YXRpYyBQYXNzUmVmUHRyPFRleHRN ZXRyaWNzPiBjcmVhdGUoKSB7IHJldHVybiBhZG9wdFJlZihuZXcgVGV4dE1ldHJpY3MpOyB9CiAK KyAgICAvLyBGSVhNRTogSXMgY29lcmNpbmcgdG8gYW4gaW50ZWdlciB2YWx1ZSBpbnRlbnRpb25h bD8gSWYgc28sIHRoZXJlIHNob3VsZCBiZSBhIHN0YXRpY19jYXN0PHVuc2lnbmVkPigpIGhlcmUu CiAgICAgdW5zaWduZWQgd2lkdGgoKSBjb25zdCB7IHJldHVybiBtX3dpZHRoOyB9CiAgICAgdm9p ZCBzZXRXaWR0aChmbG9hdCB3KSB7IG1fd2lkdGggPSB3OyB9CiAKZGlmZiAtLWdpdCBhL1dlYkNv cmUvcmVuZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaCBiL1dlYkNvcmUvcmVu ZGVyaW5nL3N0eWxlL1N0eWxlUmFyZUluaGVyaXRlZERhdGEuaAppbmRleCAyZTg3ZTZiOTdmZDJh MGFjMDE4YjU2OTZkNTM3ZmVhMjJlNGM5ZDJiLi5mOTFiOTBmODIxY2QzMzJjZGYyMGFlMjQ3MjFi MjgwODE5ZTUwMDNiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3JlbmRlcmluZy9zdHlsZS9TdHlsZVJh cmVJbmhlcml0ZWREYXRhLmgKKysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJl SW5oZXJpdGVkRGF0YS5oCkBAIC0zMiw3ICszMiw3IEBACiAKIG5hbWVzcGFjZSBXZWJDb3JlIHsK IAotc3RydWN0IFNoYWRvd0RhdGE7CitjbGFzcyBTaGFkb3dEYXRhOwogCiAvLyBUaGlzIHN0cnVj dCBpcyBmb3IgcmFyZWx5IHVzZWQgaW5oZXJpdGVkIENTUzMsIENTUzIsIGFuZCBXZWJLaXQtc3Bl Y2lmaWMgcHJvcGVydGllcy4KIC8vIEJ5IGdyb3VwaW5nIHRoZW0gdG9nZXRoZXIsIHdlIHNhdmUg c3BhY2UsIGFuZCBvbmx5IGFsbG9jYXRlIHRoaXMgb2JqZWN0IHdoZW4gc29tZW9uZQpkaWZmIC0t Z2l0IGEvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5o IGIvV2ViQ29yZS9yZW5kZXJpbmcvc3R5bGUvU3R5bGVSYXJlTm9uSW5oZXJpdGVkRGF0YS5oCmlu ZGV4IDQ1MmIyNzNkZTJmNjI1NjYyOWE4YzAwMWI3NDBiNTU0MTVmMTI0MmMuLjIxYmJlOTQzNGIz NGUyOGNkM2E5YzE1NDJiZDgxOWYzZDJkZDNmNzMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcmVuZGVy aW5nL3N0eWxlL1N0eWxlUmFyZU5vbkluaGVyaXRlZERhdGEuaAorKysgYi9XZWJDb3JlL3JlbmRl cmluZy9zdHlsZS9TdHlsZVJhcmVOb25Jbmhlcml0ZWREYXRhLmgKQEAgLTQwLDEzICs0MCwxNCBA QCBuYW1lc3BhY2UgV2ViQ29yZSB7CiAKIGNsYXNzIEFuaW1hdGlvbkxpc3Q7CiBjbGFzcyBDU1NT dHlsZVNlbGVjdG9yOworY2xhc3MgU2hhZG93RGF0YTsKIGNsYXNzIFN0eWxlRmxleGlibGVCb3hE YXRhOwogY2xhc3MgU3R5bGVNYXJxdWVlRGF0YTsKIGNsYXNzIFN0eWxlTXVsdGlDb2xEYXRhOwog Y2xhc3MgU3R5bGVSZWZsZWN0aW9uOwogY2xhc3MgU3R5bGVUcmFuc2Zvcm1EYXRhOworCiBzdHJ1 Y3QgQ29udGVudERhdGE7Ci1zdHJ1Y3QgU2hhZG93RGF0YTsKIAogI2lmIEVOQUJMRShEQVNIQk9B UkRfU1VQUE9SVCkKIGNsYXNzIFN0eWxlRGFzaGJvYXJkUmVnaW9uOwo=