38056 2010-04-23 12:21:33 -0700 [Android] The touchmove delta used in basic-single-touch-events.html is too small for Android 2010-04-23 20:37:01 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 benm webkit-unassigned android-webkit-unforking commit-queue gdk hausmann jorlow oldest_to_newest 216509 0 benm 2010-04-23 12:21:33 -0700 Android is failing the basic-single-touch-events test due to an optimisation in the Android framework that does not forward touch events to WebCore if they are a small move. Currently the delta used in the singleTouchSequence function in basic-single-touch-events (10, 10) -> (20, 15) falls within the scope of the optimisation and so we fail the test as the touch event is not sent to WebCore. I'd like to propose increasing this delta so that the test passes on Android. Proposed patch to follow. 216513 1 54181 benm 2010-04-23 12:36:56 -0700 Created attachment 54181 Proposed Patch 216548 2 54181 jorlow 2010-04-23 13:51:13 -0700 Comment on attachment 54181 Proposed Patch Might it be a good idea to change one of the values so that they're not both 50 and/or 20? 216566 3 benm 2010-04-23 14:37:36 -0700 (In reply to comment #2) > (From update of attachment 54181 [details]) > Might it be a good idea to change one of the values so that they're not both 50 > and/or 20? I could do ... although all the analysis I've done I've always looked at the x and y as a pair, so it was only useful to make the x,y pair distinct from other pairs. Unless you feel strongly I think we can just leave as-is. Thanks, Ben 216573 4 jorlow 2010-04-23 14:56:19 -0700 I r+'ed it because I was OK with it in its current state. Just a suggestion. 216575 5 54181 benm 2010-04-23 14:59:49 -0700 Comment on attachment 54181 Proposed Patch Great, thanks. Setting cq+. 216683 6 54181 commit-queue 2010-04-23 20:36:55 -0700 Comment on attachment 54181 Proposed Patch Clearing flags on attachment: 54181 Committed r58208: <http://trac.webkit.org/changeset/58208> 216684 7 commit-queue 2010-04-23 20:37:01 -0700 All reviewed patches have been landed. Closing bug. 54181 2010-04-23 12:36:56 -0700 2010-04-23 20:36:55 -0700 Proposed Patch 38056.txt text/plain 4250 benm SW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0cy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MTgxKQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTggQEAKKzIwMTAtMDQtMjMgIEJlbiBNdXJkb2NoICA8YmVu bUBnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtBbmRyb2lkXSBUaGUgdG91Y2htb3ZlIGRlbHRhIHVzZWQgaW4gYmFzaWMtc2luZ2xl LXRvdWNoLWV2ZW50cy5odG1sIGlzIHRvbyBzbWFsbCBmb3IgQW5kcm9pZAorICAgICAgICBodHRw czovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwNTYKKworICAgICAgICAqIGZh c3QvZXZlbnRzL3RvdWNoL2Jhc2ljLXNpbmdsZS10b3VjaC1ldmVudHMtZXhwZWN0ZWQudHh0Ogor ICAgICAgICAgICAgLSB1cGRhdGUgdGhlIHRlc3QgZXhwZWN0ZWQgb3V0cHV0CisgICAgICAgICog ZmFzdC9ldmVudHMvdG91Y2gvc2NyaXB0LXRlc3RzL2Jhc2ljLXNpbmdsZS10b3VjaC1ldmVudHMu anM6CisgICAgICAgICh2ZXJpZnlUb3VjaCk6IHVwZGF0ZSB0ZXN0IGV4cGVjdGF0aW9uIHdpdGgg bmV3IGNvb3JkaW5hdGVzLgorICAgICAgICAoc2luZ2xlVG91Y2hTZXF1ZW5jZSk6IGluY3JlYXNl IHRoZSB0b3VjaCBtb3ZlIGRlbHRhLgorICAgICAgICAodG91Y2hUYXJnZXRzKTogU3RhcnQgdGhl IHRvdWNoIGF0IGEgZGlmZmVyZW50IHBvaW50IHRvCisgICAgICAgICAgICAgICAgIHNpbmdsZVRv dWNoU2VxdWVuY2UgdG8gbWFrZSBleGFtaW5pbmcgYmVoYXZpb3IgZWFzaWVyLgorCiAyMDEwLTA0 LTIzICBLZW5uZXRoIFJvaGRlIENocmlzdGlhbnNlbiAgPGtlbm5ldGhAd2Via2l0Lm9yZz4KIAog ICAgICAgICBVbnJldmlld2VkIGxheW91dCBmaXguCkluZGV4OiBMYXlvdXRUZXN0cy9mYXN0L2V2 ZW50cy90b3VjaC9iYXNpYy1zaW5nbGUtdG91Y2gtZXZlbnRzLWV4cGVjdGVkLnR4dAo9PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09Ci0tLSBMYXlvdXRUZXN0cy9mYXN0L2V2ZW50cy90b3VjaC9iYXNpYy1zaW5nbGUtdG91Y2gt ZXZlbnRzLWV4cGVjdGVkLnR4dAkocmV2aXNpb24gNTgxODApCisrKyBMYXlvdXRUZXN0cy9mYXN0 L2V2ZW50cy90b3VjaC9iYXNpYy1zaW5nbGUtdG91Y2gtZXZlbnRzLWV4cGVjdGVkLnR4dAkod29y a2luZyBjb3B5KQpAQCAtMzIsMTAgKzMyLDEwIEBAIFBBU1MgbGFzdEV2ZW50LmNoYW5nZWRUb3Vj aGVzLmxlbmd0aCBpcyAKIFBBU1MgbGFzdEV2ZW50LnRhcmdldFRvdWNoZXMubGVuZ3RoIGlzIDEK IFBBU1MgbGFzdEV2ZW50LnBhZ2VYIGlzIDAKIFBBU1MgbGFzdEV2ZW50LnBhZ2VZIGlzIDAKLVBB U1MgbGFzdEV2ZW50LnRvdWNoZXNbMF0ucGFnZVggaXMgMjAKLVBBU1MgbGFzdEV2ZW50LnRvdWNo ZXNbMF0ucGFnZVkgaXMgMTUKLVBBU1MgbGFzdEV2ZW50LnRvdWNoZXNbMF0uY2xpZW50WCBpcyAy MAotUEFTUyBsYXN0RXZlbnQudG91Y2hlc1swXS5jbGllbnRZIGlzIDE1CitQQVNTIGxhc3RFdmVu dC50b3VjaGVzWzBdLnBhZ2VYIGlzIDUwCitQQVNTIGxhc3RFdmVudC50b3VjaGVzWzBdLnBhZ2VZ IGlzIDUwCitQQVNTIGxhc3RFdmVudC50b3VjaGVzWzBdLmNsaWVudFggaXMgNTAKK1BBU1MgbGFz dEV2ZW50LnRvdWNoZXNbMF0uY2xpZW50WSBpcyA1MAogUEFTUyBsYXN0RXZlbnQudG91Y2hlc1sw XS5pZGVudGlmaWVyIGlzIDAKIFBBU1MgbGFzdEV2ZW50LnNoaWZ0S2V5IGlzIHRydWUKIFBBU1Mg bGFzdEV2ZW50LmFsdEtleSBpcyB0cnVlCkBAIC00NywxMCArNDcsMTAgQEAgUEFTUyBsYXN0RXZl bnQuY2hhbmdlZFRvdWNoZXMubGVuZ3RoIGlzIAogUEFTUyBsYXN0RXZlbnQudGFyZ2V0VG91Y2hl cy5sZW5ndGggaXMgMAogUEFTUyBsYXN0RXZlbnQucGFnZVggaXMgMAogUEFTUyBsYXN0RXZlbnQu cGFnZVkgaXMgMAotUEFTUyBsYXN0RXZlbnQuY2hhbmdlZFRvdWNoZXNbMF0ucGFnZVggaXMgMjAK LVBBU1MgbGFzdEV2ZW50LmNoYW5nZWRUb3VjaGVzWzBdLnBhZ2VZIGlzIDE1Ci1QQVNTIGxhc3RF dmVudC5jaGFuZ2VkVG91Y2hlc1swXS5jbGllbnRYIGlzIDIwCi1QQVNTIGxhc3RFdmVudC5jaGFu Z2VkVG91Y2hlc1swXS5jbGllbnRZIGlzIDE1CitQQVNTIGxhc3RFdmVudC5jaGFuZ2VkVG91Y2hl c1swXS5wYWdlWCBpcyA1MAorUEFTUyBsYXN0RXZlbnQuY2hhbmdlZFRvdWNoZXNbMF0ucGFnZVkg aXMgNTAKK1BBU1MgbGFzdEV2ZW50LmNoYW5nZWRUb3VjaGVzWzBdLmNsaWVudFggaXMgNTAKK1BB U1MgbGFzdEV2ZW50LmNoYW5nZWRUb3VjaGVzWzBdLmNsaWVudFkgaXMgNTAKIFBBU1MgbGFzdEV2 ZW50LmNoYW5nZWRUb3VjaGVzWzBdLmlkZW50aWZpZXIgaXMgMAogUEFTUyBsYXN0RXZlbnQuc2hp ZnRLZXkgaXMgZmFsc2UKIFBBU1MgbGFzdEV2ZW50LmFsdEtleSBpcyBmYWxzZQpJbmRleDogTGF5 b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvc2NyaXB0LXRlc3RzL2Jhc2ljLXNpbmdsZS10b3Vj aC1ldmVudHMuanMKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gv c2NyaXB0LXRlc3RzL2Jhc2ljLXNpbmdsZS10b3VjaC1ldmVudHMuanMJKHJldmlzaW9uIDU4MTgw KQorKysgTGF5b3V0VGVzdHMvZmFzdC9ldmVudHMvdG91Y2gvc2NyaXB0LXRlc3RzL2Jhc2ljLXNp bmdsZS10b3VjaC1ldmVudHMuanMJKHdvcmtpbmcgY29weSkKQEAgLTYyLDcgKzYyLDcgQEAgZnVu Y3Rpb24gdmVyaWZ5VG91Y2god2hpY2gpIHsKICAgICAgICAgYnJlYWs7CiAgICAgICAgIGNhc2Ug MToKICAgICAgICAgICAgdmVyaWZ5VG91Y2hFdmVudCgidG91Y2htb3ZlIiwgMSwgMSwgMSk7Ci0g ICAgICAgICAgIHZlcmlmeVRvdWNoUG9pbnQoInRvdWNoZXMiLCAwLCAyMCwgMTUsIDApOworICAg ICAgICAgICB2ZXJpZnlUb3VjaFBvaW50KCJ0b3VjaGVzIiwgMCwgNTAsIDUwLCAwKTsKICAgICAg ICAgICAgc2hvdWxkQmUoImxhc3RFdmVudC5zaGlmdEtleSIsICJ0cnVlIik7CiAgICAgICAgICAg IHNob3VsZEJlKCJsYXN0RXZlbnQuYWx0S2V5IiwgInRydWUiKTsKICAgICAgICAgICAgc2hvdWxk QmUoImxhc3RFdmVudC5jdHJsS2V5IiwgImZhbHNlIik7CkBAIC03MCw3ICs3MCw3IEBAIGZ1bmN0 aW9uIHZlcmlmeVRvdWNoKHdoaWNoKSB7CiAgICAgICAgIGJyZWFrOwogICAgICAgICBjYXNlIDI6 CiAgICAgICAgICAgICB2ZXJpZnlUb3VjaEV2ZW50KCJ0b3VjaGVuZCIsIDAsIDEsIDApOwotICAg ICAgICAgICAgdmVyaWZ5VG91Y2hQb2ludCgiY2hhbmdlZFRvdWNoZXMiLCAwLCAyMCwgMTUsIDAp OworICAgICAgICAgICAgdmVyaWZ5VG91Y2hQb2ludCgiY2hhbmdlZFRvdWNoZXMiLCAwLCA1MCwg NTAsIDApOwogICAgICAgICAgICAgc2hvdWxkQmUoImxhc3RFdmVudC5zaGlmdEtleSIsICJmYWxz ZSIpOwogICAgICAgICAgICAgc2hvdWxkQmUoImxhc3RFdmVudC5hbHRLZXkiLCAiZmFsc2UiKTsK ICAgICAgICAgYnJlYWs7CkBAIC05Miw3ICs5Miw3IEBAIGZ1bmN0aW9uIHNpbmdsZVRvdWNoU2Vx dWVuY2UoKQogICAgIGV2ZW50U2VuZGVyLmFkZFRvdWNoUG9pbnQoMTAsIDEwKTsKICAgICBldmVu dFNlbmRlci50b3VjaFN0YXJ0KCk7CiAKLSAgICBldmVudFNlbmRlci51cGRhdGVUb3VjaFBvaW50 KDAsIDIwLCAxNSk7CisgICAgZXZlbnRTZW5kZXIudXBkYXRlVG91Y2hQb2ludCgwLCA1MCwgNTAp OwogICAgIGV2ZW50U2VuZGVyLnNldFRvdWNoTW9kaWZpZXIoInNoaWZ0IiwgdHJ1ZSk7CiAgICAg ZXZlbnRTZW5kZXIuc2V0VG91Y2hNb2RpZmllcigiYWx0IiwgdHJ1ZSk7CiAgICAgZXZlbnRTZW5k ZXIudG91Y2hNb3ZlKCk7CkBAIC0xMDYsNyArMTA2LDcgQEAgZnVuY3Rpb24gc2luZ2xlVG91Y2hT ZXF1ZW5jZSgpCiAKIGZ1bmN0aW9uIHRvdWNoVGFyZ2V0cygpCiB7Ci0gICAgZXZlbnRTZW5kZXIu YWRkVG91Y2hQb2ludCgxMCwgMTApOworICAgIGV2ZW50U2VuZGVyLmFkZFRvdWNoUG9pbnQoMjAs IDIwKTsKICAgICBldmVudFNlbmRlci50b3VjaFN0YXJ0KCk7CiAKICAgICBldmVudFNlbmRlci51 cGRhdGVUb3VjaFBvaW50KDAsIDEwMDAsIDEwMDApOwo=