38051 2010-04-23 10:35:53 -0700 [GTK] Fix out of source build failure 2010-05-03 09:00:15 -0700 1 1 1 Unclassified WebKit WebKitGTK 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 0 geoff.levand webkit-unassigned commit-queue eric webkit.review.bot xan.lopez oldest_to_newest 216465 0 geoff.levand 2010-04-23 10:35:53 -0700 Add a preprocessor include path for generated GTK header files. Fixes build errors like these when building GTK out of source: webkit.h: error: webkit/webkitversion.h: No such file or directory -Geoff 216467 1 54171 geoff.levand 2010-04-23 10:39:15 -0700 Created attachment 54171 patch v1 216477 2 54176 geoff.levand 2010-04-23 11:00:53 -0700 Created attachment 54176 patch v2 216479 3 webkit.review.bot 2010-04-23 11:03:27 -0700 Attachment 54176 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 216485 4 54177 geoff.levand 2010-04-23 11:12:41 -0700 Created attachment 54177 patch v3 216487 5 webkit.review.bot 2010-04-23 11:15:13 -0700 Attachment 54177 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 Total errors found: 0 in 0 files If any of these errors are false positives, please file a bug against check-webkit-style. 216496 6 54178 geoff.levand 2010-04-23 11:38:37 -0700 Created attachment 54178 patch v4 219956 7 54178 eric 2010-05-02 19:07:07 -0700 Comment on attachment 54178 patch v4 OK... rs=me. 219957 8 54178 eric 2010-05-02 19:08:19 -0700 Comment on attachment 54178 patch v4 I think what you all are actually looking for is forwarding headers. See WebCore/ForwardingHeaders as examples. Or at least that's how this sort of problem of internal header paths vs. external header paths are solved on Mac. But this looks OK too. 219977 9 54178 commit-queue 2010-05-02 19:21:44 -0700 Comment on attachment 54178 patch v4 Clearing flags on attachment: 54178 Committed r58664: <http://trac.webkit.org/changeset/58664> 219978 10 commit-queue 2010-05-02 19:21:50 -0700 All reviewed patches have been landed. Closing bug. 220044 11 xan.lopez 2010-05-03 02:03:15 -0700 (In reply to comment #0) > Add a preprocessor include path for generated GTK header files. > Fixes build errors like these when building GTK out of source: > > webkit.h: error: webkit/webkitversion.h: No such file or directory > > -Geoff When you say out of source you simply mean using a build directory like WebKitBuild? It's strange that you say it does not work for you, since we all use that every day. What is your environment like exactly? 220124 12 geoff.levand 2010-05-03 08:49:43 -0700 Hi, (In reply to comment #11) > (In reply to comment #0) > > Add a preprocessor include path for generated GTK header files. > > Fixes build errors like these when building GTK out of source: > > > > webkit.h: error: webkit/webkitversion.h: No such file or directory > > When you say out of source you simply mean using a build directory like > WebKitBuild? It's strange that you say it does not work for you, since we all > use that every day. What is your environment like exactly? This is a common automake makefile bug. Something like this will hit it: git clone git://git.webkit.org/WebKit.git cd WebKit ./autogen.sh mkdir ../build cd ../build ../Webkit/configure make -Geoff 220126 13 xan.lopez 2010-05-03 09:00:15 -0700 (In reply to comment #12) > This is a common automake makefile bug. Something like this > will hit it: > > git clone git://git.webkit.org/WebKit.git > cd WebKit > ./autogen.sh > mkdir ../build > cd ../build > ../Webkit/configure > make > > -Geoff Yeah, we all use something like that and this is the first time I hear from anyone of a build failure. That's why I was wondering of the exact details of your environment. 54171 2010-04-23 10:39:15 -0700 2010-04-23 11:00:53 -0700 patch v1 gtk-fix-out-of-source-build.diff text/plain 1083 geoff.levand U3ViamVjdDogW0dUS10gRml4IG91dCBvZiBzb3VyY2UgYnVpbGQgZmFpbHVyZQoKU2lnbmVkLW9m Zi1ieTogR2VvZmYgTGV2YW5kIDxnZW9mZi5sZXZhbmRAYW0uc29ueS5jb20+Ci0tLQogQ2hhbmdl TG9nICAgICAgfCAgIDE0ICsrKysrKysrKysrKysrCiBHTlVtYWtlZmlsZS5hbSB8ICAgIDEgKwog MiBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNlcnRpb25zKCspCgotLS0gYS9DaGFuZ2VMb2cKKysrIGIv Q2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjMgIEdlb2ZmIExldmFuZCAgPGdl b2ZmcmV5LmxldmFuZEBhbS5zb255LmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBbR1RLXSBGaXggb3V0IG9mIHNvdXJjZSBidWlsZCBmYWlsdXJl CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODA1MQor CisgICAgICAgIEFkZCBhIHByZXByb2Nlc3NvciBpbmNsdWRlIHBhdGggZm9yIGdlbmVyYXRlZCBH VEsgaGVhZGVyIGZpbGVzLgorICAgICAgICBGaXhlcyBidWlsZCBlcnJvcnMgbGlrZSB0aGVzZSB3 aGVuIGJ1aWxkaW5nIEdUSyBvdXQgb2Ygc291cmNlOgorCisgICAgICAgICAgd2Via2l0Lmg6IGVy cm9yOiB3ZWJraXQvd2Via2l0dmVyc2lvbi5oOiBObyBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5CisK KyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwogMjAxMC0wNC0yMSAgWGFuIExvcGV6ICA8eGxv cGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KLS0tIGEv R05VbWFrZWZpbGUuYW0KKysrIGIvR05VbWFrZWZpbGUuYW0KQEAgLTM5Nyw2ICszOTcsNyBAQCB3 ZWJraXRndGtfY3BwZmxhZ3MgKz0gXAogCS1JJChzcmNkaXIpL1dlYktpdC9ndGsgXAogCS1JJChz cmNkaXIpL1dlYktpdC9ndGsvV2ViQ29yZVN1cHBvcnQgXAogCS1JJChzcmNkaXIpL1dlYktpdC9n dGsvd2Via2l0IFwKKwktSSQodG9wX2J1aWxkZGlyKS9XZWJLaXQvZ3RrIFwKIAktSSQodG9wX2J1 aWxkZGlyKS9XZWJLaXQvZ3RrL3dlYmtpdCBcCiAJLUkkKEdFTlNPVVJDRVNXRUJLSVRET00pCiAK 54176 2010-04-23 11:00:53 -0700 2010-04-23 11:12:41 -0700 patch v2 gtk-fix-out-of-source-build.diff text/plain 1025 geoff.levand U3ViamVjdDogW0dUS10gRml4IG91dCBvZiBzb3VyY2UgYnVpbGQgZmFpbHVyZQoKLS0tCiBDaGFu Z2VMb2cgICAgICB8ICAgMTQgKysrKysrKysrKysrKysKIEdOVW1ha2VmaWxlLmFtIHwgICAgMSAr CiAyIGZpbGVzIGNoYW5nZWQsIDE1IGluc2VydGlvbnMoKykKCi0tLSBhL0NoYW5nZUxvZworKysg Yi9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNyBAQAorMjAxMC0wNC0yMyAgR2VvZmYgTGV2YW5kICA8 Z2VvZmYubGV2YW5kQGFtLnNvbnkuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIFtHVEtdIEZpeCBvdXQgb2Ygc291cmNlIGJ1aWxkIGZhaWx1cmUK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDUxCisK KyAgICAgICAgQWRkIGEgcHJlcHJvY2Vzc29yIGluY2x1ZGUgcGF0aCBmb3IgZ2VuZXJhdGVkIEdU SyBoZWFkZXIgZmlsZXMuCisgICAgICAgIEZpeGVzIGJ1aWxkIGVycm9ycyBsaWtlIHRoZXNlIHdo ZW4gYnVpbGRpbmcgR1RLIG91dCBvZiBzb3VyY2U6CisKKyAgICAgICAgICB3ZWJraXQuaDogZXJy b3I6IHdlYmtpdC93ZWJraXR2ZXJzaW9uLmg6IE5vIHN1Y2ggZmlsZSBvciBkaXJlY3RvcnkKKwor ICAgICAgICAqIEdOVW1ha2VmaWxlLmFtOgorCiAyMDEwLTA0LTIxICBYYW4gTG9wZXogIDx4bG9w ZXpAaWdhbGlhLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBBZGFtIEJhcnRoLgotLS0gYS9H TlVtYWtlZmlsZS5hbQorKysgYi9HTlVtYWtlZmlsZS5hbQpAQCAtMzk3LDYgKzM5Nyw3IEBAIHdl YmtpdGd0a19jcHBmbGFncyArPSBcCiAJLUkkKHNyY2RpcikvV2ViS2l0L2d0ayBcCiAJLUkkKHNy Y2RpcikvV2ViS2l0L2d0ay9XZWJDb3JlU3VwcG9ydCBcCiAJLUkkKHNyY2RpcikvV2ViS2l0L2d0 ay93ZWJraXQgXAorCS1JJCh0b3BfYnVpbGRkaXIpL1dlYktpdC9ndGsgXAogCS1JJCh0b3BfYnVp bGRkaXIpL1dlYktpdC9ndGsvd2Via2l0IFwKIAktSSQoR0VOU09VUkNFU1dFQktJVERPTSkKIAo= 54177 2010-04-23 11:12:41 -0700 2010-04-23 11:38:37 -0700 patch v3 gtk-fix-out-of-source-build.diff text/plain 874 geoff.levand LS0tIGEvQ2hhbmdlTG9nCisrKyBiL0NoYW5nZUxvZwpAQCAtMSwzICsxLDE3IEBACisyMDEwLTA0 LTIzICBHZW9mZiBMZXZhbmQgIDxnZW9mZi5sZXZhbmRAYW0uc29ueS5jb20+CisKKyAgICAgICAg UmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW0dUS10gRml4IG91dCBvZiBz b3VyY2UgYnVpbGQgZmFpbHVyZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzgwNTEKKworICAgICAgICBBZGQgYSBwcmVwcm9jZXNzb3IgaW5jbHVkZSBw YXRoIGZvciBnZW5lcmF0ZWQgR1RLIGhlYWRlciBmaWxlcy4KKyAgICAgICAgRml4ZXMgYnVpbGQg ZXJyb3JzIGxpa2UgdGhlc2Ugd2hlbiBidWlsZGluZyBHVEsgb3V0IG9mIHNvdXJjZToKKworICAg ICAgICAgIHdlYmtpdC5oOiBlcnJvcjogd2Via2l0L3dlYmtpdHZlcnNpb24uaDogTm8gc3VjaCBm aWxlIG9yIGRpcmVjdG9yeQorCisgICAgICAgICogR05VbWFrZWZpbGUuYW06CisKIDIwMTAtMDQt MjEgIFhhbiBMb3BleiAgPHhsb3BlekBpZ2FsaWEuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IEFkYW0gQmFydGguCi0tLSBhL0dOVW1ha2VmaWxlLmFtCisrKyBiL0dOVW1ha2VmaWxlLmFtCkBA IC0zOTcsNiArMzk3LDcgQEAgd2Via2l0Z3RrX2NwcGZsYWdzICs9IFwKIAktSSQoc3JjZGlyKS9X ZWJLaXQvZ3RrIFwKIAktSSQoc3JjZGlyKS9XZWJLaXQvZ3RrL1dlYkNvcmVTdXBwb3J0IFwKIAkt SSQoc3JjZGlyKS9XZWJLaXQvZ3RrL3dlYmtpdCBcCisJLUkkKHRvcF9idWlsZGRpcikvV2ViS2l0 L2d0ayBcCiAJLUkkKHRvcF9idWlsZGRpcikvV2ViS2l0L2d0ay93ZWJraXQgXAogCS1JJChHRU5T T1VSQ0VTV0VCS0lURE9NKQogCg== 54178 2010-04-23 11:38:37 -0700 2010-05-02 19:21:44 -0700 patch v4 ,,gtk-fix-out-of-source-build-v4.diff text/plain 1014 geoff.levand ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCBlZDJlMmU1Li4wMzQxZTJl IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTcgQEAK KzIwMTAtMDQtMjMgIEdlb2ZmIExldmFuZCAgPGdlb2ZmLmxldmFuZEBhbS5zb255LmNvbT4KKwor ICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBGaXgg b3V0IG9mIHNvdXJjZSBidWlsZCBmYWlsdXJlCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zODA1MQorCisgICAgICAgIEFkZCBhIHByZXByb2Nlc3NvciBp bmNsdWRlIHBhdGggZm9yIGdlbmVyYXRlZCBHVEsgaGVhZGVyIGZpbGVzLgorICAgICAgICBGaXhl cyBidWlsZCBlcnJvcnMgbGlrZSB0aGVzZSB3aGVuIGJ1aWxkaW5nIEdUSyBvdXQgb2Ygc291cmNl OgorCisgICAgICAgICAgd2Via2l0Lmg6IGVycm9yOiB3ZWJraXQvd2Via2l0dmVyc2lvbi5oOiBO byBzdWNoIGZpbGUgb3IgZGlyZWN0b3J5CisKKyAgICAgICAgKiBHTlVtYWtlZmlsZS5hbToKKwog MjAxMC0wNC0yMSAgWGFuIExvcGV6ICA8eGxvcGV6QGlnYWxpYS5jb20+CiAKICAgICAgICAgUmV2 aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlmZiAtLWdpdCBhL0dOVW1ha2VmaWxlLmFtIGIvR05VbWFr ZWZpbGUuYW0KaW5kZXggMzY4MjIwZC4uYjYyMGE4MiAxMDA2NDQKLS0tIGEvR05VbWFrZWZpbGUu YW0KKysrIGIvR05VbWFrZWZpbGUuYW0KQEAgLTM5Nyw2ICszOTcsNyBAQCB3ZWJraXRndGtfY3Bw ZmxhZ3MgKz0gXAogCS1JJChzcmNkaXIpL1dlYktpdC9ndGsgXAogCS1JJChzcmNkaXIpL1dlYktp dC9ndGsvV2ViQ29yZVN1cHBvcnQgXAogCS1JJChzcmNkaXIpL1dlYktpdC9ndGsvd2Via2l0IFwK KwktSSQodG9wX2J1aWxkZGlyKS9XZWJLaXQvZ3RrIFwKIAktSSQodG9wX2J1aWxkZGlyKS9XZWJL aXQvZ3RrL3dlYmtpdCBcCiAJLUkkKEdFTlNPVVJDRVNXRUJLSVRET00pCiAK