38043 2010-04-23 05:01:47 -0700 Web Inspector: Profiler: A status item is required when record button is pressed. 2010-05-04 03:04:44 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 loislo mnaganov mnaganov pfeldman timothy yurys oldest_to_newest 216376 0 loislo 2010-04-23 05:01:47 -0700 %SUBJ% 219441 1 54793 mnaganov 2010-04-30 04:49:11 -0700 Created attachment 54793 proposed patch 219487 2 54793 pfeldman 2010-04-30 07:56:27 -0700 Comment on attachment 54793 proposed patch WebCore/inspector/front-end/ProfilesPanel.js:328 + if (this._profiles[i].uid == profile.uid) { === ? 220538 3 mnaganov 2010-05-04 03:04:44 -0700 Manually committed as http://trac.webkit.org/changeset/58745. 2010-05-04 Mikhail Naganov <mnaganov@chromium.org> Reviewed by Pavel Feldman. Display "Recording..." item when recording an user-initiated CPU profile. https://bugs.webkit.org/show_bug.cgi?id=38043 * English.lproj/localizedStrings.js: * inspector/front-end/ProfilesPanel.js: (WebInspector.ProfilesPanel.prototype.addProfileHeader): (WebInspector.ProfilesPanel.prototype.removeProfileHeader): (WebInspector.ProfilesPanel.prototype.showProfile): * inspector/front-end/inspector.js: (WebInspector.setRecordingProfile): 54793 2010-04-30 04:49:11 -0700 2010-04-30 07:56:27 -0700 proposed patch fix-38043-patch text/plain 3957 mnaganov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MzQzNzdjNy4uMDM0M2MyNCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxOSBAQAorMjAxMC0wNC0zMCAgTWlraGFpbCBOYWdh bm92ICA8bW5hZ2Fub3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIERpc3BsYXkgIlJlY29yZGluZy4uLiIgaXRlbSB3aGVuIHJl Y29yZGluZyBhbiB1c2VyLWluaXRpYXRlZCBDUFUgcHJvZmlsZS4KKworICAgICAgICBodHRwczov L2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwNDMKKworICAgICAgICAqIEVuZ2xp c2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qczoKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQt ZW5kL1Byb2ZpbGVzUGFuZWwuanM6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJvZmlsZXNQYW5l bC5wcm90b3R5cGUuYWRkUHJvZmlsZUhlYWRlcik6CisgICAgICAgIChXZWJJbnNwZWN0b3IuUHJv ZmlsZXNQYW5lbC5wcm90b3R5cGUucmVtb3ZlUHJvZmlsZUhlYWRlcik6CisgICAgICAgIChXZWJJ bnNwZWN0b3IuUHJvZmlsZXNQYW5lbC5wcm90b3R5cGUuc2hvd1Byb2ZpbGUpOgorICAgICAgICAq IGluc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpzOgorICAgICAgICAoV2ViSW5zcGVjdG9y LnNldFJlY29yZGluZ1Byb2ZpbGUpOgorCiAyMDEwLTA0LTMwICBTaGluaWNoaXJvIEhhbWFqaSAg PGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIu CmRpZmYgLS1naXQgYS9XZWJDb3JlL0VuZ2xpc2gubHByb2ovbG9jYWxpemVkU3RyaW5ncy5qcyBi L1dlYkNvcmUvRW5nbGlzaC5scHJvai9sb2NhbGl6ZWRTdHJpbmdzLmpzCmluZGV4IDQyNGZjNmUz ZDBlYzZkNjRmNjk1NWRlOGM0YzMzNzU4ZWM0ODM2OGEuLjEyMGY4NWJmMjgyMTg0ZTQzZWQ4ZGZm Zjc4MDJhOTZkMzE1MjY5YzQgMTAwNjQ0CkdJVCBiaW5hcnkgcGF0Y2gKZGVsdGEgNTIKemNtY2J4 aEgyQVVyVlJucENkVVA7Tz5WR1pWTlloclhEREp3bllAcmdjPUViXzktJk56SmNlYHpKdXA7YXV4 OCs1CkYwMDd8ezRvbTw1CgpkZWx0YSA5ClFjbWRuQW1nJk04clZSbnAwMmZPSGJecmhYCgpkaWZm IC0tZ2l0IGEvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL1Byb2ZpbGVzUGFuZWwuanMgYi9X ZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5lbC5qcwppbmRleCAyZjlkMzhk Li42Mzg1NjFkIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmls ZXNQYW5lbC5qcworKysgYi9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvUHJvZmlsZXNQYW5l bC5qcwpAQCAtMzExLDE0ICszMTEsMzcgQEAgV2ViSW5zcGVjdG9yLlByb2ZpbGVzUGFuZWwucHJv dG90eXBlID0gewogICAgICAgICBwcm9maWxlLl9wcm9maWxlc1RyZWVFbGVtZW50ID0gcHJvZmls ZVRyZWVFbGVtZW50OwogCiAgICAgICAgIHNpZGViYXJQYXJlbnQuYXBwZW5kQ2hpbGQocHJvZmls ZVRyZWVFbGVtZW50KTsKLSAgICAgICAgdGhpcy53ZWxjb21lVmlldy5oaWRlKCk7Ci0gICAgICAg IGlmICghdGhpcy52aXNpYmxlVmlldykKLSAgICAgICAgICAgIHRoaXMuc2hvd1Byb2ZpbGUocHJv ZmlsZSk7CisgICAgICAgIGlmICghcHJvZmlsZS5pc1RlbXBvcmFyeSkgeworICAgICAgICAgICAg dGhpcy53ZWxjb21lVmlldy5oaWRlKCk7CisgICAgICAgICAgICBpZiAoIXRoaXMudmlzaWJsZVZp ZXcpCisgICAgICAgICAgICAgICAgdGhpcy5zaG93UHJvZmlsZShwcm9maWxlKTsKKyAgICAgICAg fQorICAgIH0sCisKKyAgICByZW1vdmVQcm9maWxlSGVhZGVyOiBmdW5jdGlvbihwcm9maWxlKQor ICAgIHsKKyAgICAgICAgdmFyIHR5cGVJZCA9IHByb2ZpbGUudHlwZUlkOworICAgICAgICB2YXIg cHJvZmlsZVR5cGUgPSB0aGlzLmdldFByb2ZpbGVUeXBlKHR5cGVJZCk7CisgICAgICAgIHZhciBz aWRlYmFyUGFyZW50ID0gcHJvZmlsZVR5cGUudHJlZUVsZW1lbnQ7CisKKyAgICAgICAgZm9yICh2 YXIgaSA9IDA7IGkgPCB0aGlzLl9wcm9maWxlcy5sZW5ndGg7ICsraSkgeworICAgICAgICAgICAg aWYgKHRoaXMuX3Byb2ZpbGVzW2ldLnVpZCA9PSBwcm9maWxlLnVpZCkgeworICAgICAgICAgICAg ICAgIHByb2ZpbGUgPSB0aGlzLl9wcm9maWxlc1tpXTsKKyAgICAgICAgICAgICAgICB0aGlzLl9w cm9maWxlcy5zcGxpY2UoaSwgMSk7CisgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAg ICB9CisgICAgICAgIH0KKyAgICAgICAgZGVsZXRlIHRoaXMuX3Byb2ZpbGVzSWRNYXBbdGhpcy5f bWFrZUtleShwcm9maWxlLnVpZCwgdHlwZUlkKV07CisKKyAgICAgICAgdmFyIHByb2ZpbGVUaXRs ZUtleSA9IHRoaXMuX21ha2VLZXkocHJvZmlsZS50aXRsZSwgdHlwZUlkKTsKKyAgICAgICAgZGVs ZXRlIHRoaXMuX3Byb2ZpbGVHcm91cHNbcHJvZmlsZVRpdGxlS2V5XTsKKworICAgICAgICBzaWRl YmFyUGFyZW50LnJlbW92ZUNoaWxkKHByb2ZpbGUuX3Byb2ZpbGVzVHJlZUVsZW1lbnQpOwogICAg IH0sCiAKICAgICBzaG93UHJvZmlsZTogZnVuY3Rpb24ocHJvZmlsZSkKICAgICB7Ci0gICAgICAg IGlmICghcHJvZmlsZSkKKyAgICAgICAgaWYgKCFwcm9maWxlIHx8IHByb2ZpbGUuaXNUZW1wb3Jh cnkpCiAgICAgICAgICAgICByZXR1cm47CiAKICAgICAgICAgdGhpcy5jbG9zZVZpc2libGVWaWV3 KCk7CmRpZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVjdG9yLmpz IGIvV2ViQ29yZS9pbnNwZWN0b3IvZnJvbnQtZW5kL2luc3BlY3Rvci5qcwppbmRleCBjNzVkZDlj Li4yYmMzM2ZlIDEwMDY0NAotLS0gYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvaW5zcGVj dG9yLmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9pbnNwZWN0b3IuanMKQEAg LTE0NTcsNiArMTQ1NywyMSBAQCBXZWJJbnNwZWN0b3IuYWRkUHJvZmlsZUhlYWRlciA9IGZ1bmN0 aW9uKHByb2ZpbGUpCiBXZWJJbnNwZWN0b3Iuc2V0UmVjb3JkaW5nUHJvZmlsZSA9IGZ1bmN0aW9u KGlzUHJvZmlsaW5nKQogewogICAgIHRoaXMucGFuZWxzLnByb2ZpbGVzLmdldFByb2ZpbGVUeXBl KFdlYkluc3BlY3Rvci5DUFVQcm9maWxlVHlwZS5UeXBlSWQpLnNldFJlY29yZGluZ1Byb2ZpbGUo aXNQcm9maWxpbmcpOworICAgIGlmICh0aGlzLl9wcmV2aW91c0lzUHJvZmlsaW5nICE9PSBpc1By b2ZpbGluZykgeworICAgICAgICBpZiAoIXRoaXMuX3RlbXBvcmFyeVJlY29yZGluZ1Byb2ZpbGUp IHsKKyAgICAgICAgICAgIHRoaXMuX3RlbXBvcmFyeVJlY29yZGluZ1Byb2ZpbGUgPSB7CisgICAg ICAgICAgICAgICAgdHlwZUlkOiBXZWJJbnNwZWN0b3IuQ1BVUHJvZmlsZVR5cGUuVHlwZUlkLAor ICAgICAgICAgICAgICAgIHRpdGxlOiBXZWJJbnNwZWN0b3IuVUlTdHJpbmcoJ1JlY29yZGluZy4u LicpLAorICAgICAgICAgICAgICAgIHVpZDogLTEsCisgICAgICAgICAgICAgICAgaXNUZW1wb3Jh cnk6IHRydWUgCisgICAgICAgICAgICB9OworICAgICAgICB9CisgICAgICAgIHRoaXMuX3ByZXZp b3VzSXNQcm9maWxpbmcgPSBpc1Byb2ZpbGluZzsKKyAgICAgICAgaWYgKGlzUHJvZmlsaW5nKQor ICAgICAgICAgICAgdGhpcy5wYW5lbHMucHJvZmlsZXMuYWRkUHJvZmlsZUhlYWRlcih0aGlzLl90 ZW1wb3JhcnlSZWNvcmRpbmdQcm9maWxlKTsKKyAgICAgICAgZWxzZQorICAgICAgICAgICAgdGhp cy5wYW5lbHMucHJvZmlsZXMucmVtb3ZlUHJvZmlsZUhlYWRlcih0aGlzLl90ZW1wb3JhcnlSZWNv cmRpbmdQcm9maWxlKTsKKyAgICB9CiAgICAgdGhpcy5wYW5lbHMucHJvZmlsZXMudXBkYXRlUHJv ZmlsZVR5cGVCdXR0b25zKCk7CiB9CiAK