38028 2010-04-22 20:42:13 -0700 [chromium] build-webkit --chromium should build release by default 2010-04-26 18:27:15 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 tony webkit-unassigned levin oldest_to_newest 216253 0 tony 2010-04-22 20:42:13 -0700 [chromium] build-webkit --chromium should build release by default 216254 1 54125 tony 2010-04-22 20:43:39 -0700 Created attachment 54125 Patch 216310 2 54125 abarth 2010-04-23 00:33:32 -0700 Comment on attachment 54125 Patch WebKitTools/Scripts/webkitdirs.pm:  + Why remove this random line? I don't read perl, but this looks plausible. Leaving it for a perl hacker though. 216311 3 tony 2010-04-23 00:34:39 -0700 (In reply to comment #2) > (From update of attachment 54125 [details]) > WebKitTools/Scripts/webkitdirs.pm:  > + > Why remove this random line? Oops, that's an accident. 216314 4 54137 tony 2010-04-23 00:37:03 -0700 Created attachment 54137 Patch 217376 5 levin 2010-04-26 17:31:21 -0700 Why does this only change the Chromium OSX builds (and not the Windows or Linux builds)? 217391 6 tony 2010-04-26 17:47:13 -0700 (In reply to comment #5) > Why does this only change the Chromium OSX builds (and not the Windows or Linux > builds)? Windows and Linux already do the right thing in buildChromiumMakefile and buildChromiumVisualStudioProject. 217417 7 54137 tony 2010-04-26 18:27:06 -0700 Comment on attachment 54137 Patch Clearing flags on attachment: 54137 Committed r58275: <http://trac.webkit.org/changeset/58275> 217418 8 tony 2010-04-26 18:27:15 -0700 All reviewed patches have been landed. Closing bug. 54125 2010-04-22 20:43:39 -0700 2010-04-23 00:36:57 -0700 Patch bug-38028-20100423124337.patch text/plain 2804 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCAxMzY1ZGMzLi41Mzc2YTliIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MjIgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGJ1aWxkLXdlYmtpdCAtLWNo cm9taXVtIHNob3VsZCBidWlsZCByZWxlYXNlIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDI4CisKKyAgICAgICAgKiBTY3JpcHRz L2J1aWxkLWR1bXByZW5kZXJ0cmVlOiBBbHNvIHNob3VsZCBidWlsZCByZWxlYXNlIGJ5IGRlZmF1 bHQKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogTWFrZSBzdXJlIHRvIHBhc3MgY29t bWFuZCBsaW5lIGFyZ3MgdGhyb3VnaAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTog QnVpbGQgdGhlIHJpZ2h0IGNvbmZpZ3VyYXRpb24KKwogMjAxMC0wNC0yMiAgRXJpYyBTZWlkZWwg IDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KZGlm ZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUgYi9XZWJL aXRUb29scy9TY3JpcHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlCmluZGV4IDE0NjkwYTguLjY1MDI5 MTYgMTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUK KysrIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC1kdW1wcmVuZGVydHJlZQpAQCAtNzUsNyAr NzUsNyBAQCBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgJHJlc3VsdCA9IDA7CiB9IGVs c2lmIChpc0Nocm9taXVtKCkpIHsKICAgICBpZiAoaXNEYXJ3aW4oKSkgewotICAgICAgICAkcmVz dWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIkR1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJl ZSIsICRjbGVhbiwgQEFSR1YpOworICAgICAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3Qo IkR1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZSIsICRjbGVhbiwgIi1jb25maWd1cmF0 aW9uIiwgY29uZmlndXJhdGlvbigpLCBAQVJHVik7CiAgICAgfSBlbHNpZiAoaXNDeWd3aW4oKSB8 fCBpc1dpbmRvd3MoKSkgewogICAgICAgICAjIFdpbmRvd3MgYnVpbGQgLSBidWlsZHMgdGhlIHJv b3QgdmlzdWFsIHN0dWRpbyBzb2x1dGlvbi4KICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkQ2hyb21p dW1WaXN1YWxTdHVkaW9Qcm9qZWN0KCJEdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUu c2xuIiwgJGNsZWFuKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Vi a2l0IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggMmQxNzJjNS4uN2E0 NjQxYSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIv V2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTM2Nyw2ICszNjcsNyBAQCBpZiAo aXNXeCgpKSB7CiB9CiAKIGlmIChpc0Nocm9taXVtKCkpIHsKKyAgICBAb3B0aW9ucyA9IEBBUkdW OwogICAgICMgQ2hyb21pdW0gZG9lc24ndCBidWlsZCBieSBwcm9qZWN0IGRpcmVjdG9yaWVzLgog ICAgIEBwcm9qZWN0cyA9ICgpOwogICAgIG15ICRyZXN1bHQgPSBidWlsZENocm9taXVtKCRjbGVh biwgQG9wdGlvbnMpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJz LnBtIGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDBiMTgzNzMuLjc5 MzJmOWUgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysg Yi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTExMDksNyArMTEwOSw2IEBA IHN1YiBidWlsZFhDb2RlUHJvamVjdCgkJEApCiAgICAgICAgIHB1c2goQGV4dHJhT3B0aW9ucywg Ii1hbGx0YXJnZXRzIik7CiAgICAgICAgIHB1c2goQGV4dHJhT3B0aW9ucywgImNsZWFuIik7CiAg ICAgfQotCiAgICAgcmV0dXJuIHN5c3RlbSAieGNvZGVidWlsZCIsICItcHJvamVjdCIsICIkcHJv amVjdC54Y29kZXByb2oiLCBAZXh0cmFPcHRpb25zOwogfQogCkBAIC0xNDc5LDcgKzE0NzgsNyBA QCBzdWIgYnVpbGRDaHJvbWl1bSgkQCkKICAgICBteSAkcmVzdWx0ID0gMTsKICAgICBpZiAoaXNE YXJ3aW4oKSkgewogICAgICAgICAjIE1hYyBidWlsZCAtIGJ1aWxkcyB0aGUgcm9vdCB4Y29kZSBw cm9qZWN0LgotICAgICAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIldlYktpdC9jaHJv bWl1bS9XZWJLaXQiLCAkY2xlYW4sIChAb3B0aW9ucykpOworICAgICAgICAkcmVzdWx0ID0gYnVp bGRYQ29kZVByb2plY3QoIldlYktpdC9jaHJvbWl1bS9XZWJLaXQiLCAkY2xlYW4sICItY29uZmln dXJhdGlvbiIsIGNvbmZpZ3VyYXRpb24oKSwgQG9wdGlvbnMpOwogICAgIH0gZWxzaWYgKGlzQ3ln d2luKCkgfHwgaXNXaW5kb3dzKCkpIHsKICAgICAgICAgIyBXaW5kb3dzIGJ1aWxkIC0gYnVpbGRz IHRoZSByb290IHZpc3VhbCBzdHVkaW8gc29sdXRpb24uCiAgICAgICAgICRyZXN1bHQgPSBidWls ZENocm9taXVtVmlzdWFsU3R1ZGlvUHJvamVjdCgiV2ViS2l0L2Nocm9taXVtL1dlYktpdC5zbG4i LCAkY2xlYW4pOwo= 54137 2010-04-23 00:37:03 -0700 2010-04-26 18:27:06 -0700 Patch bug-38028-20100423163702.patch text/plain 2572 tony ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBkMjk3YjgzLi4yYWJmMjNjIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MjMgIFRvbnkgQ2hhbmcgIDx0b255QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBi eSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbY2hyb21pdW1dIGJ1aWxkLXdlYmtpdCAtLWNo cm9taXVtIHNob3VsZCBidWlsZCByZWxlYXNlIGJ5IGRlZmF1bHQKKyAgICAgICAgaHR0cHM6Ly9i dWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDI4CisKKyAgICAgICAgKiBTY3JpcHRz L2J1aWxkLWR1bXByZW5kZXJ0cmVlOiBBbHNvIHNob3VsZCBidWlsZCByZWxlYXNlIGJ5IGRlZmF1 bHQKKyAgICAgICAgKiBTY3JpcHRzL2J1aWxkLXdlYmtpdDogTWFrZSBzdXJlIHRvIHBhc3MgY29t bWFuZCBsaW5lIGFyZ3MgdGhyb3VnaAorICAgICAgICAqIFNjcmlwdHMvd2Via2l0ZGlycy5wbTog QnVpbGQgdGhlIHJpZ2h0IGNvbmZpZ3VyYXRpb24KKwogMjAxMC0wNC0yMiAgRnVtaXRvc2hpIFVr YWkgIDx1a2FpQGNocm9taXVtLm9yZz4KIAogICAgICAgICBVbnJldmlld2VkIGZpeC4KZGlmZiAt LWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUgYi9XZWJLaXRU b29scy9TY3JpcHRzL2J1aWxkLWR1bXByZW5kZXJ0cmVlCmluZGV4IDE0NjkwYTguLjY1MDI5MTYg MTAwNzU1Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtZHVtcHJlbmRlcnRyZWUKKysr IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC1kdW1wcmVuZGVydHJlZQpAQCAtNzUsNyArNzUs NyBAQCBpZiAoaXNBcHBsZU1hY1dlYktpdCgpKSB7CiAgICAgJHJlc3VsdCA9IDA7CiB9IGVsc2lm IChpc0Nocm9taXVtKCkpIHsKICAgICBpZiAoaXNEYXJ3aW4oKSkgewotICAgICAgICAkcmVzdWx0 ID0gYnVpbGRYQ29kZVByb2plY3QoIkR1bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZSIs ICRjbGVhbiwgQEFSR1YpOworICAgICAgICAkcmVzdWx0ID0gYnVpbGRYQ29kZVByb2plY3QoIkR1 bXBSZW5kZXJUcmVlLmd5cC9EdW1wUmVuZGVyVHJlZSIsICRjbGVhbiwgIi1jb25maWd1cmF0aW9u IiwgY29uZmlndXJhdGlvbigpLCBAQVJHVik7CiAgICAgfSBlbHNpZiAoaXNDeWd3aW4oKSB8fCBp c1dpbmRvd3MoKSkgewogICAgICAgICAjIFdpbmRvd3MgYnVpbGQgLSBidWlsZHMgdGhlIHJvb3Qg dmlzdWFsIHN0dWRpbyBzb2x1dGlvbi4KICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkQ2hyb21pdW1W aXN1YWxTdHVkaW9Qcm9qZWN0KCJEdW1wUmVuZGVyVHJlZS5neXAvRHVtcFJlbmRlclRyZWUuc2xu IiwgJGNsZWFuKTsKZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL1NjcmlwdHMvYnVpbGQtd2Via2l0 IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKaW5kZXggMmQxNzJjNS4uN2E0NjQx YSAxMDA3NTUKLS0tIGEvV2ViS2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKKysrIGIvV2Vi S2l0VG9vbHMvU2NyaXB0cy9idWlsZC13ZWJraXQKQEAgLTM2Nyw2ICszNjcsNyBAQCBpZiAoaXNX eCgpKSB7CiB9CiAKIGlmIChpc0Nocm9taXVtKCkpIHsKKyAgICBAb3B0aW9ucyA9IEBBUkdWOwog ICAgICMgQ2hyb21pdW0gZG9lc24ndCBidWlsZCBieSBwcm9qZWN0IGRpcmVjdG9yaWVzLgogICAg IEBwcm9qZWN0cyA9ICgpOwogICAgIG15ICRyZXN1bHQgPSBidWlsZENocm9taXVtKCRjbGVhbiwg QG9wdGlvbnMpOwpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBt IGIvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRkaXJzLnBtCmluZGV4IDBiMTgzNzMuLjZmM2Nh OTYgMTAwNjQ0Ci0tLSBhL1dlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0ZGlycy5wbQorKysgYi9X ZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdGRpcnMucG0KQEAgLTE0NzksNyArMTQ3OSw3IEBAIHN1 YiBidWlsZENocm9taXVtKCRAKQogICAgIG15ICRyZXN1bHQgPSAxOwogICAgIGlmIChpc0Rhcndp bigpKSB7CiAgICAgICAgICMgTWFjIGJ1aWxkIC0gYnVpbGRzIHRoZSByb290IHhjb2RlIHByb2pl Y3QuCi0gICAgICAgICRyZXN1bHQgPSBidWlsZFhDb2RlUHJvamVjdCgiV2ViS2l0L2Nocm9taXVt L1dlYktpdCIsICRjbGVhbiwgKEBvcHRpb25zKSk7CisgICAgICAgICRyZXN1bHQgPSBidWlsZFhD b2RlUHJvamVjdCgiV2ViS2l0L2Nocm9taXVtL1dlYktpdCIsICRjbGVhbiwgIi1jb25maWd1cmF0 aW9uIiwgY29uZmlndXJhdGlvbigpLCBAb3B0aW9ucyk7CiAgICAgfSBlbHNpZiAoaXNDeWd3aW4o KSB8fCBpc1dpbmRvd3MoKSkgewogICAgICAgICAjIFdpbmRvd3MgYnVpbGQgLSBidWlsZHMgdGhl IHJvb3QgdmlzdWFsIHN0dWRpbyBzb2x1dGlvbi4KICAgICAgICAgJHJlc3VsdCA9IGJ1aWxkQ2hy b21pdW1WaXN1YWxTdHVkaW9Qcm9qZWN0KCJXZWJLaXQvY2hyb21pdW0vV2ViS2l0LnNsbiIsICRj bGVhbik7Cg==