38026 2010-04-22 20:12:01 -0700 [Qt] Disable Netscape plugin support for minimal configuration 2010-04-23 14:06:52 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 1 laszlo.gombos webkit-unassigned abarth commit-queue eric webkit.review.bot oldest_to_newest 216241 0 laszlo.gombos 2010-04-22 20:12:01 -0700 Now that we have a "minimal" buildbot for QtWebKit and NPAPI-less configuration is often broken, it could be a real win to disable NPAPI for minimal configuration so that we get an immediate build-break. 216245 1 54124 laszlo.gombos 2010-04-22 20:27:10 -0700 Created attachment 54124 proposed patch This patch make the minimal configuration option visible in the Qt make system, which could be useful later as well. An alternative to this patch is to create a global "npapi support" build option to build-webkit, but as many ports do not support this option,I felt it is best to do it for the Qt port only. 216491 2 54124 commit-queue 2010-04-23 11:31:48 -0700 Comment on attachment 54124 proposed patch Clearing flags on attachment: 54124 Committed r58178: <http://trac.webkit.org/changeset/58178> 216492 3 commit-queue 2010-04-23 11:31:54 -0700 All reviewed patches have been landed. Closing bug. 216497 4 webkit.review.bot 2010-04-23 11:43:42 -0700 http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release minimal 216504 5 vestbo 2010-04-23 12:14:13 -0700 Any reason you didn't add it as a normal enable/disable option to build-webkit so that the --minimal option would do this automatically? 216507 6 vestbo 2010-04-23 12:17:14 -0700 (In reply to comment #1) > An alternative to this patch is to create a global "npapi support" build option > to build-webkit, but as many ports do not support this option,I felt it is best > to do it for the Qt port only. Never mind, didn't see this comment. If we can I'd rather we move this to a global option if possible. 216551 7 laszlo.gombos 2010-04-23 14:06:52 -0700 (In reply to comment #4) > http://trac.webkit.org/changeset/58178 might have broken Qt Linux Release > minimal Dependency problems with the bot, bug filed - bug 38054 54124 2010-04-22 20:27:10 -0700 2010-04-23 11:31:48 -0700 proposed patch 38026.patch text/plain 2272 laszlo.gombos SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODE0MikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjIgIExhc3psbyBHb21ib3MgIDxsYXN6bG8uMS5nb21i b3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisg ICAgICAgIFtRdF0gRGlzYWJsZSBOZXRzY2FwZSBwbHVnaW4gc3VwcG9ydCBmb3IgbWluaW1hbCBj b25maWd1cmF0aW9uCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNn aT9pZD0zODAyNgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYXMgdGhlcmUgaXMgbm8gbmV3IGZ1 bmN0aW9uYWxpdHkuCisKKyAgICAgICAgKiBXZWJDb3JlLnByaToKKwogMjAxMC0wNC0yMiAgWmhl bnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEZp c2hlci4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5wcmkKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9X ZWJDb3JlLnByaQkocmV2aXNpb24gNTgxMzgpCisrKyBXZWJDb3JlL1dlYkNvcmUucHJpCSh3b3Jr aW5nIGNvcHkpCkBAIC00LDYgKzQsMTAgQEAgQ09ORklHKHN0YW5kYWxvbmVfcGFja2FnZSkgewog ICAgIGlzRW1wdHkoV0NfR0VORVJBVEVEX1NPVVJDRVNfRElSKTpXQ19HRU5FUkFURURfU09VUkNF U19ESVIgPSBnZW5lcmF0ZWQKIH0KIAorQ09ORklHKG1pbmltYWwpIHsKKyAgREVGSU5FUyArPSBF TkFCTEVfTkVUU0NBUEVfUExVR0lOX0FQST0wCit9CisKICMjIERlZmluZSBkZWZhdWx0IGZlYXR1 cmVzIG1hY3JvcyBmb3Igb3B0aW9uYWwgY29tcG9uZW50cwogIyMgKGxvb2sgZm9yIGRlZnMgaW4g Y29uZmlnLmggYW5kIGluY2x1ZGVkIGZpbGVzISkKICMgVHJ5IHRvIGxvY2F0ZSBzcWxpdGUzIHNv dXJjZQpJbmRleDogV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdFRv b2xzL0NoYW5nZUxvZwkocmV2aXNpb24gNTgxNDIpCisrKyBXZWJLaXRUb29scy9DaGFuZ2VMb2cJ KHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNSBAQAorMjAxMC0wNC0yMiAgTGFzemxvIEdvbWJv cyAgPGxhc3psby4xLmdvbWJvc0Bub2tpYS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9C T0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0XSBEaXNhYmxlIE5ldHNjYXBlIHBsdWdpbiBzdXBw b3J0IGZvciBtaW5pbWFsIGNvbmZpZ3VyYXRpb24KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtp dC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDI2CisKKyAgICAgICAgUGFzcyB0aGUgbWluaW1hbCBj b25maWd1cmF0aW9uIG9wdGlvbiB0byBRdCBidWlsZCBzeXN0ZW0gCisgICAgICAgIGFzIHBhcnQg b2YgdGhlIENPTkZJRyB2YXJpYWJsZS4KKworICAgICAgICAqIFNjcmlwdHMvYnVpbGQtd2Via2l0 OgorCiAyMDEwLTA0LTIyICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4KIAogICAgICAg ICBSZXZpZXdlZCBieSBEaW1pdHJpIEdsYXprb3YuCkluZGV4OiBXZWJLaXRUb29scy9TY3JpcHRz L2J1aWxkLXdlYmtpdAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdl YmtpdAkocmV2aXNpb24gNTgxMzgpCisrKyBXZWJLaXRUb29scy9TY3JpcHRzL2J1aWxkLXdlYmtp dAkod29ya2luZyBjb3B5KQpAQCAtMzUwLDYgKzM1MCwxMCBAQCBpZiAoaXNHdGsoKSkgewogICAg IGZvcmVhY2ggKEBmZWF0dXJlcykgewogICAgICAgICBwdXNoIEBvcHRpb25zLCAiREVGSU5FUys9 JF8tPntkZWZpbmV9PSR7JF8tPnt2YWx1ZX19IiBpZiAkeyRfLT57dmFsdWV9fSAhPSAkXy0+e2Rl ZmF1bHR9OwogICAgIH0KKyAgICAKKyAgICBpZiAoJG1pbmltYWwpIHsKKyAgICAgICAgcHVzaCBA b3B0aW9ucywgIkNPTkZJRys9bWluaW1hbCI7CisgICAgfQogfQogCiAjIEZvcmNlIHJlLWxpbmsg b2YgZXhpc3RpbmcgbGlicmFyaWVzIGlmIGRpZmZlcmVudCB0aGFuIGV4cGVjdGVkCg==