38021 2010-04-22 18:27:33 -0700 complete rietveld bugzilla integration 2010-08-19 13:49:08 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) PC OS X 10.5 RESOLVED WONTFIX P2 Normal --- 38162 1 ojan ojan abarth atwilson eric jamesr jparent levin slightlyoff webkit.review.bot oldest_to_newest 216203 0 ojan 2010-04-22 18:27:33 -0700 We've gotten all the feedback we're going to get without moving forward. So, I think we should take the next steps. Some options: 1. Make --fancy-review the default. Pro: People who have the chrome extension installed and start doing real reviews and find the bugs. Con: Upload takes longer 2. Move the extension code into bugzilla. 3. Make upload put the rietveld issue in the ChangeLog so we can upload to the same issue instead of creating a new one each time. Ideally we'd start working on all three of these immediately. 1 is the simplest. I volunteer to do that assuming there are no objections. Once we've done 1, that will let us get a better sense of what the outstanding issues are with the upload/reitveld process. Sound OK? 216511 1 abarth 2010-04-23 12:30:03 -0700 Sounds good to me. 217194 2 54319 ojan 2010-04-26 11:09:44 -0700 Created attachment 54319 Patch-11001 217259 3 eric 2010-04-26 14:02:23 -0700 I'm not sure I like that this is going to put rietveld bug review links in every bug I upload. 217268 4 ojan 2010-04-26 14:10:45 -0700 (In reply to comment #3) > I'm not sure I like that this is going to put rietveld bug review links in > every bug I upload. All it does is append the rietveld issue id to the patch description. It only shows a rietveld review link if you have the chrome extension installed. It no longer appends a review link to the bug comments, ever. 217269 5 ojan 2010-04-26 14:11:20 -0700 Note that I uploaded this patch using --fancy-review, so this bug is a good example of what will change (i.e. very little). 217273 6 54319 eric 2010-04-26 14:16:09 -0700 Comment on attachment 54319 Patch-11001 Woh, ok. We probably need to change the description name slightly. 217298 7 ojan 2010-04-26 14:52:50 -0700 Committed r58265: <http://trac.webkit.org/changeset/58265> 217305 8 ojan 2010-04-26 14:59:53 -0700 Filed bug 38143 and bug 38144 for items 2 and 3 above. 217468 9 abarth 2010-04-26 20:36:15 -0700 Reverted r58265 for reason: This change prevents me from uploading patches Committed r58282: <http://trac.webkit.org/changeset/58282> 217480 10 webkit.review.bot 2010-04-26 21:08:29 -0700 http://trac.webkit.org/changeset/58282 might have broken SnowLeopard Intel Release (Tests) The following changes are on the blame list: http://trac.webkit.org/changeset/58281 http://trac.webkit.org/changeset/58282 217711 11 ojan 2010-04-27 08:16:45 -0700 (In reply to comment #9) > This change prevents me from uploading patches Ugh. Sorry this broke you. What was the error you were getting? Also, how did it break sheriffbot? 219997 12 eric 2010-05-02 19:38:50 -0700 Attachment 54319 was posted by a committer and has review+, assigning to Ojan Vafai for commit. 220008 13 54319 ojan 2010-05-02 21:08:43 -0700 Comment on attachment 54319 Patch-11001 This has been committed and rolled back. 266936 14 ojan 2010-08-19 13:49:08 -0700 This is obsolete. The rietveld work is going on in different patches. 54319 2010-04-26 11:09:44 -0700 2010-06-11 11:51:15 -0700 Patch-11001 bug-38021-20100426110943.patch text/plain 2302 ojan ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBhMmYzMmZlNTY5MzZkZDcyMjRjZWU4M2Q3YWE2ZDU4OGJjZDA3M2RmLi43ZmE3Y2I2 ZjM5MWJhMWU2NGU1NTVmNWIxNDRmMzcyZDUxMjA2NzFlIDEwMDY0NAotLS0gYS9XZWJLaXRUb29s cy9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDQtMjYgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBjb21wbGV0ZSByaWV0dmVsZCBi dWd6aWxsYSBpbnRlZ3JhdGlvbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93 X2J1Zy5jZ2k/aWQ9MzgwMjEKKworICAgICAgICBNYWtlcyAtLWZhbmN5LXJldmlldyB0aGUgZGVm YXVsdC4gQWxsIHRoaXMgbWVhbnMgaXMgdGhhdCB0aGUgcGF0Y2ggd2lsbAorICAgICAgICBiZSB1 cGxvYWRlZCB0byByaWV0dmVsZCBpbiBhZGRpdGlvbiB0byBidWdzLndlYmtpdC5vcmcuIAorCisg ICAgICAgICogU2NyaXB0cy93ZWJraXRweS90b29sL3N0ZXBzL29wdGlvbnMucHk6CisKIDIwMTAt MDQtMDYgIE9qYW4gVmFmYWkgIDxvamFuQGNocm9taXVtLm9yZz4KIAogICAgICAgICBSZXZpZXdl ZCBieSBBZGFtIEJhcnRoLgpkaWZmIC0tZ2l0IGEvV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS90b29sL3N0ZXBzL29wdGlvbnMucHkgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rv b2wvc3RlcHMvb3B0aW9ucy5weQppbmRleCA1MjRhMjUyOThlM2IzZGZkMDc2ZjJhZTEzNjRmNTI2 Y2RmYjAwOTgyLi42Mjc5NDE2ZjhhZDNjYzdkMzhhMzNmNmQ0NDZlNjZlNzAzZGViM2M1IDEwMDY0 NAotLS0gYS9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvb3B0aW9ucy5w eQorKysgYi9XZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L3Rvb2wvc3RlcHMvb3B0aW9ucy5w eQpAQCAtNDAsNyArNDAsNyBAQCBjbGFzcyBPcHRpb25zKG9iamVjdCk6CiAgICAgY29uZmlybSA9 IG1ha2Vfb3B0aW9uKCItLW5vLWNvbmZpcm0iLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwgZGVzdD0i Y29uZmlybSIsIGRlZmF1bHQ9VHJ1ZSwgaGVscD0iU2tpcCBjb25maXJtYXRpb24gc3RlcHMuIikK ICAgICBkZXNjcmlwdGlvbiA9IG1ha2Vfb3B0aW9uKCItbSIsICItLWRlc2NyaXB0aW9uIiwgYWN0 aW9uPSJzdG9yZSIsIHR5cGU9InN0cmluZyIsIGRlc3Q9ImRlc2NyaXB0aW9uIiwgaGVscD0iRGVz Y3JpcHRpb24gc3RyaW5nIGZvciB0aGUgYXR0YWNobWVudCAoZGVmYXVsdDogXCJwYXRjaFwiKSIp CiAgICAgZW1haWwgPSBtYWtlX29wdGlvbigiLS1lbWFpbCIsIGFjdGlvbj0ic3RvcmUiLCB0eXBl PSJzdHJpbmciLCBkZXN0PSJlbWFpbCIsIGhlbHA9IkVtYWlsIGFkZHJlc3MgdG8gdXNlIGluIENo YW5nZUxvZ3MuIikKLSAgICBmYW5jeV9yZXZpZXcgPSBtYWtlX29wdGlvbigiLS1mYW5jeS1yZXZp ZXciLCBhY3Rpb249InN0b3JlX3RydWUiLCBkZXN0PSJmYW5jeV9yZXZpZXciLCBkZWZhdWx0PUZh bHNlLCBoZWxwPSIoRXhwZXJpbWVudGFsKSBVcGxvYWQgdGhlIHBhdGNoIHRvIFJpZXR2ZWxkIGNv ZGUgcmV2aWV3IHRvb2wuIikKKyAgICBmYW5jeV9yZXZpZXcgPSBtYWtlX29wdGlvbigiLS1uby1m YW5jeS1yZXZpZXciLCBhY3Rpb249InN0b3JlX2ZhbHNlIiwgZGVzdD0iZmFuY3lfcmV2aWV3Iiwg ZGVmYXVsdD1UcnVlLCBoZWxwPSJEbyBub3QgdXBsb2FkIHRoZSBwYXRjaCB0byBSaWV0dmVsZCBj b2RlIHJldmlldyB0b29sLiIpCiAgICAgZm9yY2VfY2xlYW4gPSBtYWtlX29wdGlvbigiLS1mb3Jj ZS1jbGVhbiIsIGFjdGlvbj0ic3RvcmVfdHJ1ZSIsIGRlc3Q9ImZvcmNlX2NsZWFuIiwgZGVmYXVs dD1GYWxzZSwgaGVscD0iQ2xlYW4gd29ya2luZyBkaXJlY3RvcnkgYmVmb3JlIGFwcGx5aW5nIHBh dGNoZXMgKHJlbW92ZXMgbG9jYWwgY2hhbmdlcyBhbmQgY29tbWl0cykiKQogIyBGSVhNRTogTWFr ZSBjb21taXQgcmFuZ2VzIHRyZWF0IGVhY2ggY29tbWl0IHNlcGFyYXRlbHkgaW5zdGVhZCBvZiBz cXVhc2hpbmcgdGhlbSBpbnRvIG9uZS4KICAgICBnaXRfY29tbWl0ID0gbWFrZV9vcHRpb24oIi0t Z2l0LWNvbW1pdCIsIGFjdGlvbj0ic3RvcmUiLCBkZXN0PSJnaXRfY29tbWl0IiwgaGVscD0iTG9j YWwgZ2l0IGNvbW1pdCB0byB1cGxvYWQvbGFuZC4gSWYgYSByYW5nZSwgdGhlIGNvbW1pdHMgYXJl IHNxdWFzaGVkIGludG8gb25lLiIpCg==