38017 2010-04-22 17:50:09 -0700 CompositeAnimation::updateKeyframeAnimations() can make a KeyframeAnimation for animation "none" 2010-04-23 13:23:24 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser cmarrin oldest_to_newest 216190 0 simon.fraser 2010-04-22 17:50:09 -0700 Code ni CompositeAnimation::updateKeyframeAnimations() makes KeyframeAnimation objects when the animation-name is "none" (which explicitly should not animate anything). 216450 1 54169 simon.fraser 2010-04-23 09:49:11 -0700 Created attachment 54169 Patch 216480 2 54169 mitz 2010-04-23 11:04:08 -0700 Comment on attachment 54169 Patch You could add an explanation for the lack of a regression test. 216538 3 simon.fraser 2010-04-23 13:23:24 -0700 http://trac.webkit.org/changeset/58185 54169 2010-04-23 09:49:11 -0700 2010-04-23 11:04:08 -0700 Patch bug-38017-20100423094910.patch text/plain 2128 simon.fraser ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MWZhMWY2Yi4uMTc2MDdkNSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMyAgU2ltb24gRnJhc2Vy ICA8c2ltb24uZnJhc2VyQGFwcGxlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkg KE9PUFMhKS4KKworICAgICAgICBDb21wb3NpdGVBbmltYXRpb246OnVwZGF0ZUtleWZyYW1lQW5p bWF0aW9ucygpIGNhbiBtYWtlIGEgS2V5ZnJhbWVBbmltYXRpb24gZm9yIGFuaW1hdGlvbiAibm9u ZSIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDE3 CisKKyAgICAgICAgQ2hlY2sgdG8gc2VlIGlmIHRoZSBhbmltYXRpb24gbmFtZSBpcyAibm9uZSIs IGFuZCBkb24ndCBmaXJlIG9mZiBhIGtleWZyYW1lIGFuaW1hdGlvbiBpbgorICAgICAgICB0aGF0 IGNhc2UuCisKKyAgICAgICAgKiBwYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uY3Bw OgorICAgICAgICAoV2ViQ29yZTo6Q29tcG9zaXRlQW5pbWF0aW9uOjp1cGRhdGVLZXlmcmFtZUFu aW1hdGlvbnMpOgorCiAyMDEwLTA0LTIyICBaaGVueWFvIE1vICA8em1vQGdvb2dsZS5jb20+CiAK ICAgICAgICAgUmV2aWV3ZWQgYnkgRGltaXRyaSBHbGF6a292LgpkaWZmIC0tZ2l0IGEvV2ViQ29y ZS9wYWdlL2FuaW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uY3BwIGIvV2ViQ29yZS9wYWdlL2Fu aW1hdGlvbi9Db21wb3NpdGVBbmltYXRpb24uY3BwCmluZGV4IDBmMjM4ZmQuLjc2MTliMWYgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvcGFnZS9hbmltYXRpb24vQ29tcG9zaXRlQW5pbWF0aW9uLmNwcAor KysgYi9XZWJDb3JlL3BhZ2UvYW5pbWF0aW9uL0NvbXBvc2l0ZUFuaW1hdGlvbi5jcHAKQEAgLTIw NSw2ICsyMDUsOCBAQCB2b2lkIENvbXBvc2l0ZUFuaW1hdGlvbjo6dXBkYXRlS2V5ZnJhbWVBbmlt YXRpb25zKFJlbmRlck9iamVjdCogcmVuZGVyZXIsIFJlbmRlcgogICAgICAgICAgICAgCiAgICAg ICAgIC8vIFRvc3MgdGhlIGFuaW1hdGlvbiBvcmRlciBtYXAuCiAgICAgICAgIG1fa2V5ZnJhbWVB bmltYXRpb25PcmRlck1hcC5jbGVhcigpOworCisgICAgICAgIERFRklORV9TVEFUSUNfTE9DQUwo Y29uc3QgQXRvbWljU3RyaW5nLCBub25lLCAoIm5vbmUiKSk7CiAgICAgICAgIAogICAgICAgICAv LyBOb3cgbWFyayBhbnkgc3RpbGwgYWN0aXZlIGFuaW1hdGlvbnMgYXMgYWN0aXZlIGFuZCBhZGQg YW55IG5ldyBhbmltYXRpb25zLgogICAgICAgICBpZiAodGFyZ2V0U3R5bGUtPmFuaW1hdGlvbnMo KSkgewpAQCAtMjMyLDcgKzIzNCw3IEBAIHZvaWQgQ29tcG9zaXRlQW5pbWF0aW9uOjp1cGRhdGVL ZXlmcmFtZUFuaW1hdGlvbnMoUmVuZGVyT2JqZWN0KiByZW5kZXJlciwgUmVuZGVyCiAgICAgICAg ICAgICAgICAgICAgIC8vIFNldCB0aGUgc2F2ZWQgYW5pbWF0aW9uIHRvIHRoaXMgbmV3IG9uZSwg anVzdCBpbiBjYXNlIHRoZSBwbGF5IHN0YXRlIGhhcyBjaGFuZ2VkLgogICAgICAgICAgICAgICAg ICAgICBrZXlmcmFtZUFuaW0tPnNldEFuaW1hdGlvbihhbmltKTsKICAgICAgICAgICAgICAgICAg ICAga2V5ZnJhbWVBbmltLT5zZXRJbmRleChpKTsKLSAgICAgICAgICAgICAgICB9IGVsc2UgaWYg KChhbmltLT5kdXJhdGlvbigpIHx8IGFuaW0tPmRlbGF5KCkpICYmIGFuaW0tPml0ZXJhdGlvbkNv dW50KCkpIHsKKyAgICAgICAgICAgICAgICB9IGVsc2UgaWYgKChhbmltLT5kdXJhdGlvbigpIHx8 IGFuaW0tPmRlbGF5KCkpICYmIGFuaW0tPml0ZXJhdGlvbkNvdW50KCkgJiYgYW5pbWF0aW9uTmFt ZSAhPSBub25lKSB7CiAgICAgICAgICAgICAgICAgICAgIGtleWZyYW1lQW5pbSA9IEtleWZyYW1l QW5pbWF0aW9uOjpjcmVhdGUoY29uc3RfY2FzdDxBbmltYXRpb24qPihhbmltKSwgcmVuZGVyZXIs IGksIHRoaXMsIHRhcmdldFN0eWxlKTsKICAgICAgICAgICAgICAgICAgICAgbV9rZXlmcmFtZUFu aW1hdGlvbnMuc2V0KGtleWZyYW1lQW5pbS0+bmFtZSgpLmltcGwoKSwga2V5ZnJhbWVBbmltKTsK ICAgICAgICAgICAgICAgICB9Cg==