38008 2010-04-22 15:34:51 -0700 [chromium] Skia needs to fade DragImages 2010-05-02 00:01:48 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC All RESOLVED FIXED P2 Normal --- 1 estade webkit-unassigned commit-queue eric evan oldest_to_newest 216106 0 estade 2010-04-22 15:34:51 -0700 linux chrome side: http://codereview.chromium.org/1756008/show 216110 1 54100 estade 2010-04-22 15:40:51 -0700 Created attachment 54100 try1 216116 2 evan 2010-04-22 15:46:10 -0700 changelog has your lowercase tag name stuff in it 216142 3 54105 estade 2010-04-22 16:17:42 -0700 Created attachment 54105 clean up changelog 218034 4 54105 levin 2010-04-27 16:31:53 -0700 Comment on attachment 54105 clean up changelog r- for swapping the x and y variable names. WebCore/platform/chromium/DragImageChromiumSkia.cpp:79 + for (int x = 0; x < image->height(); ++x) { y for height and x for width would be more typical. I thought the params passed to getaddr32 were reversed and then realized it was the naming. WebKit/chromium/tests/DragImageTest.cpp:  + // This is not implemented, so we don't do any output validation. And why don't we do any validation now? WebKit/chromium/ChangeLog:9 + (WebCore::TEST): This isn't really correct. It is typically the function name. WebKit/chromium/ChangeLog:6 + additional tests This feels lacking. Perhaps it would be just as well to omit this text. 218041 5 estade 2010-04-27 16:47:51 -0700 (In reply to comment #4) > (From update of attachment 54105 [details]) > r- for swapping the x and y variable names. > > WebCore/platform/chromium/DragImageChromiumSkia.cpp:79 > + for (int x = 0; x < image->height(); ++x) { > y for height and x for width would be more typical. I thought the params passed > to getaddr32 were reversed and then realized it was the naming. oops. will fix. > > WebKit/chromium/tests/DragImageTest.cpp:  > + // This is not implemented, so we don't do any output validation. > And why don't we do any validation now? well, a couple reasons. First, there is no DragImage function for checking the value of an individual pixel (so checking pixel values wouldn't be portable across platforms) Second, different platforms may want to handle this function differently, since it is purely aesthetic. I implemented it literally according to the function name, but I think other platforms (particularly mac) might want to do something cooler (like <http://chromium.googlecode.com/issues/attachment?aid=6416915653984701464&name=expected_result.png&inline=1>). Third, pixel tests seem to be a path to pain in general (as you can see with pixel layout tests: trivially correct changes require rebaselining). > > WebKit/chromium/ChangeLog:9 > + (WebCore::TEST): > This isn't really correct. It is typically the function name. I guess the prepare-changelog script doesn't deal well with macros. Should I replace it with a TestGroup.TestCase style name? > > WebKit/chromium/ChangeLog:6 > + additional tests > This feels lacking. Perhaps it would be just as well to omit this text. ok 218684 6 54635 estade 2010-04-28 16:04:00 -0700 Created attachment 54635 review feedback 218740 7 54635 levin 2010-04-28 18:15:56 -0700 Comment on attachment 54635 review feedback Loved x and y just had a problem with them being reversed. Sorry, but I couldn't parse r and c until you told me it stood for row and column (so use either x and y or row and column). 218742 8 54653 estade 2010-04-28 18:20:06 -0700 Created attachment 54653 r->row, c->column 218927 9 54653 commit-queue 2010-04-29 03:14:57 -0700 Comment on attachment 54653 r->row, c->column Rejecting patch 54653 from commit-queue. Unexpected failure when landing patch! Please file a bug against webkit-patch. Failed to run "['./WebKitTools/Scripts/webkit-patch', '--status-host=webkit-commit-queue.appspot.com', 'land-attachment', '--force-clean', '--build', '--test', '--non-interactive', '--ignore-builders', '--build-style=both', '--quiet', 54653, '--parent-command=commit-queue', '--no-update']" exit_code: 1 Logging in as eseidel@chromium.org... Fetching: https://bugs.webkit.org/attachment.cgi?id=54653&action=edit Fetching: https://bugs.webkit.org/show_bug.cgi?id=38008&ctype=xml Processing 1 patch from 1 bug. Cleaning working directory Processing patch 54653 from bug 38008. ERROR: /Users/eseidel/Projects/CommitQueue/WebKit/chromium/ChangeLog neither lists a valid reviewer nor contains the string "Unreviewed" or "Rubber stamp" (case insensitive). 219114 10 54722 estade 2010-04-29 11:28:13 -0700 Created attachment 54722 so I managed to bungle the changelog 219292 11 54722 levin 2010-04-29 17:22:59 -0700 Comment on attachment 54722 so I managed to bungle the changelog If this doesn't require a re-review, i.e. it is just some ChangeLog fix that you'd do by hand and then submit if you were doing it on your local machine, then don't put it up to re-review and use the time of reviewers that would be spent reviewing other patches :( I suspect you are doing this to use this commit queue. Here's how you can do this: Adjust the patch as if you were going to commit it (Change the "Reviewed by NOBODY (OOPS!)." to whoever reviewed it) and then put the patch in the bug and only mark it as cq+ (but leave the review field blank). 219295 12 eric 2010-04-29 17:29:10 -0700 Webkit-patch land-safely will set the reviewer in the changelog for you and the post your partch with cq+ Basically it does exactly what dave said. Except automatically. :) 219296 13 54761 estade 2010-04-29 17:30:08 -0700 Created attachment 54761 doing as I'm told 219783 14 54761 commit-queue 2010-05-02 00:01:40 -0700 Comment on attachment 54761 doing as I'm told Clearing flags on attachment: 54761 Committed r58641: <http://trac.webkit.org/changeset/58641> 219784 15 commit-queue 2010-05-02 00:01:48 -0700 All reviewed patches have been landed. Closing bug. 54100 2010-04-22 15:40:51 -0700 2010-04-22 16:17:42 -0700 try1 dragfade.diff text/plain 5358 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWEwYzgxOS4uYTAyNDA3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMiAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKwor ICAgICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3Nv bHZlRHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAx MC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBU aWdlciBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Ry YWdJbWFnZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJ bWFnZUNocm9taXVtU2tpYS5jcHAKaW5kZXggMjRiZDhmZC4uNzc0M2YyZCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnSW1hZ2VDaHJvbWl1bVNraWEuY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcApAQCAt NjgsOSArNjgsMjYgQEAgRHJhZ0ltYWdlUmVmIHNjYWxlRHJhZ0ltYWdlKERyYWdJbWFnZVJlZiBp bWFnZSwgRmxvYXRTaXplIHNjYWxlKQogICAgIHJldHVybiBzY2FsZWRJbWFnZTsKIH0KIAotRHJh Z0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2Us IGZsb2F0KQorRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1h Z2VSZWYgaW1hZ2UsIGZsb2F0IGZyYWN0aW9uKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgaWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpbWFnZS0+c2V0SXNPcGFx dWUoZmFsc2UpOworICAgIGltYWdlLT5sb2NrUGl4ZWxzKCk7CisKKyAgICBmb3IgKGludCB4ID0g MDsgeCA8IGltYWdlLT5oZWlnaHQoKTsgKyt4KSB7CisgICAgICAgIGZvciAoaW50IHkgPSAwOyB5 IDwgaW1hZ2UtPndpZHRoKCk7ICsreSkgeworICAgICAgICAgICAgdWludDMyX3QqIHBpeGVsID0g aW1hZ2UtPmdldEFkZHIzMih5LCB4KTsKKyAgICAgICAgICAgICpwaXhlbCA9IFNrUHJlTXVsdGlw bHlBUkdCKFNrQ29sb3JHZXRBKCpwaXhlbCkgKiBmcmFjdGlvbiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFNrQ29sb3JHZXRSKCpwaXhlbCksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBTa0NvbG9yR2V0RygqcGl4ZWwpLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tDb2xvckdldEIoKnBpeGVsKSk7CisgICAg ICAgIH0KKyAgICB9CisKKyAgICBpbWFnZS0+dW5sb2NrUGl4ZWxzKCk7CisKICAgICByZXR1cm4g aW1hZ2U7CiB9CiAKQEAgLTgwLDcgKzk3LDEyIEBAIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1h Z2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdlKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIE5hdGl2 ZUltYWdlU2tpYSogYml0bWFwID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7 Ci0gICAgcmV0dXJuIGJpdG1hcCA/IG5ldyBTa0JpdG1hcCgqYml0bWFwKSA6IDA7CisgICAgaWYg KCFiaXRtYXApCisgICAgICAgIHJldHVybiAwOworCisgICAgU2tCaXRtYXAqIGRyYWdJbWFnZSA9 IG5ldyBTa0JpdG1hcCgpOworICAgIGJpdG1hcC0+Y29weVRvKGRyYWdJbWFnZSwgU2tCaXRtYXA6 OmtBUkdCXzg4ODhfQ29uZmlnKTsKKyAgICByZXR1cm4gZHJhZ0ltYWdlOwogfQogCiBEcmFnSW1h Z2VSZWYgY3JlYXRlRHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlKENhY2hlZEltYWdlKikKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCmluZGV4IGJiYmEyMDguLmU5NGQ4OGQgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDQw IEBACisyMDEwLTA0LTIyICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIFNraWEgbmVlZHMgdG8gZmFkZSBEcmFnSW1hZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODAwOAorCisgICAgICAgIGFk ZGl0aW9uYWwgdGVzdHMKKworICAgICAgICAqIHNyYy9XZWJQYWdlU2VyaWFsaXplci5jcHA6Cisg ICAgICAgIChXZWJLaXQ6OldlYlBhZ2VTZXJpYWxpemVyOjpnZW5lcmF0ZU1ldGFDaGFyc2V0RGVj bGFyYXRpb24pOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlU2VyaWFsaXplcjo6Z2VuZXJhdGVC YXNlVGFnRGVjbGFyYXRpb24pOgorICAgICAgICAqIHNyYy9XZWJQYWdlU2VyaWFsaXplckltcGwu Y3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlU2VyaWFsaXplckltcGw6Om9wZW5UYWdUb1N0 cmluZyk6CisgICAgICAgIChXZWJLaXQ6OldlYlBhZ2VTZXJpYWxpemVySW1wbDo6ZW5kVGFnVG9T dHJpbmcpOgorICAgICAgICAqIHRlc3RzL0RyYWdJbWFnZVRlc3QuY3BwOgorICAgICAgICAoV2Vi Q29yZTo6VEVTVCk6CisKKzIwMTAtMDQtMjEgIEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0u b3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtj aHJvbWl1bV0gV2ViIHBhZ2Ugc2VyaWFsaXplciBzYXZlcyB0YWcgbmFtZXMgaW4gdXBwZXIgY2Fz ZQorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5NDAK KworICAgICAgICBTaW1wbHkgY29udmVydCBhbGwgdGFncyB0byBsb3dlciBjYXNlLgorCisgICAg ICAgIFRoaXMgaXMgdGVzdGVkIGJ5IGNocm9tZSB0ZXN0czoKKyAgICAgICAgIC0gc2F2ZSBwYWdl IGJyb3dzZXIgdGVzdHMKKyAgICAgICAgIC0gZW5jb2RpbmcgdWkgdGVzdHMKKyAgICAgICAgIC0g d2ViIHBhZ2Ugc2VyaWFsaXplciB0ZXN0IHNoZWxsIHRlc3RzCisKKyAgICAgICAgKiBzcmMvV2Vi UGFnZVNlcmlhbGl6ZXIuY3BwOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlU2VyaWFsaXplcjo6 Z2VuZXJhdGVNZXRhQ2hhcnNldERlY2xhcmF0aW9uKToKKyAgICAgICAgKFdlYktpdDo6V2ViUGFn ZVNlcmlhbGl6ZXI6OmdlbmVyYXRlQmFzZVRhZ0RlY2xhcmF0aW9uKToKKyAgICAgICAgKiBzcmMv V2ViUGFnZVNlcmlhbGl6ZXJJbXBsLmNwcDoKKyAgICAgICAgKFdlYktpdDo6V2ViUGFnZVNlcmlh bGl6ZXJJbXBsOjpvcGVuVGFnVG9TdHJpbmcpOgorICAgICAgICAoV2ViS2l0OjpXZWJQYWdlU2Vy aWFsaXplckltcGw6OmVuZFRhZ1RvU3RyaW5nKToKKwogMjAxMC0wNC0yMCAgQWRhbSBCYXJ0aCAg PGFiYXJ0aEB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpk aWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwIGIvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwCmluZGV4IDZjOTcxOGUuLjdiN2Q0 ZWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcAor KysgYi9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAKQEAgLTExOCwxOSAr MTE4LDI5IEBAIFRFU1QoRHJhZ0ltYWdlVGVzdCwgTm9uTnVsbEhhbmRsaW5nKQogICAgIEVYUEVD VF9FUSgxLCBzaXplLndpZHRoKCkpOwogICAgIEVYUEVDVF9FUSgxLCBzaXplLmhlaWdodCgpKTsK IAotICAgIC8vIFRoaXMgaXMgbm90IGltcGxlbWVudGVkLCBzbyB3ZSBkb24ndCBkbyBhbnkgb3V0 cHV0IHZhbGlkYXRpb24uCiAgICAgZHJhZ0ltYWdlID0gZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0 aW9uKGRyYWdJbWFnZSwgMC41KTsKICAgICBBU1NFUlRfVFJVRShkcmFnSW1hZ2UpOwogCiAgICAg ZGVsZXRlRHJhZ0ltYWdlKGRyYWdJbWFnZSk7CiB9CiAKLVRFU1QoRHJhZ0ltYWdlVGVzdCwgQ3Jl YXRlRHJhZ0ltYWdlUmV0dXJuaW5nTnVsbCkKK1RFU1QoRHJhZ0ltYWdlVGVzdCwgQ3JlYXRlRHJh Z0ltYWdlKQogewotICAgIC8vIFRlc3RzIHRoYXQgdGhlIERyYWdlSW1hZ2UgaW1wbGVtZW50YXRp b24gZG9lc24ndCBjaG9rZSBvbiBudWxsIHZhbHVlcwotICAgIC8vIG9mIG5hdGl2ZUltYWdlRm9y Q3VycmVudEZyYW1lKCkuCi0gICAgVGVzdEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7Ci0g ICAgRVhQRUNUX0ZBTFNFKGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZSgmdGVzdEltYWdlKSk7Cisg ICAgeworICAgICAgICAvLyBUZXN0cyB0aGF0IHRoZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9u IGRvZXNuJ3QgY2hva2Ugb24gbnVsbCB2YWx1ZXMKKyAgICAgICAgLy8gb2YgbmF0aXZlSW1hZ2VG b3JDdXJyZW50RnJhbWUoKS4KKyAgICAgICAgVGVzdEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgp KSk7CisgICAgICAgIEVYUEVDVF9GQUxTRShjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJ bWFnZSkpOworICAgIH0KKworICAgIHsKKyAgICAgICAgLy8gVGVzdHMgdGhhdCB0aGUgZHJhZyBp bWFnZSBpcyBhIGRlZXAgY29weS4KKyAgICAgICAgVGVzdEltYWdlIHRlc3RJbWFnZShJbnRTaXpl KDEsIDEpKTsKKyAgICAgICAgRHJhZ0ltYWdlUmVmIGRyYWdJbWFnZSA9IGNyZWF0ZURyYWdJbWFn ZUZyb21JbWFnZSgmdGVzdEltYWdlKTsKKyAgICAgICAgQVNTRVJUX1RSVUUoZHJhZ0ltYWdlKTsK KyAgICAgICAgU2tBdXRvTG9ja1BpeGVscyBsb2NrMSgqZHJhZ0ltYWdlKSwgbG9jazIoKnRlc3RJ bWFnZS5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKTsKKyAgICAgICAgRVhQRUNUX05FKGRy YWdJbWFnZS0+Z2V0UGl4ZWxzKCksIHRlc3RJbWFnZS5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFt ZSgpLT5nZXRQaXhlbHMoKSk7CisgICAgfQogfQogCiB9IC8vIGFub255bW91cyBuYW1lc3BhY2UK 54105 2010-04-22 16:17:42 -0700 2010-04-28 16:04:00 -0700 clean up changelog dragfade.diff text/plain 4267 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWEwYzgxOS4uYTAyNDA3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMiAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKwor ICAgICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3Nv bHZlRHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAx MC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBU aWdlciBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Ry YWdJbWFnZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJ bWFnZUNocm9taXVtU2tpYS5jcHAKaW5kZXggMjRiZDhmZC4uNzc0M2YyZCAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnSW1hZ2VDaHJvbWl1bVNraWEuY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcApAQCAt NjgsOSArNjgsMjYgQEAgRHJhZ0ltYWdlUmVmIHNjYWxlRHJhZ0ltYWdlKERyYWdJbWFnZVJlZiBp bWFnZSwgRmxvYXRTaXplIHNjYWxlKQogICAgIHJldHVybiBzY2FsZWRJbWFnZTsKIH0KIAotRHJh Z0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2Us IGZsb2F0KQorRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1h Z2VSZWYgaW1hZ2UsIGZsb2F0IGZyYWN0aW9uKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgaWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpbWFnZS0+c2V0SXNPcGFx dWUoZmFsc2UpOworICAgIGltYWdlLT5sb2NrUGl4ZWxzKCk7CisKKyAgICBmb3IgKGludCB4ID0g MDsgeCA8IGltYWdlLT5oZWlnaHQoKTsgKyt4KSB7CisgICAgICAgIGZvciAoaW50IHkgPSAwOyB5 IDwgaW1hZ2UtPndpZHRoKCk7ICsreSkgeworICAgICAgICAgICAgdWludDMyX3QqIHBpeGVsID0g aW1hZ2UtPmdldEFkZHIzMih5LCB4KTsKKyAgICAgICAgICAgICpwaXhlbCA9IFNrUHJlTXVsdGlw bHlBUkdCKFNrQ29sb3JHZXRBKCpwaXhlbCkgKiBmcmFjdGlvbiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFNrQ29sb3JHZXRSKCpwaXhlbCksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBTa0NvbG9yR2V0RygqcGl4ZWwpLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tDb2xvckdldEIoKnBpeGVsKSk7CisgICAg ICAgIH0KKyAgICB9CisKKyAgICBpbWFnZS0+dW5sb2NrUGl4ZWxzKCk7CisKICAgICByZXR1cm4g aW1hZ2U7CiB9CiAKQEAgLTgwLDcgKzk3LDEyIEBAIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1h Z2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdlKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIE5hdGl2 ZUltYWdlU2tpYSogYml0bWFwID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7 Ci0gICAgcmV0dXJuIGJpdG1hcCA/IG5ldyBTa0JpdG1hcCgqYml0bWFwKSA6IDA7CisgICAgaWYg KCFiaXRtYXApCisgICAgICAgIHJldHVybiAwOworCisgICAgU2tCaXRtYXAqIGRyYWdJbWFnZSA9 IG5ldyBTa0JpdG1hcCgpOworICAgIGJpdG1hcC0+Y29weVRvKGRyYWdJbWFnZSwgU2tCaXRtYXA6 OmtBUkdCXzg4ODhfQ29uZmlnKTsKKyAgICByZXR1cm4gZHJhZ0ltYWdlOwogfQogCiBEcmFnSW1h Z2VSZWYgY3JlYXRlRHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlKENhY2hlZEltYWdlKikKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCmluZGV4IGJiYmEyMDguLjhjZjE4YjUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEz IEBACisyMDEwLTA0LTIyICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIFNraWEgbmVlZHMgdG8gZmFkZSBEcmFnSW1hZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODAwOAorCisgICAgICAgIGFk ZGl0aW9uYWwgdGVzdHMKKworICAgICAgICAqIHRlc3RzL0RyYWdJbWFnZVRlc3QuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6VEVTVCk6CisKIDIwMTAtMDQtMjAgIEFkYW0gQmFydGggIDxhYmFydGhA d2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBFcmljIFNlaWRlbC4KZGlmZiAtLWdp dCBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcCBiL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcAppbmRleCA2Yzk3MThlLi43YjdkNGVlIDEwMDY0 NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAKKysrIGIvV2Vi S2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwCkBAIC0xMTgsMTkgKzExOCwyOSBA QCBURVNUKERyYWdJbWFnZVRlc3QsIE5vbk51bGxIYW5kbGluZykKICAgICBFWFBFQ1RfRVEoMSwg c2l6ZS53aWR0aCgpKTsKICAgICBFWFBFQ1RfRVEoMSwgc2l6ZS5oZWlnaHQoKSk7CiAKLSAgICAv LyBUaGlzIGlzIG5vdCBpbXBsZW1lbnRlZCwgc28gd2UgZG9uJ3QgZG8gYW55IG91dHB1dCB2YWxp ZGF0aW9uLgogICAgIGRyYWdJbWFnZSA9IGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihkcmFn SW1hZ2UsIDAuNSk7CiAgICAgQVNTRVJUX1RSVUUoZHJhZ0ltYWdlKTsKIAogICAgIGRlbGV0ZURy YWdJbWFnZShkcmFnSW1hZ2UpOwogfQogCi1URVNUKERyYWdJbWFnZVRlc3QsIENyZWF0ZURyYWdJ bWFnZVJldHVybmluZ051bGwpCitURVNUKERyYWdJbWFnZVRlc3QsIENyZWF0ZURyYWdJbWFnZSkK IHsKLSAgICAvLyBUZXN0cyB0aGF0IHRoZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9uIGRvZXNu J3QgY2hva2Ugb24gbnVsbCB2YWx1ZXMKLSAgICAvLyBvZiBuYXRpdmVJbWFnZUZvckN1cnJlbnRG cmFtZSgpLgotICAgIFRlc3RJbWFnZSB0ZXN0SW1hZ2UoKEludFNpemUoKSkpOwotICAgIEVYUEVD VF9GQUxTRShjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSkpOworICAgIHsKKyAg ICAgICAgLy8gVGVzdHMgdGhhdCB0aGUgRHJhZ2VJbWFnZSBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0 IGNob2tlIG9uIG51bGwgdmFsdWVzCisgICAgICAgIC8vIG9mIG5hdGl2ZUltYWdlRm9yQ3VycmVu dEZyYW1lKCkuCisgICAgICAgIFRlc3RJbWFnZSB0ZXN0SW1hZ2UoKEludFNpemUoKSkpOworICAg ICAgICBFWFBFQ1RfRkFMU0UoY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKCZ0ZXN0SW1hZ2UpKTsK KyAgICB9CisKKyAgICB7CisgICAgICAgIC8vIFRlc3RzIHRoYXQgdGhlIGRyYWcgaW1hZ2UgaXMg YSBkZWVwIGNvcHkuCisgICAgICAgIFRlc3RJbWFnZSB0ZXN0SW1hZ2UoSW50U2l6ZSgxLCAxKSk7 CisgICAgICAgIERyYWdJbWFnZVJlZiBkcmFnSW1hZ2UgPSBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1h Z2UoJnRlc3RJbWFnZSk7CisgICAgICAgIEFTU0VSVF9UUlVFKGRyYWdJbWFnZSk7CisgICAgICAg IFNrQXV0b0xvY2tQaXhlbHMgbG9jazEoKmRyYWdJbWFnZSksIGxvY2syKCp0ZXN0SW1hZ2UubmF0 aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKSk7CisgICAgICAgIEVYUEVDVF9ORShkcmFnSW1hZ2Ut PmdldFBpeGVscygpLCB0ZXN0SW1hZ2UubmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS0+Z2V0 UGl4ZWxzKCkpOworICAgIH0KIH0KIAogfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCg== 54635 2010-04-28 16:04:00 -0700 2010-04-28 18:20:06 -0700 review feedback dragfade.diff text/plain 4295 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWEwYzgxOS4uYTAyNDA3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMiAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKwor ICAgICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3Nv bHZlRHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAx MC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBU aWdlciBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Ry YWdJbWFnZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJ bWFnZUNocm9taXVtU2tpYS5jcHAKaW5kZXggMjRiZDhmZC4uZThhMGM2MiAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnSW1hZ2VDaHJvbWl1bVNraWEuY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcApAQCAt NjgsOSArNjgsMjYgQEAgRHJhZ0ltYWdlUmVmIHNjYWxlRHJhZ0ltYWdlKERyYWdJbWFnZVJlZiBp bWFnZSwgRmxvYXRTaXplIHNjYWxlKQogICAgIHJldHVybiBzY2FsZWRJbWFnZTsKIH0KIAotRHJh Z0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2Us IGZsb2F0KQorRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1h Z2VSZWYgaW1hZ2UsIGZsb2F0IGZyYWN0aW9uKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgaWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpbWFnZS0+c2V0SXNPcGFx dWUoZmFsc2UpOworICAgIGltYWdlLT5sb2NrUGl4ZWxzKCk7CisKKyAgICBmb3IgKGludCByID0g MDsgciA8IGltYWdlLT5oZWlnaHQoKTsgKytyKSB7CisgICAgICAgIGZvciAoaW50IGMgPSAwOyBj IDwgaW1hZ2UtPndpZHRoKCk7ICsrYykgeworICAgICAgICAgICAgdWludDMyX3QqIHBpeGVsID0g aW1hZ2UtPmdldEFkZHIzMihjLCByKTsKKyAgICAgICAgICAgICpwaXhlbCA9IFNrUHJlTXVsdGlw bHlBUkdCKFNrQ29sb3JHZXRBKCpwaXhlbCkgKiBmcmFjdGlvbiwKKyAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgIFNrQ29sb3JHZXRSKCpwaXhlbCksCisgICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBTa0NvbG9yR2V0RygqcGl4ZWwpLAorICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tDb2xvckdldEIoKnBpeGVsKSk7CisgICAg ICAgIH0KKyAgICB9CisKKyAgICBpbWFnZS0+dW5sb2NrUGl4ZWxzKCk7CisKICAgICByZXR1cm4g aW1hZ2U7CiB9CiAKQEAgLTgwLDcgKzk3LDEyIEBAIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1h Z2VGcm9tSW1hZ2UoSW1hZ2UqIGltYWdlKQogICAgICAgICByZXR1cm4gMDsKIAogICAgIE5hdGl2 ZUltYWdlU2tpYSogYml0bWFwID0gaW1hZ2UtPm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCk7 Ci0gICAgcmV0dXJuIGJpdG1hcCA/IG5ldyBTa0JpdG1hcCgqYml0bWFwKSA6IDA7CisgICAgaWYg KCFiaXRtYXApCisgICAgICAgIHJldHVybiAwOworCisgICAgU2tCaXRtYXAqIGRyYWdJbWFnZSA9 IG5ldyBTa0JpdG1hcCgpOworICAgIGJpdG1hcC0+Y29weVRvKGRyYWdJbWFnZSwgU2tCaXRtYXA6 OmtBUkdCXzg4ODhfQ29uZmlnKTsKKyAgICByZXR1cm4gZHJhZ0ltYWdlOwogfQogCiBEcmFnSW1h Z2VSZWYgY3JlYXRlRHJhZ0ltYWdlSWNvbkZvckNhY2hlZEltYWdlKENhY2hlZEltYWdlKikKZGlm ZiAtLWdpdCBhL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cgYi9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nCmluZGV4IGJiYmEyMDguLjJiODIzYjYgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS9DaGFuZ2VMb2cKKysrIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEx IEBACisyMDEwLTA0LTIyICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KKworICAg ICAgICBbY2hyb21pdW1dIFNraWEgbmVlZHMgdG8gZmFkZSBEcmFnSW1hZ2VzCisgICAgICAgIGh0 dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zODAwOAorCisgICAgICAgICog dGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHA6CisgICAgICAgIChEcmFnSW1hZ2VUZXN0LkNyZWF0ZURy YWdJbWFnZSk6IHRlc3QgdGhhdCB0aGUgZHJhZyBpbWFnZSBpcyBhIGRlZXAgY29weQorCiAyMDEw LTA0LTIwICBBZGFtIEJhcnRoICA8YWJhcnRoQHdlYmtpdC5vcmc+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgRXJpYyBTZWlkZWwuCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJh Z0ltYWdlVGVzdC5jcHAgYi9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAK aW5kZXggNmM5NzE4ZS4uN2I3ZDRlZSAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL3Rlc3Rz L0RyYWdJbWFnZVRlc3QuY3BwCisrKyBiL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFnSW1hZ2VU ZXN0LmNwcApAQCAtMTE4LDE5ICsxMTgsMjkgQEAgVEVTVChEcmFnSW1hZ2VUZXN0LCBOb25OdWxs SGFuZGxpbmcpCiAgICAgRVhQRUNUX0VRKDEsIHNpemUud2lkdGgoKSk7CiAgICAgRVhQRUNUX0VR KDEsIHNpemUuaGVpZ2h0KCkpOwogCi0gICAgLy8gVGhpcyBpcyBub3QgaW1wbGVtZW50ZWQsIHNv IHdlIGRvbid0IGRvIGFueSBvdXRwdXQgdmFsaWRhdGlvbi4KICAgICBkcmFnSW1hZ2UgPSBkaXNz b2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oZHJhZ0ltYWdlLCAwLjUpOwogICAgIEFTU0VSVF9UUlVF KGRyYWdJbWFnZSk7CiAKICAgICBkZWxldGVEcmFnSW1hZ2UoZHJhZ0ltYWdlKTsKIH0KIAotVEVT VChEcmFnSW1hZ2VUZXN0LCBDcmVhdGVEcmFnSW1hZ2VSZXR1cm5pbmdOdWxsKQorVEVTVChEcmFn SW1hZ2VUZXN0LCBDcmVhdGVEcmFnSW1hZ2UpCiB7Ci0gICAgLy8gVGVzdHMgdGhhdCB0aGUgRHJh Z2VJbWFnZSBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0IGNob2tlIG9uIG51bGwgdmFsdWVzCi0gICAg Ly8gb2YgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS4KLSAgICBUZXN0SW1hZ2UgdGVzdElt YWdlKChJbnRTaXplKCkpKTsKLSAgICBFWFBFQ1RfRkFMU0UoY3JlYXRlRHJhZ0ltYWdlRnJvbUlt YWdlKCZ0ZXN0SW1hZ2UpKTsKKyAgICB7CisgICAgICAgIC8vIFRlc3RzIHRoYXQgdGhlIERyYWdl SW1hZ2UgaW1wbGVtZW50YXRpb24gZG9lc24ndCBjaG9rZSBvbiBudWxsIHZhbHVlcworICAgICAg ICAvLyBvZiBuYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLgorICAgICAgICBUZXN0SW1hZ2Ug dGVzdEltYWdlKChJbnRTaXplKCkpKTsKKyAgICAgICAgRVhQRUNUX0ZBTFNFKGNyZWF0ZURyYWdJ bWFnZUZyb21JbWFnZSgmdGVzdEltYWdlKSk7CisgICAgfQorCisgICAgeworICAgICAgICAvLyBU ZXN0cyB0aGF0IHRoZSBkcmFnIGltYWdlIGlzIGEgZGVlcCBjb3B5LgorICAgICAgICBUZXN0SW1h Z2UgdGVzdEltYWdlKEludFNpemUoMSwgMSkpOworICAgICAgICBEcmFnSW1hZ2VSZWYgZHJhZ0lt YWdlID0gY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKCZ0ZXN0SW1hZ2UpOworICAgICAgICBBU1NF UlRfVFJVRShkcmFnSW1hZ2UpOworICAgICAgICBTa0F1dG9Mb2NrUGl4ZWxzIGxvY2sxKCpkcmFn SW1hZ2UpLCBsb2NrMigqdGVzdEltYWdlLm5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkpOwor ICAgICAgICBFWFBFQ1RfTkUoZHJhZ0ltYWdlLT5nZXRQaXhlbHMoKSwgdGVzdEltYWdlLm5hdGl2 ZUltYWdlRm9yQ3VycmVudEZyYW1lKCktPmdldFBpeGVscygpKTsKKyAgICB9CiB9CiAKIH0gLy8g YW5vbnltb3VzIG5hbWVzcGFjZQo= 54653 2010-04-28 18:20:06 -0700 2010-04-29 11:28:13 -0700 r->row, c->column dragfade.diff text/plain 4323 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg ZWEwYzgxOS4uYTAyNDA3MCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMiAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKwor ICAgICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3Nv bHZlRHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAx MC0wNC0yMSAgQWxleGV5IFByb3NrdXJ5YWtvdiAgPGFwQGFwcGxlLmNvbT4KIAogICAgICAgICBU aWdlciBidWlsZCBmaXguCmRpZmYgLS1naXQgYS9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0Ry YWdJbWFnZUNocm9taXVtU2tpYS5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJ bWFnZUNocm9taXVtU2tpYS5jcHAKaW5kZXggMjRiZDhmZC4uZTVjMWNlZSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnSW1hZ2VDaHJvbWl1bVNraWEuY3BwCisrKyBi L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcApAQCAt NjgsOSArNjgsMjYgQEAgRHJhZ0ltYWdlUmVmIHNjYWxlRHJhZ0ltYWdlKERyYWdJbWFnZVJlZiBp bWFnZSwgRmxvYXRTaXplIHNjYWxlKQogICAgIHJldHVybiBzY2FsZWRJbWFnZTsKIH0KIAotRHJh Z0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1hZ2VSZWYgaW1hZ2Us IGZsb2F0KQorRHJhZ0ltYWdlUmVmIGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihEcmFnSW1h Z2VSZWYgaW1hZ2UsIGZsb2F0IGZyYWN0aW9uKQogewotICAgIG5vdEltcGxlbWVudGVkKCk7Cisg ICAgaWYgKCFpbWFnZSkKKyAgICAgICAgcmV0dXJuIDA7CisKKyAgICBpbWFnZS0+c2V0SXNPcGFx dWUoZmFsc2UpOworICAgIGltYWdlLT5sb2NrUGl4ZWxzKCk7CisKKyAgICBmb3IgKGludCByb3cg PSAwOyByb3cgPCBpbWFnZS0+aGVpZ2h0KCk7ICsrcm93KSB7CisgICAgICAgIGZvciAoaW50IGNv bHVtbiA9IDA7IGNvbHVtbiA8IGltYWdlLT53aWR0aCgpOyArK2NvbHVtbikgeworICAgICAgICAg ICAgdWludDMyX3QqIHBpeGVsID0gaW1hZ2UtPmdldEFkZHIzMihjb2x1bW4sIHJvdyk7CisgICAg ICAgICAgICAqcGl4ZWwgPSBTa1ByZU11bHRpcGx5QVJHQihTa0NvbG9yR2V0QSgqcGl4ZWwpICog ZnJhY3Rpb24sCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBTa0NvbG9y R2V0UigqcGl4ZWwpLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tD b2xvckdldEcoKnBpeGVsKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg IFNrQ29sb3JHZXRCKCpwaXhlbCkpOworICAgICAgICB9CisgICAgfQorCisgICAgaW1hZ2UtPnVu bG9ja1BpeGVscygpOworCiAgICAgcmV0dXJuIGltYWdlOwogfQogCkBAIC04MCw3ICs5NywxMiBA QCBEcmFnSW1hZ2VSZWYgY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKEltYWdlKiBpbWFnZSkKICAg ICAgICAgcmV0dXJuIDA7CiAKICAgICBOYXRpdmVJbWFnZVNraWEqIGJpdG1hcCA9IGltYWdlLT5u YXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpOwotICAgIHJldHVybiBiaXRtYXAgPyBuZXcgU2tC aXRtYXAoKmJpdG1hcCkgOiAwOworICAgIGlmICghYml0bWFwKQorICAgICAgICByZXR1cm4gMDsK KworICAgIFNrQml0bWFwKiBkcmFnSW1hZ2UgPSBuZXcgU2tCaXRtYXAoKTsKKyAgICBiaXRtYXAt PmNvcHlUbyhkcmFnSW1hZ2UsIFNrQml0bWFwOjprQVJHQl84ODg4X0NvbmZpZyk7CisgICAgcmV0 dXJuIGRyYWdJbWFnZTsKIH0KIAogRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUljb25Gb3JD YWNoZWRJbWFnZShDYWNoZWRJbWFnZSopCmRpZmYgLS1naXQgYS9XZWJLaXQvY2hyb21pdW0vQ2hh bmdlTG9nIGIvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwppbmRleCBiYmJhMjA4Li4yYjgyM2I2 IDEwMDY0NAotLS0gYS9XZWJLaXQvY2hyb21pdW0vQ2hhbmdlTG9nCisrKyBiL1dlYktpdC9jaHJv bWl1bS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMSBAQAorMjAxMC0wNC0yMiAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRv IGZhZGUgRHJhZ0ltYWdlcworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1 Zy5jZ2k/aWQ9MzgwMDgKKworICAgICAgICAqIHRlc3RzL0RyYWdJbWFnZVRlc3QuY3BwOgorICAg ICAgICAoRHJhZ0ltYWdlVGVzdC5DcmVhdGVEcmFnSW1hZ2UpOiB0ZXN0IHRoYXQgdGhlIGRyYWcg aW1hZ2UgaXMgYSBkZWVwIGNvcHkKKwogMjAxMC0wNC0yMCAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3 ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEVyaWMgU2VpZGVsLgpkaWZmIC0tZ2l0 IGEvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwIGIvV2ViS2l0L2Nocm9t aXVtL3Rlc3RzL0RyYWdJbWFnZVRlc3QuY3BwCmluZGV4IDZjOTcxOGUuLjdiN2Q0ZWUgMTAwNjQ0 Ci0tLSBhL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcAorKysgYi9XZWJL aXQvY2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAKQEAgLTExOCwxOSArMTE4LDI5IEBA IFRFU1QoRHJhZ0ltYWdlVGVzdCwgTm9uTnVsbEhhbmRsaW5nKQogICAgIEVYUEVDVF9FUSgxLCBz aXplLndpZHRoKCkpOwogICAgIEVYUEVDVF9FUSgxLCBzaXplLmhlaWdodCgpKTsKIAotICAgIC8v IFRoaXMgaXMgbm90IGltcGxlbWVudGVkLCBzbyB3ZSBkb24ndCBkbyBhbnkgb3V0cHV0IHZhbGlk YXRpb24uCiAgICAgZHJhZ0ltYWdlID0gZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGRyYWdJ bWFnZSwgMC41KTsKICAgICBBU1NFUlRfVFJVRShkcmFnSW1hZ2UpOwogCiAgICAgZGVsZXRlRHJh Z0ltYWdlKGRyYWdJbWFnZSk7CiB9CiAKLVRFU1QoRHJhZ0ltYWdlVGVzdCwgQ3JlYXRlRHJhZ0lt YWdlUmV0dXJuaW5nTnVsbCkKK1RFU1QoRHJhZ0ltYWdlVGVzdCwgQ3JlYXRlRHJhZ0ltYWdlKQog ewotICAgIC8vIFRlc3RzIHRoYXQgdGhlIERyYWdlSW1hZ2UgaW1wbGVtZW50YXRpb24gZG9lc24n dCBjaG9rZSBvbiBudWxsIHZhbHVlcwotICAgIC8vIG9mIG5hdGl2ZUltYWdlRm9yQ3VycmVudEZy YW1lKCkuCi0gICAgVGVzdEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7Ci0gICAgRVhQRUNU X0ZBTFNFKGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZSgmdGVzdEltYWdlKSk7CisgICAgeworICAg ICAgICAvLyBUZXN0cyB0aGF0IHRoZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9uIGRvZXNuJ3Qg Y2hva2Ugb24gbnVsbCB2YWx1ZXMKKyAgICAgICAgLy8gb2YgbmF0aXZlSW1hZ2VGb3JDdXJyZW50 RnJhbWUoKS4KKyAgICAgICAgVGVzdEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7CisgICAg ICAgIEVYUEVDVF9GQUxTRShjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSkpOwor ICAgIH0KKworICAgIHsKKyAgICAgICAgLy8gVGVzdHMgdGhhdCB0aGUgZHJhZyBpbWFnZSBpcyBh IGRlZXAgY29weS4KKyAgICAgICAgVGVzdEltYWdlIHRlc3RJbWFnZShJbnRTaXplKDEsIDEpKTsK KyAgICAgICAgRHJhZ0ltYWdlUmVmIGRyYWdJbWFnZSA9IGNyZWF0ZURyYWdJbWFnZUZyb21JbWFn ZSgmdGVzdEltYWdlKTsKKyAgICAgICAgQVNTRVJUX1RSVUUoZHJhZ0ltYWdlKTsKKyAgICAgICAg U2tBdXRvTG9ja1BpeGVscyBsb2NrMSgqZHJhZ0ltYWdlKSwgbG9jazIoKnRlc3RJbWFnZS5uYXRp dmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpKTsKKyAgICAgICAgRVhQRUNUX05FKGRyYWdJbWFnZS0+ Z2V0UGl4ZWxzKCksIHRlc3RJbWFnZS5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLT5nZXRQ aXhlbHMoKSk7CisgICAgfQogfQogCiB9IC8vIGFub255bW91cyBuYW1lc3BhY2UK 54722 2010-04-29 11:28:13 -0700 2010-04-29 17:30:08 -0700 so I managed to bungle the changelog dragfade2.diff text/plain 4366 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTNhYTA2OS4uZDlhZWY3MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yOCAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BT ISkuCisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcwor ICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKwor ICAgICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hy b21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3Nv bHZlRHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAx MC0wNC0yOCAgTWlrZSBUaG9sZSAgPG10aG9sZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3 ZWQgYnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9E cmFnSW1hZ2VDaHJvbWl1bVNraWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFn SW1hZ2VDaHJvbWl1bVNraWEuY3BwCmluZGV4IDI0YmQ4ZmQuLmU1YzFjZWUgMTAwNjQ0Ci0tLSBh L1dlYkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcAorKysg Yi9XZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJbWFnZUNocm9taXVtU2tpYS5jcHAKQEAg LTY4LDkgKzY4LDI2IEBAIERyYWdJbWFnZVJlZiBzY2FsZURyYWdJbWFnZShEcmFnSW1hZ2VSZWYg aW1hZ2UsIEZsb2F0U2l6ZSBzY2FsZSkKICAgICByZXR1cm4gc2NhbGVkSW1hZ2U7CiB9CiAKLURy YWdJbWFnZVJlZiBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oRHJhZ0ltYWdlUmVmIGltYWdl LCBmbG9hdCkKK0RyYWdJbWFnZVJlZiBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oRHJhZ0lt YWdlUmVmIGltYWdlLCBmbG9hdCBmcmFjdGlvbikKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOwor ICAgIGlmICghaW1hZ2UpCisgICAgICAgIHJldHVybiAwOworCisgICAgaW1hZ2UtPnNldElzT3Bh cXVlKGZhbHNlKTsKKyAgICBpbWFnZS0+bG9ja1BpeGVscygpOworCisgICAgZm9yIChpbnQgcm93 ID0gMDsgcm93IDwgaW1hZ2UtPmhlaWdodCgpOyArK3JvdykgeworICAgICAgICBmb3IgKGludCBj b2x1bW4gPSAwOyBjb2x1bW4gPCBpbWFnZS0+d2lkdGgoKTsgKytjb2x1bW4pIHsKKyAgICAgICAg ICAgIHVpbnQzMl90KiBwaXhlbCA9IGltYWdlLT5nZXRBZGRyMzIoY29sdW1uLCByb3cpOworICAg ICAgICAgICAgKnBpeGVsID0gU2tQcmVNdWx0aXBseUFSR0IoU2tDb2xvckdldEEoKnBpeGVsKSAq IGZyYWN0aW9uLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tDb2xv ckdldFIoKnBpeGVsKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNr Q29sb3JHZXRHKCpwaXhlbCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICBTa0NvbG9yR2V0QigqcGl4ZWwpKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIGltYWdlLT51 bmxvY2tQaXhlbHMoKTsKKwogICAgIHJldHVybiBpbWFnZTsKIH0KIApAQCAtODAsNyArOTcsMTIg QEAgRHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZShJbWFnZSogaW1hZ2UpCiAg ICAgICAgIHJldHVybiAwOwogCiAgICAgTmF0aXZlSW1hZ2VTa2lhKiBiaXRtYXAgPSBpbWFnZS0+ bmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKLSAgICByZXR1cm4gYml0bWFwID8gbmV3IFNr Qml0bWFwKCpiaXRtYXApIDogMDsKKyAgICBpZiAoIWJpdG1hcCkKKyAgICAgICAgcmV0dXJuIDA7 CisKKyAgICBTa0JpdG1hcCogZHJhZ0ltYWdlID0gbmV3IFNrQml0bWFwKCk7CisgICAgYml0bWFw LT5jb3B5VG8oZHJhZ0ltYWdlLCBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpOworICAgIHJl dHVybiBkcmFnSW1hZ2U7CiB9CiAKIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VJY29uRm9y Q2FjaGVkSW1hZ2UoQ2FjaGVkSW1hZ2UqKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0No YW5nZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMWE3M2ViNS4uMWU2ZGUz YyAxMDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMjggIEV2YW4gU3RhZGUg IDxlc3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtjaHJvbWl1bV0gU2tpYSBuZWVkcyB0byBmYWRlIERyYWdJbWFnZXMK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM4MDA4CisK KyAgICAgICAgKiB0ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcDoKKyAgICAgICAgKERyYWdJbWFnZVRl c3QuQ3JlYXRlRHJhZ0ltYWdlKTogdGVzdCB0aGF0IHRoZSBkcmFnIGltYWdlIGlzIGEgZGVlcCBj b3B5CisKIDIwMTAtMDQtMjggIERhcmluIEZpc2hlciAgPGRhcmluQGNocm9taXVtLm9yZz4KIAog ICAgICAgICBSZXZpZXdlZCBieSBEYXZpZCBMZXZpbi4KZGlmZiAtLWdpdCBhL1dlYktpdC9jaHJv bWl1bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcCBiL1dlYktpdC9jaHJvbWl1bS90ZXN0cy9EcmFn SW1hZ2VUZXN0LmNwcAppbmRleCA2Yzk3MThlLi43YjdkNGVlIDEwMDY0NAotLS0gYS9XZWJLaXQv Y2hyb21pdW0vdGVzdHMvRHJhZ0ltYWdlVGVzdC5jcHAKKysrIGIvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0RyYWdJbWFnZVRlc3QuY3BwCkBAIC0xMTgsMTkgKzExOCwyOSBAQCBURVNUKERyYWdJbWFn ZVRlc3QsIE5vbk51bGxIYW5kbGluZykKICAgICBFWFBFQ1RfRVEoMSwgc2l6ZS53aWR0aCgpKTsK ICAgICBFWFBFQ1RfRVEoMSwgc2l6ZS5oZWlnaHQoKSk7CiAKLSAgICAvLyBUaGlzIGlzIG5vdCBp bXBsZW1lbnRlZCwgc28gd2UgZG9uJ3QgZG8gYW55IG91dHB1dCB2YWxpZGF0aW9uLgogICAgIGRy YWdJbWFnZSA9IGRpc3NvbHZlRHJhZ0ltYWdlVG9GcmFjdGlvbihkcmFnSW1hZ2UsIDAuNSk7CiAg ICAgQVNTRVJUX1RSVUUoZHJhZ0ltYWdlKTsKIAogICAgIGRlbGV0ZURyYWdJbWFnZShkcmFnSW1h Z2UpOwogfQogCi1URVNUKERyYWdJbWFnZVRlc3QsIENyZWF0ZURyYWdJbWFnZVJldHVybmluZ051 bGwpCitURVNUKERyYWdJbWFnZVRlc3QsIENyZWF0ZURyYWdJbWFnZSkKIHsKLSAgICAvLyBUZXN0 cyB0aGF0IHRoZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgY2hva2Ugb24gbnVs bCB2YWx1ZXMKLSAgICAvLyBvZiBuYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLgotICAgIFRl c3RJbWFnZSB0ZXN0SW1hZ2UoKEludFNpemUoKSkpOwotICAgIEVYUEVDVF9GQUxTRShjcmVhdGVE cmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSkpOworICAgIHsKKyAgICAgICAgLy8gVGVzdHMg dGhhdCB0aGUgRHJhZ2VJbWFnZSBpbXBsZW1lbnRhdGlvbiBkb2Vzbid0IGNob2tlIG9uIG51bGwg dmFsdWVzCisgICAgICAgIC8vIG9mIG5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkuCisgICAg ICAgIFRlc3RJbWFnZSB0ZXN0SW1hZ2UoKEludFNpemUoKSkpOworICAgICAgICBFWFBFQ1RfRkFM U0UoY3JlYXRlRHJhZ0ltYWdlRnJvbUltYWdlKCZ0ZXN0SW1hZ2UpKTsKKyAgICB9CisKKyAgICB7 CisgICAgICAgIC8vIFRlc3RzIHRoYXQgdGhlIGRyYWcgaW1hZ2UgaXMgYSBkZWVwIGNvcHkuCisg ICAgICAgIFRlc3RJbWFnZSB0ZXN0SW1hZ2UoSW50U2l6ZSgxLCAxKSk7CisgICAgICAgIERyYWdJ bWFnZVJlZiBkcmFnSW1hZ2UgPSBjcmVhdGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSk7 CisgICAgICAgIEFTU0VSVF9UUlVFKGRyYWdJbWFnZSk7CisgICAgICAgIFNrQXV0b0xvY2tQaXhl bHMgbG9jazEoKmRyYWdJbWFnZSksIGxvY2syKCp0ZXN0SW1hZ2UubmF0aXZlSW1hZ2VGb3JDdXJy ZW50RnJhbWUoKSk7CisgICAgICAgIEVYUEVDVF9ORShkcmFnSW1hZ2UtPmdldFBpeGVscygpLCB0 ZXN0SW1hZ2UubmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS0+Z2V0UGl4ZWxzKCkpOworICAg IH0KIH0KIAogfSAvLyBhbm9ueW1vdXMgbmFtZXNwYWNlCg== 54761 2010-04-29 17:30:08 -0700 2010-05-02 00:01:40 -0700 doing as I'm told dragfade2.diff text/plain 4359 estade ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg MTNhYTA2OS4uZDlhZWY3MyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yOCAgRXZhbiBTdGFkZSAg PGVzdGFkZUBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgRGF2aWQgTGV2aW4u CisKKyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcworICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKworICAg ICAgICB0ZXN0ZWQgYnkgRHJhZ0ltYWdlVGVzdAorCisgICAgICAgICogcGxhdGZvcm0vY2hyb21p dW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmRpc3NvbHZl RHJhZ0ltYWdlVG9GcmFjdGlvbik6aW1wbGVtZW50CisgICAgICAgIChXZWJDb3JlOjpjcmVhdGVE cmFnSW1hZ2VGcm9tSW1hZ2UpOmRlZXAgY29weSBpbnN0ZWFkIG9mIHNoYWxsb3cKKwogMjAxMC0w NC0yOCAgTWlrZSBUaG9sZSAgPG10aG9sZUBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgTWFyayBSb3dlLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFn SW1hZ2VDaHJvbWl1bVNraWEuY3BwIGIvV2ViQ29yZS9wbGF0Zm9ybS9jaHJvbWl1bS9EcmFnSW1h Z2VDaHJvbWl1bVNraWEuY3BwCmluZGV4IDI0YmQ4ZmQuLmU1YzFjZWUgMTAwNjQ0Ci0tLSBhL1dl YkNvcmUvcGxhdGZvcm0vY2hyb21pdW0vRHJhZ0ltYWdlQ2hyb21pdW1Ta2lhLmNwcAorKysgYi9X ZWJDb3JlL3BsYXRmb3JtL2Nocm9taXVtL0RyYWdJbWFnZUNocm9taXVtU2tpYS5jcHAKQEAgLTY4 LDkgKzY4LDI2IEBAIERyYWdJbWFnZVJlZiBzY2FsZURyYWdJbWFnZShEcmFnSW1hZ2VSZWYgaW1h Z2UsIEZsb2F0U2l6ZSBzY2FsZSkKICAgICByZXR1cm4gc2NhbGVkSW1hZ2U7CiB9CiAKLURyYWdJ bWFnZVJlZiBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oRHJhZ0ltYWdlUmVmIGltYWdlLCBm bG9hdCkKK0RyYWdJbWFnZVJlZiBkaXNzb2x2ZURyYWdJbWFnZVRvRnJhY3Rpb24oRHJhZ0ltYWdl UmVmIGltYWdlLCBmbG9hdCBmcmFjdGlvbikKIHsKLSAgICBub3RJbXBsZW1lbnRlZCgpOworICAg IGlmICghaW1hZ2UpCisgICAgICAgIHJldHVybiAwOworCisgICAgaW1hZ2UtPnNldElzT3BhcXVl KGZhbHNlKTsKKyAgICBpbWFnZS0+bG9ja1BpeGVscygpOworCisgICAgZm9yIChpbnQgcm93ID0g MDsgcm93IDwgaW1hZ2UtPmhlaWdodCgpOyArK3JvdykgeworICAgICAgICBmb3IgKGludCBjb2x1 bW4gPSAwOyBjb2x1bW4gPCBpbWFnZS0+d2lkdGgoKTsgKytjb2x1bW4pIHsKKyAgICAgICAgICAg IHVpbnQzMl90KiBwaXhlbCA9IGltYWdlLT5nZXRBZGRyMzIoY29sdW1uLCByb3cpOworICAgICAg ICAgICAgKnBpeGVsID0gU2tQcmVNdWx0aXBseUFSR0IoU2tDb2xvckdldEEoKnBpeGVsKSAqIGZy YWN0aW9uLAorICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgU2tDb2xvckdl dFIoKnBpeGVsKSwKKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIFNrQ29s b3JHZXRHKCpwaXhlbCksCisgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBT a0NvbG9yR2V0QigqcGl4ZWwpKTsKKyAgICAgICAgfQorICAgIH0KKworICAgIGltYWdlLT51bmxv Y2tQaXhlbHMoKTsKKwogICAgIHJldHVybiBpbWFnZTsKIH0KIApAQCAtODAsNyArOTcsMTIgQEAg RHJhZ0ltYWdlUmVmIGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZShJbWFnZSogaW1hZ2UpCiAgICAg ICAgIHJldHVybiAwOwogCiAgICAgTmF0aXZlSW1hZ2VTa2lhKiBiaXRtYXAgPSBpbWFnZS0+bmF0 aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKTsKLSAgICByZXR1cm4gYml0bWFwID8gbmV3IFNrQml0 bWFwKCpiaXRtYXApIDogMDsKKyAgICBpZiAoIWJpdG1hcCkKKyAgICAgICAgcmV0dXJuIDA7CisK KyAgICBTa0JpdG1hcCogZHJhZ0ltYWdlID0gbmV3IFNrQml0bWFwKCk7CisgICAgYml0bWFwLT5j b3B5VG8oZHJhZ0ltYWdlLCBTa0JpdG1hcDo6a0FSR0JfODg4OF9Db25maWcpOworICAgIHJldHVy biBkcmFnSW1hZ2U7CiB9CiAKIERyYWdJbWFnZVJlZiBjcmVhdGVEcmFnSW1hZ2VJY29uRm9yQ2Fj aGVkSW1hZ2UoQ2FjaGVkSW1hZ2UqKQpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL0NoYW5n ZUxvZyBiL1dlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKaW5kZXggMWE3M2ViNS4uMWU2ZGUzYyAx MDA2NDQKLS0tIGEvV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZworKysgYi9XZWJLaXQvY2hyb21p dW0vQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMjggIEV2YW4gU3RhZGUgIDxl c3RhZGVAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IERhdmlkIExldmluCisK KyAgICAgICAgW2Nocm9taXVtXSBTa2lhIG5lZWRzIHRvIGZhZGUgRHJhZ0ltYWdlcworICAgICAg ICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9MzgwMDgKKworICAgICAg ICAqIHRlc3RzL0RyYWdJbWFnZVRlc3QuY3BwOgorICAgICAgICAoRHJhZ0ltYWdlVGVzdC5DcmVh dGVEcmFnSW1hZ2UpOiB0ZXN0IHRoYXQgdGhlIGRyYWcgaW1hZ2UgaXMgYSBkZWVwIGNvcHkKKwog MjAxMC0wNC0yOCAgRGFyaW4gRmlzaGVyICA8ZGFyaW5AY2hyb21pdW0ub3JnPgogCiAgICAgICAg IFJldmlld2VkIGJ5IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViS2l0L2Nocm9taXVtL3Rl c3RzL0RyYWdJbWFnZVRlc3QuY3BwIGIvV2ViS2l0L2Nocm9taXVtL3Rlc3RzL0RyYWdJbWFnZVRl c3QuY3BwCmluZGV4IDZjOTcxOGUuLjdiN2Q0ZWUgMTAwNjQ0Ci0tLSBhL1dlYktpdC9jaHJvbWl1 bS90ZXN0cy9EcmFnSW1hZ2VUZXN0LmNwcAorKysgYi9XZWJLaXQvY2hyb21pdW0vdGVzdHMvRHJh Z0ltYWdlVGVzdC5jcHAKQEAgLTExOCwxOSArMTE4LDI5IEBAIFRFU1QoRHJhZ0ltYWdlVGVzdCwg Tm9uTnVsbEhhbmRsaW5nKQogICAgIEVYUEVDVF9FUSgxLCBzaXplLndpZHRoKCkpOwogICAgIEVY UEVDVF9FUSgxLCBzaXplLmhlaWdodCgpKTsKIAotICAgIC8vIFRoaXMgaXMgbm90IGltcGxlbWVu dGVkLCBzbyB3ZSBkb24ndCBkbyBhbnkgb3V0cHV0IHZhbGlkYXRpb24uCiAgICAgZHJhZ0ltYWdl ID0gZGlzc29sdmVEcmFnSW1hZ2VUb0ZyYWN0aW9uKGRyYWdJbWFnZSwgMC41KTsKICAgICBBU1NF UlRfVFJVRShkcmFnSW1hZ2UpOwogCiAgICAgZGVsZXRlRHJhZ0ltYWdlKGRyYWdJbWFnZSk7CiB9 CiAKLVRFU1QoRHJhZ0ltYWdlVGVzdCwgQ3JlYXRlRHJhZ0ltYWdlUmV0dXJuaW5nTnVsbCkKK1RF U1QoRHJhZ0ltYWdlVGVzdCwgQ3JlYXRlRHJhZ0ltYWdlKQogewotICAgIC8vIFRlc3RzIHRoYXQg dGhlIERyYWdlSW1hZ2UgaW1wbGVtZW50YXRpb24gZG9lc24ndCBjaG9rZSBvbiBudWxsIHZhbHVl cwotICAgIC8vIG9mIG5hdGl2ZUltYWdlRm9yQ3VycmVudEZyYW1lKCkuCi0gICAgVGVzdEltYWdl IHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7Ci0gICAgRVhQRUNUX0ZBTFNFKGNyZWF0ZURyYWdJbWFn ZUZyb21JbWFnZSgmdGVzdEltYWdlKSk7CisgICAgeworICAgICAgICAvLyBUZXN0cyB0aGF0IHRo ZSBEcmFnZUltYWdlIGltcGxlbWVudGF0aW9uIGRvZXNuJ3QgY2hva2Ugb24gbnVsbCB2YWx1ZXMK KyAgICAgICAgLy8gb2YgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUoKS4KKyAgICAgICAgVGVz dEltYWdlIHRlc3RJbWFnZSgoSW50U2l6ZSgpKSk7CisgICAgICAgIEVYUEVDVF9GQUxTRShjcmVh dGVEcmFnSW1hZ2VGcm9tSW1hZ2UoJnRlc3RJbWFnZSkpOworICAgIH0KKworICAgIHsKKyAgICAg ICAgLy8gVGVzdHMgdGhhdCB0aGUgZHJhZyBpbWFnZSBpcyBhIGRlZXAgY29weS4KKyAgICAgICAg VGVzdEltYWdlIHRlc3RJbWFnZShJbnRTaXplKDEsIDEpKTsKKyAgICAgICAgRHJhZ0ltYWdlUmVm IGRyYWdJbWFnZSA9IGNyZWF0ZURyYWdJbWFnZUZyb21JbWFnZSgmdGVzdEltYWdlKTsKKyAgICAg ICAgQVNTRVJUX1RSVUUoZHJhZ0ltYWdlKTsKKyAgICAgICAgU2tBdXRvTG9ja1BpeGVscyBsb2Nr MSgqZHJhZ0ltYWdlKSwgbG9jazIoKnRlc3RJbWFnZS5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFt ZSgpKTsKKyAgICAgICAgRVhQRUNUX05FKGRyYWdJbWFnZS0+Z2V0UGl4ZWxzKCksIHRlc3RJbWFn ZS5uYXRpdmVJbWFnZUZvckN1cnJlbnRGcmFtZSgpLT5nZXRQaXhlbHMoKSk7CisgICAgfQogfQog CiB9IC8vIGFub255bW91cyBuYW1lc3BhY2UK