38004 2010-04-22 13:40:12 -0700 The new review tools shouldn't clear the comment box automatically 2010-04-22 21:48:38 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned commit-queue darin oldest_to_newest 216055 0 abarth 2010-04-22 13:40:12 -0700 The new review tools shouldn't clear the comment box automatically 216057 1 54092 abarth 2010-04-22 13:41:33 -0700 Created attachment 54092 Patch 216176 2 54092 darin 2010-04-22 17:21:14 -0700 Comment on attachment 54092 Patch Seems OK. Also seems it would be best to clear the comments only when the entire comment area is untouched to avoid clobbering things people typed. Lets just keep experimenting, I guess. r=me 216261 3 54092 abarth 2010-04-22 21:25:51 -0700 Comment on attachment 54092 Patch Yeah, I think we should get the minimum viable product and then iterate from there. Sorry to have disrupted your workflow. 216270 4 54092 commit-queue 2010-04-22 21:48:33 -0700 Comment on attachment 54092 Patch Clearing flags on attachment: 54092 Committed r58148: <http://trac.webkit.org/changeset/58148> 216271 5 commit-queue 2010-04-22 21:48:38 -0700 All reviewed patches have been landed. Closing bug. 54092 2010-04-22 13:41:33 -0700 2010-04-22 21:48:32 -0700 Patch bug-38004-20100422134132.patch text/plain 2451 abarth ZGlmZiAtLWdpdCBhL0J1Z3NTaXRlL0NoYW5nZUxvZyBiL0J1Z3NTaXRlL0NoYW5nZUxvZwppbmRl eCBjYjZjZmJiLi5jZTYxMjQ2IDEwMDY0NAotLS0gYS9CdWdzU2l0ZS9DaGFuZ2VMb2cKKysrIGIv QnVnc1NpdGUvQ2hhbmdlTG9nCkBAIC0xLDUgKzEsMTkgQEAKIDIwMTAtMDQtMjIgIEFkYW0gQmFy dGggIDxhYmFydGhAd2Via2l0Lm9yZz4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9P UFMhKS4KKworICAgICAgICBUaGUgbmV3IHJldmlldyB0b29scyBzaG91bGRuJ3QgY2xlYXIgdGhl IGNvbW1lbnQgYm94IGF1dG9tYXRpY2FsbHkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5v cmcvc2hvd19idWcuY2dpP2lkPTM4MDA0CisKKyAgICAgICAgSW5zdGVhZCwgd2Ugbm93IGhhdmUg YSBidXR0b24gZm9yIGRvaW5nIHRoYXQgZXhwbGljaXRseS4gIElmIHBlb3BsZQorICAgICAgICBs aWtlIHRoaXMgdG9vbCwgd2UgY2FuIGxvb2sgYXQgZmFuY2llciBzb2x1dGlvbnMuCisKKyAgICAg ICAgQWxzbywgdHJpZWQgdG8gbWFrZSB0aGUgdG9vbCB3b3JrIG9uIHRoZSBlZGl0IHBhZ2UgYXMg d2VsbCBhcyB0aGUgcmV2aWV3IHBhZ2UuCisKKyAgICAgICAgKiBQcmV0dHlQYXRjaC9QcmV0dHlQ YXRjaC5yYjoKKworMjAxMC0wNC0yMiAgQWRhbSBCYXJ0aCAgPGFiYXJ0aEB3ZWJraXQub3JnPgor CiAgICAgICAgIFVucmV2aWV3ZWQuICBUdXJucyBvdXQgd2UgbmVlZCB0byBkbyBtb3JlIGVzY2Fw aW5nIGJlY2F1c2UgUnVieSB3YXMKICAgICAgICAgZXhwbGFuZGluZyBvdXIgbmV3bGluZXMsIGNy ZWF0aW5nIGEgc3ludGF4IGVycm9yLgogCmRpZmYgLS1naXQgYS9CdWdzU2l0ZS9QcmV0dHlQYXRj aC9QcmV0dHlQYXRjaC5yYiBiL0J1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCmlu ZGV4IGEwMDNiN2MuLjFlNWU5MDYgMTAwNjQ0Ci0tLSBhL0J1Z3NTaXRlL1ByZXR0eVBhdGNoL1By ZXR0eVBhdGNoLnJiCisrKyBiL0J1Z3NTaXRlL1ByZXR0eVBhdGNoL1ByZXR0eVBhdGNoLnJiCkBA IC0yMDIsOSArMjAyLDE1IEBAIGgxIDpob3ZlciB7CiA8c2NyaXB0IHNyYz0iaHR0cHM6Ly9idWdz LndlYmtpdC5vcmcvcHJvdG90eXBlLmpzIj48L3NjcmlwdD4gCiA8c2NyaXB0PgogLy8gQ29kZSB0 byBzdXBwb3J0IGlubGluZSBjb21tZW50cyBpbiBidWdzLndlYmtpdC5vcmcuCisKIGZ1bmN0aW9u IGdldFN1Ym1pdFRleHRBcmVhKCkgewogICAvLyBOb3RlIHRoYXQgdGhpcyBvbmx5IHdvcmtzIHdo ZW4gcnVubmluZyBvbiBzYW1lIGRvbWFpbi4KLSAgcmV0dXJuIHBhcmVudC5mcmFtZXNbMV0uZG9j dW1lbnQuZ2V0RWxlbWVudHNCeVRhZ05hbWUoInRleHRhcmVhIilbMF07CisgIGlmIChwYXJlbnQu ZnJhbWVzLmxlbmd0aCA9PSAyKSB7CisgICAgLy8gV2UncmUgcHJvYmFibHkgaW4gdGhlIGFjdGlv bj1yZXZpZXcgcGFnZS4KKyAgICByZXR1cm4gcGFyZW50LmZyYW1lc1sxXS5kb2N1bWVudC5nZXRF bGVtZW50QnlJZCgiY29tbWVudCIpOworICB9CisgIC8vIFdlJ3JlIHByb2JhYmx5IGluIHRoZSBh Y3Rpb249ZWRpdCBwYWdlLgorICByZXR1cm4gcGFyZW50LmRvY3VtZW50LmdldEVsZW1lbnRCeUlk KCJzbWFsbENvbW1lbnRGcmFtZSIpOwogfQogCiBmdW5jdGlvbiBvbkxpbmVDbGlja2VkKGUpIHsK QEAgLTI3NCwxNyArMjgwLDIxIEBAIGZ1bmN0aW9uIG9uQ29tbWVudENhbmNlbChjb21tZW50KSB7 CiAgIGNvbW1lbnQucmVtb3ZlKCk7CiB9CiAKK2Z1bmN0aW9uIG9uQ2xlYXJTdWJtaXRBcmVhKCkg eworICB2YXIgc3VibWlzc2lvbiA9IGdldFN1Ym1pdFRleHRBcmVhKCk7CisgIHN1Ym1pc3Npb24u dmFsdWUgPSAiIjsKK30KKwogaWYgKHRvcCAhPT0gd2luZG93KSB7CiAgIHdpbmRvdy5hZGRFdmVu dExpc3RlbmVyKCJsb2FkIiwgZnVuY3Rpb24gKCkgewogICAgIHZhciBsaW5lcyA9ICQkKCJkaXZb Y2xhc3N+PSdMaW5lJ10iKTsKICAgICBmb3IgKHZhciBpID0gMDsgaSA8IGxpbmVzLmxlbmd0aDsg KytpKSB7CiAgICAgICBsaW5lc1tpXS5hZGRFdmVudExpc3RlbmVyKCJjbGljayIsIG9uTGluZUNs aWNrZWQsIGZhbHNlKTsKICAgICB9Ci0gIH0sIGZhbHNlKTsKIAotICBwYXJlbnQuYWRkRXZlbnRM aXN0ZW5lcigibG9hZCIsIGZ1bmN0aW9uICgpIHsKLSAgICAvLyBSZW1vdmUgdGhlIGZ1bGwgZGlm ZiBmcm9tIHRoZSBzdWJtaXQgdGV4dCBhcmVhLgotICAgIHJldHVybiBwYXJlbnQuZnJhbWVzWzFd LmRvY3VtZW50LmdldEVsZW1lbnRzQnlUYWdOYW1lKCJ0ZXh0YXJlYSIpWzBdLnZhbHVlID0gIiI7 CisgICAgJCQoImgxIilbMF0uaW5zZXJ0KCI8YnV0dG9uIHN0eWxlPSdmbG9hdDpyaWdodDsnICIr CisgICAgICAib25jbGljaz0nb25DbGVhclN1Ym1pdEFyZWEoKSc+IiArCisgICAgICAiQ2xlYXIg TWFpbiBDb21tZW50IEJveDwvYnV0dG9uPiIpOwogICB9LCBmYWxzZSk7CiB9CiA8L3NjcmlwdD4K