37988 2010-04-22 05:58:12 -0700 Web Inspector: Audits (Image Dimensions): full image URLs are prefixed with the hosting page name 2010-04-23 06:05:17 -0700 1 1 1 Unclassified WebKit Web Inspector (Deprecated) 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 apavlov apavlov bweinstein commit-queue joepeck keishi pfeldman pmuellr rik timothy yurys oldest_to_newest 215844 0 apavlov 2010-04-22 05:58:12 -0700 If there is an "Image Dimensions" audit violation and the image URL is a complete http://foo-type URL, it will be prefixed with the page name (like, home/http://foo) in the audit results. 215847 1 54055 apavlov 2010-04-22 06:10:07 -0700 Created attachment 54055 [PATCH] Suggested fix 215884 2 54055 joepeck 2010-04-22 08:28:02 -0700 Comment on attachment 54055 [PATCH] Suggested fix > + var srcMatch = src.match(WebInspector.URLRegExp); > + if (!srcMatch) { You don't use the match object, you're just testing. This can be: if (!WebInspector.URLRegExp.test(src)) { 215921 3 54068 apavlov 2010-04-22 09:41:19 -0700 Created attachment 54068 [PATCH] Comments addressed 216386 4 54068 commit-queue 2010-04-23 06:05:12 -0700 Comment on attachment 54068 [PATCH] Comments addressed Clearing flags on attachment: 54068 Committed r58163: <http://trac.webkit.org/changeset/58163> 216387 5 commit-queue 2010-04-23 06:05:17 -0700 All reviewed patches have been landed. Closing bug. 54055 2010-04-22 06:10:07 -0700 2010-04-22 09:41:19 -0700 [PATCH] Suggested fix imageauditurls.patch text/plain 1873 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTY2MTc4NS4uNDgxM2ZiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0yMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0cyAoSW1hZ2UgRGltZW5z aW9ucyk6IGZ1bGwgaW1hZ2UgVVJMcyBhcmUgcHJlZml4ZWQgd2l0aCB0aGUgaG9zdGluZyBwYWdl IG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 OTg4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5JbWFnZURpbWVuc2lvbnNSdWxlLnByb3RvdHlw ZS5kb1J1bik6CisKIDIwMTAtMDQtMjIgIEd1c3Rhdm8gU3Zlcnp1dCBCYXJiaWVyaSAgPGJhcmJp ZXJpQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRSdWxlcy5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzCmluZGV4IGQyYzVmMDkuLmQ4 Mjk1ZWUgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVz LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzCkBAIC02 NDcsMTAgKzY0NywxMyBAQCBXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5JbWFnZURpbWVuc2lvbnNS dWxlLnByb3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgY29uc3Qgbm9kZSA9IFdlYkluc3BlY3Rv ci5kb21BZ2VudC5ub2RlRm9ySWQoaW1hZ2VJZCk7CiAgICAgICAgICAgICB2YXIgc3JjID0gbm9k ZS5nZXRBdHRyaWJ1dGUoInNyYyIpOwotICAgICAgICAgICAgZm9yICh2YXIgZnJhbWVPd25lckNh bmRpZGF0ZSA9IG5vZGU7IGZyYW1lT3duZXJDYW5kaWRhdGU7IGZyYW1lT3duZXJDYW5kaWRhdGUg PSBmcmFtZU93bmVyQ2FuZGlkYXRlLnBhcmVudE5vZGUpIHsKLSAgICAgICAgICAgICAgICBpZiAo ZnJhbWVPd25lckNhbmRpZGF0ZS5kb2N1bWVudFVSTCkgewotICAgICAgICAgICAgICAgICAgICB2 YXIgY29tcGxldGVTcmMgPSBXZWJJbnNwZWN0b3IuY29tcGxldGVVUkwoZnJhbWVPd25lckNhbmRp ZGF0ZS5kb2N1bWVudFVSTCwgc3JjKTsKLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICB2YXIgc3JjTWF0Y2ggPSBzcmMubWF0Y2goV2ViSW5zcGVjdG9yLlVSTFJlZ0V4cCk7 CisgICAgICAgICAgICBpZiAoIXNyY01hdGNoKSB7CisgICAgICAgICAgICAgICAgZm9yICh2YXIg ZnJhbWVPd25lckNhbmRpZGF0ZSA9IG5vZGU7IGZyYW1lT3duZXJDYW5kaWRhdGU7IGZyYW1lT3du ZXJDYW5kaWRhdGUgPSBmcmFtZU93bmVyQ2FuZGlkYXRlLnBhcmVudE5vZGUpIHsKKyAgICAgICAg ICAgICAgICAgICAgaWYgKGZyYW1lT3duZXJDYW5kaWRhdGUuZG9jdW1lbnRVUkwpIHsKKyAgICAg ICAgICAgICAgICAgICAgICAgIHZhciBjb21wbGV0ZVNyYyA9IFdlYkluc3BlY3Rvci5jb21wbGV0 ZVVSTChmcmFtZU93bmVyQ2FuZGlkYXRlLmRvY3VtZW50VVJMLCBzcmMpOworICAgICAgICAgICAg ICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgICAg ICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAoY29tcGxldGVTcmMpCg== 54068 2010-04-22 09:41:19 -0700 2010-04-23 06:05:12 -0700 [PATCH] Comments addressed imageauditurls.patch text/plain 1834 apavlov ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg YTY2MTc4NS4uNDgxM2ZiMyAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0yMiAgQWxleGFuZGVyIFBh dmxvdiAgPGFwYXZsb3ZAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFdlYiBJbnNwZWN0b3I6IEF1ZGl0cyAoSW1hZ2UgRGltZW5z aW9ucyk6IGZ1bGwgaW1hZ2UgVVJMcyBhcmUgcHJlZml4ZWQgd2l0aCB0aGUgaG9zdGluZyBwYWdl IG5hbWUKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 OTg4CisKKyAgICAgICAgKiBpbnNwZWN0b3IvZnJvbnQtZW5kL0F1ZGl0UnVsZXMuanM6CisgICAg ICAgIChXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5JbWFnZURpbWVuc2lvbnNSdWxlLnByb3RvdHlw ZS5kb1J1bik6CisKIDIwMTAtMDQtMjIgIEd1c3Rhdm8gU3Zlcnp1dCBCYXJiaWVyaSAgPGJhcmJp ZXJpQHByb2Z1c2lvbi5tb2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEFkYW0gUm9iZW4uCmRp ZmYgLS1naXQgYS9XZWJDb3JlL2luc3BlY3Rvci9mcm9udC1lbmQvQXVkaXRSdWxlcy5qcyBiL1dl YkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzCmluZGV4IGQyYzVmMDkuLmE2 OTc2YjEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVz LmpzCisrKyBiL1dlYkNvcmUvaW5zcGVjdG9yL2Zyb250LWVuZC9BdWRpdFJ1bGVzLmpzCkBAIC02 NDcsMTAgKzY0NywxMiBAQCBXZWJJbnNwZWN0b3IuQXVkaXRSdWxlcy5JbWFnZURpbWVuc2lvbnNS dWxlLnByb3RvdHlwZSA9IHsKIAogICAgICAgICAgICAgY29uc3Qgbm9kZSA9IFdlYkluc3BlY3Rv ci5kb21BZ2VudC5ub2RlRm9ySWQoaW1hZ2VJZCk7CiAgICAgICAgICAgICB2YXIgc3JjID0gbm9k ZS5nZXRBdHRyaWJ1dGUoInNyYyIpOwotICAgICAgICAgICAgZm9yICh2YXIgZnJhbWVPd25lckNh bmRpZGF0ZSA9IG5vZGU7IGZyYW1lT3duZXJDYW5kaWRhdGU7IGZyYW1lT3duZXJDYW5kaWRhdGUg PSBmcmFtZU93bmVyQ2FuZGlkYXRlLnBhcmVudE5vZGUpIHsKLSAgICAgICAgICAgICAgICBpZiAo ZnJhbWVPd25lckNhbmRpZGF0ZS5kb2N1bWVudFVSTCkgewotICAgICAgICAgICAgICAgICAgICB2 YXIgY29tcGxldGVTcmMgPSBXZWJJbnNwZWN0b3IuY29tcGxldGVVUkwoZnJhbWVPd25lckNhbmRp ZGF0ZS5kb2N1bWVudFVSTCwgc3JjKTsKLSAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAg ICAgICAgICBpZiAoIVdlYkluc3BlY3Rvci5VUkxSZWdFeHAudGVzdChzcmMpKSB7CisgICAgICAg ICAgICAgICAgZm9yICh2YXIgZnJhbWVPd25lckNhbmRpZGF0ZSA9IG5vZGU7IGZyYW1lT3duZXJD YW5kaWRhdGU7IGZyYW1lT3duZXJDYW5kaWRhdGUgPSBmcmFtZU93bmVyQ2FuZGlkYXRlLnBhcmVu dE5vZGUpIHsKKyAgICAgICAgICAgICAgICAgICAgaWYgKGZyYW1lT3duZXJDYW5kaWRhdGUuZG9j dW1lbnRVUkwpIHsKKyAgICAgICAgICAgICAgICAgICAgICAgIHZhciBjb21wbGV0ZVNyYyA9IFdl Ykluc3BlY3Rvci5jb21wbGV0ZVVSTChmcmFtZU93bmVyQ2FuZGlkYXRlLmRvY3VtZW50VVJMLCBz cmMpOworICAgICAgICAgICAgICAgICAgICAgICAgYnJlYWs7CisgICAgICAgICAgICAgICAgICAg IH0KICAgICAgICAgICAgICAgICB9CiAgICAgICAgICAgICB9CiAgICAgICAgICAgICBpZiAoY29t cGxldGVTcmMpCg==