37975 2010-04-21 23:52:30 -0700 webkit-patch can't fetch attachments on security bugs 2010-04-23 18:58:52 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) Other OS X 10.5 RESOLVED FIXED P2 Normal --- 1 abarth webkit-unassigned eric oldest_to_newest 215740 0 abarth 2010-04-21 23:52:30 -0700 webkit-patch can't fetch attachments on security bugs 215741 1 54032 abarth 2010-04-21 23:53:57 -0700 Created attachment 54032 Patch 215742 2 54032 eric 2010-04-21 23:57:01 -0700 Comment on attachment 54032 Patch Yay! 215743 3 abarth 2010-04-21 23:59:31 -0700 Committed r58066: <http://trac.webkit.org/changeset/58066> 216561 4 eric 2010-04-23 14:32:54 -0700 This broke a whole bunch of scm tests: ====================================================================== ERROR: test_apply_small_binary_patch (webkitpy.common.checkout.scm_unittest.SVNTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 539, in test_apply_small_binary_patch self.checkout.apply_patch(patch_file) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch run_command(args, input=patch.contents()) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents return self._bug._bugzilla.fetch_attachment_contents(self.id()) AttributeError: 'NoneType' object has no attribute '_bugzilla' ====================================================================== ERROR: test_apply_svn_patch (webkitpy.common.checkout.scm_unittest.SVNTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 545, in test_apply_svn_patch patch = self._create_patch(_svn_diff("-r4:3")) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 82, in _svn_diff return _make_diff("svn", *args) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 78, in _make_diff return run_command([command, "diff"] + args, decode_output=False) TypeError: can only concatenate list (not "tuple") to list ====================================================================== ERROR: test_apply_svn_patch_force (webkitpy.common.checkout.scm_unittest.SVNTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 551, in test_apply_svn_patch_force patch = self._create_patch(_svn_diff("-r2:4")) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 82, in _svn_diff return _make_diff("svn", *args) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 78, in _make_diff return run_command([command, "diff"] + args, decode_output=False) TypeError: can only concatenate list (not "tuple") to list ====================================================================== ERROR: test_svn_apply (webkitpy.common.checkout.scm_unittest.SVNTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 476, in test_svn_apply self.checkout.apply_patch(self._create_patch(one_line_overlap_patch)) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch run_command(args, input=patch.contents()) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents return self._bug._bugzilla.fetch_attachment_contents(self.id()) AttributeError: 'NoneType' object has no attribute '_bugzilla' ====================================================================== ERROR: test_svn_apply_git_patch (webkitpy.common.checkout.scm_unittest.SVNTest) ---------------------------------------------------------------------- Traceback (most recent call last): File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 594, in test_svn_apply_git_patch self._shared_test_svn_apply_git_patch() File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/scm_unittest.py", line 329, in _shared_test_svn_apply_git_patch self.checkout.apply_patch(self._create_patch(git_binary_addition)) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/checkout/api.py", line 124, in apply_patch run_command(args, input=patch.contents()) File "/Projects/WebKit/WebKitTools/Scripts/webkitpy/common/net/bugzilla.py", line 122, in contents return self._bug._bugzilla.fetch_attachment_contents(self.id()) AttributeError: 'NoneType' object has no attribute '_bugzilla' ---------------------------------------------------------------------- Ran 426 tests in 313.016s 216668 5 abarth 2010-04-23 18:58:52 -0700 > 313s Sorry about that. I wish the ECM tests were faster so we could run them all the time. 54032 2010-04-21 23:53:57 -0700 2010-04-21 23:57:01 -0700 Patch bug-37975-20100421235355.patch text/plain 3252 abarth SW5kZXg6IFdlYktpdFRvb2xzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9D aGFuZ2VMb2cJKHJldmlzaW9uIDU4MDY1KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3Jr aW5nIGNvcHkpCkBAIC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjEgIEFkYW0gQmFydGggIDxhYmFy dGhAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICB3ZWJraXQtcGF0Y2ggY2FuJ3QgZmV0Y2ggYXR0YWNobWVudHMgb24gc2VjdXJpdHkg YnVncworICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5 NzUKKworICAgICAgICBJbnN0ZWFkIG9mIGNhbGxpbmcgQ1VSTCwgd2UganVzdCBuZWVkIHRvIHVz ZSBvdXIgTWVjaGFuaXplIG9iamVjdCwKKyAgICAgICAgd2hpY2ggdW5kZXJzdGFuZCBidWdzLndl YmtpdC5vcmcgYXV0aGVudGljYXRpb24uCisKKyAgICAgICAgKiBTY3JpcHRzL3dlYmtpdHB5L2Nv bW1vbi9jaGVja291dC9hcGkucHk6CisgICAgICAgICogU2NyaXB0cy93ZWJraXRweS9jb21tb24v bmV0L2J1Z3ppbGxhLnB5OgorCiAyMDEwLTA0LTIxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0 Lm9yZz4KIAogICAgICAgICBVbnJldmlld2VkLiAgVGVtcG9yYXJ5IGNvbW1pdCwgd2lsbCByb2xs LW91dCBiZWZvcmUgbW9ybmluZy4KSW5kZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkv Y29tbW9uL2NoZWNrb3V0L2FwaS5weQo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRz L3dlYmtpdHB5L2NvbW1vbi9jaGVja291dC9hcGkucHkJKHJldmlzaW9uIDU4MDU5KQorKysgV2Vi S2l0VG9vbHMvU2NyaXB0cy93ZWJraXRweS9jb21tb24vY2hlY2tvdXQvYXBpLnB5CSh3b3JraW5n IGNvcHkpCkBAIC0xMTUsMTYgKzExNSwxMyBAQCBjbGFzcyBDaGVja291dChvYmplY3QpOgogICAg IGRlZiBhcHBseV9wYXRjaChzZWxmLCBwYXRjaCwgZm9yY2U9RmFsc2UpOgogICAgICAgICAjIEl0 J3MgcG9zc2libGUgdGhhdCB0aGUgcGF0Y2ggd2FzIG5vdCBtYWRlIGZyb20gdGhlIHJvb3QgZGly ZWN0b3J5LgogICAgICAgICAjIFdlIHNob3VsZCBkZXRlY3QgYW5kIGhhbmRsZSB0aGF0IGNhc2Uu Ci0gICAgICAgICMgRklYTUU6IFVzZSBFeGVjdXRpdmUgaW5zdGVhZCBvZiBzdWJwcm9jZXNzIGhl cmUuCi0gICAgICAgIGN1cmxfcHJvY2VzcyA9IHN1YnByb2Nlc3MuUG9wZW4oWydjdXJsJywgJy0t bG9jYXRpb24nLCAnLS1zaWxlbnQnLCAnLS1zaG93LWVycm9yJywgcGF0Y2gudXJsKCldLCBzdGRv dXQ9c3VicHJvY2Vzcy5QSVBFKQogICAgICAgICAjIEZJWE1FOiBNb3ZlIF9zY20uc2NyaXB0X3Bh dGggaGVyZSBvbmNlIHdlIGdldCByaWQgb2YgYWxsIHRoZSBkZXBlbmRlbmNpZXMuCiAgICAgICAg IGFyZ3MgPSBbc2VsZi5fc2NtLnNjcmlwdF9wYXRoKCdzdm4tYXBwbHknKV0KICAgICAgICAgaWYg cGF0Y2gucmV2aWV3ZXIoKToKICAgICAgICAgICAgIGFyZ3MgKz0gWyctLXJldmlld2VyJywgcGF0 Y2gucmV2aWV3ZXIoKS5mdWxsX25hbWVdCiAgICAgICAgIGlmIGZvcmNlOgogICAgICAgICAgICAg YXJncy5hcHBlbmQoJy0tZm9yY2UnKQotCi0gICAgICAgIHJ1bl9jb21tYW5kKGFyZ3MsIGlucHV0 PWN1cmxfcHJvY2Vzcy5zdGRvdXQpCisgICAgICAgIHJ1bl9jb21tYW5kKGFyZ3MsIGlucHV0PXBh dGNoLmNvbnRlbnRzKCkpCiAKICAgICBkZWYgYXBwbHlfcmV2ZXJzZV9kaWZmKHNlbGYsIHJldmlz aW9uKToKICAgICAgICAgc2VsZi5fc2NtLmFwcGx5X3JldmVyc2VfZGlmZihyZXZpc2lvbikKSW5k ZXg6IFdlYktpdFRvb2xzL1NjcmlwdHMvd2Via2l0cHkvY29tbW9uL25ldC9idWd6aWxsYS5weQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9TY3JpcHRzL3dlYmtpdHB5L2NvbW1vbi9uZXQvYnVn emlsbGEucHkJKHJldmlzaW9uIDU4MDU5KQorKysgV2ViS2l0VG9vbHMvU2NyaXB0cy93ZWJraXRw eS9jb21tb24vbmV0L2J1Z3ppbGxhLnB5CSh3b3JraW5nIGNvcHkpCkBAIC0xMTcsNiArMTE3LDEw IEBAIGNsYXNzIEF0dGFjaG1lbnQob2JqZWN0KToKICAgICAgICAgIyBkZXBlbmRzIG9uIHRoZSBj dXJyZW50IGJlaGF2aW9yLgogICAgICAgICByZXR1cm4gc2VsZi5fYXR0YWNobWVudF9kaWN0aW9u YXJ5LmdldCgidXJsIikKIAorICAgIGRlZiBjb250ZW50cyhzZWxmKToKKyAgICAgICAgIyBGSVhN RTogV2Ugc2hvdWxkbid0IGJlIGdyYWJiaW5nIGF0IF9idWd6aWxsYS4KKyAgICAgICAgcmV0dXJu IHNlbGYuX2J1Zy5fYnVnemlsbGEuZmV0Y2hfYXR0YWNobWVudF9jb250ZW50cyhzZWxmLmlkKCkp CisKICAgICBkZWYgX3ZhbGlkYXRlX2ZsYWdfdmFsdWUoc2VsZiwgZmxhZyk6CiAgICAgICAgIGVt YWlsID0gc2VsZi5fYXR0YWNobWVudF9kaWN0aW9uYXJ5LmdldCgiJXNfZW1haWwiICUgZmxhZykK ICAgICAgICAgaWYgbm90IGVtYWlsOgpAQCAtNDg2LDYgKzQ5MCwxMiBAQCBjbGFzcyBCdWd6aWxs YShvYmplY3QpOgogICAgIGRlZiBmZXRjaF9idWcoc2VsZiwgYnVnX2lkKToKICAgICAgICAgcmV0 dXJuIEJ1ZyhzZWxmLmZldGNoX2J1Z19kaWN0aW9uYXJ5KGJ1Z19pZCksIHNlbGYpCiAKKyAgICBk ZWYgZmV0Y2hfYXR0YWNobWVudF9jb250ZW50cyhzZWxmLCBhdHRhY2htZW50X2lkKToKKyAgICAg ICAgYXR0YWNobWVudF91cmwgPSBzZWxmLmF0dGFjaG1lbnRfdXJsX2Zvcl9pZChhdHRhY2htZW50 X2lkKQorICAgICAgICAjIFdlIG5lZWQgdG8gYXV0aGVudGljYXRlIHRvIGRvd25sb2FkIHBhdGNo ZXMgZnJvbSBzZWN1cml0eSBidWdzLgorICAgICAgICBzZWxmLmF1dGhlbnRpY2F0ZSgpCisgICAg ICAgIHJldHVybiBzZWxmLmJyb3dzZXIub3BlbihhdHRhY2htZW50X3VybCkucmVhZCgpCisKICAg ICBkZWYgX3BhcnNlX2J1Z19pZF9mcm9tX2F0dGFjaG1lbnRfcGFnZShzZWxmLCBwYWdlKToKICAg ICAgICAgIyBUaGUgIlVwIiByZWxhdGlvbiBoYXBwZW5zIHRvIHBvaW50IHRvIHRoZSBidWcuCiAg ICAgICAgIHVwX2xpbmsgPSBCZWF1dGlmdWxTb3VwKHBhZ2UpLmZpbmQoJ2xpbmsnLCByZWw9J1Vw JykK