37963 2010-04-21 17:24:29 -0700 Regression: framebufferRenderbuffer crashes with null renderBuffer 2010-04-22 10:04:22 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 1 kbr zmo cmarrin commit-queue dglazkov fishd kbr oliver oldest_to_newest 215581 0 kbr 2010-04-21 17:24:29 -0700 https://bugs.webkit.org/show_bug.cgi?id=35611 introduced a regression in framebufferRenderbuffer when a null renderBuffer is passed; the null pointer is dereferenced and the WebGLRenderingContext crashes. 215589 1 54009 zmo 2010-04-21 17:50:58 -0700 Created attachment 54009 patch 215590 2 54009 kbr 2010-04-21 17:55:15 -0700 Comment on attachment 54009 patch Looks good. Thanks for the quick fix. 215911 3 54009 dglazkov 2010-04-22 09:25:07 -0700 Comment on attachment 54009 patch r=me. 215934 4 54009 commit-queue 2010-04-22 10:04:15 -0700 Comment on attachment 54009 patch Clearing flags on attachment: 54009 Committed r58103: <http://trac.webkit.org/changeset/58103> 215935 5 commit-queue 2010-04-22 10:04:22 -0700 All reviewed patches have been landed. Closing bug. 54009 2010-04-21 17:50:58 -0700 2010-04-22 10:04:14 -0700 patch null.patch text/plain 4895 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODAzMikKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMjEgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBSZWdyZXNz aW9uOiBmcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZlciBjcmFzaGVzIHdpdGggbnVsbCByZW5kZXJCdWZm ZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTYz CisKKyAgICAgICAgKiBodG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwOgorICAg ICAgICAoV2ViQ29yZTo6V2ViR0xSZW5kZXJpbmdDb250ZXh0OjpmcmFtZWJ1ZmZlclJlbmRlcmJ1 ZmZlcik6IERlYWxpbmcgd2l0aCBudWxsIHJlbmRlcmJ1ZmZlciBpbnB1dC4KKwogMjAwOS0wNC0y MSAgQ2hyaXMgRmxlaXphY2ggIDxjZmxlaXphY2hAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmll d2VkIGJ5IEFsZXhleSBQcm9za3VyeWFrb3YuCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dl YkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA1ODAzMSkKKysrIFdlYkNvcmUv aHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29ya2luZyBjb3B5KQpAQCAt ODE1LDcgKzgxNSw3IEBAIHZvaWQgV2ViR0xSZW5kZXJpbmdDb250ZXh0OjpmcmFtZWJ1ZmZlclIK ICAgICAgICAgbV9jb250ZXh0LT5zeW50aGVzaXplR0xFcnJvcihHcmFwaGljc0NvbnRleHQzRDo6 SU5WQUxJRF9PUEVSQVRJT04pOwogICAgICAgICByZXR1cm47CiAgICAgfQotICAgIGlmIChidWZm ZXItPm9iamVjdCgpKSB7CisgICAgaWYgKGJ1ZmZlciAmJiBidWZmZXItPm9iamVjdCgpKSB7CiAg ICAgICAgIGJvb2wgaXNDb25mbGljdGVkID0gZmFsc2U7CiAgICAgICAgIGJvb2wgaXNEZXB0aE9y U3RlbmNpbCA9IHRydWU7CiAgICAgICAgIHN3aXRjaCAoYXR0YWNobWVudCkgewpJbmRleDogTGF5 b3V0VGVzdHMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL0NoYW5nZUxvZwko cmV2aXNpb24gNTgwMzIpCisrKyBMYXlvdXRUZXN0cy9DaGFuZ2VMb2cJKHdvcmtpbmcgY29weSkK QEAgLTEsMyArMSwxMyBAQAorMjAxMC0wNC0yMSAgWmhlbnlhbyBNbyAgPHptb0Bnb29nbGUuY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFJlZ3Jl c3Npb246IGZyYW1lYnVmZmVyUmVuZGVyYnVmZmVyIGNyYXNoZXMgd2l0aCBudWxsIHJlbmRlckJ1 ZmZlcgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5 NjMKKworICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVyLW9iamVjdC1hdHRh Y2htZW50LWV4cGVjdGVkLnR4dDogQWRkaW5nIHRlc3QgY2FzZXMgZm9yIG51bGwgcmVuZGVyYnVm ZmVyIGlucHV0LgorICAgICAgICAqIGZhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVyLW9iamVj dC1hdHRhY2htZW50Lmh0bWw6IERpdHRvLgorCiAyMDEwLTA0LTIxICBDaHJpcyBGbGVpemFjaCAg PGNmbGVpemFjaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWxleGV5IFByb3Nr dXJ5YWtvdi4KSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVy LW9iamVjdC1hdHRhY2htZW50LWV4cGVjdGVkLnR4dAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9mYXN0L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmplY3QtYXR0YWNobWVudC1leHBlY3Rl ZC50eHQJKHJldmlzaW9uIDU4MDMxKQorKysgTGF5b3V0VGVzdHMvZmFzdC9jYW52YXMvd2ViZ2wv ZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQtZXhwZWN0ZWQudHh0CSh3b3JraW5nIGNvcHkp CkBAIC00MSwyNiArNDEsMzggQEAgQXR0YWNoIGRlcHRoLCB0aGVuIHN0ZW5jaWwsIGNhdXNpbmcg Y29uZgogUEFTUyBmYm8gPSBnbC5jcmVhdGVGcmFtZWJ1ZmZlcigpIGlzIG5vbi1udWxsLgogUEFT UyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wu SU5WQUxJRF9PUEVSQVRJT04KK1BBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5OT19FUlJPUgorUEFT UyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCiBBdHRhY2ggc3RlbmNpbCwgdGhlbiBkZXB0 aCwgY2F1c2luZyBjb25mbGljdAogUEFTUyBmYm8gPSBnbC5jcmVhdGVGcmFtZWJ1ZmZlcigpIGlz IG5vbi1udWxsLgogUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCiBQQVNTIGdsLmdl dEVycm9yKCkgaXMgZ2wuSU5WQUxJRF9PUEVSQVRJT04KK1BBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBn bC5OT19FUlJPUgorUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCiBBdHRhY2ggZGVw dGgsIHRoZW4gZGVwdGhTdGVuY2lsLCBjYXVzaW5nIGNvbmZsaWN0CiBQQVNTIGZibyA9IGdsLmNy ZWF0ZUZyYW1lYnVmZmVyKCkgaXMgbm9uLW51bGwuCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wu Tk9fRVJST1IKIFBBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5JTlZBTElEX09QRVJBVElPTgorUEFT UyBnbC5nZXRFcnJvcigpIGlzIGdsLk5PX0VSUk9SCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wu Tk9fRVJST1IKIEF0dGFjaCBkZXB0aFN0ZW5jaWwsIHRoZW4gZGVwdGgsIGNhdXNpbmcgY29uZmxp Y3QKIFBBU1MgZmJvID0gZ2wuY3JlYXRlRnJhbWVidWZmZXIoKSBpcyBub24tbnVsbC4KIFBBU1Mg Z2wuZ2V0RXJyb3IoKSBpcyBnbC5OT19FUlJPUgogUEFTUyBnbC5nZXRFcnJvcigpIGlzIGdsLklO VkFMSURfT1BFUkFUSU9OCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IKK1BBU1Mg Z2wuZ2V0RXJyb3IoKSBpcyBnbC5OT19FUlJPUgogQXR0YWNoIHN0ZW5jaWwsIHRoZW4gZGVwdGhT dGVuY2lsLCBjYXVzaW5nIGNvbmZsaWN0CiBQQVNTIGZibyA9IGdsLmNyZWF0ZUZyYW1lYnVmZmVy KCkgaXMgbm9uLW51bGwuCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IKIFBBU1Mg Z2wuZ2V0RXJyb3IoKSBpcyBnbC5JTlZBTElEX09QRVJBVElPTgorUEFTUyBnbC5nZXRFcnJvcigp IGlzIGdsLk5PX0VSUk9SCitQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuTk9fRVJST1IKIEF0dGFj aCBkZXB0aFN0ZW5jaWwsIHRoZW4gc3RlbmNpbCwgY2F1c2luZyBjb25mbGljdAogUEFTUyBmYm8g PSBnbC5jcmVhdGVGcmFtZWJ1ZmZlcigpIGlzIG5vbi1udWxsLgogUEFTUyBnbC5nZXRFcnJvcigp IGlzIGdsLk5PX0VSUk9SCiBQQVNTIGdsLmdldEVycm9yKCkgaXMgZ2wuSU5WQUxJRF9PUEVSQVRJ T04KK1BBU1MgZ2wuZ2V0RXJyb3IoKSBpcyBnbC5OT19FUlJPUgorUEFTUyBnbC5nZXRFcnJvcigp IGlzIGdsLk5PX0VSUk9SCiBQQVNTIHN1Y2Nlc3NmdWxseVBhcnNlZCBpcyB0cnVlCiAKIFRFU1Qg Q09NUExFVEUKSW5kZXg6IExheW91dFRlc3RzL2Zhc3QvY2FudmFzL3dlYmdsL2ZyYW1lYnVmZmVy LW9iamVjdC1hdHRhY2htZW50Lmh0bWwKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gTGF5b3V0VGVzdHMvZmFzdC9j YW52YXMvd2ViZ2wvZnJhbWVidWZmZXItb2JqZWN0LWF0dGFjaG1lbnQuaHRtbAkocmV2aXNpb24g NTgwMzEpCisrKyBMYXlvdXRUZXN0cy9mYXN0L2NhbnZhcy93ZWJnbC9mcmFtZWJ1ZmZlci1vYmpl Y3QtYXR0YWNobWVudC5odG1sCSh3b3JraW5nIGNvcHkpCkBAIC0zNCw2ICszNCwxMyBAQCBmdW5j dGlvbiB0ZXN0QXR0YWNobWVudHMoYXR0YWNobWVudDAsIGJ1CiAgICAgc2hvdWxkQmUoImdsLmdl dEVycm9yKCkiLCAiZ2wuTk9fRVJST1IiKTsKICAgICBnbC5mcmFtZWJ1ZmZlclJlbmRlcmJ1ZmZl cihnbC5GUkFNRUJVRkZFUiwgYXR0YWNobWVudDEsIGdsLlJFTkRFUkJVRkZFUiwgYnVmZmVyMSk7 CiAgICAgc2hvdWxkQmUoImdsLmdldEVycm9yKCkiLCBpc0NvbmZsaWN0ZWQgPyAiZ2wuSU5WQUxJ RF9PUEVSQVRJT04iIDogImdsLk5PX0VSUk9SIik7CisgICAgaWYgKGlzQ29uZmxpY3RlZCkgewor ICAgICAgICAvLyBEZXRhY2ggYnVmZmVyMCBmaXJzdCB1c2luZyBhIG51bGwgb2JqZWN0LCB0aGVu IGF0dGFjaGluZyBidWZmZXIxIHNob3VsZCBzdWNjZWVkLgorICAgICAgICBnbC5mcmFtZWJ1ZmZl clJlbmRlcmJ1ZmZlcihnbC5GUkFNRUJVRkZFUiwgYXR0YWNobWVudDAsIGdsLlJFTkRFUkJVRkZF UiwgbnVsbCk7CisgICAgICAgIHNob3VsZEJlKCJnbC5nZXRFcnJvcigpIiwgImdsLk5PX0VSUk9S Iik7CisgICAgICAgIGdsLmZyYW1lYnVmZmVyUmVuZGVyYnVmZmVyKGdsLkZSQU1FQlVGRkVSLCBh dHRhY2htZW50MSwgZ2wuUkVOREVSQlVGRkVSLCBidWZmZXIxKTsKKyAgICAgICAgc2hvdWxkQmUo ImdsLmdldEVycm9yKCkiLCAiZ2wuTk9fRVJST1IiKTsKKyAgICB9CiB9CiAKIGRlc2NyaXB0aW9u KCJUZXN0IGZyYW1lYnVmZmVyIG9iamVjdCBhdHRhY2htZW50IGJlaGF2aW9ycyIpOwo=