37953 2010-04-21 14:50:05 -0700 [Qt] Refactor qtscriptglobal.h 2010-04-29 03:25:33 -0700 1 1 1 Unclassified WebKit WebKit Qt 528+ (Nightly build) PC All RESOLVED FIXED Qt P2 Normal --- 31863 1 laszlo.gombos webkit-unassigned commit-queue hausmann jedrzej.nowacki kent.hansen oldest_to_newest 215511 0 laszlo.gombos 2010-04-21 14:50:05 -0700 qtscriptglobal.h checks for Q_OS_WIN and Q_OS_SYMBIAN. Checking for Q_OS_SYMBIAN might actually be incorrect for the simulated Symbian environment, but more importantly we should have the same logic for this file as to qwebkitglobal.h (which does not check for Q_OS_SYMBIAN) and leave the knowledge of export rules to Qt itself. 215560 1 54002 laszlo.gombos 2010-04-21 16:22:32 -0700 Created attachment 54002 proposed patch Jedrzej, it would be great if you could test this change in your environment before this gets committed. 218239 2 jedrzej.nowacki 2010-04-28 00:36:45 -0700 It works on my Linux machine. Windows build is broken, but it is not because of the patch (35578). 218931 3 54002 commit-queue 2010-04-29 03:25:26 -0700 Comment on attachment 54002 proposed patch Clearing flags on attachment: 54002 Committed r58494: <http://trac.webkit.org/changeset/58494> 218932 4 commit-queue 2010-04-29 03:25:33 -0700 All reviewed patches have been landed. Closing bug. 54002 2010-04-21 16:22:32 -0700 2010-04-29 03:25:26 -0700 proposed patch 37953.patch text/plain 1902 laszlo.gombos SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4MDEzKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQtMjEgIExhc3psbyBH b21ib3MgIDxsYXN6bG8uMS5nb21ib3NAbm9raWEuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5 IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtRdF0gUmVmYWN0b3IgcXRzY3JpcHRnbG9iYWwu aAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5NTMK KworICAgICAgICBVc2UgdGhlIHNhbWUgcGF0dGVybiBpbiBxdHNjcmlwdGdsb2JhbC5oIGFzIGlu IAorICAgICAgICBxd2Via2l0Z2xvYmFsLmggd2l0aG91dCBjaGVja2luZyBmb3Igc3BlY2lmaWMg T1NzLgorCisgICAgICAgICogcXQvYXBpL3F0c2NyaXB0Z2xvYmFsLmg6CisKIDIwMTAtMDQtMjEg IFNhbSBXZWluaWcgIDxzYW1Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBHZW9m ZnJleSBHYXJlbi4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3F0L2FwaS9xdHNjcmlwdGdsb2JhbC5o Cj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT0KLS0tIEphdmFTY3JpcHRDb3JlL3F0L2FwaS9xdHNjcmlwdGdsb2JhbC5oCShy ZXZpc2lvbiA1ODAwOCkKKysrIEphdmFTY3JpcHRDb3JlL3F0L2FwaS9xdHNjcmlwdGdsb2JhbC5o CSh3b3JraW5nIGNvcHkpCkBAIC0yMiwyMyArMjIsMjIgQEAKIAogI2luY2x1ZGUgPFF0Q29yZS9x Z2xvYmFsLmg+CiAKLSNpZiBkZWZpbmVkKFFfT1NfV0lOKSB8fCBkZWZpbmVkKFFfT1NfU1lNQklB TikKLSMgIGlmIGRlZmluZWQoUVRfTk9ETEwpCi0jICBlbGlmIGRlZmluZWQoUVRfTUFLRURMTCkg ICAgICAgIC8qIGNyZWF0ZSBhIFF0IERMTCBsaWJyYXJ5ICovCi0jICAgIGlmIGRlZmluZWQoUVRf QlVJTERfSkFWQVNDUklQVF9MSUIpCi0jICAgICAgZGVmaW5lIFFfSkFWQVNDUklQVF9FWFBPUlQg UV9ERUNMX0VYUE9SVAotIyAgICBlbHNlCi0jICAgICAgZGVmaW5lIFFfSkFWQVNDUklQVF9FWFBP UlQgUV9ERUNMX0lNUE9SVAotIyAgICBlbmRpZgotIyAgZWxpZiBkZWZpbmVkKFFUX0RMTCkgLyog dXNlIGEgUXQgRExMIGxpYnJhcnkgKi8KLSMgICAgZGVmaW5lIFFfSkFWQVNDUklQVF9FWFBPUlQK KyNpZiBkZWZpbmVkKFFUX01BS0VETEwpICAgICAgICAvKiBjcmVhdGUgYSBRdCBETEwgbGlicmFy eSAqLworIyAgaWYgZGVmaW5lZChRVF9CVUlMRF9KQVZBU0NSSVBUX0xJQikKKyMgICAgZGVmaW5l IFFfSkFWQVNDUklQVF9FWFBPUlQgUV9ERUNMX0VYUE9SVAorIyAgZWxzZQorIyAgICBkZWZpbmUg UV9KQVZBU0NSSVBUX0VYUE9SVCBRX0RFQ0xfSU1QT1JUCiAjICBlbmRpZgorI2VsaWYgZGVmaW5l ZChRVF9ETEwpIC8qIHVzZSBhIFF0IERMTCBsaWJyYXJ5ICovCisjICBkZWZpbmUgUV9KQVZBU0NS SVBUX0VYUE9SVAogI2VuZGlmCiAKLSNpZiBkZWZpbmVkKFFUX1NIQVJFRCkKLSMgIGRlZmluZSBR X0pBVkFTQ1JJUFRfRVhQT1JUIFFfREVDTF9FWFBPUlQKLSNlbHNlCi0jICBkZWZpbmUgUV9KQVZB U0NSSVBUX0VYUE9SVAorI2lmICFkZWZpbmVkKFFfSkFWQVNDUklQVF9FWFBPUlQpCisjICBpZiBk ZWZpbmVkKFFUX1NIQVJFRCkKKyMgICAgZGVmaW5lIFFfSkFWQVNDUklQVF9FWFBPUlQgUV9ERUNM X0VYUE9SVAorIyAgZWxzZQorIyAgICBkZWZpbmUgUV9KQVZBU0NSSVBUX0VYUE9SVAorIyAgZW5k aWYKICNlbmRpZgogCiAjZW5kaWYK