37948 2010-04-21 13:42:45 -0700 [Android] Android should use isfinite, isinf, isnan and signbit from the std namespace 2010-04-22 20:11:03 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 38007 1 steveblock webkit-unassigned abarth android-webkit-unforking commit-queue eric steveblock webkit.review.bot oldest_to_newest 215478 0 steveblock 2010-04-21 13:42:45 -0700 http://trac.webkit.org/changeset/54388 updated MathExtras.h to use <cmath> (rather than <math.h>) which provides isfinite, isinf, isnan and signbit in the std namespace. This broke the Android build as Android's version of STL did not at the time provide these functions in the std namespace. The build was fixed with a compile guard around the using declarations in http://trac.webkit.org/changeset/54655. Android's version of STL now provides these functions in the std namespace, so we can remove the guard around the using declarations. 215482 1 53986 steveblock 2010-04-21 13:46:08 -0700 Created attachment 53986 Patch 216026 2 53986 abarth 2010-04-22 12:44:50 -0700 Comment on attachment 53986 Patch ok. 216036 3 53986 steveblock 2010-04-22 12:55:51 -0700 Comment on attachment 53986 Patch Clearing flags on attachment: 53986 Committed r58110: <http://trac.webkit.org/changeset/58110> 216037 4 steveblock 2010-04-22 12:56:00 -0700 All reviewed patches have been landed. Closing bug. 216075 5 webkit.review.bot 2010-04-22 14:17:14 -0700 http://trac.webkit.org/changeset/58110 might have broken Qt Windows 32-bit Release 216107 6 abarth 2010-04-22 15:35:51 -0700 Failure persisted after rollout 216108 7 53986 abarth 2010-04-22 15:36:06 -0700 Comment on attachment 53986 Patch Relanding. 216239 8 53986 commit-queue 2010-04-22 20:10:56 -0700 Comment on attachment 53986 Patch Clearing flags on attachment: 53986 Committed r58142: <http://trac.webkit.org/changeset/58142> 216240 9 commit-queue 2010-04-22 20:11:03 -0700 All reviewed patches have been landed. Closing bug. 53986 2010-04-21 13:46:08 -0700 2010-04-22 20:10:56 -0700 Patch bug-37948-20100421214606.patch text/plain 1187 steveblock SW5kZXg6IEphdmFTY3JpcHRDb3JlL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBKYXZhU2NyaXB0 Q29yZS9DaGFuZ2VMb2cJKHJldmlzaW9uIDU4MDExKQorKysgSmF2YVNjcmlwdENvcmUvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQtMjEgIFN0ZXZlIEJs b2NrICA8c3RldmVibG9ja0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9E WSAoT09QUyEpLgorCisgICAgICAgIFVwZGF0ZSBBbmRyb2lkIHRvIHVzZSBpc2Zpbml0ZSwgaXNp bmYsIGlzbmFuIGFuZCBzaWduYml0IGZyb20gbmFtZXNwYWNlIHN0ZC4KKyAgICAgICAgaHR0cHM6 Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTQ4CisKKyAgICAgICAgKiB3dGYv TWF0aEV4dHJhcy5oOgorCiAyMDEwLTA0LTIxICBHYXZpbiBCYXJyYWNsb3VnaCAgPGJhcnJhY2xv dWdoQGFwcGxlLmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKHdpbmRvd3MgYnVp bGQgZml4IHB0LiAzKS4KSW5kZXg6IEphdmFTY3JpcHRDb3JlL3d0Zi9NYXRoRXh0cmFzLmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gSmF2YVNjcmlwdENvcmUvd3RmL01hdGhFeHRyYXMuaAkocmV2aXNpb24gNTgw MDIpCisrKyBKYXZhU2NyaXB0Q29yZS93dGYvTWF0aEV4dHJhcy5oCSh3b3JraW5nIGNvcHkpCkBA IC0xODgsNyArMTg4LDcgQEAgaW5saW5lIGZsb2F0IGRlZzJ0dXJuKGZsb2F0IGQpIHsgcmV0dXJu IAogaW5saW5lIGZsb2F0IHJhZDJncmFkKGZsb2F0IHIpIHsgcmV0dXJuIHIgKiAyMDAuMGYgLyBw aUZsb2F0OyB9CiBpbmxpbmUgZmxvYXQgZ3JhZDJyYWQoZmxvYXQgZykgeyByZXR1cm4gZyAqIHBp RmxvYXQgLyAyMDAuMGY7IH0KIAotI2lmICFDT01QSUxFUihNU1ZDKSAmJiAhQ09NUElMRVIoUlZD VCkgJiYgIU9TKEFORFJPSUQpICYmICFDT01QSUxFUihXSU5TQ1cpCisjaWYgIUNPTVBJTEVSKE1T VkMpICYmICFDT01QSUxFUihSVkNUKSAmJiAhQ09NUElMRVIoV0lOU0NXKQogdXNpbmcgc3RkOjpp c2Zpbml0ZTsKIHVzaW5nIHN0ZDo6aXNpbmY7CiB1c2luZyBzdGQ6OmlzbmFuOwo=