37944 2010-04-21 12:57:34 -0700 last-child of a list are not styled correctly when the entire list is replaced at once 2010-07-13 03:28:33 -0700 1 1 1 Unclassified WebKit CSS 528+ (Nightly build) All All RESOLVED FIXED http://media.rawdod.com/webkit_last_child_regen_bug.html P2 Normal --- 0 rawdod webkit-unassigned commit-queue hamaji hyatt rawdod stephen tkent yhayashi yuzo oldest_to_newest 215452 0 rawdod 2010-04-21 12:57:34 -0700 Here is a link to a demo: http://media.rawdod.com/webkit_last_child_regen_bug.html This is a hacked up copy and paste of the source of: http://www.quirksmode.org/css/firstchild.html I have confirmed this bug happens on the latest chromium for linux and also the latest safari for windows. I have confirmed this works fine on the latest firefox for linux. I expect nothing platform specific about this bug from that... From what I am told, webkit should know to reparse the list and style it correctly when you replace the whole list, but it does not. This also happens when styling based on the last child of a class, thats how I found it, for example, if I replace this entire admin menu at once, I loose the border-right property being 0 on the last navigation class: Example of structure: ul.navigation { float: left; display: block; height: 75px; margin: 0 12px 0 2px; border-right: 1px dotted #9a9a9a; padding: 0 14px 0 0; list-style-image: none; list-style-type: none; line-height: 25px; } ul.navigation:last-child { border-right: 0; } <ul class="navigation"> <li><%= link_to "Realtor Appointments", :controller => "admin/realtorappointments/list" %></li> <li><%= link_to "Lender Appointments", :controller => "admin/mortgagelenderappointments/list" %></li> <li><%= link_to "Moving Appointments", :controller => "admin/moving_and_storage_appointments/list" %></li> </ul> <ul class="navigation"> <li><%= link_to "Messages", :controller => "admin/messages", :action => "list" %></li> <li><%= link_to "Reports", :controller => "admin/reports", :action => "list" %></li> <li><%= link_to "Recent Logins", :controller => "admin/logs", :action => "recent_logins" %></li> </ul> <ul class="navigation"> <li><%= link_to "Logs", :controller => "admin/logs", :action => "view" %></li> <li><%= link_to "Console", :controller => "admin/logs", :action => "console" %></li> <li><%= link_to "Imports", :controller => "admin/imports", :action => "view" %></li> </ul> <ul class="navigation"> <li><%= link_to "Marketing Material Orders", :controller => "admin/logs/material_orders" %></li> </ul> 215460 1 rawdod 2010-04-21 13:16:14 -0700 I found some workarounds: http://media.rawdod.com/webkit_last_child_regen_bug_with_workarounds.html 215463 2 rawdod 2010-04-21 13:19:40 -0700 This bug is related to 37129 but expands upon it because it also affects other things besides just whats in a list. 224496 3 55823 yhayashi 2010-05-12 03:07:47 -0700 Created attachment 55823 Proposed Patch 225019 4 yuzo 2010-05-12 18:17:35 -0700 Reviewers, I've uploaded a different patch to: https://bugs.webkit.org/show_bug.cgi?id=37129 I think we only need either one of the patches. So please review both and pick the one you like. :) 249846 5 tkent 2010-07-12 08:08:20 -0700 I read the attachment #55823 (this bug) and #55830 (Bug#37129), and I think the approach of #55823 is better because - #55830 uses a parsing flag for non-parsing process - #55823 covers not only innerHTML case but also replaceChild(fragment-with-children, node) case Any other comments? 250281 6 55823 tkent 2010-07-12 21:23:41 -0700 Comment on attachment 55823 Proposed Patch LayoutTests/fast/css/last-child-innerhtml-expected.txt:6 + 1 Leaving "1 2 3 1 2 3" in the test expectation makes no much sense. I recommend to clear children of "threeChildren" and "oneChild" before finishing the test. WebCore/dom/ContainerNode.cpp:241 + We don't need two blank lines. Remove one. 250369 7 61341 yhayashi 2010-07-13 00:43:23 -0700 Created attachment 61341 Proposed Patch 250371 8 yhayashi 2010-07-13 00:45:01 -0700 (In reply to comment #6) Thank you for review. I've modified the patch accordingly. Could you take another look? Thanks, 250393 9 61341 tkent 2010-07-13 01:52:10 -0700 Comment on attachment 61341 Proposed Patch Looks good. 250418 10 61341 commit-queue 2010-07-13 03:25:39 -0700 Comment on attachment 61341 Proposed Patch Clearing flags on attachment: 61341 Committed r63190: <http://trac.webkit.org/changeset/63190> 250419 11 commit-queue 2010-07-13 03:25:44 -0700 All reviewed patches have been landed. Closing bug. 250421 12 tkent 2010-07-13 03:28:33 -0700 *** Bug 37129 has been marked as a duplicate of this bug. *** 55823 2010-05-12 03:07:47 -0700 2010-07-13 00:43:16 -0700 Proposed Patch bug-37944-20100512190746.patch text/plain 6620 yhayashi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCA2MzlmN2QzNzgwYjc2NzY3Zjk1MmU4OGZiZTQzOGNlODczNjE1Y2FhLi5lMWQ0ZmEz YzRlNzI5NTk2N2E3MjkzMTIzN2ZlMjZlM2QzYWE0NWQwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDUtMTIgIFlvc2hpa2kgSGF5YXNoaSAgPHloYXlhc2hpQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIGNv cnJlY3QgTm9kZXMgYXJlIHBhc3NlZCB0byBjaGlsZHJlbkNoYW5nZWQgc28gdGhhdAorICAgICAg ICA6bGFzdC1jaGlsZCBnZXRzIHByb3Blcmx5IGFwcGxpZWQgd2hlbiBmcmFnbWVudCBpcyBpbnNl cnRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 OTQ0CisKKyAgICAgICAgKiBmYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2xhc3QtY2hpbGQtaW5uZXJodG1sLmh0bWw6 IEFkZGVkLgorCiAyMDEwLTA1LTEwICBKb2huIEdyZWdnICA8am9obm55Z0Bnb29nbGUuY29tPgog CiAgICAgICAgIFtjaHJvbWl1bV0gcmViYXNlbGluZSBTVkcgdGVzdCBmb3Igd2luZG93cyBhZnRl ciByZWNlbnQgY2hhbmdlcy4KZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhc3Qt Y2hpbGQtaW5uZXJodG1sLWV4cGVjdGVkLnR4dCBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhc3Qt Y2hpbGQtaW5uZXJodG1sLWV4cGVjdGVkLnR4dApuZXcgZmlsZSBtb2RlIDEwMDY0NAppbmRleCAw MDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwLi40YmI0YjkwZmQ2YmIwMTFk ZjBmMDJjNTY2NTA0MzVmOWE5ODM1YTI4Ci0tLSAvZGV2L251bGwKKysrIGIvTGF5b3V0VGVzdHMv ZmFzdC9jc3MvbGFzdC1jaGlsZC1pbm5lcmh0bWwtZXhwZWN0ZWQudHh0CkBAIC0wLDAgKzEsMjkg QEAKK0NoZWNrIGlmIHJlcGxhY2luZyBpbm5lckhUTUwgaGFuZGxlcyA6bGFzdC1jaGlsZCBwcm9w ZXJseS4gSWYgeW91IHNlZSBibHVlIDEsIGJsYWNrIDIgYW5kIHB1cnBsZSAzLCB0aGUgdGVzdCBo YXMgcGFzc2VkLiBJZiB5b3Ugc2VlIGFsbCBpbiBwdXJwbGUsIHRoZSB0ZXN0IGhhcyBmYWlsZWQu CisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNlZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMs IGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRFIi4KKworCisxCisKKzIKKworMworCisxCisKKzIK KworMworCitSZXBsYWNpbmcgdGhyZWUgY2hpbGRyZW4uCitQQVNTIGdldENvbXB1dGVkU3R5bGUo ZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3InKSBpcyAncmdiKDAsIDAsIDI1NSknCitQ QVNTIGdldENvbXB1dGVkU3R5bGUoZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3InKSBp cyAncmdiKDAsIDAsIDApJworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3Bl cnR5VmFsdWUoJ2NvbG9yJykgaXMgJ3JnYigxMjgsIDAsIDEyOCknCitSZXBsYWNpbmcgb25lIGNo aWxkLgorUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5VmFsdWUoJ2Nv bG9yJykgaXMgJ3JnYigwLCAwLCAyNTUpJworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQp LmdldFByb3BlcnR5VmFsdWUoJ2NvbG9yJykgaXMgJ3JnYigwLCAwLCAwKScKK1BBU1MgZ2V0Q29t cHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xvcicpIGlzICdyZ2IoMTI4 LCAwLCAxMjgpJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhc3QtY2hpbGQtaW5uZXJo dG1sLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjBlNzJhODRmOWFhZDc2YjgwNDIzZGJjMjVlNzE0ZDcyZTg1MDAyYWYKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRt bC5odG1sCkBAIC0wLDAgKzEsNDkgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxl c2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4K K2RpdiBwOmZpcnN0LWNoaWxkIHsKKyAgY29sb3I6IGJsdWU7Cit9CitkaXYgcDpsYXN0LWNoaWxk IHsKKyAgY29sb3I6IHB1cnBsZTsKK30KKzwvc3R5bGU+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwv cD4KKzxkaXYgaWQ9InRocmVlQ2hpbGRyZW4iPgorPHA+YTwvcD48cD5iPC9wPjxwPmM8L3A+Cis8 L2Rpdj4KKzxkaXYgaWQ9Im9uZUNoaWxkIj4KKzwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIkNoZWNrIGlmIHJlcGxhY2luZyBpbm5lckhUTUwg aGFuZGxlcyA6bGFzdC1jaGlsZCBwcm9wZXJseS4gSWYgeW91IHNlZSBibHVlIDEsIGJsYWNrIDIg YW5kIHB1cnBsZSAzLCB0aGUgdGVzdCBoYXMgcGFzc2VkLiBJZiB5b3Ugc2VlIGFsbCBpbiBwdXJw bGUsIHRoZSB0ZXN0IGhhcyBmYWlsZWQuIik7CitmdW5jdGlvbiByZXBsYWNlKHgpIHsKKyAgeC5p bm5lckhUTUwgPSAiPHA+MTwvcD48cD4yPC9wPjxwPjM8L3A+IjsKK30KKwordmFyIGVsZW1lbnQg PSBudWxsOworCitkZWJ1ZygiUmVwbGFjaW5nIHRocmVlIGNoaWxkcmVuLiIpOworcmVwbGFjZShk b2N1bWVudC5nZXRFbGVtZW50QnlJZCgidGhyZWVDaGlsZHJlbiIpKTsKK2VsZW1lbnQgPSBkb2N1 bWVudC5nZXRFbGVtZW50QnlJZCgidGhyZWVDaGlsZHJlbiIpLmZpcnN0Q2hpbGQ7CitzaG91bGRC ZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xvcicpIiwg IidyZ2IoMCwgMCwgMjU1KSciKTsKK2VsZW1lbnQgPSBlbGVtZW50Lm5leHRTaWJsaW5nOworc2hv dWxkQmUoImdldENvbXB1dGVkU3R5bGUoZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3In KSIsICIncmdiKDAsIDAsIDApJyIpOworZWxlbWVudCA9IGVsZW1lbnQubmV4dFNpYmxpbmc7Citz aG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xv cicpIiwgIidyZ2IoMTI4LCAwLCAxMjgpJyIpOworCitkZWJ1ZygiUmVwbGFjaW5nIG9uZSBjaGls ZC4iKTsKK3JlcGxhY2UoZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm9uZUNoaWxkIikpOworZWxl bWVudCA9IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJvbmVDaGlsZCIpLmZpcnN0Q2hpbGQ7Citz aG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xv cicpIiwgIidyZ2IoMCwgMCwgMjU1KSciKTsKK2VsZW1lbnQgPSBlbGVtZW50Lm5leHRTaWJsaW5n Oworc2hvdWxkQmUoImdldENvbXB1dGVkU3R5bGUoZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgn Y29sb3InKSIsICIncmdiKDAsIDAsIDApJyIpOworZWxlbWVudCA9IGVsZW1lbnQubmV4dFNpYmxp bmc7CitzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVl KCdjb2xvcicpIiwgIidyZ2IoMTI4LCAwLCAxMjgpJyIpOworCitzdWNjZXNzZnVsbHlQYXJzZWQg PSB0cnVlOworPC9zY3JpcHQ+Cis8c2NyaXB0IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3Qt cG9zdC5qcyI+PC9zY3JpcHQ+Cis8L2JvZHk+CmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxv ZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDFkYmZmNTU4ZWI3ZTU2ZTViY2NhOTdjOWY0ZmZi OWY2YzU1ZDA2MTAuLjllNWYwMzQ1MzBiZGNiNGQ4ZGIyNTNiNTVkNTg1N2E0MTFkYjY4MjQgMTAw NjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0x LDMgKzEsMTcgQEAKKzIwMTAtMDUtMTIgIFlvc2hpa2kgSGF5YXNoaSAgPHloYXlhc2hpQGdvb2ds ZS5jb20+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAg TWFrZSBzdXJlIGNvcnJlY3QgTm9kZXMgYXJlIHBhc3NlZCB0byBjaGlsZHJlbkNoYW5nZWQgc28g dGhhdAorICAgICAgICA6bGFzdC1jaGlsZCBnZXRzIHByb3Blcmx5IGFwcGxpZWQgd2hlbiBmcmFn bWVudCBpcyBpbnNlcnRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19i dWcuY2dpP2lkPTM3OTQ0CisKKyAgICAgICAgVGVzdDogZmFzdC9jc3MvbGFzdC1jaGlsZC1pbm5l cmh0bWwuaHRtbAorCisgICAgICAgICogZG9tL0NvbnRhaW5lck5vZGUuY3BwOgorICAgICAgICAo V2ViQ29yZTo6Q29udGFpbmVyTm9kZTo6cmVwbGFjZUNoaWxkKToKKyAgICAgICAgKFdlYkNvcmU6 OkNvbnRhaW5lck5vZGU6OmFwcGVuZENoaWxkKToKKwogMjAxMC0wNS0xMCAgRHVtaXRydSBEYW5p bGl1YyAgPGR1bWlAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEJyYWR5IEVp ZHNvbi4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvZG9tL0NvbnRhaW5lck5vZGUuY3BwIGIvV2ViQ29y ZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKaW5kZXggOWUyN2RlYWQ5NDE3NGMxOTlkMDhmNmJkMDBh NjdhZGM4Yzc0Y2Y5Mi4uZDNlMjVlM2FmZjRkNTdlMWE3MDA3MDY3MzE1YjY4N2RmOThiNjM3NyAx MDA2NDQKLS0tIGEvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAKKysrIGIvV2ViQ29yZS9k b20vQ29udGFpbmVyTm9kZS5jcHAKQEAgLTIxNCw3ICsyMTQsNiBAQCBib29sIENvbnRhaW5lck5v ZGU6OnJlcGxhY2VDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkLCBOb2RlKiBvbGRDaGls ZCwgRXhjZQogICAgIGJvb2wgaXNGcmFnbWVudCA9IG5ld0NoaWxkLT5ub2RlVHlwZSgpID09IERP Q1VNRU5UX0ZSQUdNRU5UX05PREU7CiAKICAgICAvLyBBZGQgdGhlIG5ldyBjaGlsZChyZW4pCi0g ICAgaW50IGNoaWxkQ291bnREZWx0YSA9IDA7CiAgICAgUmVmUHRyPE5vZGU+IGNoaWxkID0gaXNG cmFnbWVudCA/IG5ld0NoaWxkLT5maXJzdENoaWxkKCkgOiBuZXdDaGlsZDsKICAgICB3aGlsZSAo Y2hpbGQpIHsKICAgICAgICAgLy8gSWYgdGhlIG5ldyBjaGlsZCBpcyBhbHJlYWR5IGluIHRoZSBy aWdodCBwbGFjZSwgd2UncmUgZG9uZS4KQEAgLTIzOSw3ICsyMzgsNiBAQCBib29sIENvbnRhaW5l ck5vZGU6OnJlcGxhY2VDaGlsZChQYXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkLCBOb2RlKiBvbGRD aGlsZCwgRXhjZQogICAgICAgICBpZiAoY2hpbGQtPnBhcmVudE5vZGUoKSkKICAgICAgICAgICAg IGJyZWFrOwogCi0gICAgICAgIGNoaWxkQ291bnREZWx0YSsrOwogCiAgICAgICAgIEFTU0VSVCgh Y2hpbGQtPm5leHRTaWJsaW5nKCkpOwogICAgICAgICBBU1NFUlQoIWNoaWxkLT5wcmV2aW91c1Np YmxpbmcoKSk7CkBAIC0yNjgsNiArMjY2LDcgQEAgYm9vbCBDb250YWluZXJOb2RlOjpyZXBsYWNl Q2hpbGQoUGFzc1JlZlB0cjxOb2RlPiBuZXdDaGlsZCwgTm9kZSogb2xkQ2hpbGQsIEV4Y2UKICAg ICAgICAgY2hpbGQtPnNldE5leHRTaWJsaW5nKG5leHQpOwogICAgICAgICBhbGxvd0V2ZW50RGlz cGF0Y2goKTsKIAorICAgICAgICBjaGlsZHJlbkNoYW5nZWQoZmFsc2UsIHByZXYuZ2V0KCksIG5l eHQsIDEpOwogICAgICAgICBub3RpZnlDaGlsZEluc2VydGVkKGNoaWxkLmdldCgpKTsKICAgICAg ICAgICAgICAgICAKICAgICAgICAgLy8gQWRkIGNoaWxkIHRvIHRoZSByZW5kZXJpbmcgdHJlZQpA QCAtMjg2LDggKzI4NSw2IEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6cmVwbGFjZUNoaWxkKFBhc3NS ZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIG9sZENoaWxkLCBFeGNlCiAgICAgICAgIGNoaWxk ID0gbmV4dENoaWxkLnJlbGVhc2UoKTsKICAgICB9CiAKLSAgICBpZiAoY2hpbGRDb3VudERlbHRh KQotICAgICAgICBjaGlsZHJlbkNoYW5nZWQoZmFsc2UsIHByZXYuZ2V0KCksIG5leHQuZ2V0KCks IGNoaWxkQ291bnREZWx0YSk7CiAgICAgZGlzcGF0Y2hTdWJ0cmVlTW9kaWZpZWRFdmVudCgpOwog ICAgIHJldHVybiB0cnVlOwogfQpAQCAtNTMwLDYgKzUyNyw3IEBAIGJvb2wgQ29udGFpbmVyTm9k ZTo6YXBwZW5kQ2hpbGQoUGFzc1JlZlB0cjxOb2RlPiBuZXdDaGlsZCwgRXhjZXB0aW9uQ29kZSYg ZWMsIGJvCiAgICAgICAgIC8vIE5vdyB0aGF0IHRoZSBjaGlsZCBpcyBhdHRhY2hlZCB0byB0aGUg cmVuZGVyIHRyZWUsIGRpc3BhdGNoCiAgICAgICAgIC8vIHRoZSByZWxldmFudCBtdXRhdGlvbiBl dmVudHMuCiAgICAgICAgIGRpc3BhdGNoQ2hpbGRJbnNlcnRpb25FdmVudHMoY2hpbGQpOworICAg ICAgICBwcmV2ID0gY2hpbGQ7CiAgICAgfQogCiAgICAgZGlzcGF0Y2hTdWJ0cmVlTW9kaWZpZWRF dmVudCgpOwo= 61341 2010-07-13 00:43:23 -0700 2010-07-13 03:25:38 -0700 Proposed Patch bug-37944-20100713164321.patch text/plain 6453 yhayashi ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAxY2M5YzVlYzJiMGRmNzQzNTdiODEzY2QzZjRmNTRjYmRkODM4ODkyLi5iMzQ1ZmFk OGExYTNiNDRlYjVjNjEwODYwNWI3ODM5YTk2NTkyZTI4IDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0 cy9DaGFuZ2VMb2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAK KzIwMTAtMDctMTMgIFlvc2hpa2kgSGF5YXNoaSAgPHloYXlhc2hpQGdvb2dsZS5jb20+CisKKyAg ICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgTWFrZSBzdXJlIGNv cnJlY3QgTm9kZXMgYXJlIHBhc3NlZCB0byBjaGlsZHJlbkNoYW5nZWQgc28gdGhhdAorICAgICAg ICA6bGFzdC1jaGlsZCBnZXRzIHByb3Blcmx5IGFwcGxpZWQgd2hlbiBmcmFnbWVudCBpcyBpbnNl cnRlZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 OTQ0CisKKyAgICAgICAgKiBmYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC1leHBlY3RlZC50 eHQ6IEFkZGVkLgorICAgICAgICAqIGZhc3QvY3NzL2xhc3QtY2hpbGQtaW5uZXJodG1sLmh0bWw6 IEFkZGVkLgorCiAyMDEwLTA3LTEyICBNYXJ0aW4gUm9iaW5zb24gIDxtcm9iaW5zb25AaWdhbGlh LmNvbT4KIAogICAgICAgICBSZXZpZXdlZCBieSBEaXJrIFNjaHVsemUuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC1leHBlY3RlZC50eHQgYi9M YXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC1leHBlY3RlZC50eHQKbmV3 IGZpbGUgbW9kZSAxMDA2NDQKaW5kZXggMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMC4uMDgwN2JhYWNjMTZmYTlkMGQ3YjNkODMyYmM2ZDU2MWFiYmY2MjJjZQotLS0gL2Rl di9udWxsCisrKyBiL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhc3QtY2hpbGQtaW5uZXJodG1sLWV4 cGVjdGVkLnR4dApAQCAtMCwwICsxLDE3IEBACitDaGVjayBpZiByZXBsYWNpbmcgaW5uZXJIVE1M IGhhbmRsZXMgOmxhc3QtY2hpbGQgcHJvcGVybHkuCisKK09uIHN1Y2Nlc3MsIHlvdSB3aWxsIHNl ZSBhIHNlcmllcyBvZiAiUEFTUyIgbWVzc2FnZXMsIGZvbGxvd2VkIGJ5ICJURVNUIENPTVBMRVRF Ii4KKworCitSZXBsYWNpbmcgdGhyZWUgY2hpbGRyZW4uCitQQVNTIGdldENvbXB1dGVkU3R5bGUo ZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3InKSBpcyAncmdiKDAsIDAsIDI1NSknCitQ QVNTIGdldENvbXB1dGVkU3R5bGUoZWxlbWVudCkuZ2V0UHJvcGVydHlWYWx1ZSgnY29sb3InKSBp cyAncmdiKDAsIDAsIDApJworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3Bl cnR5VmFsdWUoJ2NvbG9yJykgaXMgJ3JnYigxMjgsIDAsIDEyOCknCitSZXBsYWNpbmcgb25lIGNo aWxkLgorUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5VmFsdWUoJ2Nv bG9yJykgaXMgJ3JnYigwLCAwLCAyNTUpJworUEFTUyBnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQp LmdldFByb3BlcnR5VmFsdWUoJ2NvbG9yJykgaXMgJ3JnYigwLCAwLCAwKScKK1BBU1MgZ2V0Q29t cHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdjb2xvcicpIGlzICdyZ2IoMTI4 LCAwLCAxMjgpJworUEFTUyBzdWNjZXNzZnVsbHlQYXJzZWQgaXMgdHJ1ZQorCitURVNUIENPTVBM RVRFCisKZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL2Zhc3QvY3NzL2xhc3QtY2hpbGQtaW5uZXJo dG1sLmh0bWwgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRtbC5odG1s Cm5ldyBmaWxlIG1vZGUgMTAwNjQ0CmluZGV4IDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAwMDAw MDAwMDAwMDAwMDAuLjRjYWI3ZDc3Nzc3ZDc4NGZjMTA5ODMwNGUxODM1MWJmN2I1YTA0OGIKLS0t IC9kZXYvbnVsbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L2Nzcy9sYXN0LWNoaWxkLWlubmVyaHRt bC5odG1sCkBAIC0wLDAgKzEsNTIgQEAKKzxodG1sPgorPGhlYWQ+Cis8bGluayByZWw9InN0eWxl c2hlZXQiIGhyZWY9Ii4uL2pzL3Jlc291cmNlcy9qcy10ZXN0LXN0eWxlLmNzcyI+Cis8c2NyaXB0 IHNyYz0iLi4vanMvcmVzb3VyY2VzL2pzLXRlc3QtcHJlLmpzIj48L3NjcmlwdD4KKzxzdHlsZT4K K2RpdiBwOmZpcnN0LWNoaWxkIHsKKyAgY29sb3I6IGJsdWU7Cit9CitkaXYgcDpsYXN0LWNoaWxk IHsKKyAgY29sb3I6IHB1cnBsZTsKK30KKzwvc3R5bGU+Cis8cCBpZD0iZGVzY3JpcHRpb24iPjwv cD4KKzxkaXYgaWQ9InRocmVlQ2hpbGRyZW4iPgorPHA+YTwvcD48cD5iPC9wPjxwPmM8L3A+Cis8 L2Rpdj4KKzxkaXYgaWQ9Im9uZUNoaWxkIj4KKzwvZGl2PgorPGRpdiBpZD0iY29uc29sZSI+PC9k aXY+Cis8c2NyaXB0PgorZGVzY3JpcHRpb24oIkNoZWNrIGlmIHJlcGxhY2luZyBpbm5lckhUTUwg aGFuZGxlcyA6bGFzdC1jaGlsZCBwcm9wZXJseS4iKTsKK2Z1bmN0aW9uIHJlcGxhY2UoeCkgewor ICB4LmlubmVySFRNTCA9ICI8cD4xPC9wPjxwPjI8L3A+PHA+MzwvcD4iOworfQorCit2YXIgZWxl bWVudCA9IG51bGw7CisKK2RlYnVnKCJSZXBsYWNpbmcgdGhyZWUgY2hpbGRyZW4uIik7CityZXBs YWNlKGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0aHJlZUNoaWxkcmVuIikpOworZWxlbWVudCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0aHJlZUNoaWxkcmVuIikuZmlyc3RDaGlsZDsKK3No b3VsZEJlKCJnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5VmFsdWUoJ2NvbG9y JykiLCAiJ3JnYigwLCAwLCAyNTUpJyIpOworZWxlbWVudCA9IGVsZW1lbnQubmV4dFNpYmxpbmc7 CitzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZhbHVlKCdj b2xvcicpIiwgIidyZ2IoMCwgMCwgMCknIik7CitlbGVtZW50ID0gZWxlbWVudC5uZXh0U2libGlu ZzsKK3Nob3VsZEJlKCJnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5VmFsdWUo J2NvbG9yJykiLCAiJ3JnYigxMjgsIDAsIDEyOCknIik7CisKK2RlYnVnKCJSZXBsYWNpbmcgb25l IGNoaWxkLiIpOworcmVwbGFjZShkb2N1bWVudC5nZXRFbGVtZW50QnlJZCgib25lQ2hpbGQiKSk7 CitlbGVtZW50ID0gZG9jdW1lbnQuZ2V0RWxlbWVudEJ5SWQoIm9uZUNoaWxkIikuZmlyc3RDaGls ZDsKK3Nob3VsZEJlKCJnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5VmFsdWUo J2NvbG9yJykiLCAiJ3JnYigwLCAwLCAyNTUpJyIpOworZWxlbWVudCA9IGVsZW1lbnQubmV4dFNp Ymxpbmc7CitzaG91bGRCZSgiZ2V0Q29tcHV0ZWRTdHlsZShlbGVtZW50KS5nZXRQcm9wZXJ0eVZh bHVlKCdjb2xvcicpIiwgIidyZ2IoMCwgMCwgMCknIik7CitlbGVtZW50ID0gZWxlbWVudC5uZXh0 U2libGluZzsKK3Nob3VsZEJlKCJnZXRDb21wdXRlZFN0eWxlKGVsZW1lbnQpLmdldFByb3BlcnR5 VmFsdWUoJ2NvbG9yJykiLCAiJ3JnYigxMjgsIDAsIDEyOCknIik7CisKK2RvY3VtZW50LmdldEVs ZW1lbnRCeUlkKCJ0aHJlZUNoaWxkcmVuIikuaW5uZXJIVE1MID0gIiI7Citkb2N1bWVudC5nZXRF bGVtZW50QnlJZCgib25lQ2hpbGQiKS5pbm5lckhUTUwgPSAiIjsKKworc3VjY2Vzc2Z1bGx5UGFy c2VkID0gdHJ1ZTsKKzwvc2NyaXB0PgorPHNjcmlwdCBzcmM9Ii4uL2pzL3Jlc291cmNlcy9qcy10 ZXN0LXBvc3QuanMiPjwvc2NyaXB0PgorPC9ib2R5PgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFu Z2VMb2cgYi9XZWJDb3JlL0NoYW5nZUxvZwppbmRleCA2NTgwODgzYTAzYmM0YjA5ZjRhMTI2MjZi YWQ3ODBlYzg0MmVmZmJlLi4zMmE1ZDg2NjE2M2IwZTZhODhmOTRmYzNlOTMyMzY1NzA1NTMxZTQ0 IDEwMDY0NAotLS0gYS9XZWJDb3JlL0NoYW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpA QCAtMSwzICsxLDE3IEBACisyMDEwLTA3LTEzICBZb3NoaWtpIEhheWFzaGkgIDx5aGF5YXNoaUBn b29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAg ICAgIE1ha2Ugc3VyZSBjb3JyZWN0IE5vZGVzIGFyZSBwYXNzZWQgdG8gY2hpbGRyZW5DaGFuZ2Vk IHNvIHRoYXQKKyAgICAgICAgOmxhc3QtY2hpbGQgZ2V0cyBwcm9wZXJseSBhcHBsaWVkIHdoZW4g ZnJhZ21lbnQgaXMgaW5zZXJ0ZWQuCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3No b3dfYnVnLmNnaT9pZD0zNzk0NAorCisgICAgICAgIFRlc3Q6IGZhc3QvY3NzL2xhc3QtY2hpbGQt aW5uZXJodG1sLmh0bWwKKworICAgICAgICAqIGRvbS9Db250YWluZXJOb2RlLmNwcDoKKyAgICAg ICAgKFdlYkNvcmU6OkNvbnRhaW5lck5vZGU6OnJlcGxhY2VDaGlsZCk6CisgICAgICAgIChXZWJD b3JlOjpDb250YWluZXJOb2RlOjphcHBlbmRDaGlsZCk6CisKIDIwMTAtMDctMTIgIE1paG5lYSBP dmlkZW5lYSAgPG1paG5lYUBhZG9iZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgRGlyayBT Y2h1bHplLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9kb20vQ29udGFpbmVyTm9kZS5jcHAgYi9XZWJD b3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAppbmRleCA4MGJkMDM1YWU3Yjc2ZDIyMzBkYmM4MjAy NGJmYjIxOGU2ZDhmZWI5Li41YjNmZWUwNjA3YTY2ODM1NWE5YTRjMjdiNzM2NGZmZDhlZjA1YjUz IDEwMDY0NAotLS0gYS9XZWJDb3JlL2RvbS9Db250YWluZXJOb2RlLmNwcAorKysgYi9XZWJDb3Jl L2RvbS9Db250YWluZXJOb2RlLmNwcApAQCAtMjE1LDcgKzIxNSw2IEBAIGJvb2wgQ29udGFpbmVy Tm9kZTo6cmVwbGFjZUNoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIG9sZENo aWxkLCBFeGNlCiAgICAgYm9vbCBpc0ZyYWdtZW50ID0gbmV3Q2hpbGQtPm5vZGVUeXBlKCkgPT0g RE9DVU1FTlRfRlJBR01FTlRfTk9ERTsKIAogICAgIC8vIEFkZCB0aGUgbmV3IGNoaWxkKHJlbikK LSAgICBpbnQgY2hpbGRDb3VudERlbHRhID0gMDsKICAgICBSZWZQdHI8Tm9kZT4gY2hpbGQgPSBp c0ZyYWdtZW50ID8gbmV3Q2hpbGQtPmZpcnN0Q2hpbGQoKSA6IG5ld0NoaWxkOwogICAgIHdoaWxl IChjaGlsZCkgewogICAgICAgICAvLyBJZiB0aGUgbmV3IGNoaWxkIGlzIGFscmVhZHkgaW4gdGhl IHJpZ2h0IHBsYWNlLCB3ZSdyZSBkb25lLgpAQCAtMjQwLDggKzIzOSw2IEBAIGJvb2wgQ29udGFp bmVyTm9kZTo6cmVwbGFjZUNoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIG9s ZENoaWxkLCBFeGNlCiAgICAgICAgIGlmIChjaGlsZC0+cGFyZW50Tm9kZSgpKQogICAgICAgICAg ICAgYnJlYWs7CiAKLSAgICAgICAgY2hpbGRDb3VudERlbHRhKys7Ci0KICAgICAgICAgQVNTRVJU KCFjaGlsZC0+bmV4dFNpYmxpbmcoKSk7CiAgICAgICAgIEFTU0VSVCghY2hpbGQtPnByZXZpb3Vz U2libGluZygpKTsKIApAQCAtMjY5LDYgKzI2Niw3IEBAIGJvb2wgQ29udGFpbmVyTm9kZTo6cmVw bGFjZUNoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIE5vZGUqIG9sZENoaWxkLCBFeGNl CiAgICAgICAgIGNoaWxkLT5zZXROZXh0U2libGluZyhuZXh0KTsKICAgICAgICAgYWxsb3dFdmVu dERpc3BhdGNoKCk7CiAKKyAgICAgICAgY2hpbGRyZW5DaGFuZ2VkKGZhbHNlLCBwcmV2LmdldCgp LCBuZXh0LCAxKTsKICAgICAgICAgbm90aWZ5Q2hpbGRJbnNlcnRlZChjaGlsZC5nZXQoKSk7CiAg ICAgICAgICAgICAgICAgCiAgICAgICAgIC8vIEFkZCBjaGlsZCB0byB0aGUgcmVuZGVyaW5nIHRy ZWUKQEAgLTI4Nyw4ICsyODUsNiBAQCBib29sIENvbnRhaW5lck5vZGU6OnJlcGxhY2VDaGlsZChQ YXNzUmVmUHRyPE5vZGU+IG5ld0NoaWxkLCBOb2RlKiBvbGRDaGlsZCwgRXhjZQogICAgICAgICBj aGlsZCA9IG5leHRDaGlsZC5yZWxlYXNlKCk7CiAgICAgfQogCi0gICAgaWYgKGNoaWxkQ291bnRE ZWx0YSkKLSAgICAgICAgY2hpbGRyZW5DaGFuZ2VkKGZhbHNlLCBwcmV2LmdldCgpLCBuZXh0Lmdl dCgpLCBjaGlsZENvdW50RGVsdGEpOwogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlmaWVkRXZlbnQo KTsKICAgICByZXR1cm4gdHJ1ZTsKIH0KQEAgLTUzMSw2ICs1MjcsNyBAQCBib29sIENvbnRhaW5l ck5vZGU6OmFwcGVuZENoaWxkKFBhc3NSZWZQdHI8Tm9kZT4gbmV3Q2hpbGQsIEV4Y2VwdGlvbkNv ZGUmIGVjLCBibwogICAgICAgICAvLyBOb3cgdGhhdCB0aGUgY2hpbGQgaXMgYXR0YWNoZWQgdG8g dGhlIHJlbmRlciB0cmVlLCBkaXNwYXRjaAogICAgICAgICAvLyB0aGUgcmVsZXZhbnQgbXV0YXRp b24gZXZlbnRzLgogICAgICAgICBkaXNwYXRjaENoaWxkSW5zZXJ0aW9uRXZlbnRzKGNoaWxkKTsK KyAgICAgICAgcHJldiA9IGNoaWxkOwogICAgIH0KIAogICAgIGRpc3BhdGNoU3VidHJlZU1vZGlm aWVkRXZlbnQoKTsK