37942 2010-04-21 12:42:00 -0700 [Android] Geolocation::suspend() and resume() have been erroneously removed 2010-04-21 23:32:24 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) Android Android RESOLVED FIXED P2 Normal --- 1 steveblock steveblock android-webkit-unforking commit-queue darin eric kenneth oldest_to_newest 215446 0 steveblock 2010-04-21 12:42:00 -0700 The Geolocation suspend() and resume() methods were erroneously removed in Bug 36255. These methods are required by Android (see Bug 34082 for more discussion about their use) so should be replaced. 215466 1 53983 steveblock 2010-04-21 13:26:33 -0700 Created attachment 53983 Patch 215613 2 eric 2010-04-21 18:15:58 -0700 Attachment 53983 was posted by a committer and has review+, assigning to Steve Block for commit. 215724 3 53983 commit-queue 2010-04-21 23:32:18 -0700 Comment on attachment 53983 Patch Clearing flags on attachment: 53983 Committed r58061: <http://trac.webkit.org/changeset/58061> 215725 4 commit-queue 2010-04-21 23:32:24 -0700 All reviewed patches have been landed. Closing bug. 53983 2010-04-21 13:26:33 -0700 2010-04-21 23:32:18 -0700 Patch bug-37942-20100421212631.patch text/plain 2000 steveblock SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODAxMCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjEgIFN0ZXZlIEJsb2NrICA8c3RldmVibG9ja0Bnb29n bGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFJlcGxhY2UgR2VvbG9jYXRpb246OnN1c3BlbmQoKS9yZXN1bWUoKSB3aGljaCBhcmUgcmVxdWly ZWQgYnkgQW5kcm9pZC4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM3OTQyCisKKyAgICAgICAgVGhlc2UgbWV0aG9kcyB3ZXJlIHJlbW92ZWQgaW4gQnVn IDM2MjU1LgorCisgICAgICAgIEJ1aWxkIGZpeCBvbmx5LCBubyBuZXcgdGVzdHMuCisKKyAgICAg ICAgKiBwYWdlL0dlb2xvY2F0aW9uLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9u OjpzdXNwZW5kKToKKyAgICAgICAgKFdlYkNvcmU6Okdlb2xvY2F0aW9uOjpyZXN1bWUpOgorICAg ICAgICAqIHBhZ2UvR2VvbG9jYXRpb24uaDoKKwogMjAxMC0wNC0yMSAgR2F2aW4gQmFycmFjbG91 Z2ggIDxiYXJyYWNsb3VnaEBhcHBsZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZ IChRdCBidWlsZCBmaXgpLgpJbmRleDogV2ViQ29yZS9wYWdlL0dlb2xvY2F0aW9uLmNwcAo9PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09Ci0tLSBXZWJDb3JlL3BhZ2UvR2VvbG9jYXRpb24uY3BwCShyZXZpc2lvbiA1ODAwMikK KysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTM3OSw2 ICszNzksMjIgQEAgdm9pZCBHZW9sb2NhdGlvbjo6Y2xlYXJXYXRjaChpbnQgd2F0Y2hJZAogICAg ICAgICBzdG9wVXBkYXRpbmcoKTsKIH0KIAordm9pZCBHZW9sb2NhdGlvbjo6c3VzcGVuZCgpCit7 CisjaWYgIUVOQUJMRShDTElFTlRfQkFTRURfR0VPTE9DQVRJT04pCisgICAgaWYgKGhhc0xpc3Rl bmVycygpKQorICAgICAgICBtX3NlcnZpY2UtPnN1c3BlbmQoKTsKKyNlbmRpZgorfQorCit2b2lk IEdlb2xvY2F0aW9uOjpyZXN1bWUoKQoreworI2lmICFFTkFCTEUoQ0xJRU5UX0JBU0VEX0dFT0xP Q0FUSU9OKQorICAgIGlmIChoYXNMaXN0ZW5lcnMoKSkKKyAgICAgICAgbV9zZXJ2aWNlLT5yZXN1 bWUoKTsKKyNlbmRpZgorfQorCiB2b2lkIEdlb2xvY2F0aW9uOjpzZXRJc0FsbG93ZWQoYm9vbCBh bGxvd2VkKQogewogICAgIC8vIFRoaXMgbWF5IGJlIGR1ZSB0byBlaXRoZXIgYSBuZXcgcG9zaXRp b24gZnJvbSB0aGUgc2VydmljZSwgb3IgYSBjYWNoZWQKSW5kZXg6IFdlYkNvcmUvcGFnZS9HZW9s b2NhdGlvbi5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5oCShyZXZp c2lvbiA1ODAwMikKKysrIFdlYkNvcmUvcGFnZS9HZW9sb2NhdGlvbi5oCSh3b3JraW5nIGNvcHkp CkBAIC02MSw2ICs2MSwxMCBAQCBwdWJsaWM6CiAgICAgaW50IHdhdGNoUG9zaXRpb24oUGFzc1Jl ZlB0cjxQb3NpdGlvbkNhbGxiYWNrPiwgUGFzc1JlZlB0cjxQb3NpdGlvbkVycm9yQ2FsbGJhY2s+ LCBQYXNzUmVmUHRyPFBvc2l0aW9uT3B0aW9ucz4pOwogICAgIHZvaWQgY2xlYXJXYXRjaChpbnQg d2F0Y2hJZCk7CiAKKyAgICAvLyBUaGVzZSBtZXRob2RzIGFyZSB1c2VkIGJ5IEFuZHJvaWQuCisg ICAgdm9pZCBzdXNwZW5kKCk7CisgICAgdm9pZCByZXN1bWUoKTsKKwogICAgIHZvaWQgc2V0SXNB bGxvd2VkKGJvb2wpOwogICAgIEZyYW1lKiBmcmFtZSgpIGNvbnN0IHsgcmV0dXJuIG1fZnJhbWU7 IH0KIAo=