37929 2010-04-21 09:16:50 -0700 [Mac] Implement LayoutTestController::markerTextForListItem() 2010-07-15 12:18:52 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Mac OS X 10.5 RESOLVED FIXED P2 Normal --- 42054 1 jwieczorek webkit-unassigned aroben bweinstein darin dbates simon.fraser webkit.review.bot oldest_to_newest 215348 0 jwieczorek 2010-04-21 09:16:50 -0700 Added in http://trac.webkit.org/changeset/57986 and used in the following tests: fast/lists/ol-nested-items-dynamic-insert.html fast/lists/ol-nested-items-dynamic-remove.html fast/lists/ol-nested-items.html fast/lists/ol-nested-list-dynamic-insert.html fast/lists/ol-nested-list-dynamic-remove.html fast/lists/ol-nested-list.html 251655 1 61603 dbates 2010-07-14 21:06:23 -0700 Created attachment 61603 Patch I thought to split up the Mac and Windows patches and use Bug #42054 as a meta bug. With insight from Adam Roben, I updated the patch based on Darin Adler's comment in Bug #42054 <https://bugs.webkit.org/show_bug.cgi?id=42054#c4>. Also, added class function +[DOMElement _DOMElementFromJSContext] to convert a JSContextRef and JSValueRef into a DOMElement. 251656 2 webkit.review.bot 2010-07-14 21:07:26 -0700 Attachment 61603 did not pass style-queue: Failed to run "['WebKitTools/Scripts/check-webkit-style']" exit_code: 1 WebKit/mac/DOM/WebDOMOperationsPrivate.h:32: Extra space before ( in function call [whitespace/parens] [4] Total errors found: 1 in 8 files If any of these errors are false positives, please file a bug against check-webkit-style. 251837 3 61603 darin 2010-07-15 06:27:19 -0700 Comment on attachment 61603 Patch > +@implementation DOMElement (WebDOMElementOperationsPrivate) I suggest a blank line after "@implementation" here. > + if (!context) > + return 0; > + > + JSLock lock(SilenceAssertionsOnly); > + ExecState* execState = toJS(context); > + if (!value) > + return 0; No reason to wait until after taking JSLock to null-check value. > + > + JSValue jsValue = toJS(execState, value); > + Element* element = toElement(jsValue); > + return element ? (DOMElement *)kit(element) : 0; > +} The kit function can handle null. You should be able to write it like this: return kit(toElement(toJS(toJS(context), value))); Without all the local variables and the type casts. > + > +- (NSString *)_markerTextForListItem > +{ > + return WebCore::markerTextForListItem(static_cast<WebCore::Element*>(core(self))); Do you need the type cast? I thought core and kit had type-specific versions. > +@end I suggest a line before "@end". > + JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithCFString((CFStringRef)[element _markerTextForListItem])); > + return markerText; Will this work for elements that return nil for the string? 252035 4 dbates 2010-07-15 12:13:58 -0700 Thank you for the review. (In reply to comment #3) > (From update of attachment 61603 [details]) > > +@implementation DOMElement (WebDOMElementOperationsPrivate) > > I suggest a blank line after "@implementation" here. Will add blank line before I land. > > > + if (!context) > > + return 0; > > + > > + JSLock lock(SilenceAssertionsOnly); > > + ExecState* execState = toJS(context); > > + if (!value) > > + return 0; > > No reason to wait until after taking JSLock to null-check value. Will change before I land. > > > + > > + JSValue jsValue = toJS(execState, value); > > + Element* element = toElement(jsValue); > > + return element ? (DOMElement *)kit(element) : 0; > > +} > > The kit function can handle null. You should be able to write it like this: > > return kit(toElement(toJS(toJS(context), value))); > > Without all the local variables and the type casts. Will change before I land. > > > + > > +- (NSString *)_markerTextForListItem > > +{ > > + return WebCore::markerTextForListItem(static_cast<WebCore::Element*>(core(self))); > > Do you need the type cast? I thought core and kit had type-specific versions. The cast is not necessary, will import DOMElementInternal.h to use the type-specific kit() (some how missed this file when scanning through the source). > > > +@end > > I suggest a line before "@end". Will add blank line. > > > + JSRetainPtr<JSStringRef> markerText(Adopt, JSStringCreateWithCFString((CFStringRef)[element _markerTextForListItem])); > > + return markerText; > > Will this work for elements that return nil for the string? -[DOMElement _markerTextForListItem] never returns the nil object. Moreover, it does work correctly should WebCore::markerTextForListItem() return a null string (i.e. WebCore::String()). 252036 5 dbates 2010-07-15 12:18:52 -0700 Committed r63445: <http://trac.webkit.org/changeset/63445> 61603 2010-07-14 21:06:23 -0700 2010-07-15 06:27:19 -0700 Patch Bug37929.patch text/plain 7699 dbates SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA2MzM5OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTQgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29t PgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtNYWNd IEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWFya2VyVGV4dEZvckxpc3RJdGVtKCkK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTI5CisK KyAgICAgICAgRXhwb3J0IHN5bWJvbHMgZm9yIFdlYkNvcmU6Om1hcmtlclRleHRGb3JMaXN0SXRl bSgpIGFuZCBXZWJDb3JlOjp0b0VsZW1lbnQoKS4KKworICAgICAgICAqIFdlYkNvcmUuZXhwLmlu OgorCiAyMDEwLTA3LTE0ICBFdmFuIFN0YWRlICA8ZXN0YWRlQGNocm9taXVtLm9yZz4KIAogICAg ICAgICBSZXZpZXdlZCBieSBLZW50IFRhbXVyYS4KSW5kZXg6IFdlYkNvcmUvV2ViQ29yZS5leHAu aW4KPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLmV4cC5pbgkocmV2aXNpb24gNjMzODgp CisrKyBXZWJDb3JlL1dlYkNvcmUuZXhwLmluCSh3b3JraW5nIGNvcHkpCkBAIC00MjMsNiArNDIz LDcgQEAgX19aTjdXZWJDb3JlMjBSZW5kZXJFbWJlZGRlZE9iamVjdDMwc2V0UwogX19aTjdXZWJD b3JlMjBSZXNvdXJjZVJlc3BvbnNlQmFzZTI0c2V0RXhwZWN0ZWRDb250ZW50TGVuZ3RoRXgKIF9f Wk43V2ViQ29yZTIwUmVzb3VyY2VSZXNwb25zZUJhc2VDMkV2CiBfX1pON1dlYkNvcmUyMHByb3Rv Y29sSXNKYXZhU2NyaXB0RVJLTlNfNlN0cmluZ0UKK19fWk43V2ViQ29yZTIxbWFya2VyVGV4dEZv ckxpc3RJdGVtRVBOU183RWxlbWVudEUKIF9fWk43V2ViQ29yZTIxUGxhdGZvcm1LZXlib2FyZEV2 ZW50MjRkaXNhbWJpZ3VhdGVLZXlEb3duRXZlbnRFTlMwXzRUeXBlRWIKIF9fWk43V2ViQ29yZTIx UGxhdGZvcm1LZXlib2FyZEV2ZW50QzFFUDdOU0V2ZW50CiBfX1pON1dlYkNvcmUyMVNWR0RvY3Vt ZW50RXh0ZW5zaW9uczIxc2FtcGxlQW5pbWF0aW9uQXRUaW1lRVJLTlNfNlN0cmluZ0VQTlNfMTRT VkdTTUlMRWxlbWVudEVkCkBAIC03NzYsNiArNzc3LDcgQEAgX19aTjdXZWJDb3JlOVRpbWVyQmFz ZTRzdG9wRXYKIF9fWk43V2ViQ29yZTlUaW1lckJhc2U1c3RhcnRFZGQKIF9fWk43V2ViQ29yZTlU aW1lckJhc2VDMkV2CiBfX1pON1dlYkNvcmU5VGltZXJCYXNlRDJFdgorX19aTjdXZWJDb3JlOXRv RWxlbWVudEVOM0pTQzdKU1ZhbHVlRQogX19aTjdXZWJDb3JlOWZvbnRDYWNoZUV2CiBfX1pON1dl YkNvcmU5bWFrZVJhbmdlRVJLTlNfMTVWaXNpYmxlUG9zaXRpb25FUzJfCiBfX1pON1dlYkNvcmU5 cGFnZUNhY2hlRXYKSW5kZXg6IFdlYktpdC9tYWMvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9tYWMvQ2hhbmdlTG9nCShyZXZpc2lvbiA2MzM5OSkKKysrIFdlYktpdC9tYWMvQ2hhbmdl TG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTcgQEAKKzIwMTAtMDctMTQgIERhbmllbCBC YXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09Q UyEpLgorCisgICAgICAgIFtNYWNdIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWFy a2VyVGV4dEZvckxpc3RJdGVtKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3OTI5CisKKyAgICAgICAgSW1wbGVtZW50cyBzdXBwb3J0IGZvciBtYXJr ZXJUZXh0Rm9yTGlzdEl0ZW0gaW4gdGhlIE1hYyBwb3J0LgorCisgICAgICAgICogRE9NL1dlYkRP TU9wZXJhdGlvbnMubW06CisgICAgICAgICgrW0RPTUVsZW1lbnQgX0RPTUVsZW1lbnRGcm9tSlND b250ZXh0XSk6IEFkZGVkLgorICAgICAgICAoLVtET01FbGVtZW50IF9tYXJrZXJUZXh0Rm9yTGlz dEl0ZW1dKTogQWRkZWQuCisgICAgICAgICogRE9NL1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmg6 CisKIDIwMTAtMDctMTQgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CiAK ICAgICAgICAgRml4IG5vbi1BQ0NFTEVSQVRFRF9DT01QT1NJVElORyBidWlsZC4KSW5kZXg6IFdl YktpdC9tYWMvRE9NL1dlYkRPTU9wZXJhdGlvbnMubW0KPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L21h Yy9ET00vV2ViRE9NT3BlcmF0aW9ucy5tbQkocmV2aXNpb24gNjMzODgpCisrKyBXZWJLaXQvbWFj L0RPTS9XZWJET01PcGVyYXRpb25zLm1tCSh3b3JraW5nIGNvcHkpCkBAIC0zNiwxNSArMzYsNDMg QEAKICNpbXBvcnQgIldlYkZyYW1lSW50ZXJuYWwuaCIKICNpbXBvcnQgIldlYkZyYW1lUHJpdmF0 ZS5oIgogI2ltcG9ydCAiV2ViS2l0TlNTdHJpbmdFeHRyYXMuaCIKKyNpbXBvcnQgPEphdmFTY3Jp cHRDb3JlL0FQSUNhc3QuaD4KICNpbXBvcnQgPFdlYkNvcmUvQ1NTSGVscGVyLmg+CiAjaW1wb3J0 IDxXZWJDb3JlL0RvY3VtZW50Lmg+CisjaW1wb3J0IDxXZWJDb3JlL0pTRWxlbWVudC5oPgogI2lt cG9ydCA8V2ViQ29yZS9MZWdhY3lXZWJBcmNoaXZlLmg+CiAjaW1wb3J0IDxXZWJDb3JlL21hcmt1 cC5oPgorI2ltcG9ydCA8V2ViQ29yZS9SZW5kZXJUcmVlQXNUZXh0Lmg+CiAjaW1wb3J0IDxXZWJL aXQvRE9NRXh0ZW5zaW9ucy5oPgogI2ltcG9ydCA8V2ViS2l0L0RPTUhUTUwuaD4KKyNpbXBvcnQg PHJ1bnRpbWUvSlNMb2NrLmg+CisjaW1wb3J0IDxydW50aW1lL0pTVmFsdWUuaD4KICNpbXBvcnQg PHd0Zi9Bc3NlcnRpb25zLmg+CiAKIHVzaW5nIG5hbWVzcGFjZSBXZWJDb3JlOwordXNpbmcgbmFt ZXNwYWNlIEpTQzsKKworQGltcGxlbWVudGF0aW9uIERPTUVsZW1lbnQgKFdlYkRPTUVsZW1lbnRP cGVyYXRpb25zUHJpdmF0ZSkKKysgKERPTUVsZW1lbnQgKilfRE9NRWxlbWVudEZyb21KU0NvbnRl eHQ6KEpTQ29udGV4dFJlZiljb250ZXh0IHZhbHVlOihKU1ZhbHVlUmVmKXZhbHVlCit7CisgICAg aWYgKCFjb250ZXh0KQorICAgICAgICByZXR1cm4gMDsKKworICAgIEpTTG9jayBsb2NrKFNpbGVu Y2VBc3NlcnRpb25zT25seSk7CisgICAgRXhlY1N0YXRlKiBleGVjU3RhdGUgPSB0b0pTKGNvbnRl eHQpOworICAgIGlmICghdmFsdWUpCisgICAgICAgIHJldHVybiAwOworCisgICAgSlNWYWx1ZSBq c1ZhbHVlID0gdG9KUyhleGVjU3RhdGUsIHZhbHVlKTsKKyAgICBFbGVtZW50KiBlbGVtZW50ID0g dG9FbGVtZW50KGpzVmFsdWUpOworICAgIHJldHVybiBlbGVtZW50ID8gKERPTUVsZW1lbnQgKilr aXQoZWxlbWVudCkgOiAwOworfQorCistIChOU1N0cmluZyAqKV9tYXJrZXJUZXh0Rm9yTGlzdEl0 ZW0KK3sKKyAgICByZXR1cm4gV2ViQ29yZTo6bWFya2VyVGV4dEZvckxpc3RJdGVtKHN0YXRpY19j YXN0PFdlYkNvcmU6OkVsZW1lbnQqPihjb3JlKHNlbGYpKSk7Cit9CitAZW5kCiAKIEBpbXBsZW1l bnRhdGlvbiBET01Ob2RlIChXZWJET01Ob2RlT3BlcmF0aW9ucykKIApJbmRleDogV2ViS2l0L21h Yy9ET00vV2ViRE9NT3BlcmF0aW9uc1ByaXZhdGUuaAo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvbWFj L0RPTS9XZWJET01PcGVyYXRpb25zUHJpdmF0ZS5oCShyZXZpc2lvbiA2MzM4OCkKKysrIFdlYktp dC9tYWMvRE9NL1dlYkRPTU9wZXJhdGlvbnNQcml2YXRlLmgJKHdvcmtpbmcgY29weSkKQEAgLTI3 LDYgKzI3LDEyIEBACiAgKi8KIAogI2ltcG9ydCA8V2ViS2l0L1dlYkRPTU9wZXJhdGlvbnMuaD4K KyNpbXBvcnQgPEphdmFTY3JpcHRDb3JlL0pTQmFzZS5oPgorCitAaW50ZXJmYWNlIERPTUVsZW1l bnQgKFdlYkRPTUVsZW1lbnRPcGVyYXRpb25zUHJpdmF0ZSkKKysgKERPTUVsZW1lbnQgKilfRE9N RWxlbWVudEZyb21KU0NvbnRleHQ6KEpTQ29udGV4dFJlZiljb250ZXh0IHZhbHVlOihKU1ZhbHVl UmVmKXZhbHVlOworLSAoTlNTdHJpbmcgKilfbWFya2VyVGV4dEZvckxpc3RJdGVtOworQGVuZAog CiBAaW50ZXJmYWNlIERPTURvY3VtZW50IChXZWJET01Eb2N1bWVudE9wZXJhdGlvbnNQcml2YXRl KQogLSAoTlNBcnJheSAqKV9mb2N1c2FibGVOb2RlczsKSW5kZXg6IFdlYktpdFRvb2xzL0NoYW5n ZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMzk5 KQorKysgV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTUg QEAKKzIwMTAtMDctMTQgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgorCisgICAgICAg IFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtNYWNdIEltcGxlbWVudCBM YXlvdXRUZXN0Q29udHJvbGxlcjo6bWFya2VyVGV4dEZvckxpc3RJdGVtKCkKKyAgICAgICAgaHR0 cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTI5CisKKyAgICAgICAgSW1w bGVtZW50cyBEUlQgc3VwcG9ydCBmb3IgbWFya2VyVGV4dEZvckxpc3RJdGVtIGluIHRoZSBNYWMg cG9ydC4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxl ck1hYy5tbToKKyAgICAgICAgKExheW91dFRlc3RDb250cm9sbGVyOjptYXJrZXJUZXh0Rm9yTGlz dEl0ZW0pOiBJbXBsZW1lbnRlZC4KKwogMjAxMC0wNy0xNCAgTWFjaWVqIFN0YWNob3dpYWsgIDxt anNAYXBwbGUuY29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE1hcmsgUm93ZS4KSW5kZXg6IFdl YktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL21hYy9MYXlvdXRUZXN0Q29udHJvbGxlck1hYy5tbQo9 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09Ci0tLSBXZWJLaXRUb29scy9EdW1wUmVuZGVyVHJlZS9tYWMvTGF5b3V0VGVzdENv bnRyb2xsZXJNYWMubW0JKHJldmlzaW9uIDYzMzg4KQorKysgV2ViS2l0VG9vbHMvRHVtcFJlbmRl clRyZWUvbWFjL0xheW91dFRlc3RDb250cm9sbGVyTWFjLm1tCSh3b3JraW5nIGNvcHkpCkBAIC00 Niw2ICs0Niw3IEBACiAjaW1wb3J0IDxXZWJLaXQvV2ViQ29yZVN0YXRpc3RpY3MuaD4KICNpbXBv cnQgPFdlYktpdC9XZWJEYXRhU291cmNlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV2ViRGF0YWJhc2VN YW5hZ2VyUHJpdmF0ZS5oPgorI2ltcG9ydCA8V2ViS2l0L1dlYkRPTU9wZXJhdGlvbnNQcml2YXRl Lmg+CiAjaW1wb3J0IDxXZWJLaXQvV2ViRnJhbWUuaD4KICNpbXBvcnQgPFdlYktpdC9XZWJGcmFt ZVZpZXdQcml2YXRlLmg+CiAjaW1wb3J0IDxXZWJLaXQvV2ViR2VvbG9jYXRpb25Qb3NpdGlvbi5o PgpAQCAtMTk2LDggKzE5NywxMiBAQCBKU1JldGFpblB0cjxKU1N0cmluZ1JlZj4gTGF5b3V0VGVz dENvbnRyCiAKIEpTUmV0YWluUHRyPEpTU3RyaW5nUmVmPiBMYXlvdXRUZXN0Q29udHJvbGxlcjo6 bWFya2VyVGV4dEZvckxpc3RJdGVtKEpTQ29udGV4dFJlZiBjb250ZXh0LCBKU1ZhbHVlUmVmIG5v ZGVPYmplY3QpIGNvbnN0CiB7Ci0gICAgLy8gRklYTUU6IEltcGxlbWVudCBtZS4KLSAgICByZXR1 cm4gSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+KCk7CisgICAgRE9NRWxlbWVudCAqZWxlbWVudCA9 IFtET01FbGVtZW50IF9ET01FbGVtZW50RnJvbUpTQ29udGV4dDpjb250ZXh0IHZhbHVlOm5vZGVP YmplY3RdOworICAgIGlmICghZWxlbWVudCkKKyAgICAgICAgcmV0dXJuIEpTUmV0YWluUHRyPEpT U3RyaW5nUmVmPigpOworCisgICAgSlNSZXRhaW5QdHI8SlNTdHJpbmdSZWY+IG1hcmtlclRleHQo QWRvcHQsIEpTU3RyaW5nQ3JlYXRlV2l0aENGU3RyaW5nKChDRlN0cmluZ1JlZilbZWxlbWVudCBf bWFya2VyVGV4dEZvckxpc3RJdGVtXSkpOworICAgIHJldHVybiBtYXJrZXJUZXh0OwogfQogCiBp bnQgTGF5b3V0VGVzdENvbnRyb2xsZXI6OnBhZ2VOdW1iZXJGb3JFbGVtZW50QnlJZChKU1N0cmlu Z1JlZiBpZCwgZmxvYXQgcGFnZVdpZHRoSW5QaXhlbHMsIGZsb2F0IHBhZ2VIZWlnaHRJblBpeGVs cykKSW5kZXg6IExheW91dFRlc3RzL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBMYXlvdXRUZXN0 cy9DaGFuZ2VMb2cJKHJldmlzaW9uIDYzMzk5KQorKysgTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCSh3 b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDctMTQgIERhbmllbCBCYXRlcyAg PGRiYXRlc0ByaW0uY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIFtNYWNdIEltcGxlbWVudCBMYXlvdXRUZXN0Q29udHJvbGxlcjo6bWFya2VyVGV4 dEZvckxpc3RJdGVtKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcu Y2dpP2lkPTM3OTI5CisKKyAgICAgICAgUmVtb3ZlIHNraXBwZWQgbGF5b3V0IHRlc3RzIG5vdyB0 aGF0IHdlIGhhdmUgRFJUIHN1cHBvcnQuCisKKyAgICAgICAgKiBwbGF0Zm9ybS9tYWMvU2tpcHBl ZDoKKwogMjAxMC0wNy0xNCAgRXJpYyBTZWlkZWwgIDxlcmljQHdlYmtpdC5vcmc+CiAKICAgICAg ICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0aC4KSW5kZXg6IExheW91dFRlc3RzL3BsYXRmb3JtL21h Yy9Ta2lwcGVkCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVk CShyZXZpc2lvbiA2MzM4OCkKKysrIExheW91dFRlc3RzL3BsYXRmb3JtL21hYy9Ta2lwcGVkCSh3 b3JraW5nIGNvcHkpCkBAIC0xNTYsMTQgKzE1Niw2IEBAIGZhc3Qvb3ZlcmZsb3cvc2Nyb2xsYmFy LXJlc3RvcmVkLWFuZC10aGUKIGVkaXRpbmcvcGFzdGVib2FyZC9vbnBhc3RlLXRleHQtaHRtbC5o dG1sCiBmYXN0L2V2ZW50cy9vbmRyb3AtdGV4dC1odG1sLmh0bWwKIAotIyBNaXNzaW5nIGFuIGlt cGxlbWVudGF0aW9uIG9mIExheW91dFRlc3RDb250cm9sbGVyOjptYXJrZXJUZXh0Rm9yTGlzdEl0 ZW0oKQotZmFzdC9saXN0cy9vbC1uZXN0ZWQtaXRlbXMtZHluYW1pYy1pbnNlcnQuaHRtbAotZmFz dC9saXN0cy9vbC1uZXN0ZWQtaXRlbXMtZHluYW1pYy1yZW1vdmUuaHRtbAotZmFzdC9saXN0cy9v bC1uZXN0ZWQtaXRlbXMuaHRtbAotZmFzdC9saXN0cy9vbC1uZXN0ZWQtbGlzdC1keW5hbWljLWlu c2VydC5odG1sCi1mYXN0L2xpc3RzL29sLW5lc3RlZC1saXN0LWR5bmFtaWMtcmVtb3ZlLmh0bWwK LWZhc3QvbGlzdHMvb2wtbmVzdGVkLWxpc3QuaHRtbAotCiAjIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zMzgxMgogZmFzdC9kb20vaWNvbi11cmwtcHJvcGVydHkuaHRt bAogCg==