37922 2010-04-21 07:11:47 -0700 Lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter 2010-04-21 07:43:07 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC All RESOLVED FIXED http://build.webkit.org/results/SnowLeopard%20Intel%20Leaks/r57973%20(6207)/DumpRenderTree-leaks.txt InRadar P2 Normal --- 1 aroben aroben oldest_to_newest 215296 0 aroben 2010-04-21 07:11:47 -0700 The SnowLeopard leaks bot is showing lots of leaks of SVGFilterBuilder objects in RenderSVGResourceFilter. I think the bug is in RenderSVGResourceFilter::applyResource, which allocates a FilterData (which holds an SVGFilterBuilder) on the heap, but doesn't destroy it when returning early under error conditions. Using an OwnPtr should fix this easily. 215298 1 aroben 2010-04-21 07:12:28 -0700 <rdar://problem/7888397> 215310 2 53955 aroben 2010-04-21 07:40:42 -0700 Created attachment 53955 Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter 215311 3 53955 hyatt 2010-04-21 07:41:23 -0700 Comment on attachment 53955 Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter r=me 215312 4 aroben 2010-04-21 07:43:07 -0700 Committed r57980: <http://trac.webkit.org/changeset/57980> 53955 2010-04-21 07:40:42 -0700 2010-04-21 07:41:23 -0700 Fix leaks of FilterData/SVGFilterBuilder in RenderSVGResourceFilter bug-37922-20100421104040.patch text/plain 1626 aroben ZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXgg NjQxNGI1Yy4uN2ZkMGYwOCAxMDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2Vi Q29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMSAgQWRhbSBSb2JlbiAg PGFyb2JlbkBhcHBsZS5jb20+CisKKyAgICAgICAgRml4IGxlYWtzIG9mIEZpbHRlckRhdGEvU1ZH RmlsdGVyQnVpbGRlciBpbiBSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcgorCisgICAgICAgIEZpeGVz IDxodHRwOi8vd2Via2l0Lm9yZy9iLzM3OTIyPi4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JP RFkgKE9PUFMhKS4KKworICAgICAgICAqIHJlbmRlcmluZy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRl ci5jcHA6CisgICAgICAgIChXZWJDb3JlOjpSZW5kZXJTVkdSZXNvdXJjZUZpbHRlcjo6YXBwbHlS ZXNvdXJjZSk6IFVzZSBhbiBPd25QdHIgdG8KKyAgICAgICAgaG9sZCB0aGUgaGVhcC1hbGxvY2F0 ZWQgRmlsdGVyRGF0YSBvYmplY3QsIHNvIHRoYXQgd2Ugd29uJ3QgbGVhayBpdAorICAgICAgICB3 aGVuIHdlIGJhaWwgb3V0IG9mIHRoaXMgZnVuY3Rpb24gb24gZXJyb3IuCisKIDIwMTAtMDQtMjEg IEJlbmphbWluIFBvdWxhaW4gIDxpa2lwb3VAZ21haWwuY29tPgogCiAgICAgICAgIFJldmlld2Vk IGJ5IFNpbW9uIEZyYXNlci4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNW R1Jlc291cmNlRmlsdGVyLmNwcCBiL1dlYkNvcmUvcmVuZGVyaW5nL1JlbmRlclNWR1Jlc291cmNl RmlsdGVyLmNwcAppbmRleCBlOTdkZmYxLi5jYmVkZmUzIDEwMDY0NAotLS0gYS9XZWJDb3JlL3Jl bmRlcmluZy9SZW5kZXJTVkdSZXNvdXJjZUZpbHRlci5jcHAKKysrIGIvV2ViQ29yZS9yZW5kZXJp bmcvUmVuZGVyU1ZHUmVzb3VyY2VGaWx0ZXIuY3BwCkBAIC0xNDksNyArMTQ5LDcgQEAgYm9vbCBS ZW5kZXJTVkdSZXNvdXJjZUZpbHRlcjo6YXBwbHlSZXNvdXJjZShSZW5kZXJPYmplY3QqIG9iamVj dCwgR3JhcGhpY3NDb250ZXgKICAgICAgICAgZGVsZXRlIG1fZmlsdGVyLnRha2Uob2JqZWN0KTsg Ly8gT29wcywgaGF2ZSB0byByZWJ1aWxkLCBnbyB0aHJvdWdoIG5vcm1hbCBjb2RlIHBhdGgKICAg ICB9CiAKLSAgICBGaWx0ZXJEYXRhKiBmaWx0ZXJEYXRhID0gbmV3IEZpbHRlckRhdGE7CisgICAg T3duUHRyPEZpbHRlckRhdGE+IGZpbHRlckRhdGEobmV3IEZpbHRlckRhdGEpOwogICAgIGZpbHRl ckRhdGEtPmJ1aWxkZXIgPSBidWlsZFByaW1pdGl2ZXMoKTsKICAgICBpZiAoIWZpbHRlckRhdGEt PmJ1aWxkZXIpCiAgICAgICAgIHJldHVybiBmYWxzZTsKQEAgLTIyMyw3ICsyMjMsNyBAQCBib29s IFJlbmRlclNWR1Jlc291cmNlRmlsdGVyOjphcHBseVJlc291cmNlKFJlbmRlck9iamVjdCogb2Jq ZWN0LCBHcmFwaGljc0NvbnRleAogICAgIG1fc2F2ZWRDb250ZXh0ID0gY29udGV4dDsKIAogICAg IGNvbnRleHQgPSBzb3VyY2VHcmFwaGljQ29udGV4dDsKLSAgICBtX2ZpbHRlci5zZXQob2JqZWN0 LCBmaWx0ZXJEYXRhKTsKKyAgICBtX2ZpbHRlci5zZXQob2JqZWN0LCBmaWx0ZXJEYXRhLnJlbGVh c2UoKSk7CiAKICAgICByZXR1cm4gdHJ1ZTsKIH0K