37918 2010-04-21 04:42:56 -0700 [GTK] Markup of copied non ASCII characters is broken 2010-05-05 23:23:59 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) PC Linux RESOLVED FIXED P2 Normal --- 1 hamaji hamaji eric oldest_to_newest 215248 0 53943 hamaji 2010-04-21 04:42:56 -0700 Created attachment 53943 test case How to reproduce: - Open the attached HTML with GtkLauncher - Select more than 4 UTF8 characters in the HTML and copy it - Paste it after "paste here:" - You should see a string shorter than the original text This is the reason why editing/pasteboard/copy-backslash-with-euc.html is failing. I'll post a patch soon later. 215249 1 53944 hamaji 2010-04-21 04:46:14 -0700 Created attachment 53944 Patch v1 215251 2 hamaji 2010-04-21 04:48:09 -0700 (In reply to comment #1) > Created an attachment (id=53944) [details] > Patch v1 FYI, this document doesn't say gtk_selection_data_set() takes the number of UTF8 characters as the length of data. http://library.gnome.org/devel/gtk/stable/gtk-Selections.html#gtk-selection-data-set 219958 3 53944 eric 2010-05-02 19:09:58 -0700 Comment on attachment 53944 Patch v1 It seems a comment in the code would be helpful here. 219959 4 eric 2010-05-02 19:10:29 -0700 LGTM, I dont' need to see this again, even if you add a comment. If you want to cq it with changes, you can always use "webkit-patch land-safely". 219960 5 eric 2010-05-02 19:11:04 -0700 I'm not sure a comment is needed, but if you feel others might be confused by this API like the original author was, then please add one. 219989 6 eric 2010-05-02 19:31:41 -0700 Attachment 53944 was posted by a committer and has review+, assigning to Shinichiro Hamaji for commit. 221518 7 hamaji 2010-05-05 23:06:35 -0700 It seemed this fix was done by this change: http://trac.webkit.org/changeset/58468 So, I'll just commit the change for the Skipped list. 221523 8 hamaji 2010-05-05 23:23:59 -0700 Committed r58866: <http://trac.webkit.org/changeset/58866> 53943 2010-04-21 04:42:56 -0700 2010-04-21 04:42:56 -0700 test case copy-secure.html text/html 225 hamaji PG1ldGEgY2hhcnNldD0iVVRGLTgiPgo8ZGl2IHN0eWxlPSItd2Via2l0LXRleHQtc2VjdXJpdHk6 Y2lyY2xlIj5mb29iYXJiYXogZm9vYmFyYmF6PC9kaXY+CjxkaXY+4pem4pem4pem4pem4pem4pem 4pem4pem4pem4pem4pem4pem4pem4pem4pem4pem4pem4pem4pemPC9kaXY+CjxkaXY+zrHOss6z zrTigKbOtjwvZGl2Pgo8ZGl2IGNvbnRlbnRFZGl0YWJsZT5wYXN0ZSBoZXJlOiA8L2Rpdj4K 53944 2010-04-21 04:46:14 -0700 2010-05-02 19:09:57 -0700 Patch v1 bug-37918-20100421204612.patch text/plain 2701 hamaji ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyNDI4NjFlLi40MmMwODUwIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQt MjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWppQGNocm9taXVtLm9yZz4KKworICAgICAgICBS ZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBbR1RLXSBNYXJrdXAgb2YgY29w aWVkIG5vbiBBU0NJSSBjaGFyYWN0ZXJzIGlzIGJyb2tlbgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5MTgKKworICAgICAgICAqIHBsYXRmb3JtL2d0 ay9Ta2lwcGVkOgorCiAyMDEwLTA0LTIxICBFcmljIFNlaWRlbCAgPGVyaWNAd2Via2l0Lm9yZz4K IAogICAgICAgICBVbnJldmlld2VkLCByb2xsaW5nIG91dCByNTc5NjMuCmRpZmYgLS1naXQgYS9M YXlvdXRUZXN0cy9wbGF0Zm9ybS9ndGsvU2tpcHBlZCBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0 ay9Ta2lwcGVkCmluZGV4IGQyOTkwOWUuLjMyZmZiMDUgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L3BsYXRmb3JtL2d0ay9Ta2lwcGVkCisrKyBiL0xheW91dFRlc3RzL3BsYXRmb3JtL2d0ay9Ta2lw cGVkCkBAIC01OTk2LDkgKzU5OTYsNSBAQCBpbnNwZWN0b3IvdGltZWxpbmUtcGFpbnQuaHRtbAog IyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc3NTMKIG1lZGlhL2F1 ZGlvLWNvbnN0cnVjdG9yLXByZWxvYWQuaHRtbAogCi0jIGh0dHBzOi8vYnVncy53ZWJraXQub3Jn L3Nob3dfYnVnLmNnaT9pZD0zNjQxOQotIyBUaGUgY29waWVkIHNlY3VyZSB0ZXh0IGlzIHNvbWVo b3cgYnJva2VuLgotZWRpdGluZy9wYXN0ZWJvYXJkL2NvcHktYmFja3NsYXNoLXdpdGgtZXVjLmh0 bWwKLQogIyBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5MTQKIGZh c3QvZnJhbWVzL2ZyYW1lLWNyYXNoLXdpdGgtcGFnZS1jYWNoZS5odG1sCmRpZmYgLS1naXQgYS9X ZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hhbmdlTG9nCmluZGV4IDQwYzJhN2QuLjQwZTVk YTEgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9n CkBAIC0xLDMgKzEsMTkgQEAKKzIwMTAtMDQtMjEgIFNoaW5pY2hpcm8gSGFtYWppICA8aGFtYWpp QGNocm9taXVtLm9yZz4KKworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKwor ICAgICAgICBbR1RLXSBNYXJrdXAgb2YgY29waWVkIG5vbiBBU0NJSSBjaGFyYWN0ZXJzIGlzIGJy b2tlbgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc5 MTgKKworICAgICAgICBVc2Ugc3RybGVuIGluc3RlYWQgb2YgZ191dGY4X3N0cmxlbiB0byBjb3Vu dCB0aGUgbnVtYmVyIG9mIGJ5dGVzCisgICAgICAgIHdoZW4gd2UgcHV0IGEgVVRGOCBzdHJpbmcg aW50byB0aGUgY2xpcGJvYXJkLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cywgYnV0IGVkaXRpbmcv cGFzdGVib2FyZC9jb3B5LWJhY2tzbGFzaC13aXRoLWV1Yy5odG1sCisgICAgICAgIHNob3VsZCB0 ZXN0IHRoaXMgY2hhbmdlLgorCisgICAgICAgICogcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsu Y3BwOgorICAgICAgICAoV2ViQ29yZTo6Y2xpcGJvYXJkX2dldF9jb250ZW50c19jYik6CisKIDIw MTAtMDQtMjEgIEd1c3Rhdm8gU3Zlcnp1dCBCYXJiaWVyaSAgPGJhcmJpZXJpQHByb2Z1c2lvbi5t b2JpPgogCiAgICAgICAgIFJldmlld2VkIGJ5IE5pa29sYXMgWmltbWVybWFubi4KZGlmZiAtLWdp dCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3RrL1Bhc3RlYm9hcmRHdGsuY3BwIGIvV2ViQ29yZS9wbGF0 Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKaW5kZXggOTA3YTU1ZS4uOWU3YjIzYSAxMDA2NDQK LS0tIGEvV2ViQ29yZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKKysrIGIvV2ViQ29y ZS9wbGF0Zm9ybS9ndGsvUGFzdGVib2FyZEd0ay5jcHAKQEAgLTYxLDcgKzYxLDcgQEAgc3RhdGlj IHZvaWQgY2xpcGJvYXJkX2dldF9jb250ZW50c19jYihHdGtDbGlwYm9hcmQgKmNsaXBib2FyZCwg R3RrU2VsZWN0aW9uRGF0YQogICAgIGlmIChpbmZvID09IFBhc3RlYm9hcmQ6OmdlbmVyYWxQYXN0 ZWJvYXJkKCktPmhlbHBlcigpLT5nZXRJZEZvclRhcmdldFR5cGUoUGFzdGVib2FyZEhlbHBlcjo6 VGFyZ2V0VHlwZU1hcmt1cCkpCiAgICAgICAgIGd0a19zZWxlY3Rpb25fZGF0YV9zZXQoc2VsZWN0 aW9uX2RhdGEsIHNlbGVjdGlvbl9kYXRhLT50YXJnZXQsIDgsCiAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgcmVpbnRlcnByZXRfY2FzdDxjb25zdCBndWNoYXIqPihjbGlwYm9hcmREYXRh LT5tYXJrdXAoKSksCi0gICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgZ191dGY4X3N0cmxl bihjbGlwYm9hcmREYXRhLT5tYXJrdXAoKSwgLTEpKTsKKyAgICAgICAgICAgICAgICAgICAgICAg ICAgICAgICBzdHJsZW4oY2xpcGJvYXJkRGF0YS0+bWFya3VwKCkpKTsKICAgICBlbHNlCiAgICAg ICAgIGd0a19zZWxlY3Rpb25fZGF0YV9zZXRfdGV4dChzZWxlY3Rpb25fZGF0YSwgY2xpcGJvYXJk RGF0YS0+dGV4dCgpLCAtMSk7CiB9Cg==