37915 2010-04-21 02:14:34 -0700 WebKit build failure with xhtmlmp enabled , after patches for Bug 37175 2010-04-21 19:42:04 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Major --- 0 charles.wei webkit-unassigned commit-queue staikos oldest_to_newest 215200 0 charles.wei 2010-04-21 02:14:34 -0700 With bug 37175, which factors out DocumentWriter from FrameLoader, the API FrameLoader::responseMIMEType() is now DocumentWriter::mimeType(). #if ENABLE(XHTMLMP) bool Document::isXHTMLMPDocument() const { ... return frame()->loader()->responseMIMEType() == "application/vnd.wap.xhtml+xml"; } #endif should be changed to : return frame()->loader()->writer()->mimeType() == "application/vnd.wap.xhtml+xml"; 215205 1 53933 charles.wei 2010-04-21 02:25:04 -0700 Created attachment 53933 This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled) This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled) 215655 2 53933 commit-queue 2010-04-21 19:42:00 -0700 Comment on attachment 53933 This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled) Clearing flags on attachment: 53933 Committed r58041: <http://trac.webkit.org/changeset/58041> 215656 3 commit-queue 2010-04-21 19:42:04 -0700 All reviewed patches have been landed. Closing bug. 53933 2010-04-21 02:25:04 -0700 2010-04-21 19:42:00 -0700 This patch fixes the build problem caused by defect 37175 (only fails when xhtmlmp is enabled) 37915.patch text/plain 1477 charles.wei SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzk1OSkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjEgIENoYXJsZXMgV2VpICA8Y2hhcmxlcy53ZWlAdG9y Y2htb2JpbGUuY29tLmNuPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgor CisgICAgICAgIEZpeCB3ZWJraXQgYnVpbGQgcHJvYmxlbSB3aGVuIHhodG1sbXAgZW5hYmxlZCwg d2hpY2ggaXMgaW50cm9kdWNlZCBieSByZXZpc2lvbiA1NzkyNywgZm9yIAorICAgICAgICBidWcg Zml4IG9mIDM3MTc1ICwgd2hpY2ggc2VwZXJhdGVzIERvY3VtZW50V3JpdGVyIGZyb20gRnJhbWVM b2FkZXIKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3 OTE1CisKKyAgICAgICAgTm8gbmV3IHRlc3RzIHNpbmNlIHRoaXMgb25seSBmaXhlcyB0aGUgYnVp bGQgcHJvYmxlbS4KKworICAgICAgICAqIGRvbS9Eb2N1bWVudC5jcHA6CisgICAgICAgIChXZWJD b3JlOjpEb2N1bWVudDo6aXNYSFRNTE1QRG9jdW1lbnQpOgorCiAyMDEwLTA0LTIxICBSeW9zdWtl IE5pd2EgIDxybml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIE5vIHJldmlldy4gU3B1cmlvdXMg d2hpdGVzcGFjZSB3YXMgcmVtb3ZlZCBmcm9tIHByb2plY3QgZmlsZS4KSW5kZXg6IFdlYkNvcmUv ZG9tL0RvY3VtZW50LmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL2RvbS9Eb2N1bWVudC5jcHAJ KHJldmlzaW9uIDU3OTU5KQorKysgV2ViQ29yZS9kb20vRG9jdW1lbnQuY3BwCSh3b3JraW5nIGNv cHkpCkBAIC00ODYyLDcgKzQ4NjIsNyBAQCBib29sIERvY3VtZW50Ojppc1hIVE1MTVBEb2N1bWVu dCgpIGNvbnN0CiAgICAgLy8gTVVTVCBhY2NlcHQgWEhUTUxNUCBkb2N1bWVudCBpZGVudGlmaWVk IGFzICJhcHBsaWNhdGlvbi92bmQud2FwLnhodG1sK3htbCIKICAgICAvLyBhbmQgU0hPVUxEIGFj Y2VwdCBpdCBpZGVudGlmaWVkIGFzICJhcHBsaWNhdGlvbi94aHRtbCt4bWwiICwgImFwcGxpY2F0 aW9uL3hodG1sK3htbCIgaXMgYSAKICAgICAvLyBnZW5lcmFsIE1JTUUgdHlwZSBmb3IgYWxsIFhI VE1MIGRvY3VtZW50cywgbm90IG9ubHkgZm9yIFhIVE1MTVAKLSAgICByZXR1cm4gZnJhbWUoKS0+ bG9hZGVyKCktPnJlc3BvbnNlTUlNRVR5cGUoKSA9PSAiYXBwbGljYXRpb24vdm5kLndhcC54aHRt bCt4bWwiOworICAgIHJldHVybiBmcmFtZSgpLT5sb2FkZXIoKS0+d3JpdGVyKCktPm1pbWVUeXBl KCkgPT0gImFwcGxpY2F0aW9uL3ZuZC53YXAueGh0bWwreG1sIjsKIH0KICNlbmRpZgogCg==