37912 2010-04-20 23:32:12 -0700 [Qt] Build fix: warning on L933 of CompositeEditCommand.cpp 2010-07-13 04:59:28 -0700 1 1 1 Unclassified WebKit HTML Editing 528+ (Nightly build) All Linux RESOLVED FIXED P1 Normal --- 1 rniwa rniwa oldest_to_newest 215169 0 rniwa 2010-04-20 23:32:12 -0700 Qt Linux builds complains about the line 933 of CompositeEditCommand.cpp because it uses ternary operator to initialize RefPtr. 215171 1 53922 rniwa 2010-04-20 23:36:39 -0700 Created attachment 53922 replaces the ternary operator by an if statement 215175 2 53923 rniwa 2010-04-20 23:45:39 -0700 Created attachment 53923 added more comments and removed the changes in xcodeproj 215176 3 53923 eric 2010-04-20 23:47:28 -0700 Comment on attachment 53923 added more comments and removed the changes in xcodeproj Fantastic! 215194 4 53923 rniwa 2010-04-21 01:10:41 -0700 Comment on attachment 53923 added more comments and removed the changes in xcodeproj Removed from the commit queue since this patch has already been committed. 215195 5 rniwa 2010-04-21 01:11:40 -0700 Landed in http://trac.webkit.org/changeset/57957. 250441 6 61356 morrita 2010-07-13 04:53:16 -0700 Created attachment 61356 another repro (with automation) 250444 7 61356 morrita 2010-07-13 04:59:28 -0700 Comment on attachment 61356 another repro (with automation) Oops. posted to a wrong bug. 53922 2010-04-20 23:36:39 -0700 2010-04-20 23:45:39 -0700 replaces the ternary operator by an if statement fix37912 text/plain 2544 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzk1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBCdWlsZCBmaXg6IHdhcm5pbmcgb24gTDkzMyBvZiBDb21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTEyCisK KyAgICAgICAgUmVwbGFjZWQgdGhlIHRlcm5hcnkgb3BlcmF0b3IgYnkgYW4gaWYgc3RhdGVtZW50 LgorCisgICAgICAgICogV2ViQ29yZS54Y29kZXByb2ovcHJvamVjdC5wYnhwcm9qOgorICAgICAg ICAqIGVkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwOgorICAgICAgICAoV2ViQ29yZTo6 Q29tcG9zaXRlRWRpdENvbW1hbmQ6Om1vdmVQYXJhZ3JhcGhzKToKKwogMjAxMC0wNC0yMCAgUnlv c3VrZSBOaXdhICA8cm5pd2FAd2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZpZXdlZCBieSBKdXN0 aW4gR2FyY2lhLgpJbmRleDogV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHBy b2oJKHJldmlzaW9uIDU3OTUzKQorKysgV2ViQ29yZS9XZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0 LnBieHByb2oJKHdvcmtpbmcgY29weSkKQEAgLTIxMTA0LDcgKzIxMTA0LDcgQEAKIAkJCQlDRUY0 MThDRTExNzk2NzhDMDA5RDExMkMgLyogVmlld3BvcnRBcmd1bWVudHMuY3BwIGluIFNvdXJjZXMg Ki8sCiAJCQkJMEZEMzA4MEUxMTdDRjdFNzAwQTc5MUY3IC8qIFJlbmRlckZyYW1lQmFzZS5jcHAg aW4gU291cmNlcyAqLywKIAkJCQkwRkQzMDhENTExN0QxNjg1MDBBNzkxRjcgLyogUmVuZGVySUZy YW1lLmNwcCBpbiBTb3VyY2VzICovLAotIAkJCQk5NzM4ODlBMDExNkVBOURDMDBBREYzMTMgLyog RG9jdW1lbnRXcml0ZXIuY3BwIGluIFNvdXJjZXMgKi8sCisJCQkJOTczODg5QTAxMTZFQTlEQzAw QURGMzEzIC8qIERvY3VtZW50V3JpdGVyLmNwcCBpbiBTb3VyY2VzICovLAogCQkJKTsKIAkJCXJ1 bk9ubHlGb3JEZXBsb3ltZW50UG9zdHByb2Nlc3NpbmcgPSAwOwogCQl9OwpJbmRleDogV2ViQ29y ZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3Jl L2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCShyZXZpc2lvbiA1Nzk1MykKKysrIFdl YkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAJKHdvcmtpbmcgY29weSkKQEAg LTkzMCw4ICs5MzAsMTAgQEAgdm9pZCBDb21wb3NpdGVFZGl0Q29tbWFuZDo6bW92ZVBhcmFncmFw aAogCiAgICAgLy8gRklYTUU6IFRoaXMgaXMgYW4gaW5lZmZpY2llbnQgd2F5IHRvIHByZXNlcnZl IHN0eWxlIG9uIG5vZGVzIGluIHRoZSBwYXJhZ3JhcGggdG8gbW92ZS4gSXQKICAgICAvLyBzaG91 bGRuJ3QgbWF0dGVyIHRob3VnaCwgc2luY2UgbW92ZWQgcGFyYWdyYXBocyB3aWxsIHVzdWFsbHkg YmUgcXVpdGUgc21hbGwuCi0gICAgUmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50ID0g c3RhcnRPZlBhcmFncmFwaFRvTW92ZSAhPSBlbmRPZlBhcmFncmFwaFRvTW92ZSA/IGNyZWF0ZUZy YWdtZW50RnJvbU1hcmt1cChkb2N1bWVudCgpLCBjcmVhdGVNYXJrdXAocmFuZ2UuZ2V0KCksIDAs IERvTm90QW5ub3RhdGVGb3JJbnRlcmNoYW5nZSwgdHJ1ZSksICIiKSA6IDA7Ci0gICAgCisgICAg UmVmUHRyPERvY3VtZW50RnJhZ21lbnQ+IGZyYWdtZW50OworICAgIGlmIChzdGFydE9mUGFyYWdy YXBoVG9Nb3ZlICE9IGVuZE9mUGFyYWdyYXBoVG9Nb3ZlKQorICAgICAgICBmcmFnbWVudCA9IGNy ZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChkb2N1bWVudCgpLCBjcmVhdGVNYXJrdXAocmFuZ2UuZ2V0 KCksIDAsIERvTm90QW5ub3RhdGVGb3JJbnRlcmNoYW5nZSwgdHJ1ZSksICIiKTsKKwogICAgIC8v IEEgbm9uLWVtcHR5IHBhcmFncmFwaCdzIHN0eWxlIGlzIG1vdmVkIHdoZW4gd2UgY29weSBhbmQg bW92ZSBpdC4gIFdlIGRvbid0IG1vdmUgCiAgICAgLy8gYW55dGhpbmcgaWYgd2UncmUgZ2l2ZW4g YW4gZW1wdHkgcGFyYWdyYXBoLCBidXQgYW4gZW1wdHkgcGFyYWdyYXBoIGNhbiBoYXZlIHN0eWxl CiAgICAgLy8gdG9vLCA8ZGl2PjxiPjxicj48L2I+PC9kaXY+IGZvciBleGFtcGxlLiAgU2F2ZSBp dCBzbyB0aGF0IHdlIGNhbiBwcmVzZXJ2ZSBpdCBsYXRlci4K 53923 2010-04-20 23:45:39 -0700 2010-04-21 01:10:41 -0700 added more comments and removed the changes in xcodeproj fix37912b text/plain 2094 rniwa SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzk1NCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjAgIFJ5b3N1a2UgTml3YSAgPHJuaXdhQHdlYmtpdC5v cmc+CisKKyAgICAgICAgUmV2aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgW1F0 XSBCdWlsZCBmaXg6IHdhcm5pbmcgb24gTDkzMyBvZiBDb21wb3NpdGVFZGl0Q29tbWFuZC5jcHAK KyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hvd19idWcuY2dpP2lkPTM3OTEyCisK KyAgICAgICAgUmVwbGFjZWQgdGhlIHRlcm5hcnkgb3BlcmF0b3IgYnkgYW4gaWYgc3RhdGVtZW50 IGJlY2F1c2UgR0NDIHdhcyBjb25mdXNlZCBieSB0aGUgdXNlIG9mCisgICAgICAgIHRlcm5hcnkg b3BlcmF0b3IgYW5kIHByb2R1Y2luZyB3YXJuaW5ncyBvbiBRdCBidWlsZHMuCisKKyAgICAgICAg KiBXZWJDb3JlLnhjb2RlcHJvai9wcm9qZWN0LnBieHByb2o6CisgICAgICAgICogZWRpdGluZy9D b21wb3NpdGVFZGl0Q29tbWFuZC5jcHA6CisgICAgICAgIChXZWJDb3JlOjpDb21wb3NpdGVFZGl0 Q29tbWFuZDo6bW92ZVBhcmFncmFwaHMpOgorCiAyMDEwLTA0LTIwICBSeW9zdWtlIE5pd2EgIDxy bml3YUB3ZWJraXQub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IEp1c3RpbiBHYXJjaWEuCklu ZGV4OiBXZWJDb3JlL2VkaXRpbmcvQ29tcG9zaXRlRWRpdENvbW1hbmQuY3BwCj09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0K LS0tIFdlYkNvcmUvZWRpdGluZy9Db21wb3NpdGVFZGl0Q29tbWFuZC5jcHAJKHJldmlzaW9uIDU3 OTU0KQorKysgV2ViQ29yZS9lZGl0aW5nL0NvbXBvc2l0ZUVkaXRDb21tYW5kLmNwcAkod29ya2lu ZyBjb3B5KQpAQCAtOTMwLDggKzkzMCwxMSBAQCB2b2lkIENvbXBvc2l0ZUVkaXRDb21tYW5kOjpt b3ZlUGFyYWdyYXBoCiAKICAgICAvLyBGSVhNRTogVGhpcyBpcyBhbiBpbmVmZmljaWVudCB3YXkg dG8gcHJlc2VydmUgc3R5bGUgb24gbm9kZXMgaW4gdGhlIHBhcmFncmFwaCB0byBtb3ZlLiBJdAog ICAgIC8vIHNob3VsZG4ndCBtYXR0ZXIgdGhvdWdoLCBzaW5jZSBtb3ZlZCBwYXJhZ3JhcGhzIHdp bGwgdXN1YWxseSBiZSBxdWl0ZSBzbWFsbC4KLSAgICBSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4g ZnJhZ21lbnQgPSBzdGFydE9mUGFyYWdyYXBoVG9Nb3ZlICE9IGVuZE9mUGFyYWdyYXBoVG9Nb3Zl ID8gY3JlYXRlRnJhZ21lbnRGcm9tTWFya3VwKGRvY3VtZW50KCksIGNyZWF0ZU1hcmt1cChyYW5n ZS5nZXQoKSwgMCwgRG9Ob3RBbm5vdGF0ZUZvckludGVyY2hhbmdlLCB0cnVlKSwgIiIpIDogMDsK LSAgICAKKyAgICBSZWZQdHI8RG9jdW1lbnRGcmFnbWVudD4gZnJhZ21lbnQ7CisgICAgLy8gVGhp cyB1c2VkIHRvIHVzZSBhIHRlcm5hcnkgZm9yIGluaXRpYWxpemF0aW9uLCBidXQgdGhhdCBjb25m dXNlZCBzb21lIHZlcnNpb25zIG9mIEdDQywgc2VlIGJ1ZyAzNzkxMgorICAgIGlmIChzdGFydE9m UGFyYWdyYXBoVG9Nb3ZlICE9IGVuZE9mUGFyYWdyYXBoVG9Nb3ZlKQorICAgICAgICBmcmFnbWVu dCA9IGNyZWF0ZUZyYWdtZW50RnJvbU1hcmt1cChkb2N1bWVudCgpLCBjcmVhdGVNYXJrdXAocmFu Z2UuZ2V0KCksIDAsIERvTm90QW5ub3RhdGVGb3JJbnRlcmNoYW5nZSwgdHJ1ZSksICIiKTsKKwog ICAgIC8vIEEgbm9uLWVtcHR5IHBhcmFncmFwaCdzIHN0eWxlIGlzIG1vdmVkIHdoZW4gd2UgY29w eSBhbmQgbW92ZSBpdC4gIFdlIGRvbid0IG1vdmUgCiAgICAgLy8gYW55dGhpbmcgaWYgd2UncmUg Z2l2ZW4gYW4gZW1wdHkgcGFyYWdyYXBoLCBidXQgYW4gZW1wdHkgcGFyYWdyYXBoIGNhbiBoYXZl IHN0eWxlCiAgICAgLy8gdG9vLCA8ZGl2PjxiPjxicj48L2I+PC9kaXY+IGZvciBleGFtcGxlLiAg U2F2ZSBpdCBzbyB0aGF0IHdlIGNhbiBwcmVzZXJ2ZSBpdCBsYXRlci4K 61356 2010-07-13 04:53:16 -0700 2010-07-13 04:59:28 -0700 another repro (with automation) spellbr.html text/html 577 morrita PGh0bWw+CjxoZWFkPgo8c2NyaXB0PgpmdW5jdGlvbiB0ZXN0KCkKewogICAgdmFyIHRhcmdldCA9 IGRvY3VtZW50LmdldEVsZW1lbnRCeUlkKCJ0YXJnZXQiKTsKICAgIHRhcmdldC5mb2N1cygpOwog ICAgdmFyIHNlbCA9IGRvY3VtZW50LmdldFNlbGVjdGlvbigpOwogICAgc2VsLm1vZGlmeSgibW92 ZSIsICJmb3J3YXJkIiwgImxpbmUiKTsKICAgIGRvY3VtZW50LmV4ZWNDb21tYW5kKCJpbnNlcnRU ZXh0IiwgZmFsc2UsICIuIik7CiAgICBzZWwubW9kaWZ5KCJtb3ZlIiwgImxlZnQiLCAid29yZCIp OwogICAgc2VsLm1vZGlmeSgibW92ZSIsICJsZWZ0IiwgIndvcmQiKTsKICAgIGRvY3VtZW50LmV4 ZWNDb21tYW5kKCJEZWxldGUiLCBmYWxzZSk7Cn0KPC9zY3JpcHQ+CjwvaGVhZD4KPGJvZHkgb25s b2FkPSJ0ZXN0KCk7Ij4KPGRpdiBpZD0idGFyZ2V0IiBjb250ZW50RWRpdGFibGU9InRydWUiPgo8 ZGl2PkhpLDwvZGl2Pgo8ZGl2PmhlbGxvIFdybGQ8L2Rpdj4KPC9kaXY+CjxwPiJXcmxkIiBhYm92 ZSBzaG91bGQgaGF2ZSBhbiB1bmRlcmxpbmUgZm9yIG1pc3NwZWxsaW5nLjwvcD4KPC9ib2R5Pgo8 L2h0bWw+Cg==