37889 2010-04-20 14:29:34 -0700 URL patterns for file URLs fail to match 2010-04-20 23:03:45 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P1 Critical --- 1 timothy timothy aroben bweinstein eric hyatt oldest_to_newest 214949 0 timothy 2010-04-20 14:29:34 -0700 A pattern like "file:///*" always fails to match a file URL. 214961 1 53882 timothy 2010-04-20 14:46:07 -0700 Created attachment 53882 Proposed change 214962 2 53882 hyatt 2010-04-20 14:46:57 -0700 Comment on attachment 53882 Proposed change r=me 214964 3 timothy 2010-04-20 14:51:23 -0700 Landed in r57923. 215146 4 eric 2010-04-20 22:57:11 -0700 I think this might have introduced new inspector failures on windows? http://build.webkit.org/results/Windows%20Release%20(Tests)/r57923%20(11512)/results.html 215149 5 timothy 2010-04-20 23:00:50 -0700 No. 215152 6 eric 2010-04-20 23:03:45 -0700 The failures are https://bugs.webkit.org/show_bug.cgi?id=36946. However, they're now every time starting between r57921 and r57923. 53882 2010-04-20 14:46:07 -0700 2010-04-20 14:46:57 -0700 Proposed change 0001-Fix-match-of-file-patterns-by-not-trying-to-compare-.patch text/plain 3323 timothy RnJvbSA0ZDRiMTMzYmYzMGUwOTkxNmQ5YjZlMGU0OWQ3ODA3MTA2N2RlZDU0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBUaW1vdGh5IEhhdGNoZXIgPHRpbW90aHlAYXBwbGUuY29tPgpE YXRlOiBUdWUsIDIwIEFwciAyMDEwIDE0OjQwOjIyIC0wNzAwClN1YmplY3Q6IFtQQVRDSF0gRml4 IG1hdGNoIG9mICJmaWxlOi8vLyoiIHBhdHRlcm5zIGJ5IG5vdCB0cnlpbmcgdG8gY29tcGFyZSB0 aGUgaG9zdC4gVGhlIGhvc3QgaXMKIGlycmVsZXZhbnQgZm9yIGZpbGUgVVJMcy4KCkFsc28gZml4 IGNvbXBhcmlzb25zIHRvIGJlIGNhc2UgaW5zZW5zaXRpdmUuCgpodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4ODkKClJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgoK KiBwYWdlL1VzZXJDb250ZW50VVJMUGF0dGVybi5jcHA6CihXZWJDb3JlOjpVc2VyQ29udGVudFVS TFBhdHRlcm46OnBhcnNlKTogVXNlIGVxdWFsSWdub3JpbmdDYXNlIHdoZW4gY29tcGFyaW5nIGZv ciAiZmlsZSIgc2NoZW1lcy4KKFdlYkNvcmU6OlVzZXJDb250ZW50VVJMUGF0dGVybjo6bWF0Y2hl cyk6IFVzZSBlcXVhbElnbm9yaW5nQ2FzZSB3aGVuIGNvbXBhcmluZyBzY2hlbWVzLiBPbmx5IGNh bGwKbWF0Y2hlc0hvc3QgaWYgdGhlIHNjaGVtZSBpc24ndCAiZmlsZSIuCihXZWJDb3JlOjpVc2Vy Q29udGVudFVSTFBhdHRlcm46Om1hdGNoZXNIb3N0KTogQ2FsbCBlcXVhbElnbm9yaW5nQ2FzZSB3 aGVuIGNvbXBhcmluZyBob3N0cy4gVGhlIGVuZHNXaXRoCndhcyBhbHJlYWR5IGRvaW5nIGEgY2Fz ZS1pbnNlbnNpdGl2ZSBjb21wYXJlLCBzbyBleGlzdGluZyB0ZXN0cyB3b3JrZWQgdGhvdWdoIHRo aXMgcGF0aC4KLS0tCiBXZWJDb3JlL0NoYW5nZUxvZyAgICAgICAgICAgICAgICAgICAgICB8ICAg MTggKysrKysrKysrKysrKysrKysrCiBXZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRVUkxQYXR0ZXJu LmNwcCB8ICAgIDggKysrKy0tLS0KIDIgZmlsZXMgY2hhbmdlZCwgMjIgaW5zZXJ0aW9ucygrKSwg NCBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUv Q2hhbmdlTG9nCmluZGV4IDQ0NDZkMWMuLjFhOTczNTAgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hh bmdlTG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMjEgQEAKKzIwMTAtMDQt MjAgIFRpbW90aHkgSGF0Y2hlciAgPHRpbW90aHlAYXBwbGUuY29tPgorCisgICAgICAgIEZpeCBt YXRjaCBvZiAiZmlsZTovLy8qIiBwYXR0ZXJucyBieSBub3QgdHJ5aW5nIHRvIGNvbXBhcmUgdGhl IGhvc3QuIFRoZSBob3N0IGlzCisgICAgICAgIGlycmVsZXZhbnQgZm9yIGZpbGUgVVJMcy4KKwor ICAgICAgICBBbHNvIGZpeCBjb21wYXJpc29ucyB0byBiZSBjYXNlIGluc2Vuc2l0aXZlLgorCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg4OQorCisg ICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgICogcGFnZS9Vc2Vy Q29udGVudFVSTFBhdHRlcm4uY3BwOgorICAgICAgICAoV2ViQ29yZTo6VXNlckNvbnRlbnRVUkxQ YXR0ZXJuOjpwYXJzZSk6IFVzZSBlcXVhbElnbm9yaW5nQ2FzZSB3aGVuIGNvbXBhcmluZyBmb3Ig ImZpbGUiIHNjaGVtZXMuCisgICAgICAgIChXZWJDb3JlOjpVc2VyQ29udGVudFVSTFBhdHRlcm46 Om1hdGNoZXMpOiBVc2UgZXF1YWxJZ25vcmluZ0Nhc2Ugd2hlbiBjb21wYXJpbmcgc2NoZW1lcy4g T25seSBjYWxsCisgICAgICAgIG1hdGNoZXNIb3N0IGlmIHRoZSBzY2hlbWUgaXNuJ3QgImZpbGUi LgorICAgICAgICAoV2ViQ29yZTo6VXNlckNvbnRlbnRVUkxQYXR0ZXJuOjptYXRjaGVzSG9zdCk6 IENhbGwgZXF1YWxJZ25vcmluZ0Nhc2Ugd2hlbiBjb21wYXJpbmcgaG9zdHMuIFRoZSBlbmRzV2l0 aAorICAgICAgICB3YXMgYWxyZWFkeSBkb2luZyBhIGNhc2UtaW5zZW5zaXRpdmUgY29tcGFyZSwg c28gZXhpc3RpbmcgdGVzdHMgd29ya2VkIHRob3VnaCB0aGlzIHBhdGguCisKIDIwMTAtMDQtMjAg IEV2YW4gU3RhZGUgIDxlc3RhZGVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5 IERhdmlkIExldmluLgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wYWdlL1VzZXJDb250ZW50VVJMUGF0 dGVybi5jcHAgYi9XZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRVUkxQYXR0ZXJuLmNwcAppbmRleCA1 ZjBhMzExLi44NzQyNjRiIDEwMDY0NAotLS0gYS9XZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRVUkxQ YXR0ZXJuLmNwcAorKysgYi9XZWJDb3JlL3BhZ2UvVXNlckNvbnRlbnRVUkxQYXR0ZXJuLmNwcApA QCAtNzUsNyArNzUsNyBAQCBib29sIFVzZXJDb250ZW50VVJMUGF0dGVybjo6cGFyc2UoY29uc3Qg U3RyaW5nJiBwYXR0ZXJuKQogCiAgICAgaW50IHBhdGhTdGFydFBvcyA9IDA7CiAKLSAgICBpZiAo bV9zY2hlbWUgPT0gImZpbGUiKQorICAgIGlmIChlcXVhbElnbm9yaW5nQ2FzZShtX3NjaGVtZSwg ImZpbGUiKSkKICAgICAgICAgcGF0aFN0YXJ0UG9zID0gaG9zdFN0YXJ0UG9zOwogICAgIGVsc2Ug ewogICAgICAgICBpbnQgaG9zdEVuZFBvcyA9IHBhdHRlcm4uZmluZCgiLyIsIGhvc3RTdGFydFBv cyk7CkBAIC0xMTQsMTAgKzExNCwxMCBAQCBib29sIFVzZXJDb250ZW50VVJMUGF0dGVybjo6bWF0 Y2hlcyhjb25zdCBLVVJMJiB0ZXN0KSBjb25zdAogICAgIGlmIChtX2ludmFsaWQpCiAgICAgICAg IHJldHVybiBmYWxzZTsKIAotICAgIGlmICh0ZXN0LnByb3RvY29sKCkgIT0gbV9zY2hlbWUpCisg ICAgaWYgKCFlcXVhbElnbm9yaW5nQ2FzZSh0ZXN0LnByb3RvY29sKCksIG1fc2NoZW1lKSkKICAg ICAgICAgcmV0dXJuIGZhbHNlOwogCi0gICAgaWYgKCFtYXRjaGVzSG9zdCh0ZXN0KSkKKyAgICBp ZiAoIWVxdWFsSWdub3JpbmdDYXNlKG1fc2NoZW1lLCAiZmlsZSIpICYmICFtYXRjaGVzSG9zdCh0 ZXN0KSkKICAgICAgICAgcmV0dXJuIGZhbHNlOwogCiAgICAgcmV0dXJuIG1hdGNoZXNQYXRoKHRl c3QpOwpAQCAtMTI1LDcgKzEyNSw3IEBAIGJvb2wgVXNlckNvbnRlbnRVUkxQYXR0ZXJuOjptYXRj aGVzKGNvbnN0IEtVUkwmIHRlc3QpIGNvbnN0CiAKIGJvb2wgVXNlckNvbnRlbnRVUkxQYXR0ZXJu OjptYXRjaGVzSG9zdChjb25zdCBLVVJMJiB0ZXN0KSBjb25zdAogewotICAgIGlmICh0ZXN0Lmhv c3QoKSA9PSBtX2hvc3QpCisgICAgaWYgKGVxdWFsSWdub3JpbmdDYXNlKHRlc3QuaG9zdCgpLCBt X2hvc3QpKQogICAgICAgICByZXR1cm4gdHJ1ZTsKIAogICAgIGlmICghbV9tYXRjaFN1YmRvbWFp bnMpCi0tIAoxLjcuMC4yCgo=