37888 2010-04-20 14:21:58 -0700 IDLParser.pm exhausts system resources with open2 2010-05-02 05:47:21 -0700 1 1 1 Unclassified WebKit New Bugs 528+ (Nightly build) PC Windows XP RESOLVED FIXED P2 Minor --- 0 lists.bugzilla webkit-unassigned commit-queue staikos oldest_to_newest 214944 0 lists.bugzilla 2010-04-20 14:21:58 -0700 When building WebCore, IDL files are parsed and binding files are generated using the code in WebCore/bindings/scripts. Specifically, IDLParser.pm in this folder uses the open2 call to invoke a preprocessor on the IDL file. If multiple IDL files are parsed in a tight loop, the code dies after 64 IDL files because it exhausts the process IDs available. The error message that it dies with is "Can't spawn-NOWAIT: resource temporarily unavailable". 215099 1 staikos 2010-04-20 18:34:53 -0700 Please attach the patch :) 215303 2 53953 lists.bugzilla 2010-04-21 07:27:33 -0700 Created attachment 53953 Patch that adds a call to waitpid to the parser 215319 3 53953 darin 2010-04-21 07:52:53 -0700 Comment on attachment 53953 Patch that adds a call to waitpid to the parser Change looks good. Needs a change log so review-. 215548 4 54000 lists.bugzilla 2010-04-21 16:10:53 -0700 Created attachment 54000 Proposed patch, now with change description Not sure if "git format-patch" is an acceptable patch format here but I don't have webkit set up in svn and it looks like at least some of the other patches in the commit queue are in this format. 215593 5 54000 darin 2010-04-21 17:59:45 -0700 Comment on attachment 54000 Proposed patch, now with change description The change log entry needs to be in the WebCore/ChangeLog file. 216025 6 54000 abarth 2010-04-22 12:44:03 -0700 Comment on attachment 54000 Proposed patch, now with change description No changelog. 219547 7 54814 lists.bugzilla 2010-04-30 11:42:37 -0700 Created attachment 54814 Now with changelog patch as well Updated with Changelog patch 219686 8 54814 lists.bugzilla 2010-04-30 19:59:19 -0700 Comment on attachment 54814 Now with changelog patch as well Whoops, noticed my Changelog description doesn't reference this bug. Will upload another patch with the link. 219687 9 54845 lists.bugzilla 2010-04-30 20:06:14 -0700 Created attachment 54845 Patch updated with link to this bug 219689 10 54846 lists.bugzilla 2010-04-30 20:27:27 -0700 Created attachment 54846 Attempt #2, without the missing linebreak this time 219831 11 54846 commit-queue 2010-05-02 05:47:16 -0700 Comment on attachment 54846 Attempt #2, without the missing linebreak this time Clearing flags on attachment: 54846 Committed r58653: <http://trac.webkit.org/changeset/58653> 219832 12 commit-queue 2010-05-02 05:47:21 -0700 All reviewed patches have been landed. Closing bug. 53953 2010-04-21 07:27:33 -0700 2010-04-21 16:10:53 -0700 Patch that adds a call to waitpid to the parser waitpid.patch text/plain 669 lists.bugzilla ZGlmZiAtLWdpdCBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0gYi9XZWJD b3JlL2JpbmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCmluZGV4IDc0YmU4YTQuLjdiNTE1NjEg MTAwNjQ0Ci0tLSBhL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG0KKysrIGIv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbQpAQCAtNzMsMTAgKzczLDExIEBA IHN1YiBQYXJzZQogCiAgICAgcHJpbnQgIiB8ICoqKiBTdGFydGluZyB0byBwYXJzZSAkZmlsZU5h bWUuLi5cbiB8XG4iIHVubGVzcyAkYmVRdWlldDsKIAotICAgIG9wZW4yKFwqUFBfT1VULCBcKlBQ X0lOLCBzcGxpdCgnICcsICRwcmVwcm9jZXNzb3IpLCAobWFwIHsgIi1EJF8iIH0gc3BsaXQoJyAn LCAkZGVmaW5lcykpLCAkZmlsZU5hbWUpOworICAgICRwaWQgPSBvcGVuMihcKlBQX09VVCwgXCpQ UF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJvY2Vzc29yKSwgKG1hcCB7ICItRCRfIiB9IHNwbGl0KCcg JywgJGRlZmluZXMpKSwgJGZpbGVOYW1lKTsKICAgICBjbG9zZSBQUF9JTjsKICAgICBteSBAZG9j dW1lbnRDb250ZW50ID0gPFBQX09VVD47CiAgICAgY2xvc2UgUFBfT1VUOworICAgIHdhaXRwaWQo JHBpZCwgMCk7CiAKICAgICBteSAkZGF0YUF2YWlsYWJsZSA9IDA7CiAK 54000 2010-04-21 16:10:53 -0700 2010-04-30 20:06:14 -0700 Proposed patch, now with change description 0001-2010-04-19-Kartikaya-Gupta-kagupta-rim.com.patch text/plain 1411 lists.bugzilla RnJvbSA2ZTZiOTQ2NTQ3ZmZkOGY3ZTRmNjgxNWJjZjBlZjI4ZWZkZmQ5YTk0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBLYXJ0aWtheWEgR3VwdGEgPGthZ3VwdGFAcmltLmNvbT4KRGF0 ZTogTW9uLCAxOSBBcHIgMjAxMCAxNjoyMDo0MCAtMDQwMApTdWJqZWN0OiBbUEFUQ0hdIDIwMTAt MDQtMTkgIEthcnRpa2F5YSBHdXB0YSAgPGthZ3VwdGFAcmltLmNvbT4KCiAgICAgICAgUmV2aWV3 ZWQgYnkgR2VvcmdlIFN0YWlrb3MuCgogICAgICAgIFdoZW4gcnVubmluZyB0aGUgSURMIGZpbGUg dGhyb3VnaCB0aGUgcHJlcHJvY2Vzc29yLCB3YWl0IGZvciB0aGUgcHJlcHJvY2Vzc29yIHN1YmNv bW1hbmQgdG8gZnVsbHkgdGVybWluYXRlIGJlZm9yZSBjb250aW51aW5nLiBXaXRob3V0IHRoaXMs IGlmIG11bHRpcGxlIElETCBmaWxlcyBhcmUgcGFyc2VkIGluIGEgdGlnaHQgbG9vcCwgdGhlIGNv ZGUgZGllcyBhZnRlciA2NCBJREwgZmlsZXMgYmVjYXVzZSBpdCBleGhhdXN0cyB0aGUgYXZhaWxh YmxlIHN5c3RlbSByZXNvdXJjZXMuCgogICAgICAgIE5vIG5ldyB0ZXN0cy4gTm9uZSBuZWVkZWQu CgogICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9JRExQYXJzZXIucG06Ci0tLQogV2ViQ29yZS9i aW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSB8ICAgIDMgKystCiAxIGZpbGVzIGNoYW5nZWQs IDIgaW5zZXJ0aW9ucygrKSwgMSBkZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lE TFBhcnNlci5wbQppbmRleCA3NGJlOGE0Li43YjUxNTYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2Jp bmRpbmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9JRExQYXJzZXIucG0KQEAgLTczLDEwICs3MywxMSBAQCBzdWIgUGFyc2UKIAogICAgIHByaW50 ICIgfCAqKiogU3RhcnRpbmcgdG8gcGFyc2UgJGZpbGVOYW1lLi4uXG4gfFxuIiB1bmxlc3MgJGJl UXVpZXQ7CiAKLSAgICBvcGVuMihcKlBQX09VVCwgXCpQUF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJv Y2Vzc29yKSwgKG1hcCB7ICItRCRfIiB9IHNwbGl0KCcgJywgJGRlZmluZXMpKSwgJGZpbGVOYW1l KTsKKyAgICAkcGlkID0gb3BlbjIoXCpQUF9PVVQsIFwqUFBfSU4sIHNwbGl0KCcgJywgJHByZXBy b2Nlc3NvciksIChtYXAgeyAiLUQkXyIgfSBzcGxpdCgnICcsICRkZWZpbmVzKSksICRmaWxlTmFt ZSk7CiAgICAgY2xvc2UgUFBfSU47CiAgICAgbXkgQGRvY3VtZW50Q29udGVudCA9IDxQUF9PVVQ+ OwogICAgIGNsb3NlIFBQX09VVDsKKyAgICB3YWl0cGlkKCRwaWQsIDApOwogCiAgICAgbXkgJGRh dGFBdmFpbGFibGUgPSAwOwogCi0tIAoxLjYuNS4xLjEzNjcuZ2NkNDgKCg== 54814 2010-04-30 11:42:37 -0700 2010-04-30 20:06:14 -0700 Now with changelog patch as well IDLparser.patch text/plain 1340 lists.bugzilla ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGQ0OTVmLi45YTA3ZDQ5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAK KzIwMTAtMDQtMTkgIEthcnRpa2F5YSBHdXB0YSAgPGthZ3VwdGFAcmltLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICBXaGVuIHJ1bm5pbmcgdGhl IElETCBmaWxlIHRocm91Z2ggdGhlIHByZXByb2Nlc3Nvciwgd2FpdCBmb3IgdGhlIHByZXByb2Nl c3NvciBzdWJjb21tYW5kIHRvIGZ1bGx5IHRlcm1pbmF0ZSBiZWZvcmUgY29udGludWluZy4gV2l0 aG91dCB0aGlzLCBpZiBtdWx0aXBsZSBJREwgZmlsZXMgYXJlIHBhcnNlZCBpbiBhIHRpZ2h0IGxv b3AsIHRoZSBjb2RlIGRpZXMgYWZ0ZXIgNjQgSURMIGZpbGVzIGJlY2F1c2UgaXQgZXhoYXVzdHMg dGhlIGF2YWlsYWJsZSBzeXN0ZW0gcmVzb3VyY2VzLgorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm9uZSBuZWVkZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbToK KwogMjAxMC0wMS0xMyAgSm9jZWx5biBUdXJjb3R0ZSAgPGpvY2VseW4udHVyY290dGVAbm9raWEu Y29tPgogCiAgICAgICAgIFJldmlld2VkIGJ5IFNpbW9uIEhhdXNtYW5uLgpkaWZmIC0tZ2l0IGEv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSBiL1dlYkNvcmUvYmluZGluZ3Mv c2NyaXB0cy9JRExQYXJzZXIucG0KaW5kZXggNzRiZThhNC4uN2I1MTU2MSAxMDA2NDQKLS0tIGEv V2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbQorKysgYi9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCkBAIC03MywxMCArNzMsMTEgQEAgc3ViIFBhcnNlCiAK ICAgICBwcmludCAiIHwgKioqIFN0YXJ0aW5nIHRvIHBhcnNlICRmaWxlTmFtZS4uLlxuIHxcbiIg dW5sZXNzICRiZVF1aWV0OwogCi0gICAgb3BlbjIoXCpQUF9PVVQsIFwqUFBfSU4sIHNwbGl0KCcg JywgJHByZXByb2Nlc3NvciksIChtYXAgeyAiLUQkXyIgfSBzcGxpdCgnICcsICRkZWZpbmVzKSks ICRmaWxlTmFtZSk7CisgICAgJHBpZCA9IG9wZW4yKFwqUFBfT1VULCBcKlBQX0lOLCBzcGxpdCgn ICcsICRwcmVwcm9jZXNzb3IpLCAobWFwIHsgIi1EJF8iIH0gc3BsaXQoJyAnLCAkZGVmaW5lcykp LCAkZmlsZU5hbWUpOwogICAgIGNsb3NlIFBQX0lOOwogICAgIG15IEBkb2N1bWVudENvbnRlbnQg PSA8UFBfT1VUPjsKICAgICBjbG9zZSBQUF9PVVQ7CisgICAgd2FpdHBpZCgkcGlkLCAwKTsKIAog ICAgIG15ICRkYXRhQXZhaWxhYmxlID0gMDsKIAo= 54845 2010-04-30 20:06:14 -0700 2010-04-30 20:27:27 -0700 Patch updated with link to this bug IDLParser.patch text/plain 1380 lists.bugzilla ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGQ0OTVmLi45YTA3ZDQ5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDQtMTkgIEthcnRpa2F5YSBHdXB0YSAgPGthZ3VwdGFAcmltLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICBXaGVuIHJ1bm5pbmcgdGhl IElETCBmaWxlIHRocm91Z2ggdGhlIHByZXByb2Nlc3Nvciwgd2FpdCBmb3IgdGhlIHByZXByb2Nl c3NvciBzdWJjb21tYW5kIHRvIGZ1bGx5IHRlcm1pbmF0ZSBiZWZvcmUgY29udGludWluZy4gV2l0 aG91dCB0aGlzLCBpZiBtdWx0aXBsZSBJREwgZmlsZXMgYXJlIHBhcnNlZCBpbiBhIHRpZ2h0IGxv b3AsIHRoZSBjb2RlIGRpZXMgYWZ0ZXIgNjQgSURMIGZpbGVzIGJlY2F1c2UgaXQgZXhoYXVzdHMg dGhlIGF2YWlsYWJsZSBzeXN0ZW0gcmVzb3VyY2VzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg4OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm9uZSBuZWVkZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbToK KwogMjAxMC0wNC0yOCAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LmRpZmYgLS1naXQgYS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtIGIvV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRzL0lETFBh cnNlci5wbQppbmRleCA3NGJlOGE0Li43YjUxNTYxIDEwMDY0NAotLS0gYS9XZWJDb3JlL2JpbmRp bmdzL3NjcmlwdHMvSURMUGFyc2VyLnBtCisrKyBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9J RExQYXJzZXIucG0KQEAgLTczLDEwICs3MywxMSBAQCBzdWIgUGFyc2UKCiAgICAgcHJpbnQgIiB8 ICoqKiBTdGFydGluZyB0byBwYXJzZSAkZmlsZU5hbWUuLi5cbiB8XG4iIHVubGVzcyAkYmVRdWll dDsKCi0gICAgb3BlbjIoXCpQUF9PVVQsIFwqUFBfSU4sIHNwbGl0KCcgJywgJHByZXByb2Nlc3Nv ciksIChtYXAgeyAiLUQkXyIgfSBzcGxpdCgnICcsICRkZWZpbmVzKSksICRmaWxlTmFtZSk7Cisg ICAgJHBpZCA9IG9wZW4yKFwqUFBfT1VULCBcKlBQX0lOLCBzcGxpdCgnICcsICRwcmVwcm9jZXNz b3IpLCAobWFwIHsgIi1EJF8iIH0gc3BsaXQoJyAnLCAkZGVmaW5lcykpLCAkZmlsZU5hbWUpOwog ICAgIGNsb3NlIFBQX0lOOwogICAgIG15IEBkb2N1bWVudENvbnRlbnQgPSA8UFBfT1VUPjsKICAg ICBjbG9zZSBQUF9PVVQ7CisgICAgd2FpdHBpZCgkcGlkLCAwKTsKCiAgICAgbXkgJGRhdGFBdmFp bGFibGUgPSAwOwoK 54846 2010-04-30 20:27:27 -0700 2010-05-02 05:47:16 -0700 Attempt #2, without the missing linebreak this time IDLParser.patch text/plain 1381 lists.bugzilla ZGlmZiAtLWdpdCBhL0NoYW5nZUxvZyBiL0NoYW5nZUxvZwppbmRleCA1ZGQ0OTVmLi45YTA3ZDQ5 IDEwMDY0NAotLS0gYS9DaGFuZ2VMb2cKKysrIGIvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAK KzIwMTAtMDQtMTkgIEthcnRpa2F5YSBHdXB0YSAgPGthZ3VwdGFAcmltLmNvbT4KKworICAgICAg ICBSZXZpZXdlZCBieSBHZW9yZ2UgU3RhaWtvcy4KKworICAgICAgICBXaGVuIHJ1bm5pbmcgdGhl IElETCBmaWxlIHRocm91Z2ggdGhlIHByZXByb2Nlc3Nvciwgd2FpdCBmb3IgdGhlIHByZXByb2Nl c3NvciBzdWJjb21tYW5kIHRvIGZ1bGx5IHRlcm1pbmF0ZSBiZWZvcmUgY29udGludWluZy4gV2l0 aG91dCB0aGlzLCBpZiBtdWx0aXBsZSBJREwgZmlsZXMgYXJlIHBhcnNlZCBpbiBhIHRpZ2h0IGxv b3AsIHRoZSBjb2RlIGRpZXMgYWZ0ZXIgNjQgSURMIGZpbGVzIGJlY2F1c2UgaXQgZXhoYXVzdHMg dGhlIGF2YWlsYWJsZSBzeXN0ZW0gcmVzb3VyY2VzLgorCisgICAgICAgIGh0dHBzOi8vYnVncy53 ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg4OAorCisgICAgICAgIE5vIG5ldyB0ZXN0cy4g Tm9uZSBuZWVkZWQuCisKKyAgICAgICAgKiBiaW5kaW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbToK KwogMjAxMC0wNC0yOCAgSm9zZXBoIFBlY29yYXJvICA8am9lcGVja0B3ZWJraXQub3JnPgogCiAg ICAgICAgIFJldmlld2VkIGJ5IE9saXZlciBIdW50LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbSBiL1dlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9JRExQ YXJzZXIucG0KaW5kZXggNzRiZThhNC4uN2I1MTU2MSAxMDA2NDQKLS0tIGEvV2ViQ29yZS9iaW5k aW5ncy9zY3JpcHRzL0lETFBhcnNlci5wbQorKysgYi9XZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv SURMUGFyc2VyLnBtCkBAIC03MywxMCArNzMsMTEgQEAgc3ViIFBhcnNlCgogICAgIHByaW50ICIg fCAqKiogU3RhcnRpbmcgdG8gcGFyc2UgJGZpbGVOYW1lLi4uXG4gfFxuIiB1bmxlc3MgJGJlUXVp ZXQ7CgotICAgIG9wZW4yKFwqUFBfT1VULCBcKlBQX0lOLCBzcGxpdCgnICcsICRwcmVwcm9jZXNz b3IpLCAobWFwIHsgIi1EJF8iIH0gc3BsaXQoJyAnLCAkZGVmaW5lcykpLCAkZmlsZU5hbWUpOwor ICAgICRwaWQgPSBvcGVuMihcKlBQX09VVCwgXCpQUF9JTiwgc3BsaXQoJyAnLCAkcHJlcHJvY2Vz c29yKSwgKG1hcCB7ICItRCRfIiB9IHNwbGl0KCcgJywgJGRlZmluZXMpKSwgJGZpbGVOYW1lKTsK ICAgICBjbG9zZSBQUF9JTjsKICAgICBteSBAZG9jdW1lbnRDb250ZW50ID0gPFBQX09VVD47CiAg ICAgY2xvc2UgUFBfT1VUOworICAgIHdhaXRwaWQoJHBpZCwgMCk7CgogICAgIG15ICRkYXRhQXZh aWxhYmxlID0gMDsKCg==