37887 2010-04-20 13:57:23 -0700 worker-close.html is flaky on slow machines. 2010-04-20 16:08:31 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 37894 1 dimich dimich abarth atwilson eric levin webkit.review.bot oldest_to_newest 214930 0 dimich 2010-04-20 13:57:23 -0700 The test sends a message to the worker to close and also to reply with a message. Immediately, it sets up a timer for 500ms which will terminate the test. On slow machines, the timer may terminate test before the reply comes from the worker, so the actual dump is one message short. Fix is to start timer after the message comes. Patch coming. 214932 1 53877 dimich 2010-04-20 13:59:39 -0700 Created attachment 53877 Patch. 214935 2 53877 abarth 2010-04-20 14:05:24 -0700 Comment on attachment 53877 Patch. Ok. I'm sad that we have to setTimeout at all... 214947 3 dimich 2010-04-20 14:23:36 -0700 Landed: http://trac.webkit.org/changeset/57916 214966 4 webkit.review.bot 2010-04-20 14:53:18 -0700 http://trac.webkit.org/changeset/57919 might have broken SnowLeopard Intel Release (Tests) 215044 5 webkit.review.bot 2010-04-20 16:08:31 -0700 http://trac.webkit.org/changeset/57916 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/57909 http://trac.webkit.org/changeset/57910 http://trac.webkit.org/changeset/57911 http://trac.webkit.org/changeset/57913 http://trac.webkit.org/changeset/57914 http://trac.webkit.org/changeset/57915 http://trac.webkit.org/changeset/57916 http://trac.webkit.org/changeset/57917 http://trac.webkit.org/changeset/57918 53877 2010-04-20 13:59:39 -0700 2010-04-20 14:05:24 -0700 Patch. patch.txt text/plain 1402 dimich ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCAyMGJhNjBkLi43YWQzOGIzIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTIgQEAKKzIwMTAtMDQt MjAgIERtaXRyeSBUaXRvdiAgPGRpbWljaEBjaHJvbWl1bS5vcmc+CisKKyAgICAgICAgUmV2aWV3 ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgd29ya2VyLWNsb3NlLmh0bWwgaXMgZmxh a3kgb24gc2xvdyBtYWNoaW5lcy4KKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3ODg3CisKKyAgICAgICAgKiBmYXN0L3dvcmtlcnMvd29ya2VyLWNsb3Nl Lmh0bWw6IE1vdmUgdGhlIHN0YXJ0IG9mIHRoZSB0aW1lciB0byB0ZXJtaW5hdGUgdGhlIHRlc3Qg YWZ0ZXIgYW4gZXhwZWN0ZWQgbWVzc2FnZSBpcyByZWNlaXZlZC4KKwogMjAxMC0wNC0xOSAgSmFt ZXMgUm9iaW5zb24gIDxqYW1lc3JAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2aWV3ZWQg YnVpbGQgZml4IGZvciBDaHJvbWl1bQpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvZmFzdC93b3Jr ZXJzL3dvcmtlci1jbG9zZS5odG1sIGIvTGF5b3V0VGVzdHMvZmFzdC93b3JrZXJzL3dvcmtlci1j bG9zZS5odG1sCmluZGV4IGY0YjhjYWQuLjZmNmEzMmYgMTAwNjQ0Ci0tLSBhL0xheW91dFRlc3Rz L2Zhc3Qvd29ya2Vycy93b3JrZXItY2xvc2UuaHRtbAorKysgYi9MYXlvdXRUZXN0cy9mYXN0L3dv cmtlcnMvd29ya2VyLWNsb3NlLmh0bWwKQEAgLTg3LDEyICs4NywxMiBAQCBmdW5jdGlvbiB0ZXN0 VGVybWluYXRlQWZ0ZXJDbG9zZSgpCiAgICAgd29ya2VyLnBvc3RNZXNzYWdlKCJjbG9zZSIpOwog ICAgIHdvcmtlci5vbm1lc3NhZ2UgPSBmdW5jdGlvbihldnQpIHsKICAgICAgICAgbG9nKCJQQVNT OiBSZWNlaXZlZCBtZXNzYWdlIGFmdGVyIHdvcmtlciBjbG9zZWQ6ICIgKyBldnQuZGF0YSk7Cisg ICAgICAgIC8vIEdpdmUgd29ya2VyIGEgY2hhbmNlIHRvIGNsb3NlIGZpcnN0LCB0aGVuIHRlcm1p bmF0ZSBpdC4KKyAgICAgICAgdGltZW91dCA9IHNldFRpbWVvdXQoZnVuY3Rpb24oKSB7CisgICAg ICAgICAgICB3b3JrZXIudGVybWluYXRlKCk7CisgICAgICAgICAgICBkb25lKCk7CisgICAgICAg IH0sIDUwMCk7CiAgICAgfTsKLSAgICAvLyBHaXZlIHdvcmtlciBhIGNoYW5jZSB0byBjbG9zZSBm aXJzdCwgdGhlbiB0ZXJtaW5hdGUgaXQuCi0gICAgdGltZW91dCA9IHNldFRpbWVvdXQoZnVuY3Rp b24oKSB7Ci0gICAgICAgIHdvcmtlci50ZXJtaW5hdGUoKTsKLSAgICAgICAgZG9uZSgpOwotICAg IH0sIDUwMCk7CiB9CiAKIGZ1bmN0aW9uIGRvbmUoKSB7Cg==