37885 2010-04-20 13:32:51 -0700 backgroundColor is oddly indented in layer tree dump 2010-04-20 22:42:15 -0700 1 1 1 Unclassified WebKit Layout and Rendering 528+ (Nightly build) All OS X 10.5 RESOLVED FIXED P2 Normal --- 1 simon.fraser simon.fraser abarth cmarrin eric webkit.review.bot oldest_to_newest 214918 0 simon.fraser 2010-04-20 13:32:51 -0700 In the layer tree dump obtained via layoutTestController.layerTreeAsText(), the backgroundColor property is weirdly indented: (backfaceVisibility visible) (backgroundColor none) (transform identity) 214921 1 53875 simon.fraser 2010-04-20 13:38:32 -0700 Created attachment 53875 Patch 214923 2 53875 andersca 2010-04-20 13:39:14 -0700 Comment on attachment 53875 Patch r=me 214924 3 simon.fraser 2010-04-20 13:41:26 -0700 http://trac.webkit.org/changeset/57913 215043 4 webkit.review.bot 2010-04-20 16:08:19 -0700 http://trac.webkit.org/changeset/57913 might have broken Qt Windows 32-bit Debug The following changes are on the blame list: http://trac.webkit.org/changeset/57909 http://trac.webkit.org/changeset/57910 http://trac.webkit.org/changeset/57911 http://trac.webkit.org/changeset/57913 http://trac.webkit.org/changeset/57914 http://trac.webkit.org/changeset/57915 http://trac.webkit.org/changeset/57916 http://trac.webkit.org/changeset/57917 http://trac.webkit.org/changeset/57918 215140 5 eric 2010-04-20 22:42:15 -0700 I think this broke Snow Leopard. 53875 2010-04-20 13:38:32 -0700 2010-04-20 13:39:13 -0700 Patch bug-37885-20100420133831.patch text/plain 4458 simon.fraser ZGlmZiAtLWdpdCBhL0xheW91dFRlc3RzL0NoYW5nZUxvZyBiL0xheW91dFRlc3RzL0NoYW5nZUxv ZwppbmRleCBjNzBmOTIxLi44YmQ3ODdhIDEwMDY0NAotLS0gYS9MYXlvdXRUZXN0cy9DaGFuZ2VM b2cKKysrIGIvTGF5b3V0VGVzdHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MjAgIFNpbW9uIEZyYXNlciAgPHNpbW9uLmZyYXNlckBhcHBsZS5jb20+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgYmFja2dyb3VuZENvbG9yIGlzIG9k ZGx5IGluZGVudGVkIGluIGxheWVyIHRyZWUgZHVtcAorICAgICAgICBodHRwczovL2J1Z3Mud2Vi a2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4ODUKKyAgICAgICAgCisgICAgICAgIEZpeCBpbmRl bnRhdGlvbiBpbiB0aGlzIGV4cGVjdGVkIHJlc3VsdC4KKworICAgICAgICAqIGNvbXBvc2l0aW5n L2dlb21ldHJ5L3ByZXNlcnZlLTNkLXN3aXRjaGluZy1leHBlY3RlZC50eHQ6CisKIDIwMTAtMDQt MjAgIFNlcmdleSBVbGFub3YgPHNlcmdleXVAY2hyb21pdW0ub3JnPgogCiAgICAgICAgIFVucmV2 aWV3ZWQsIGNoZWNraW5nIGluIGJhc2VsaW5lcyBkdWUgdG8gY2hhbmdlcyB0byBDaHJvbWl1bSdz IHZpZGVvIHNjYWxpbmcgYWxnb3JpdGhtLgpkaWZmIC0tZ2l0IGEvTGF5b3V0VGVzdHMvY29tcG9z aXRpbmcvZ2VvbWV0cnkvcHJlc2VydmUtM2Qtc3dpdGNoaW5nLWV4cGVjdGVkLnR4dCBiL0xheW91 dFRlc3RzL2NvbXBvc2l0aW5nL2dlb21ldHJ5L3ByZXNlcnZlLTNkLXN3aXRjaGluZy1leHBlY3Rl ZC50eHQKaW5kZXggYTQwYzE4OC4uZDg2M2QzNyAxMDA2NDQKLS0tIGEvTGF5b3V0VGVzdHMvY29t cG9zaXRpbmcvZ2VvbWV0cnkvcHJlc2VydmUtM2Qtc3dpdGNoaW5nLWV4cGVjdGVkLnR4dAorKysg Yi9MYXlvdXRUZXN0cy9jb21wb3NpdGluZy9nZW9tZXRyeS9wcmVzZXJ2ZS0zZC1zd2l0Y2hpbmct ZXhwZWN0ZWQudHh0CkBAIC0xMCw3ICsxMCw3IEBAIFRoZSBncmVlbiBib3ggYXBwZWFyIGFuZ2xl ZCBvdXQgZnJvbSB0aGUgeWVsbG93IGJveCBhbmQgZW1iZWRkZWQgaW4gaXQuCiAgIChwcmVzZXJ2 ZXMzRCAwKQogICAoZHJhd3NDb250ZW50IDApCiAgIChiYWNrZmFjZVZpc2liaWxpdHkgdmlzaWJs ZSkKLSAgICAoYmFja2dyb3VuZENvbG9yIG5vbmUpCisgIChiYWNrZ3JvdW5kQ29sb3Igbm9uZSkK ICAgKHRyYW5zZm9ybSBpZGVudGl0eSkKICAgKGNoaWxkcmVuVHJhbnNmb3JtIGlkZW50aXR5KQog ICAoY2hpbGRyZW4gMQpAQCAtMjMsNyArMjMsNyBAQCBUaGUgZ3JlZW4gYm94IGFwcGVhciBhbmds ZWQgb3V0IGZyb20gdGhlIHllbGxvdyBib3ggYW5kIGVtYmVkZGVkIGluIGl0LgogICAgICAgKHBy ZXNlcnZlczNEIDApCiAgICAgICAoZHJhd3NDb250ZW50IDApCiAgICAgICAoYmFja2ZhY2VWaXNp YmlsaXR5IHZpc2libGUpCi0gICAgICAgICAgICAoYmFja2dyb3VuZENvbG9yIG5vbmUpCisgICAg ICAoYmFja2dyb3VuZENvbG9yIG5vbmUpCiAgICAgICAodHJhbnNmb3JtIGlkZW50aXR5KQogICAg ICAgKGNoaWxkcmVuVHJhbnNmb3JtIGlkZW50aXR5KQogICAgICAgKGNoaWxkcmVuIDEKQEAgLTM2 LDcgKzM2LDcgQEAgVGhlIGdyZWVuIGJveCBhcHBlYXIgYW5nbGVkIG91dCBmcm9tIHRoZSB5ZWxs b3cgYm94IGFuZCBlbWJlZGRlZCBpbiBpdC4KICAgICAgICAgICAocHJlc2VydmVzM0QgMCkKICAg ICAgICAgICAoZHJhd3NDb250ZW50IDEpCiAgICAgICAgICAgKGJhY2tmYWNlVmlzaWJpbGl0eSB2 aXNpYmxlKQotICAgICAgICAgICAgICAgICAgICAoYmFja2dyb3VuZENvbG9yIG5vbmUpCisgICAg ICAgICAgKGJhY2tncm91bmRDb2xvciBub25lKQogICAgICAgICAgICh0cmFuc2Zvcm0gaWRlbnRp dHkpCiAgICAgICAgICAgKGNoaWxkcmVuVHJhbnNmb3JtIFsxLjAwIDAuMDAgMC4wMCAwLjAwXSBb MC4wMCAxLjAwIDAuMDAgMC4wMF0gWzAuMDAgMC4wMCAxLjAwIC0wLjAwXSBbMC4wMCAwLjAwIDAu MDAgMS4wMF0pCiAgICAgICAgICAgKGNoaWxkcmVuIDEKQEAgLTQ5LDcgKzQ5LDcgQEAgVGhlIGdy ZWVuIGJveCBhcHBlYXIgYW5nbGVkIG91dCBmcm9tIHRoZSB5ZWxsb3cgYm94IGFuZCBlbWJlZGRl ZCBpbiBpdC4KICAgICAgICAgICAgICAgKHByZXNlcnZlczNEIDEpCiAgICAgICAgICAgICAgIChk cmF3c0NvbnRlbnQgMSkKICAgICAgICAgICAgICAgKGJhY2tmYWNlVmlzaWJpbGl0eSB2aXNpYmxl KQotICAgICAgICAgICAgICAgICAgICAgICAgICAgIChiYWNrZ3JvdW5kQ29sb3Igbm9uZSkKKyAg ICAgICAgICAgICAgKGJhY2tncm91bmRDb2xvciBub25lKQogICAgICAgICAgICAgICAodHJhbnNm b3JtIFswLjc3IC0wLjU2IC0wLjMyIDAuMDBdIFswLjAwIDAuNTAgLTAuODcgMC4wMF0gWzAuNjQg MC42NiAwLjM4IDAuMDBdIFswLjAwIDAuMDAgMC4wMCAxLjAwXSkKICAgICAgICAgICAgICAgKGNo aWxkcmVuVHJhbnNmb3JtIGlkZW50aXR5KQogICAgICAgICAgICAgICAoY2hpbGRyZW4gMQpAQCAt NjIsNyArNjIsNyBAQCBUaGUgZ3JlZW4gYm94IGFwcGVhciBhbmdsZWQgb3V0IGZyb20gdGhlIHll bGxvdyBib3ggYW5kIGVtYmVkZGVkIGluIGl0LgogICAgICAgICAgICAgICAgICAgKHByZXNlcnZl czNEIDApCiAgICAgICAgICAgICAgICAgICAoZHJhd3NDb250ZW50IDEpCiAgICAgICAgICAgICAg ICAgICAoYmFja2ZhY2VWaXNpYmlsaXR5IHZpc2libGUpCi0gICAgICAgICAgICAgICAgICAgICAg ICAgICAgICAgICAgICAoYmFja2dyb3VuZENvbG9yIG5vbmUpCisgICAgICAgICAgICAgICAgICAo YmFja2dyb3VuZENvbG9yIG5vbmUpCiAgICAgICAgICAgICAgICAgICAodHJhbnNmb3JtIFswLjc3 IDAuMDAgMC42NCAwLjAwXSBbMC4wMCAxLjAwIDAuMDAgMC4wMF0gWy0wLjY0IDAuMDAgMC43NyAw LjAwXSBbMC4wMCAwLjAwIDUwLjAwIDEuMDBdKQogICAgICAgICAgICAgICAgICAgKGNoaWxkcmVu VHJhbnNmb3JtIGlkZW50aXR5KQogICAgICAgICAgICAgICAgICkKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggZWI5Njk3OS4uNjUwYzI4NiAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsNSArMSwxOCBAQAogMjAxMC0wNC0yMCAgU2ltb24gRnJhc2VyICA8c2ltb24uZnJhc2VyQGFw cGxlLmNvbT4KIAorICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAg ICBiYWNrZ3JvdW5kQ29sb3IgaXMgb2RkbHkgaW5kZW50ZWQgaW4gbGF5ZXIgdHJlZSBkdW1wCisg ICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg4NQorCisg ICAgICAgIFRoZSB3cml0ZUluZGVudCgpIHdhcyBtaXN0YWtlbmx5IG91dHNpZGUgdGhlIExheWVy VHJlZUFzVGV4dERlYnVnIGNsYXVzZSwgY2F1c2luZyBpbmRlbnRzCisgICAgICAgIHRvIGJlIHdy aXR0ZW4gdHdpY2UuCisgICAgICAgIAorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBo aWNzTGF5ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6R3JhcGhpY3NMYXllcjo6ZHVtcFByb3Bl cnRpZXMpOgorCisyMDEwLTA0LTIwICBTaW1vbiBGcmFzZXIgIDxzaW1vbi5mcmFzZXJAYXBwbGUu Y29tPgorCiAgICAgICAgIFJldmlld2VkIGJ5IERpbWl0cmkgR2xhemtvdi4KIAogICAgICAgICBD bGVhbiB1cCBSZW5kZXJQYXJ0L1JlbmRlclBhcnRPYmplY3QvUmVuZGVyRnJhbWUvUmVuZGVyRW1i ZWRkZWRPYmplY3QKZGlmZiAtLWdpdCBhL1dlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhp Y3NMYXllci5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzTGF5ZXIuY3Bw CmluZGV4IDNlZmI4Y2YuLmI3NTY3YmYgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvcGxhdGZvcm0vZ3Jh cGhpY3MvR3JhcGhpY3NMYXllci5jcHAKKysrIGIvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9H cmFwaGljc0xheWVyLmNwcApAQCAtNDM1LDggKzQzNSw4IEBAIHZvaWQgR3JhcGhpY3NMYXllcjo6 ZHVtcFByb3BlcnRpZXMoVGV4dFN0cmVhbSYgdHMsIGludCBpbmRlbnQsIExheWVyVHJlZUFzVGV4 dEJlCiAgICAgd3JpdGVJbmRlbnQodHMsIGluZGVudCArIDEpOwogICAgIHRzIDw8ICIoYmFja2Zh Y2VWaXNpYmlsaXR5ICIgPDwgKG1fYmFja2ZhY2VWaXNpYmlsaXR5ID8gInZpc2libGUiIDogImhp ZGRlbiIpIDw8ICIpXG4iOwogCi0gICAgd3JpdGVJbmRlbnQodHMsIGluZGVudCArIDEpOwogICAg IGlmIChiZWhhdmlvciAmIExheWVyVHJlZUFzVGV4dERlYnVnKSB7CisgICAgICAgIHdyaXRlSW5k ZW50KHRzLCBpbmRlbnQgKyAxKTsKICAgICAgICAgdHMgPDwgIigiOwogICAgICAgICBpZiAobV9j bGllbnQpCiAgICAgICAgICAgICB0cyA8PCAiY2xpZW50ICIgPDwgc3RhdGljX2Nhc3Q8dm9pZCo+ KG1fY2xpZW50KTsK