37872 2010-04-20 11:07:48 -0700 Add isGLES2Compliant to GraphicsContext3D 2010-04-23 22:52:27 -0700 1 1 1 Unclassified WebKit WebGL 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 1 kbr zmo abarth cmarrin commit-queue dglazkov eric fishd kbr oliver simon.fraser webkit.review.bot oldest_to_newest 214775 0 kbr 2010-04-20 11:07:48 -0700 Some GraphicsContext3D implementations will be built on top of desktop OpenGL, and some will be built on top of compliant OpenGL ES 2.0 implementations. In order to enforce strict OpenGL ES 2.0 and WebGL semantics on all platforms, it is convenient to have some checks in the shared code in WebGLRenderingContext. However, these checks need to be disabled when WebGLRenderingContext is delegating to an OpenGL ES 2.0 compliant GraphicsContext3D. We should add a bool isGLES2Compliant() to GraphicsContext3D to be able to conditionalize some of these checks. 214909 1 53871 zmo 2010-04-20 13:21:12 -0700 Created attachment 53871 patch 215519 2 53871 fishd 2010-04-21 14:55:54 -0700 Comment on attachment 53871 patch This looks good to me, but this patch alone just adds unused code. It is in general not a good idea to add unused code. If this could be combined with at least a single user or if the patch that will use this is already pending review, then no problem. 215522 3 zmo 2010-04-21 15:00:04 -0700 (In reply to comment #2) > (From update of attachment 53871 [details]) > This looks good to me, but this patch alone just adds unused code. It is in > general not a good idea to add unused code. If this could be combined with at > least a single user or if the patch that will use this is already pending > review, then no problem. We are going to use this piece code in the following bug (and probably a few more) https://bugs.webkit.org/show_bug.cgi?id=33805 215594 4 kbr 2010-04-21 18:00:08 -0700 For what it's worth, I suggested separating this out into its own patch because I've received feedback on earlier patches that they should address independent issues. This particular entry point will shortly be used in several places throughout the WebKit WebGL code. We do need to land the Chromium portion of this change first. Mo, perhaps remove the review? flag for the time being? 215942 5 zmo 2010-04-22 10:27:53 -0700 Chrome side patch already landed. 216222 6 53871 commit-queue 2010-04-22 19:07:16 -0700 Comment on attachment 53871 patch Clearing flags on attachment: 53871 Committed r58140: <http://trac.webkit.org/changeset/58140> 216223 7 commit-queue 2010-04-22 19:07:21 -0700 All reviewed patches have been landed. Closing bug. 216225 8 simon.fraser 2010-04-22 19:10:05 -0700 The isGLES2Compliant() method should be |const| 216302 9 fishd 2010-04-23 00:07:49 -0700 (In reply to comment #8) > The isGLES2Compliant() method should be |const| Indeed. Good catch, Simon! @zmo: can you post a patch to fix that? 216455 10 zmo 2010-04-23 10:13:29 -0700 (In reply to comment #9) > (In reply to comment #8) > > The isGLES2Compliant() method should be |const| > > Indeed. Good catch, Simon! @zmo: can you post a patch to fix that? Will do. 216470 11 54173 zmo 2010-04-23 10:43:22 -0700 Created attachment 54173 patch: make isGLES2Compliant() const 216474 12 kbr 2010-04-23 10:54:25 -0700 Are you sure this compiles? Doesn't WebGraphicsContext3D::isGLES2Compliant need to become const as a consequence of this change? 216478 13 zmo 2010-04-23 11:01:17 -0700 (In reply to comment #12) > Are you sure this compiles? Doesn't WebGraphicsContext3D::isGLES2Compliant need > to become const as a consequence of this change? It compiles fine on my Mac machine. I was going to change it in WebGraphicsContext3D too, but noticed that methods there like width() and height() are not made const, so I felt it would be better to be consistent. 216483 14 kbr 2010-04-23 11:09:42 -0700 It looks fine to me as long as it compiles, but I personally feel that there are so many methods on GraphicsContext3D that should otherwise be const that they should all be cleaned up in one shot. 216694 15 54173 fishd 2010-04-23 22:01:36 -0700 Comment on attachment 54173 patch: make isGLES2Compliant() const If there are more that should be const, then let's convert those as well, but this change R=me. 216696 16 54173 commit-queue 2010-04-23 22:17:27 -0700 Comment on attachment 54173 patch: make isGLES2Compliant() const Clearing flags on attachment: 54173 Committed r58209: <http://trac.webkit.org/changeset/58209> 216697 17 commit-queue 2010-04-23 22:17:38 -0700 All reviewed patches have been landed. Closing bug. 216700 18 webkit.review.bot 2010-04-23 22:52:27 -0700 http://trac.webkit.org/changeset/58209 might have broken SnowLeopard Intel Release (Tests) 53871 2010-04-20 13:21:12 -0700 2010-04-22 19:07:16 -0700 patch gles.patch text/plain 6742 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1NzkwOCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTcgQEAKKzIwMTAtMDQtMjAgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaXNH TEVTMkNvbXBsaWFudCB0byBHcmFwaGljc0NvbnRleHQzRAorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NzIKKworICAgICAgICAqIGh0bWwvY2FudmFz L1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHA6IEFkZCBpc0dMRVMyQ29tcGxpYW50KCkuCisgICAg ICAgIChXZWJDb3JlOjpXZWJHTFJlbmRlcmluZ0NvbnRleHQ6OmlzR0xFUzJDb21wbGlhbnQpOgor ICAgICAgICAqIGh0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5oOiBEaXR0by4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5oOiBEaXR0by4KKyAg ICAgICAgKiBwbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMuY3BwOiBE aXR0by4KKyAgICAgICAgKFdlYkNvcmU6OkdyYXBoaWNzQ29udGV4dDNEOjppc0dMRVMyQ29tcGxp YW50KToKKwogMjAxMC0wNC0yMCAgR2F2aW4gQmFycmFjbG91Z2ggIDxiYXJyYWNsb3VnaEBhcHBs ZS5jb20+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgR2VvZmYgR2FyZW4uCkluZGV4OiBXZWJDb3Jl L2h0bWwvY2FudmFzL1dlYkdMUmVuZGVyaW5nQ29udGV4dC5jcHAKPT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2Vi Q29yZS9odG1sL2NhbnZhcy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuY3BwCShyZXZpc2lvbiA1Nzg5 NSkKKysrIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xSZW5kZXJpbmdDb250ZXh0LmNwcAkod29y a2luZyBjb3B5KQpAQCAtMjgxOSw2ICsyODE5LDExIEBAIFdlYkdMR2V0SW5mbyBXZWJHTFJlbmRl cmluZ0NvbnRleHQ6OmdldFcKICAgICByZXR1cm4gV2ViR0xHZXRJbmZvKFdlYkdMVW5zaWduZWRC eXRlQXJyYXk6OmNyZWF0ZSh2YWx1ZSwgbGVuZ3RoKSk7CiB9CiAKK2Jvb2wgV2ViR0xSZW5kZXJp bmdDb250ZXh0Ojppc0dMRVMyQ29tcGxpYW50KCkKK3sKKyAgICByZXR1cm4gbV9jb250ZXh0LT5p c0dMRVMyQ29tcGxpYW50KCk7Cit9CisKIH0gLy8gbmFtZXNwYWNlIFdlYkNvcmUKIAogI2VuZGlm IC8vIEVOQUJMRSgzRF9DQU5WQVMpCkluZGV4OiBXZWJDb3JlL2h0bWwvY2FudmFzL1dlYkdMUmVu ZGVyaW5nQ29udGV4dC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvaHRtbC9jYW52YXMvV2ViR0xS ZW5kZXJpbmdDb250ZXh0LmgJKHJldmlzaW9uIDU3ODk1KQorKysgV2ViQ29yZS9odG1sL2NhbnZh cy9XZWJHTFJlbmRlcmluZ0NvbnRleHQuaAkod29ya2luZyBjb3B5KQpAQCAtMjk4LDYgKzI5OCw4 IEBAIGNsYXNzIFdlYktpdENTU01hdHJpeDsKICAgICAgICAgICAgIGlmIChjaGFuZ2VkKQogICAg ICAgICAgICAgICAgIG1hcmtDb250ZXh0Q2hhbmdlZCgpOwogICAgICAgICB9CisKKyAgICAgICAg Ym9vbCBpc0dMRVMyQ29tcGxpYW50KCk7CiAgICAgICAgIAogICAgICAgICAvLyBCYXNpYyB2YWxp ZGF0aW9uIG9mIGNvdW50IGFuZCBvZmZzZXQgYWdhaW5zdCBudW1iZXIgb2YgZWxlbWVudHMgaW4g ZWxlbWVudCBhcnJheSBidWZmZXIKICAgICAgICAgYm9vbCB2YWxpZGF0ZUVsZW1lbnRBcnJheVNp emUodW5zaWduZWQgbG9uZyBjb3VudCwgdW5zaWduZWQgbG9uZyB0eXBlLCBsb25nIG9mZnNldCk7 CkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmgKPT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGljc0NvbnRleHQzRC5o CShyZXZpc2lvbiA1Nzg5NSkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvR3JhcGhpY3ND b250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtNjg1LDYgKzY4NSw4IEBAIG5hbWVzcGFjZSBX ZWJDb3JlIHsKICAgICAgICAgLy8gZ2V0RXJyb3IgaW4gdGhlIG9yZGVyIHRoZXkgd2VyZSBhZGRl ZC4KICAgICAgICAgdm9pZCBzeW50aGVzaXplR0xFcnJvcih1bnNpZ25lZCBsb25nIGVycm9yKTsK IAorICAgICAgICBib29sIGlzR0xFUzJDb21wbGlhbnQoKTsKKwogICAgIHByaXZhdGU6ICAgICAg ICAKICAgICAgICAgR3JhcGhpY3NDb250ZXh0M0QoQXR0cmlidXRlcyBhdHRycywgSG9zdFdpbmRv dyogaG9zdFdpbmRvdyk7CiAKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dy YXBoaWNzQ29udGV4dDNETWFjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dy YXBoaWNzL21hYy9HcmFwaGljc0NvbnRleHQzRE1hYy5jcHAJKHJldmlzaW9uIDU3ODk1KQorKysg V2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMuY3BwCSh3 b3JraW5nIGNvcHkpCkBAIC0yMzUsNiArMjM1LDExIEBAIHZvaWQgR3JhcGhpY3NDb250ZXh0M0Q6 OmVuZFBhaW50KCkKIHsKIH0KIAorYm9vbCBHcmFwaGljc0NvbnRleHQzRDo6aXNHTEVTMkNvbXBs aWFudCgpCit7CisgICAgcmV0dXJuIGZhbHNlOworfQorCiB2b2lkIEdyYXBoaWNzQ29udGV4dDNE OjpyZXNoYXBlKGludCB3aWR0aCwgaW50IGhlaWdodCkKIHsKICAgICBpZiAod2lkdGggPT0gbV9j dXJyZW50V2lkdGggJiYgaGVpZ2h0ID09IG1fY3VycmVudEhlaWdodCB8fCAhbV9jb250ZXh0T2Jq KQpJbmRleDogV2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwo9PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQv Y2hyb21pdW0vQ2hhbmdlTG9nCShyZXZpc2lvbiA1NzkwOCkKKysrIFdlYktpdC9jaHJvbWl1bS9D aGFuZ2VMb2cJKHdvcmtpbmcgY29weSkKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0wNC0yMCAgWmhl bnlhbyBNbyAgPHptb0Bnb29nbGUuY29tPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAo T09QUyEpLgorCisgICAgICAgIEFkZCBpc0dMRVMyQ29tcGxpYW50IHRvIEdyYXBoaWNzQ29udGV4 dDNECisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQub3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg3 MgorCisgICAgICAgICogcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmg6IEFkZCBpc0dMRVMy Q29tcGxpYW50KCkuCisgICAgICAgICogc3JjL0dyYXBoaWNzQ29udGV4dDNELmNwcDogRGl0dG8u CisgICAgICAgICogc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwuY3BwOiBEaXR0 by4KKyAgICAgICAgKFdlYktpdDo6V2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbDo6aXNH TEVTMkNvbXBsaWFudCk6CisgICAgICAgICogc3JjL1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVs dEltcGwuaDogRGl0dG8uCisKIDIwMTAtMDQtMjAgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21p dW0ub3JnPgogCiAgICAgICAgIFJldmlld2VkIGJ5IERhcmluIEFkbGVyLgpJbmRleDogV2ViS2l0 L2Nocm9taXVtL3B1YmxpYy9XZWJHcmFwaGljc0NvbnRleHQzRC5oCj09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdl YktpdC9jaHJvbWl1bS9wdWJsaWMvV2ViR3JhcGhpY3NDb250ZXh0M0QuaAkocmV2aXNpb24gNTc4 OTUpCisrKyBXZWJLaXQvY2hyb21pdW0vcHVibGljL1dlYkdyYXBoaWNzQ29udGV4dDNELmgJKHdv cmtpbmcgY29weSkKQEAgLTk5LDYgKzk5LDkgQEAgcHVibGljOgogICAgIC8vIFJlc2l6ZXMgdGhl IHJlZ2lvbiBpbnRvIHdoaWNoIHRoaXMgV2ViR3JhcGhpY3NDb250ZXh0M0QgaXMgZHJhd2luZy4K ICAgICB2aXJ0dWFsIHZvaWQgcmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpID0gMDsKIAor ICAgIC8vIFF1ZXJ5IHdoZXRoZXIgaXQgaXMgYnVpbHQgb24gdG9wIG9mIGNvbXBsaWFudCBHTEVT MiBpbXBsZW1lbnRhdGlvbi4KKyAgICB2aXJ0dWFsIGJvb2wgaXNHTEVTMkNvbXBsaWFudCgpID0g MDsKKwogICAgIC8vIEhlbHBlciBmb3Igc29mdHdhcmUgY29tcG9zaXRpbmcgcGF0aC4gUmVhZHMg YmFjayB0aGUgZnJhbWUgYnVmZmVyIGludG8KICAgICAvLyB0aGUgbWVtb3J5IHJlZ2lvbiBwb2lu dGVkIHRvIGJ5ICJwaXhlbHMiIHdpdGggc2l6ZSAiYnVmZmVyU2l6ZSIuIEl0IGlzCiAgICAgLy8g ZXhwZWN0ZWQgdGhhdCB0aGUgc3RvcmFnZSBmb3IgInBpeGVscyIgY292ZXJzICg0ICogd2lkdGgg KiBoZWlnaHQpIGJ5dGVzLgpJbmRleDogV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRl eHQzRC5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGljc0NvbnRl eHQzRC5jcHAJKHJldmlzaW9uIDU3ODk1KQorKysgV2ViS2l0L2Nocm9taXVtL3NyYy9HcmFwaGlj c0NvbnRleHQzRC5jcHAJKHdvcmtpbmcgY29weSkKQEAgLTExMSw2ICsxMTEsOCBAQCBwdWJsaWM6 CiAgICAgdm9pZCBiZWdpblBhaW50KFdlYkdMUmVuZGVyaW5nQ29udGV4dCogY29udGV4dCk7CiAg ICAgdm9pZCBlbmRQYWludCgpOwogCisgICAgYm9vbCBpc0dMRVMyQ29tcGxpYW50KCk7CisKICAg ICAvLy0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0KICAgICAvLyBFbnRyeSBwb2ludHMgZm9yIFdlYkdMLgogICAgIC8v CkBAIC02MTcsNiArNjE5LDggQEAgcnQgR3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6bmFtZSh0 MSBhMQogREVMRUdBVEVfVE9fSU1QTF9SKG1ha2VDb250ZXh0Q3VycmVudCwgYm9vbCkKIERFTEVH QVRFX1RPX0lNUExfMVIoc2l6ZUluQnl0ZXMsIGludCwgaW50KQogCitERUxFR0FURV9UT19JTVBM X1IoaXNHTEVTMkNvbXBsaWFudCwgYm9vbCkKKwogREVMRUdBVEVfVE9fSU1QTF8xKGFjdGl2ZVRl eHR1cmUsIHVuc2lnbmVkIGxvbmcpCiBERUxFR0FURV9UT19JTVBMXzJfWDEyKGF0dGFjaFNoYWRl ciwgV2ViR0xQcm9ncmFtKiwgV2ViR0xTaGFkZXIqKQogCkBAIC0xMjkwLDYgKzEyOTQsNyBAQCBE RUxFR0FURV9UT19JTlRFUk5BTF8xKGRlbGV0ZVNoYWRlciwgdW5zCiBERUxFR0FURV9UT19JTlRF Uk5BTF8xKGRlbGV0ZVRleHR1cmUsIHVuc2lnbmVkKQogCiBERUxFR0FURV9UT19JTlRFUk5BTF8x KHN5bnRoZXNpemVHTEVycm9yLCB1bnNpZ25lZCBsb25nKQorREVMRUdBVEVfVE9fSU5URVJOQUxf Uihpc0dMRVMyQ29tcGxpYW50LCBib29sKQogCiB9IC8vIG5hbWVzcGFjZSBXZWJDb3JlCiAKSW5k ZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5j cHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PQotLS0gV2ViS2l0L2Nocm9taXVtL3NyYy9XZWJHcmFwaGljc0NvbnRleHQz RERlZmF1bHRJbXBsLmNwcAkocmV2aXNpb24gNTc4OTUpCisrKyBXZWJLaXQvY2hyb21pdW0vc3Jj L1dlYkdyYXBoaWNzQ29udGV4dDNERGVmYXVsdEltcGwuY3BwCSh3b3JraW5nIGNvcHkpCkBAIC00 NjQsNiArNDY0LDExIEBAIGludCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBsOjpzaXoK ICAgICByZXR1cm4gMDsKIH0KIAorYm9vbCBXZWJHcmFwaGljc0NvbnRleHQzRERlZmF1bHRJbXBs Ojppc0dMRVMyQ29tcGxpYW50KCkKK3sKKyAgICByZXR1cm4gZmFsc2U7Cit9CisKIHN0YXRpYyBp bnQgY3JlYXRlVGV4dHVyZU9iamVjdChHTGVudW0gdGFyZ2V0KQogewogICAgIEdMdWludCB0ZXh0 dXJlID0gMDsKSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0M0RE ZWZhdWx0SW1wbC5oCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYktpdC9jaHJvbWl1bS9zcmMvV2ViR3JhcGhp Y3NDb250ZXh0M0REZWZhdWx0SW1wbC5oCShyZXZpc2lvbiA1Nzg5NSkKKysrIFdlYktpdC9jaHJv bWl1bS9zcmMvV2ViR3JhcGhpY3NDb250ZXh0M0REZWZhdWx0SW1wbC5oCSh3b3JraW5nIGNvcHkp CkBAIC03NSw2ICs3NSw4IEBAIHB1YmxpYzoKIAogICAgIHZpcnR1YWwgaW50IHNpemVJbkJ5dGVz KGludCB0eXBlKTsKIAorICAgIHZpcnR1YWwgYm9vbCBpc0dMRVMyQ29tcGxpYW50KCk7CisKICAg ICB2aXJ0dWFsIHZvaWQgcmVzaGFwZShpbnQgd2lkdGgsIGludCBoZWlnaHQpOwogCiAgICAgdmly dHVhbCBib29sIHJlYWRCYWNrRnJhbWVidWZmZXIodW5zaWduZWQgY2hhciogcGl4ZWxzLCBzaXpl X3QgYnVmZmVyU2l6ZSk7Cg== 54173 2010-04-23 10:43:22 -0700 2010-04-23 22:17:27 -0700 patch: make isGLES2Compliant() const const.patch text/plain 3998 zmo SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1ODE3NykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4K KworICAgICAgICBSZXZpZXdlZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaXNH TEVTMkNvbXBsaWFudCB0byBHcmFwaGljc0NvbnRleHQzRDogbWFrZSB0aGUgbWV0aG9kIGNvbnN0 LgorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NzIK KworICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29udGV4dDNELmg6IE1ha2Ug aXNHTEVTMkNvbXBsaWFudCgpIGNvbnN0LgorICAgICAgICAqIHBsYXRmb3JtL2dyYXBoaWNzL21h Yy9HcmFwaGljc0NvbnRleHQzRE1hYy5jcHA6IERpdHRvLgorICAgICAgICAoV2ViQ29yZTo6R3Jh cGhpY3NDb250ZXh0M0Q6OmlzR0xFUzJDb21wbGlhbnQpOgorCiAyMDEwLTA0LTIzICBTaGluaWNo aXJvIEhhbWFqaSAgPGhhbWFqaUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkg RGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL0dyYXBoaWNzQ29u dGV4dDNELmgKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGljcy9HcmFwaGlj c0NvbnRleHQzRC5oCShyZXZpc2lvbiA1ODE0MCkKKysrIFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhp Y3MvR3JhcGhpY3NDb250ZXh0M0QuaAkod29ya2luZyBjb3B5KQpAQCAtNDc5LDYgKzQ3OSw4IEBA IG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgIGJvb2wg ZmxpcFZlcnRpY2FsbHksCiAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICBBbHBoYU9wIGFs cGhhT3ApOwogCisgICAgICAgIGJvb2wgaXNHTEVTMkNvbXBsaWFudCgpIGNvbnN0OworCiAgICAg ICAgIC8vLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLQogICAgICAgICAvLyBFbnRyeSBwb2ludHMgZm9yIFdlYkdMLgog ICAgICAgICAvLwpAQCAtNjg1LDggKzY4Nyw2IEBAIG5hbWVzcGFjZSBXZWJDb3JlIHsKICAgICAg ICAgLy8gZ2V0RXJyb3IgaW4gdGhlIG9yZGVyIHRoZXkgd2VyZSBhZGRlZC4KICAgICAgICAgdm9p ZCBzeW50aGVzaXplR0xFcnJvcih1bnNpZ25lZCBsb25nIGVycm9yKTsKIAotICAgICAgICBib29s IGlzR0xFUzJDb21wbGlhbnQoKTsKLQogICAgIHByaXZhdGU6ICAgICAgICAKICAgICAgICAgR3Jh cGhpY3NDb250ZXh0M0QoQXR0cmlidXRlcyBhdHRycywgSG9zdFdpbmRvdyogaG9zdFdpbmRvdyk7 CiAKSW5kZXg6IFdlYkNvcmUvcGxhdGZvcm0vZ3JhcGhpY3MvbWFjL0dyYXBoaWNzQ29udGV4dDNE TWFjLmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL21hYy9HcmFw aGljc0NvbnRleHQzRE1hYy5jcHAJKHJldmlzaW9uIDU4MTQwKQorKysgV2ViQ29yZS9wbGF0Zm9y bS9ncmFwaGljcy9tYWMvR3JhcGhpY3NDb250ZXh0M0RNYWMuY3BwCSh3b3JraW5nIGNvcHkpCkBA IC0yMzUsNyArMjM1LDcgQEAgdm9pZCBHcmFwaGljc0NvbnRleHQzRDo6ZW5kUGFpbnQoKQogewog fQogCi1ib29sIEdyYXBoaWNzQ29udGV4dDNEOjppc0dMRVMyQ29tcGxpYW50KCkKK2Jvb2wgR3Jh cGhpY3NDb250ZXh0M0Q6OmlzR0xFUzJDb21wbGlhbnQoKSBjb25zdAogewogICAgIHJldHVybiBm YWxzZTsKIH0KSW5kZXg6IFdlYktpdC9jaHJvbWl1bS9DaGFuZ2VMb2cKPT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0g V2ViS2l0L2Nocm9taXVtL0NoYW5nZUxvZwkocmV2aXNpb24gNTgxNzcpCisrKyBXZWJLaXQvY2hy b21pdW0vQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBAIC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQt MjMgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KKworICAgICAgICBSZXZpZXdlZCBieSBO T0JPRFkgKE9PUFMhKS4KKworICAgICAgICBBZGQgaXNHTEVTMkNvbXBsaWFudCB0byBHcmFwaGlj c0NvbnRleHQzRDogbWFrZSB0aGUgbWV0aG9kIGNvbnN0LgorICAgICAgICBodHRwczovL2J1Z3Mu d2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NzIKKworICAgICAgICAqIHNyYy9HcmFwaGlj c0NvbnRleHQzRC5jcHA6IE1ha2UgaXNHTEVTMkNvbXBsaWFudCgpIGNvbnN0LgorICAgICAgICAo V2ViQ29yZTo6R3JhcGhpY3NDb250ZXh0M0RJbnRlcm5hbDo6aXNHTEVTMkNvbXBsaWFudCk6Cisg ICAgICAgIChXZWJDb3JlOjpHcmFwaGljc0NvbnRleHQzRDo6aXNHTEVTMkNvbXBsaWFudCk6CisK IDIwMTAtMDQtMjIgIFpoZW55YW8gTW8gIDx6bW9AZ29vZ2xlLmNvbT4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXJpbiBGaXNoZXIuCkluZGV4OiBXZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNz Q29udGV4dDNELmNwcAo9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09Ci0tLSBXZWJLaXQvY2hyb21pdW0vc3JjL0dyYXBoaWNz Q29udGV4dDNELmNwcAkocmV2aXNpb24gNTgxNDApCisrKyBXZWJLaXQvY2hyb21pdW0vc3JjL0dy YXBoaWNzQ29udGV4dDNELmNwcAkod29ya2luZyBjb3B5KQpAQCAtMTExLDcgKzExMSw3IEBAIHB1 YmxpYzoKICAgICB2b2lkIGJlZ2luUGFpbnQoV2ViR0xSZW5kZXJpbmdDb250ZXh0KiBjb250ZXh0 KTsKICAgICB2b2lkIGVuZFBhaW50KCk7CiAKLSAgICBib29sIGlzR0xFUzJDb21wbGlhbnQoKTsK KyAgICBib29sIGlzR0xFUzJDb21wbGlhbnQoKSBjb25zdDsKIAogICAgIC8vLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0t LQogICAgIC8vIEVudHJ5IHBvaW50cyBmb3IgV2ViR0wuCkBAIC02MTksNyArNjE5LDEwIEBAIHJ0 IEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6Om5hbWUodDEgYTEKIERFTEVHQVRFX1RPX0lNUExf UihtYWtlQ29udGV4dEN1cnJlbnQsIGJvb2wpCiBERUxFR0FURV9UT19JTVBMXzFSKHNpemVJbkJ5 dGVzLCBpbnQsIGludCkKIAotREVMRUdBVEVfVE9fSU1QTF9SKGlzR0xFUzJDb21wbGlhbnQsIGJv b2wpCitib29sIEdyYXBoaWNzQ29udGV4dDNESW50ZXJuYWw6OmlzR0xFUzJDb21wbGlhbnQoKSBj b25zdAoreworICAgIHJldHVybiBtX2ltcGwtPmlzR0xFUzJDb21wbGlhbnQoKTsKK30KIAogREVM RUdBVEVfVE9fSU1QTF8xKGFjdGl2ZVRleHR1cmUsIHVuc2lnbmVkIGxvbmcpCiBERUxFR0FURV9U T19JTVBMXzJfWDEyKGF0dGFjaFNoYWRlciwgV2ViR0xQcm9ncmFtKiwgV2ViR0xTaGFkZXIqKQpA QCAtMTI5NCw3ICsxMjk3LDExIEBAIERFTEVHQVRFX1RPX0lOVEVSTkFMXzEoZGVsZXRlU2hhZGVy LCB1bnMKIERFTEVHQVRFX1RPX0lOVEVSTkFMXzEoZGVsZXRlVGV4dHVyZSwgdW5zaWduZWQpCiAK IERFTEVHQVRFX1RPX0lOVEVSTkFMXzEoc3ludGhlc2l6ZUdMRXJyb3IsIHVuc2lnbmVkIGxvbmcp Ci1ERUxFR0FURV9UT19JTlRFUk5BTF9SKGlzR0xFUzJDb21wbGlhbnQsIGJvb2wpCisKK2Jvb2wg R3JhcGhpY3NDb250ZXh0M0Q6OmlzR0xFUzJDb21wbGlhbnQoKSBjb25zdAoreworICAgIHJldHVy biBtX2ludGVybmFsLT5pc0dMRVMyQ29tcGxpYW50KCk7Cit9CiAKIH0gLy8gbmFtZXNwYWNlIFdl YkNvcmUKIAo=