37857 2010-04-20 07:05:41 -0700 Fixes v8 binding generator for EventSource 2010-04-21 05:00:43 -0700 1 1 1 Unclassified WebKit WebCore Misc. 528+ (Nightly build) All All RESOLVED FIXED P2 Normal --- 0 bulach webkit-unassigned bulach commit-queue japhet oldest_to_newest 214633 0 bulach 2010-04-20 07:05:41 -0700 EventSource needs to be marked as an ActiveDomType. 214637 1 53813 bulach 2010-04-20 07:12:13 -0700 Created attachment 53813 Patch 214649 2 bulach 2010-04-20 07:21:42 -0700 Hi Nate, Ages ago I implemented the binding for eventsource, and turns out I didn't fully enable it, so looks like it got a bit stale. As a follow up of this change, I'll enable eventsource by default on the other side and will make sure the layout tests are properly turned on this time.. :) Would you please take a look at this patch? Thanks! Marcus 214681 3 53823 bulach 2010-04-20 08:31:37 -0700 Created attachment 53823 Patch (fixes error message required by fast/eventsource layout tests). 214690 4 53823 japhet 2010-04-20 08:50:38 -0700 Comment on attachment 53823 Patch (fixes error message required by fast/eventsource layout tests). Ok, looks good. Do you need cq+ on this? 214691 5 bulach 2010-04-20 08:53:18 -0700 thanks for the quick review! yep, I need cq+ thanks, marcus (In reply to comment #4) > (From update of attachment 53823 [details]) > Ok, looks good. > > Do you need cq+ on this? 214693 6 53823 japhet 2010-04-20 08:55:55 -0700 Comment on attachment 53823 Patch (fixes error message required by fast/eventsource layout tests). cq+ then. So will Chromium be enabling eventsource on tip of tree and running these tests soon then? 214695 7 bulach 2010-04-20 09:02:52 -0700 (In reply to comment #6) > (From update of attachment 53823 [details]) > cq+ then. > > So will Chromium be enabling eventsource on tip of tree and running these tests > soon then? precisely! once we roll this change, I'll enable eventsource: http://codereview.chromium.org/557037 and then once it's enable, I'll turn on the tests: https://bugs.webkit.org/show_bug.cgi?id=37863 just needs a few rounds to get it through both sides. 215254 8 53823 commit-queue 2010-04-21 05:00:38 -0700 Comment on attachment 53823 Patch (fixes error message required by fast/eventsource layout tests). Clearing flags on attachment: 53823 Committed r57967: <http://trac.webkit.org/changeset/57967> 215255 9 commit-queue 2010-04-21 05:00:43 -0700 All reviewed patches have been landed. Closing bug. 53813 2010-04-20 07:12:13 -0700 2010-04-20 08:31:37 -0700 Patch 37857.patch text/plain 2577 bulach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzg4OCkKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTQgQEAKKzIwMTAtMDQtMjAgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEV2ZW50U291cmNlIG5lZWRzIHRvIGJlIG1hcmtlZCBhcyBhbiBBY3RpdmVEb21UeXBlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NTcKKyAgICAg ICAgRXhpc3RpbmcgbGF5b3V0IHRlc3RzIChmYXN0L2V2ZW50c291cmNlIGFuZCBodHRwL3Rlc3Rz L2V2ZW50c291cmNlLykgc2hvdWxkIHBhc3Mgd2hlbiBjb21waWxpbmcgd2l0aCBldmVudHNvdXJj ZSBlbmFibGVkLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG06CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKwogMjAxMC0wNC0y MCAgRXZhbiBTdGFkZSAgPGVzdGFkZUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQg YnkgRGF2aWQgTGV2aW4uCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMvQ29kZUdlbmVy YXRvclY4LnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2Vu ZXJhdG9yVjgucG0JKHJldmlzaW9uIDU3ODU1KQorKysgV2ViQ29yZS9iaW5kaW5ncy9zY3JpcHRz L0NvZGVHZW5lcmF0b3JWOC5wbQkod29ya2luZyBjb3B5KQpAQCAtMjI2NSw2ICsyMjY1LDcgQEAg c3ViIElzQWN0aXZlRG9tVHlwZQogewogICAgICMgRklYTUU6IENvbnNpZGVyIG1ha2luZyB0aGlz IGFuIC5pZGwgYXR0cmlidXRlLgogICAgIG15ICR0eXBlID0gc2hpZnQ7CisgICAgcmV0dXJuIDEg aWYgJHR5cGUgZXEgIkV2ZW50U291cmNlIjsKICAgICByZXR1cm4gMSBpZiAkdHlwZSBlcSAiTWVz c2FnZVBvcnQiOwogICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJYTUxIdHRwUmVxdWVzdCI7CiAg ICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYlNvY2tldCI7CkluZGV4OiBXZWJDb3JlL2JpbmRp bmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5ncy92 OC9WOERPTVdyYXBwZXIuY3BwCShyZXZpc2lvbiA1Nzg1NSkKKysrIFdlYkNvcmUvYmluZGluZ3Mv djgvVjhET01XcmFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSwxMCArMSwxMCBAQAogLyoK ICAqIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJlc2VydmVkLgot ICogCisgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5kIGJpbmFyeSBm b3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJtaXR0ZWQgcHJv dmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCiAgKiBtZXQ6Ci0gKiAKKyAq CiAgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCByZXRhaW4gdGhl IGFib3ZlIGNvcHlyaWdodAogICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0aW9ucyBhbmQg dGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgogICogICAgICogUmVkaXN0cmlidXRpb25zIGluIGJp bmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQpAQCAtMTQsNyArMTQsNyBAQAogICog ICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5hbWVzIG9mIGl0 cwogICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJvbW90ZSBwcm9k dWN0cyBkZXJpdmVkIGZyb20KICAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVjaWZpYyBwcmlv ciB3cml0dGVuIHBlcm1pc3Npb24uCi0gKiAKKyAqCiAgKiBUSElTIFNPRlRXQVJFIElTIFBST1ZJ REVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCiAgKiAiQVMgSVMi IEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElORywgQlVUIE5P VAogICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJDSEFOVEFCSUxJ VFkgQU5EIEZJVE5FU1MgRk9SCkBAIC00Niw2ICs0Niw3IEBACiAjaW5jbHVkZSAiVjhET01NYXAu aCIKICNpbmNsdWRlICJWOERPTVdpbmRvdy5oIgogI2luY2x1ZGUgIlY4RXZlbnRMaXN0ZW5lckxp c3QuaCIKKyNpbmNsdWRlICJWOEV2ZW50U291cmNlLmgiCiAjaW5jbHVkZSAiVjhIVE1MQ29sbGVj dGlvbi5oIgogI2luY2x1ZGUgIlY4SFRNTERvY3VtZW50LmgiCiAjaW5jbHVkZSAiVjhJc29sYXRl ZENvbnRleHQuaCIK 53823 2010-04-20 08:31:37 -0700 2010-04-21 05:00:38 -0700 Patch (fixes error message required by fast/eventsource layout tests). 37857.patch text/plain 3594 bulach SW5kZXg6IFdlYkNvcmUvQ2hhbmdlTG9nCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvQ2hhbmdlTG9n CShyZXZpc2lvbiA1Nzg5MykKKysrIFdlYkNvcmUvQ2hhbmdlTG9nCSh3b3JraW5nIGNvcHkpCkBA IC0xLDMgKzEsMTYgQEAKKzIwMTAtMDQtMjAgIE1hcmN1cyBCdWxhY2ggIDxidWxhY2hAY2hyb21p dW0ub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IEV2ZW50U291cmNlIG5lZWRzIHRvIGJlIG1hcmtlZCBhcyBhbiBBY3RpdmVEb21UeXBlLgorICAg ICAgICBodHRwczovL2J1Z3Mud2Via2l0Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NTcKKyAgICAg ICAgRXhpc3RpbmcgbGF5b3V0IHRlc3RzIChmYXN0L2V2ZW50c291cmNlIGFuZCBodHRwL3Rlc3Rz L2V2ZW50c291cmNlLykgc2hvdWxkIHBhc3Mgd2hlbiBjb21waWxpbmcgd2l0aCBldmVudHNvdXJj ZSBlbmFibGVkLgorCisgICAgICAgICogYmluZGluZ3Mvc2NyaXB0cy9Db2RlR2VuZXJhdG9yVjgu cG06CisgICAgICAgICogYmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcDoKKyAgICAgICAgKiBi aW5kaW5ncy92OC9jdXN0b20vVjhFdmVudFNvdXJjZUNvbnN0cnVjdG9yLmNwcDoKKyAgICAgICAg KFdlYkNvcmU6OlY4RXZlbnRTb3VyY2U6OmNvbnN0cnVjdG9yQ2FsbGJhY2spOgorCiAyMDEwLTA0 LTIwICBKYWt1YiBXaWVjem9yZWsgIDxqd2llY3pvcmVrQHdlYmtpdC5vcmc+CiAKICAgICAgICAg UmV2aWV3ZWQgYnkgRGFyaW4gQWRsZXIuCkluZGV4OiBXZWJDb3JlL2JpbmRpbmdzL3NjcmlwdHMv Q29kZUdlbmVyYXRvclY4LnBtCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIFdlYkNvcmUvYmluZGluZ3Mvc2NyaXB0 cy9Db2RlR2VuZXJhdG9yVjgucG0JKHJldmlzaW9uIDU3ODU1KQorKysgV2ViQ29yZS9iaW5kaW5n cy9zY3JpcHRzL0NvZGVHZW5lcmF0b3JWOC5wbQkod29ya2luZyBjb3B5KQpAQCAtMjI2NSw2ICsy MjY1LDcgQEAgc3ViIElzQWN0aXZlRG9tVHlwZQogewogICAgICMgRklYTUU6IENvbnNpZGVyIG1h a2luZyB0aGlzIGFuIC5pZGwgYXR0cmlidXRlLgogICAgIG15ICR0eXBlID0gc2hpZnQ7CisgICAg cmV0dXJuIDEgaWYgJHR5cGUgZXEgIkV2ZW50U291cmNlIjsKICAgICByZXR1cm4gMSBpZiAkdHlw ZSBlcSAiTWVzc2FnZVBvcnQiOwogICAgIHJldHVybiAxIGlmICR0eXBlIGVxICJYTUxIdHRwUmVx dWVzdCI7CiAgICAgcmV0dXJuIDEgaWYgJHR5cGUgZXEgIldlYlNvY2tldCI7CkluZGV4OiBXZWJD b3JlL2JpbmRpbmdzL3Y4L1Y4RE9NV3JhcHBlci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9i aW5kaW5ncy92OC9WOERPTVdyYXBwZXIuY3BwCShyZXZpc2lvbiA1Nzg1NSkKKysrIFdlYkNvcmUv YmluZGluZ3MvdjgvVjhET01XcmFwcGVyLmNwcAkod29ya2luZyBjb3B5KQpAQCAtMSwxMCArMSwx MCBAQAogLyoKICAqIENvcHlyaWdodCAoQykgMjAwOSBHb29nbGUgSW5jLiBBbGwgcmlnaHRzIHJl c2VydmVkLgotICogCisgKgogICogUmVkaXN0cmlidXRpb24gYW5kIHVzZSBpbiBzb3VyY2UgYW5k IGJpbmFyeSBmb3Jtcywgd2l0aCBvciB3aXRob3V0CiAgKiBtb2RpZmljYXRpb24sIGFyZSBwZXJt aXR0ZWQgcHJvdmlkZWQgdGhhdCB0aGUgZm9sbG93aW5nIGNvbmRpdGlvbnMgYXJlCiAgKiBtZXQ6 Ci0gKiAKKyAqCiAgKiAgICAgKiBSZWRpc3RyaWJ1dGlvbnMgb2Ygc291cmNlIGNvZGUgbXVzdCBy ZXRhaW4gdGhlIGFib3ZlIGNvcHlyaWdodAogICogbm90aWNlLCB0aGlzIGxpc3Qgb2YgY29uZGl0 aW9ucyBhbmQgdGhlIGZvbGxvd2luZyBkaXNjbGFpbWVyLgogICogICAgICogUmVkaXN0cmlidXRp b25zIGluIGJpbmFyeSBmb3JtIG11c3QgcmVwcm9kdWNlIHRoZSBhYm92ZQpAQCAtMTQsNyArMTQs NyBAQAogICogICAgICogTmVpdGhlciB0aGUgbmFtZSBvZiBHb29nbGUgSW5jLiBub3IgdGhlIG5h bWVzIG9mIGl0cwogICogY29udHJpYnV0b3JzIG1heSBiZSB1c2VkIHRvIGVuZG9yc2Ugb3IgcHJv bW90ZSBwcm9kdWN0cyBkZXJpdmVkIGZyb20KICAqIHRoaXMgc29mdHdhcmUgd2l0aG91dCBzcGVj aWZpYyBwcmlvciB3cml0dGVuIHBlcm1pc3Npb24uCi0gKiAKKyAqCiAgKiBUSElTIFNPRlRXQVJF IElTIFBST1ZJREVEIEJZIFRIRSBDT1BZUklHSFQgSE9MREVSUyBBTkQgQ09OVFJJQlVUT1JTCiAg KiAiQVMgSVMiIEFORCBBTlkgRVhQUkVTUyBPUiBJTVBMSUVEIFdBUlJBTlRJRVMsIElOQ0xVRElO RywgQlVUIE5PVAogICogTElNSVRFRCBUTywgVEhFIElNUExJRUQgV0FSUkFOVElFUyBPRiBNRVJD SEFOVEFCSUxJVFkgQU5EIEZJVE5FU1MgRk9SCkBAIC00Niw2ICs0Niw3IEBACiAjaW5jbHVkZSAi VjhET01NYXAuaCIKICNpbmNsdWRlICJWOERPTVdpbmRvdy5oIgogI2luY2x1ZGUgIlY4RXZlbnRM aXN0ZW5lckxpc3QuaCIKKyNpbmNsdWRlICJWOEV2ZW50U291cmNlLmgiCiAjaW5jbHVkZSAiVjhI VE1MQ29sbGVjdGlvbi5oIgogI2luY2x1ZGUgIlY4SFRNTERvY3VtZW50LmgiCiAjaW5jbHVkZSAi VjhJc29sYXRlZENvbnRleHQuaCIKSW5kZXg6IFdlYkNvcmUvYmluZGluZ3MvdjgvY3VzdG9tL1Y4 RXZlbnRTb3VyY2VDb25zdHJ1Y3Rvci5jcHAKPT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PQotLS0gV2ViQ29yZS9iaW5kaW5n cy92OC9jdXN0b20vVjhFdmVudFNvdXJjZUNvbnN0cnVjdG9yLmNwcAkocmV2aXNpb24gNTc4NTUp CisrKyBXZWJDb3JlL2JpbmRpbmdzL3Y4L2N1c3RvbS9WOEV2ZW50U291cmNlQ29uc3RydWN0b3Iu Y3BwCSh3b3JraW5nIGNvcHkpCkBAIC01NiwxMyArNTYsMTMgQEAgdjg6OkhhbmRsZTx2ODo6VmFs dWU+IFY4RXZlbnRTb3VyY2U6OmNvbgogICAgIGlmICghY29udGV4dCkKICAgICAgICAgcmV0dXJu IHRocm93RXJyb3IoIkV2ZW50U291cmNlIGNvbnN0cnVjdG9yJ3MgYXNzb2NpYXRlZCBjb250ZXh0 IGlzIG5vdCBhdmFpbGFibGUiLCBWOFByb3h5OjpSZWZlcmVuY2VFcnJvcik7CiAgICAgaWYgKGFy Z3MuTGVuZ3RoKCkgIT0gMSkKLSAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIkV2ZW50U291cmNl IGNvbnN0cnVjdG9yIHdyb25nIG51bWJlciBvZiBwYXJhbWV0ZXJzIiwgVjhQcm94eTo6VHlwZUVy cm9yKTsKKyAgICAgICAgcmV0dXJuIHRocm93RXJyb3IoIk5vdCBlbm91Z2ggYXJndW1lbnRzIiwg VjhQcm94eTo6U3ludGF4RXJyb3IpOwogCiAgICAgRXhjZXB0aW9uQ29kZSBlYyA9IDA7CiAgICAg U3RyaW5nIHVybCA9IHRvV2ViQ29yZVN0cmluZyhhcmdzWzBdKTsKIAogICAgIFJlZlB0cjxFdmVu dFNvdXJjZT4gZXZlbnRTb3VyY2UgPSBFdmVudFNvdXJjZTo6Y3JlYXRlKHVybCwgY29udGV4dCwg ZWMpOwotICAgIAorCiAgICAgaWYgKGVjKQogICAgICAgICByZXR1cm4gdGhyb3dFcnJvcihlYyk7 CiAK