37849 2010-04-20 04:24:49 -0700 [SVG+Qt] applyStrokeStyleToContext does not set the stroke style under Qt 2010-04-26 03:05:27 -0700 1 1 1 Unclassified WebKit SVG 528+ (Nightly build) PC OS X 10.5 RESOLVED FIXED P2 Normal --- 1 zherczeg webkit-unassigned commit-queue eric krit ossy oldest_to_newest 214564 0 zherczeg 2010-04-20 04:24:49 -0700 The following example does not draw a black border around the red circle in QtLauncher: http://www.w3schools.com/svg/tryit.asp?filename=circle1&type=svg I did some debugging, and perhaps the issue comes from the following code: WebCore/svg/graphics/SVGPaintServer.cpp : applyStrokeStyleToContext function set all style related parameters, except the setStrokeStyle. Actually the stroke style was set to NoStroke somewhere before, and it still contains this value, hence no line is drawn. I can fix it for Qt, but it may affect other platforms in a bad way. CC'ing Eric, since he committed the code. Unfortunately it could be his landing bot, so I am not sure who actually wrote it. 214566 1 zherczeg 2010-04-20 04:31:41 -0700 Did some search. Dirk Schulze made the patch (his email address, vbs85@gmx.de is not accepted by bugzilla) and Eric reviewed it [r36734] 214568 2 zherczeg 2010-04-20 04:41:34 -0700 Only the following platforms need an explicit stroke style set: QT, CAIRO, SKIA, HAIKU, OPENVG GraphicsContext.cpp: #if !PLATFORM(QT) && !PLATFORM(CAIRO) && !PLATFORM(SKIA) \ && !PLATFORM(HAIKU) && !PLATFORM(OPENVG) void GraphicsContext::setPlatformStrokeStyle(const StrokeStyle&) { } #endif Probably the reason this bug was not noticed before. 214580 3 53799 zherczeg 2010-04-20 05:16:16 -0700 Created attachment 53799 proposed fix Anyway, here is my solution 214581 4 zherczeg 2010-04-20 05:17:00 -0700 Dirk Schulze changed his email. 214604 5 krit 2010-04-20 06:21:38 -0700 We're working with dasharrays in SVG. That was the initial reason not to set any stroke style. The most platforms use solid, if no DashArray is created. Looks like OpenVG had similiar problems. OpenVG has a work around in it's GraphicsContext implementation. Maybe it's better to make an expliclit call of strokeStyle, if no DashArray was created. 214616 6 zherczeg 2010-04-20 06:39:50 -0700 In Qt, setLineDash does not affect the stroke style. In a sense, line dash and stroke style is overlapping, I agree. Although setStrokeStyle seems a cheap operation compared to set line dash. 214739 7 krit 2010-04-20 10:21:00 -0700 (In reply to comment #6) > In Qt, setLineDash does not affect the stroke style. In a sense, line dash and > stroke style is overlapping, I agree. Although setStrokeStyle seems a cheap > operation compared to set line dash. But maybe it's more secure to check if the dashArray is empty, after:     const DashArray& dashes = dashArrayFromRenderingStyle(object->style(), object->document()->documentElement()->renderStyle()); If yes, set strokeStyle to solid and return? 214765 8 zherczeg 2010-04-20 10:48:40 -0700 I am pretty sure you know far more about SVG in WebKit than me, and your solution is ok for me. I found the GraphicsContext API a little confusing, is there a documentation about about this? For example, what is the difference between DrawPath and StrokePath? 214772 9 krit 2010-04-20 10:59:34 -0700 (In reply to comment #8) > I am pretty sure you know far more about SVG in WebKit than me, and your > solution is ok for me. I found the GraphicsContext API a little confusing, is > there a documentation about about this? For example, what is the difference > between DrawPath and StrokePath? fillPath fills a path, strokePath just strokes the path, drawPath makes both at onece. drawPath could be faster on some platforms, but is not necessarily the case for qt. Also nothing in WebCore uses drawPath. 215201 10 53931 zherczeg 2010-04-21 02:15:25 -0700 Created attachment 53931 updated fix 215202 11 zherczeg 2010-04-21 02:18:34 -0700 Updated the patch according to Dirk's suggestion. 215207 12 53934 zherczeg 2010-04-21 02:30:27 -0700 Created attachment 53934 updated fix Eh, isEmpty(), instead of !size() 215216 13 krit 2010-04-21 03:26:52 -0700 (In reply to comment #12) > Created an attachment (id=53934) [details] > updated fix > > Eh, isEmpty(), instead of !size() Does Qt provide pixel tests? 215217 14 krit 2010-04-21 03:28:13 -0700 Also have you tested, if the changes influence DRT tests? 215286 15 ossy 2010-04-21 06:52:49 -0700 (In reply to comment #14) > Does Qt provide pixel tests? Yes, but unfortunately there is a bug around run-webkit-tests and/or imagediff. That means running test may stuck in an infinite loop and there are some sideeffect problem. I will file a bug on it, we would like to fix it. But until then we shouldn't commit hundreds of png. 215288 16 ossy 2010-04-21 06:55:26 -0700 (In reply to comment #14) > Also have you tested, if the changes influence DRT tests? Done. This patch doesn't brake any layout test. (rendertree dump) Additionally I ran pixel tests on our 326 enabled svg test, and nothing changed. 215292 17 zherczeg 2010-04-21 07:00:49 -0700 Thanks Ossy 216782 18 krit 2010-04-24 21:59:01 -0700 (In reply to comment #17) > Thanks Ossy Please update the patch to trunk and add more detailed information in the ChangeLog as well as a short explaination why you can't test it. I'll r+ your patch with the changes above. 216940 19 54266 zherczeg 2010-04-26 01:24:26 -0700 Created attachment 54266 update to tot 216942 20 zherczeg 2010-04-26 01:29:11 -0700 > why you can't test it. Ossy is a build and layout expert here, he could notice not only regressions, but unwanted slowdowns, strange behaviour as well. I usually develop jscore things, hence I rarely run layout tests. But that can be changed in the future :) 216944 21 54266 krit 2010-04-26 01:41:14 -0700 Comment on attachment 54266 update to tot LGTM r=me. Nevertheless, please make a comment on the Changelogs why it is not possible to add a regression test next time. This helps other reviewers. 216954 22 54266 commit-queue 2010-04-26 03:05:19 -0700 Comment on attachment 54266 update to tot Clearing flags on attachment: 54266 Committed r58243: <http://trac.webkit.org/changeset/58243> 216955 23 commit-queue 2010-04-26 03:05:27 -0700 All reviewed patches have been landed. Closing bug. 53799 2010-04-20 05:16:16 -0700 2010-04-21 02:15:25 -0700 proposed fix 0001-setStrokeStyle.patch text/plain 1734 zherczeg RnJvbSBmZGRkMmFiNTgzYzBkOTNhNTBmZThiM2QzYTBhOWIxYjg3M2U3MTJkIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUdWUsIDIwIEFwciAyMDEwIDE0OjEzOjQ3ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc2V0U3Ryb2tlU3R5bGUKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3pl Z0BpbmYudS1zemVnZWQuaHU+Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQYWludFNl cnZlci5jcHAgfCAgICAxICsKIDIgZmlsZXMgY2hhbmdlZCwgMTEgaW5zZXJ0aW9ucygrKSwgMCBk ZWxldGlvbnMoLSkKCmRpZmYgLS1naXQgYS9XZWJDb3JlL0NoYW5nZUxvZyBiL1dlYkNvcmUvQ2hh bmdlTG9nCmluZGV4IDI3YTkyZDUuLmVlYzdiOGMgMTAwNjQ0Ci0tLSBhL1dlYkNvcmUvQ2hhbmdl TG9nCisrKyBiL1dlYkNvcmUvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTMgQEAKKzIwMTAtMDQtMjAg IFpvbHRhbiBIZXJjemVnICA8emhlcmN6ZWdAd2Via2l0Lm9yZz4KKworICAgICAgICBSZXZpZXdl ZCBieSBOT0JPRFkgKE9PUFMhKS4KKworICAgICAgICBDYWxsIHNldFN0cm9rZVN0eWxlIGluIGFw cGx5U3Ryb2tlU3R5bGVUb0NvbnRleHQKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcv c2hvd19idWcuY2dpP2lkPTM3ODQ5CisKKyAgICAgICAgKiBzdmcvZ3JhcGhpY3MvU1ZHUGFpbnRT ZXJ2ZXIuY3BwOgorICAgICAgICAoV2ViQ29yZTo6YXBwbHlTdHJva2VTdHlsZVRvQ29udGV4dCk6 CisKIDIwMTAtMDQtMTkgIEplc3NpZSBCZXJsaW4gIDxqYmVybGluQHdlYmtpdC5vcmc+CiAKICAg ICAgICAgUmV2aWV3ZWQgYnkgRGF2ZSBIeWF0dC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvc3ZnL2dy YXBoaWNzL1NWR1BhaW50U2VydmVyLmNwcCBiL1dlYkNvcmUvc3ZnL2dyYXBoaWNzL1NWR1BhaW50 U2VydmVyLmNwcAppbmRleCBhZWI2OWFlLi5iNmZkN2E4IDEwMDY0NAotLS0gYS9XZWJDb3JlL3N2 Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHAKKysrIGIvV2ViQ29yZS9zdmcvZ3JhcGhpY3Mv U1ZHUGFpbnRTZXJ2ZXIuY3BwCkBAIC0yMDEsNiArMjAxLDcgQEAgdm9pZCBhcHBseVN0cm9rZVN0 eWxlVG9Db250ZXh0KEdyYXBoaWNzQ29udGV4dCogY29udGV4dCwgY29uc3QgUmVuZGVyU3R5bGUq IHN0eWwKICAgICBjb250ZXh0LT5zZXRTdHJva2VUaGlja25lc3MoU1ZHUmVuZGVyU3R5bGU6OmNz c1ByaW1pdGl2ZVRvTGVuZ3RoKG9iamVjdCwgc3R5bGUtPnN2Z1N0eWxlKCktPnN0cm9rZVdpZHRo KCksIDEuMGYpKTsKICAgICBjb250ZXh0LT5zZXRMaW5lQ2FwKHN0eWxlLT5zdmdTdHlsZSgpLT5j YXBTdHlsZSgpKTsKICAgICBjb250ZXh0LT5zZXRMaW5lSm9pbihzdHlsZS0+c3ZnU3R5bGUoKS0+ am9pblN0eWxlKCkpOworICAgIGNvbnRleHQtPnNldFN0cm9rZVN0eWxlKHN0eWxlLT5zdmdTdHls ZSgpLT5zdHJva2VPcGFjaXR5KCkgPiAwLjAgPyBTb2xpZFN0cm9rZSA6IE5vU3Ryb2tlKTsKICAg ICBpZiAoc3R5bGUtPnN2Z1N0eWxlKCktPmpvaW5TdHlsZSgpID09IE1pdGVySm9pbikKICAgICAg ICAgY29udGV4dC0+c2V0TWl0ZXJMaW1pdChzdHlsZS0+c3ZnU3R5bGUoKS0+c3Ryb2tlTWl0ZXJM aW1pdCgpKTsKIAotLSAKMS42LjAuNAoK 53931 2010-04-21 02:15:25 -0700 2010-04-21 02:30:27 -0700 updated fix 0001-setStrokeStyle.patch text/plain 1846 zherczeg RnJvbSAwMjUwYzcxMzU1NTE3MmE1YzVlZDk5ZjMwODI3MWU3YjI3MjhjNjc1IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDIxIEFwciAyMDEwIDExOjEyOjU0ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc2V0U3Ryb2tlU3R5bGUKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3pl Z0BpbmYudS1zemVnZWQuaHU+Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQYWludFNl cnZlci5jcHAgfCAgICA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAyN2E5MmQ1Li5lZWM3YjhjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0 LTIwICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCBzZXRTdHJva2VTdHlsZSBp biBhcHBseVN0cm9rZVN0eWxlVG9Db250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg0OQorCisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR1Bh aW50U2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGx5U3Ryb2tlU3R5bGVUb0NvbnRl eHQpOgorCiAyMDEwLTA0LTE5ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2 Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHAgYi9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQ YWludFNlcnZlci5jcHAKaW5kZXggYWViNjlhZS4uZGI0ZjQxOSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9zdmcvZ3JhcGhpY3MvU1ZHUGFpbnRTZXJ2ZXIuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL2dyYXBo aWNzL1NWR1BhaW50U2VydmVyLmNwcApAQCAtMjA2LDcgKzIwNiwxMCBAQCB2b2lkIGFwcGx5U3Ry b2tlU3R5bGVUb0NvbnRleHQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBSZW5kZXJT dHlsZSogc3R5bAogCiAgICAgY29uc3QgRGFzaEFycmF5JiBkYXNoZXMgPSBkYXNoQXJyYXlGcm9t UmVuZGVyaW5nU3R5bGUob2JqZWN0LT5zdHlsZSgpLCBvYmplY3QtPmRvY3VtZW50KCktPmRvY3Vt ZW50RWxlbWVudCgpLT5yZW5kZXJTdHlsZSgpKTsKICAgICBmbG9hdCBkYXNoT2Zmc2V0ID0gU1ZH UmVuZGVyU3R5bGU6OmNzc1ByaW1pdGl2ZVRvTGVuZ3RoKG9iamVjdCwgc3R5bGUtPnN2Z1N0eWxl KCktPnN0cm9rZURhc2hPZmZzZXQoKSwgMC4wZik7Ci0gICAgY29udGV4dC0+c2V0TGluZURhc2go ZGFzaGVzLCBkYXNoT2Zmc2V0KTsKKyAgICBpZiAoIWRhc2hlcy5zaXplKCkpCisgICAgICAgIGNv bnRleHQtPnNldFN0cm9rZVN0eWxlKFNvbGlkU3Ryb2tlKTsKKyAgICBlbHNlCisgICAgICAgIGNv bnRleHQtPnNldExpbmVEYXNoKGRhc2hlcywgZGFzaE9mZnNldCk7CiB9CiAKIGJvb2wgU1ZHUGFp bnRTZXJ2ZXI6OnNldHVwKEdyYXBoaWNzQ29udGV4dComIGNvbnRleHQsIGNvbnN0IFJlbmRlck9i amVjdCogb2JqZWN0LCBTVkdQYWludFRhcmdldFR5cGUgdHlwZSwgYm9vbCBpc1BhaW50aW5nVGV4 dCkgY29uc3QKLS0gCjEuNi4wLjQKCg== 53934 2010-04-21 02:30:27 -0700 2010-04-26 01:24:26 -0700 updated fix 0001-setStrokeStyle.patch text/plain 1848 zherczeg RnJvbSA5OWJlY2RiMjkxYWEzYWZmODFhYjI0YzQ0NDhiMzI0NzI3NTQ1MWExIE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBXZWQsIDIxIEFwciAyMDEwIDExOjI0OjE5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc2V0U3Ryb2tlU3R5bGUKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3pl Z0BpbmYudS1zemVnZWQuaHU+Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgIHwgICAxMCArKysrKysrKysrCiBXZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQYWludFNl cnZlci5jcHAgfCAgICA1ICsrKystCiAyIGZpbGVzIGNoYW5nZWQsIDE0IGluc2VydGlvbnMoKyks IDEgZGVsZXRpb25zKC0pCgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9DaGFuZ2VMb2cgYi9XZWJDb3Jl L0NoYW5nZUxvZwppbmRleCAyN2E5MmQ1Li5lZWM3YjhjIDEwMDY0NAotLS0gYS9XZWJDb3JlL0No YW5nZUxvZworKysgYi9XZWJDb3JlL0NoYW5nZUxvZwpAQCAtMSwzICsxLDEzIEBACisyMDEwLTA0 LTIwICBab2x0YW4gSGVyY3plZyAgPHpoZXJjemVnQHdlYmtpdC5vcmc+CisKKyAgICAgICAgUmV2 aWV3ZWQgYnkgTk9CT0RZIChPT1BTISkuCisKKyAgICAgICAgQ2FsbCBzZXRTdHJva2VTdHlsZSBp biBhcHBseVN0cm9rZVN0eWxlVG9Db250ZXh0CisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg0OQorCisgICAgICAgICogc3ZnL2dyYXBoaWNzL1NWR1Bh aW50U2VydmVyLmNwcDoKKyAgICAgICAgKFdlYkNvcmU6OmFwcGx5U3Ryb2tlU3R5bGVUb0NvbnRl eHQpOgorCiAyMDEwLTA0LTE5ICBKZXNzaWUgQmVybGluICA8amJlcmxpbkB3ZWJraXQub3JnPgog CiAgICAgICAgIFJldmlld2VkIGJ5IERhdmUgSHlhdHQuCmRpZmYgLS1naXQgYS9XZWJDb3JlL3N2 Zy9ncmFwaGljcy9TVkdQYWludFNlcnZlci5jcHAgYi9XZWJDb3JlL3N2Zy9ncmFwaGljcy9TVkdQ YWludFNlcnZlci5jcHAKaW5kZXggYWViNjlhZS4uNTNmYzY2ZSAxMDA2NDQKLS0tIGEvV2ViQ29y ZS9zdmcvZ3JhcGhpY3MvU1ZHUGFpbnRTZXJ2ZXIuY3BwCisrKyBiL1dlYkNvcmUvc3ZnL2dyYXBo aWNzL1NWR1BhaW50U2VydmVyLmNwcApAQCAtMjA2LDcgKzIwNiwxMCBAQCB2b2lkIGFwcGx5U3Ry b2tlU3R5bGVUb0NvbnRleHQoR3JhcGhpY3NDb250ZXh0KiBjb250ZXh0LCBjb25zdCBSZW5kZXJT dHlsZSogc3R5bAogCiAgICAgY29uc3QgRGFzaEFycmF5JiBkYXNoZXMgPSBkYXNoQXJyYXlGcm9t UmVuZGVyaW5nU3R5bGUob2JqZWN0LT5zdHlsZSgpLCBvYmplY3QtPmRvY3VtZW50KCktPmRvY3Vt ZW50RWxlbWVudCgpLT5yZW5kZXJTdHlsZSgpKTsKICAgICBmbG9hdCBkYXNoT2Zmc2V0ID0gU1ZH UmVuZGVyU3R5bGU6OmNzc1ByaW1pdGl2ZVRvTGVuZ3RoKG9iamVjdCwgc3R5bGUtPnN2Z1N0eWxl KCktPnN0cm9rZURhc2hPZmZzZXQoKSwgMC4wZik7Ci0gICAgY29udGV4dC0+c2V0TGluZURhc2go ZGFzaGVzLCBkYXNoT2Zmc2V0KTsKKyAgICBpZiAoZGFzaGVzLmlzRW1wdHkoKSkKKyAgICAgICAg Y29udGV4dC0+c2V0U3Ryb2tlU3R5bGUoU29saWRTdHJva2UpOworICAgIGVsc2UKKyAgICAgICAg Y29udGV4dC0+c2V0TGluZURhc2goZGFzaGVzLCBkYXNoT2Zmc2V0KTsKIH0KIAogYm9vbCBTVkdQ YWludFNlcnZlcjo6c2V0dXAoR3JhcGhpY3NDb250ZXh0KiYgY29udGV4dCwgY29uc3QgUmVuZGVy T2JqZWN0KiBvYmplY3QsIFNWR1BhaW50VGFyZ2V0VHlwZSB0eXBlLCBib29sIGlzUGFpbnRpbmdU ZXh0KSBjb25zdAotLSAKMS42LjAuNAoK 54266 2010-04-26 01:24:26 -0700 2010-04-26 03:05:19 -0700 update to tot 0001-setStrokeStyle.patch text/plain 1916 zherczeg RnJvbSBiYWE2YWRhMzBjMDQ4MDQ1YmJmM2ViMDI1YzA1NWU3YmIwMzgwYzI3IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBNb24sIDI2IEFwciAyMDEwIDEwOjIwOjE2ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc2V0U3Ryb2tlU3R5bGUKClNpZ25lZC1vZmYtYnk6IFpvbHRhbiBIZXJjemVnIDx6aGVyY3pl Z0BpbmYudS1zemVnZWQuaHU+Ci0tLQogV2ViQ29yZS9DaGFuZ2VMb2cgICAgICAgICAgICAgICAg ICAgICAgfCAgIDEzICsrKysrKysrKysrKysKIFdlYkNvcmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1 cHBvcnQuY3BwIHwgICAgNSArKysrLQogMiBmaWxlcyBjaGFuZ2VkLCAxNyBpbnNlcnRpb25zKCsp LCAxIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNvcmUvQ2hhbmdlTG9nIGIvV2ViQ29y ZS9DaGFuZ2VMb2cKaW5kZXggZTMyOWZjMi4uYWViN2U1ZiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9D aGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAgLTEsMyArMSwxNiBAQAorMjAxMC0w NC0yNiAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJraXQub3JnPgorCisgICAgICAgIFJl dmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIENhbGwgc2V0U3Ryb2tlU3R5bGUg aW4gYXBwbHlTdHJva2VTdHlsZVRvQ29udGV4dAorICAgICAgICBodHRwczovL2J1Z3Mud2Via2l0 Lm9yZy9zaG93X2J1Zy5jZ2k/aWQ9Mzc4NDkKKworICAgICAgICBOb3QgYWxsIHBsYXRmb3JtcyBz ZXQgdGhlIHN0cm9rZSBzdHlsZSB0byBzb2xpZCBpZiB0aGV5CisgICAgICAgIGdldCBhbiBlbXB0 eSBsaW5lIGRhc2ggYXJyYXkuIFNvbWUganVzdCBpZ25vcmUgdGhlIG9wZXJhdGlvbi4KKworICAg ICAgICAqIHJlbmRlcmluZy9TVkdSZW5kZXJTdXBwb3J0LmNwcDoKKyAgICAgICAgKFdlYkNvcmU6 OmFwcGx5U3Ryb2tlU3R5bGVUb0NvbnRleHQpOgorCiAyMDEwLTA0LTI1ICBBbmRyZXkgS29zeWFr b3YgIDxjYXNlcUBjaHJvbWl1bS5vcmc+CiAKICAgICAgICAgUmV2aWV3ZWQgYnkgQWRhbSBCYXJ0 aC4KZGlmZiAtLWdpdCBhL1dlYkNvcmUvcmVuZGVyaW5nL1NWR1JlbmRlclN1cHBvcnQuY3BwIGIv V2ViQ29yZS9yZW5kZXJpbmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHAKaW5kZXggZWY4MGVhNi4uMjYw MDUxMiAxMDA2NDQKLS0tIGEvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHAK KysrIGIvV2ViQ29yZS9yZW5kZXJpbmcvU1ZHUmVuZGVyU3VwcG9ydC5jcHAKQEAgLTM5OSw3ICsz OTksMTAgQEAgdm9pZCBhcHBseVN0cm9rZVN0eWxlVG9Db250ZXh0KEdyYXBoaWNzQ29udGV4dCog Y29udGV4dCwgY29uc3QgUmVuZGVyU3R5bGUqIHN0eWwKIAogICAgIGNvbnN0IERhc2hBcnJheSYg ZGFzaGVzID0gZGFzaEFycmF5RnJvbVJlbmRlcmluZ1N0eWxlKG9iamVjdC0+c3R5bGUoKSwgb2Jq ZWN0LT5kb2N1bWVudCgpLT5kb2N1bWVudEVsZW1lbnQoKS0+cmVuZGVyU3R5bGUoKSk7CiAgICAg ZmxvYXQgZGFzaE9mZnNldCA9IFNWR1JlbmRlclN0eWxlOjpjc3NQcmltaXRpdmVUb0xlbmd0aChv YmplY3QsIHN0eWxlLT5zdmdTdHlsZSgpLT5zdHJva2VEYXNoT2Zmc2V0KCksIDAuMGYpOwotICAg IGNvbnRleHQtPnNldExpbmVEYXNoKGRhc2hlcywgZGFzaE9mZnNldCk7CisgICAgaWYgKGRhc2hl cy5pc0VtcHR5KCkpCisgICAgICAgIGNvbnRleHQtPnNldFN0cm9rZVN0eWxlKFNvbGlkU3Ryb2tl KTsKKyAgICBlbHNlCisgICAgICAgIGNvbnRleHQtPnNldExpbmVEYXNoKGRhc2hlcywgZGFzaE9m ZnNldCk7CiB9CiAKIGNvbnN0IFJlbmRlck9iamVjdCogZmluZFRleHRSb290T2JqZWN0KGNvbnN0 IFJlbmRlck9iamVjdCogc3RhcnQpCi0tIAoxLjYuMC40Cgo=