37844 2010-04-20 01:52:09 -0700 [Qt] Image::drawTiled animations does not work 2011-04-19 05:15:29 -0700 1 1 1 Unclassified WebKit Platform 528+ (Nightly build) PC OS X 10.5 CLOSED FIXED P2 Normal --- 1 zherczeg webkit-unassigned commit-queue hausmann oldest_to_newest 214532 0 zherczeg 2010-04-20 01:52:09 -0700 There is no strict order requirement between calling nativeImageForCurrentFrame() and startAnimation(). Qt requires startAnimation() must be called before nativeImageForCurrentFrame(). This patch removes this order requirement 214537 1 53786 zherczeg 2010-04-20 02:01:11 -0700 Created attachment 53786 proposed fix 214647 2 53786 kenneth 2010-04-20 07:19:37 -0700 Comment on attachment 53786 proposed fix LGTM 215307 3 53786 commit-queue 2010-04-21 07:34:50 -0700 Comment on attachment 53786 proposed fix Clearing flags on attachment: 53786 Committed r57979: <http://trac.webkit.org/changeset/57979> 215308 4 commit-queue 2010-04-21 07:34:55 -0700 All reviewed patches have been landed. Closing bug. 238729 5 hausmann 2010-06-16 01:38:07 -0700 Revision r57979 cherry-picked into qtwebkit-2.0 with commit 1faaef83bb16df3b349f0ba610bdc7bbdc5197d4 53786 2010-04-20 02:01:11 -0700 2010-04-21 07:34:50 -0700 proposed fix 0001-startAnimation-fix.patch text/plain 1906 zherczeg RnJvbSAwZmU2NjM1NDE2YjNhNmIyN2ZmMmQ1MGMyYzU1NGZjNWQ4NjU3NDQ0IE1vbiBTZXAgMTcg MDA6MDA6MDAgMjAwMQpGcm9tOiBab2x0YW4gSGVyY3plZyA8emhlcmN6ZWdAaW5mLnUtc3plZ2Vk Lmh1PgpEYXRlOiBUdWUsIDIwIEFwciAyMDEwIDEwOjU4OjI5ICswMjAwClN1YmplY3Q6IFtQQVRD SF0gc3RhcnRBbmltYXRpb24gZml4CgpTaWduZWQtb2ZmLWJ5OiBab2x0YW4gSGVyY3plZyA8emhl cmN6ZWdAaW5mLnUtc3plZ2VkLmh1PgotLS0KIFdlYkNvcmUvQ2hhbmdlTG9nICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgIHwgICAxNSArKysrKysrKysrKysrKysKIFdlYkNvcmUvcGxhdGZv cm0vZ3JhcGhpY3MvcXQvSW1hZ2VEZWNvZGVyUXQuY3BwIHwgICAgMiArKwogMiBmaWxlcyBjaGFu Z2VkLCAxNyBpbnNlcnRpb25zKCspLCAwIGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL1dlYkNv cmUvQ2hhbmdlTG9nIGIvV2ViQ29yZS9DaGFuZ2VMb2cKaW5kZXggMjdhOTJkNS4uZjhjZTdlOSAx MDA2NDQKLS0tIGEvV2ViQ29yZS9DaGFuZ2VMb2cKKysrIGIvV2ViQ29yZS9DaGFuZ2VMb2cKQEAg LTEsMyArMSwxOCBAQAorMjAxMC0wNC0yMCAgWm9sdGFuIEhlcmN6ZWcgIDx6aGVyY3plZ0B3ZWJr aXQub3JnPgorCisgICAgICAgIFJldmlld2VkIGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAg IFtRdF0gc3RhcnRBbmltYXRpb24oKSBpcyBub3QgbmVlZGVkIHRvIHByZWNlZWRlIG5hdGl2ZUlt YWdlRm9yQ3VycmVudEZyYW1lKCkKKyAgICAgICAgaHR0cHM6Ly9idWdzLndlYmtpdC5vcmcvc2hv d19idWcuY2dpP2lkPTM3ODQ0CisKKyAgICAgICAgbmF0aXZlSW1hZ2VGb3JDdXJyZW50RnJhbWUo KSByZXNldHMgdGhlIG1fZGVjb2RlciBwYXJhbWV0ZXIgdW5kZXIgUXQsCisgICAgICAgIHdoaWNo IGlzIHJlcXVpcmVkIGJ5IHN0YXJ0QW5pbWF0aW9uKCkgdG8gZGV0ZWN0IGZyYW1lIGFuZCByZXBl dGl0aW9uIGNvdW50cy4KKyAgICAgICAgSGVuY2UsIEltYWdlOjpkcmF3VGlsZWQgY2Fubm90IHN0 YXJ0IGFuaW1hdGlvbnMgdW5kZXIgUXQ6CisgICAgICAgIDxodG1sPjxib2R5IGJhY2tncm91bmQ9 ImFuaW1hdGVkLmdpZiI+PC9ib2R5PjwvaHRtbD4gZG9lcyBub3Qgd29yaworCisgICAgICAgICog cGxhdGZvcm0vZ3JhcGhpY3MvcXQvSW1hZ2VEZWNvZGVyUXQuY3BwOgorICAgICAgICAoV2ViQ29y ZTo6SW1hZ2VEZWNvZGVyUXQ6OmludGVybmFsSGFuZGxlQ3VycmVudEltYWdlKToKKwogMjAxMC0w NC0xOSAgSmVzc2llIEJlcmxpbiAgPGpiZXJsaW5Ad2Via2l0Lm9yZz4KIAogICAgICAgICBSZXZp ZXdlZCBieSBEYXZlIEh5YXR0LgpkaWZmIC0tZ2l0IGEvV2ViQ29yZS9wbGF0Zm9ybS9ncmFwaGlj cy9xdC9JbWFnZURlY29kZXJRdC5jcHAgYi9XZWJDb3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0lt YWdlRGVjb2RlclF0LmNwcAppbmRleCBiMTBjYzcxLi5iNDhiMjc4IDEwMDY0NAotLS0gYS9XZWJD b3JlL3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlRGVjb2RlclF0LmNwcAorKysgYi9XZWJDb3Jl L3BsYXRmb3JtL2dyYXBoaWNzL3F0L0ltYWdlRGVjb2RlclF0LmNwcApAQCAtMjA1LDYgKzIwNSw4 IEBAIGJvb2wgSW1hZ2VEZWNvZGVyUXQ6OmludGVybmFsSGFuZGxlQ3VycmVudEltYWdlKHNpemVf dCBmcmFtZUluZGV4KQogICAgIC8vIE5vdyBnZXQgdGhlIFFJbWFnZSBmcm9tIFF0IGFuZCBwbGFj ZSBpdCBpbiB0aGUgUkdCQTMyQnVmZmVyCiAgICAgUUltYWdlIGltZzsKICAgICBpZiAoIW1fcmVh ZGVyLT5yZWFkKCZpbWcpKSB7CisgICAgICAgIGZyYW1lQ291bnQoKTsKKyAgICAgICAgcmVwZXRp dGlvbkNvdW50KCk7CiAgICAgICAgIGNsZWFyUG9pbnRlcnMoKTsKICAgICAgICAgcmV0dXJuIGZh bHNlOwogICAgIH0KLS0gCjEuNi4wLjQKCg==