37843 2010-04-19 23:53:39 -0700 [DRT/Chromium] Fix some unexpected results of editing 2010-04-20 00:15:20 -0700 1 1 1 Unclassified WebKit Tools / Tests 528+ (Nightly build) Other All RESOLVED FIXED P2 Normal --- 35902 1 tkent webkit-unassigned dglazkov hamaji oldest_to_newest 214502 0 tkent 2010-04-19 23:53:39 -0700 [DRT/Chromium] Fix some unexpected results of editing 214503 1 53777 tkent 2010-04-19 23:55:53 -0700 Created attachment 53777 Patch 214507 2 53777 hamaji 2010-04-20 00:06:09 -0700 Comment on attachment 53777 Patch Looks good! Side note: the corresponding file seems to be src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We have only one startContainer call in the chromium's code so this would be just a typo. By the way, I think it's nice to have this kind of info in ChangeLog. Could you update the ChangeLog before you land? 214508 3 tkent 2010-04-20 00:08:52 -0700 (In reply to comment #2) > (From update of attachment 53777 [details]) > Looks good! > > Side note: the corresponding file seems to be > src/webkit/tools/test_shell/test_webview_delegate.cc in chromium's tree. We > have only one startContainer call in the chromium's code so this would be just > a typo. > > By the way, I think it's nice to have this kind of info in ChangeLog. Could you > update the ChangeLog before you land? Right. This was my failure during porting test_webview_delegate.cc. I'll update the ChangeLog. 214509 4 tkent 2010-04-20 00:15:20 -0700 Committed r57876: <http://trac.webkit.org/changeset/57876> 53777 2010-04-19 23:55:53 -0700 2010-04-20 00:06:09 -0700 Patch bug-37843-20100420155551.patch text/plain 1315 tkent ZGlmZiAtLWdpdCBhL1dlYktpdFRvb2xzL0NoYW5nZUxvZyBiL1dlYktpdFRvb2xzL0NoYW5nZUxv ZwppbmRleCBjYTYwOTgzLi44ZTNmOWUzIDEwMDY0NAotLS0gYS9XZWJLaXRUb29scy9DaGFuZ2VM b2cKKysrIGIvV2ViS2l0VG9vbHMvQ2hhbmdlTG9nCkBAIC0xLDMgKzEsMTUgQEAKKzIwMTAtMDQt MTkgIEtlbnQgVGFtdXJhICA8dGtlbnRAY2hyb21pdW0ub3JnPgorCisgICAgICAgIFJldmlld2Vk IGJ5IE5PQk9EWSAoT09QUyEpLgorCisgICAgICAgIFtEUlQvQ2hyb21pdW1dIEZpeCBzb21lIHVu ZXhwZWN0ZWQgcmVzdWx0cyBvZiBlZGl0aW5nCisgICAgICAgIGh0dHBzOi8vYnVncy53ZWJraXQu b3JnL3Nob3dfYnVnLmNnaT9pZD0zNzg0MworCisgICAgICAgIFRoaXMgY2hhbmdlIGZpeGVzIGFi b3V0IDcwIHVuZXhwZWN0ZWQgcmVzdWx0cy4KKworICAgICAgICAqIER1bXBSZW5kZXJUcmVlL2No cm9taXVtL1dlYlZpZXdIb3N0LmNwcDoKKyAgICAgICAgKHByaW50UmFuZ2VEZXNjcmlwdGlvbik6 IFJlcGxhY2UgdGhlIGxhdHRlciBzdGFydENvbnRhaW5lcigpIHdpdGggZW5kQ29udGFpbmVyKCku CisKIDIwMTAtMDQtMTkgIERhbmllbCBCYXRlcyAgPGRiYXRlc0ByaW0uY29tPgogCiAgICAgICAg IE5vIHJldmlldywgcm9sbGluZyBvdXQgNTc4NjguCmRpZmYgLS1naXQgYS9XZWJLaXRUb29scy9E dW1wUmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAgYi9XZWJLaXRUb29scy9EdW1w UmVuZGVyVHJlZS9jaHJvbWl1bS9XZWJWaWV3SG9zdC5jcHAKaW5kZXggNGU5NDVjZC4uMzE3ZGEx ZSAxMDA2NDQKLS0tIGEvV2ViS2l0VG9vbHMvRHVtcFJlbmRlclRyZWUvY2hyb21pdW0vV2ViVmll d0hvc3QuY3BwCisrKyBiL1dlYktpdFRvb2xzL0R1bXBSZW5kZXJUcmVlL2Nocm9taXVtL1dlYlZp ZXdIb3N0LmNwcApAQCAtMjIwLDcgKzIyMCw3IEBAIHN0YXRpYyB2b2lkIHByaW50UmFuZ2VEZXNj cmlwdGlvbihjb25zdCBXZWJSYW5nZSYgcmFuZ2UpCiAgICAgV2ViTm9kZSBzdGFydE5vZGUgPSBy YW5nZS5zdGFydENvbnRhaW5lcihleGNlcHRpb24pOwogICAgIHByaW50Tm9kZURlc2NyaXB0aW9u KHN0YXJ0Tm9kZSwgZXhjZXB0aW9uKTsKICAgICBwcmludGYoIiB0byAlZCBvZiAiLCByYW5nZS5l bmRPZmZzZXQoKSk7Ci0gICAgV2ViTm9kZSBlbmROb2RlID0gcmFuZ2Uuc3RhcnRDb250YWluZXIo ZXhjZXB0aW9uKTsKKyAgICBXZWJOb2RlIGVuZE5vZGUgPSByYW5nZS5lbmRDb250YWluZXIoZXhj ZXB0aW9uKTsKICAgICBwcmludE5vZGVEZXNjcmlwdGlvbihlbmROb2RlLCBleGNlcHRpb24pOwog fQogCg==